df0d9b492d
Don't transmute `&List<GenericArg>` <-> `&List<Ty>` In #93505 we allowed safely transmuting between `&List<GenericArg<'_>>` and `&List<Ty<'_>>`. This was possible because `GenericArg` is a tagged pointer and the tag for types is `0b00`, such that a `GenericArg` with a type inside has the same layout as `Ty`. While this was meant as an optimization, it doesn't look like it was actually any perf or max-rss win (see https://github.com/rust-lang/rust/pull/94799#issuecomment-1064340003, https://github.com/rust-lang/rust/pull/94841, https://github.com/rust-lang/rust/pull/110496#issuecomment-1513799140). Additionally the way it was done is quite fragile — `unsafe` code was not properly documented or contained in a module, types were not marked as `repr(C)` (making the transmutes possibly unsound). All of this makes the code maintenance harder and blocks other possible optimizations (as an example I've found out about these `transmutes` when my change caused them to sigsegv compiler). Thus, I think we can safely (pun intended) remove those transmutes, making maintenance easier, optimizations possible, code less cursed, etc. r? `@compiler-errors` |
||
|---|---|---|
| .. | ||
| dep_graph | ||
| hir | ||
| infer | ||
| middle | ||
| mir | ||
| query | ||
| thir | ||
| traits | ||
| ty | ||
| util | ||
| arena.rs | ||
| error.rs | ||
| lib.rs | ||
| lint.rs | ||
| macros.rs | ||
| metadata.rs | ||
| tests.rs | ||
| thir.rs | ||
| values.rs | ||