1
Fork 0
rust/compiler
Matthias Krüger c52d58f346
Rollup merge of #105570 - Nilstrieb:actual-best-failure, r=compiler-errors
Properly calculate best failure in macro matching

Previously, we used spans. This was not good. Sometimes, the span of the token that failed to match may come from a position later in the file which has been transcribed into a token stream way earlier in the file. If precisely this token fails to match, we think that it was the best match because its span is so high, even though other arms might have gotten further in the token stream.

We now try to properly use the location in the token stream.

This needs a little cleanup as the `best_failure` field is getting out of hand but it should be mostly good to go. I hope I didn't violate too many abstraction boundaries..
2022-12-28 22:22:19 +01:00
..
rustc
rustc_abi Auto merge of #105446 - erikdesjardins:vt-size, r=nikic 2022-12-18 22:01:39 +00:00
rustc_apfloat compiler: remove unnecessary imports and qualified paths 2022-12-10 18:45:34 +01:00
rustc_arena compiler: remove unnecessary imports and qualified paths 2022-12-10 18:45:34 +01:00
rustc_ast Auto merge of #105701 - RedDocMD:bug-105634, r=cjgillot 2022-12-25 14:42:49 +00:00
rustc_ast_lowering Rollup merge of #106064 - lukas-code:outlives-macro, r=cjgillot 2022-12-27 12:33:35 -08:00
rustc_ast_passes Allow impl ~const Trait opaque types 2022-12-15 11:26:15 +00:00
rustc_ast_pretty Auto merge of #105160 - nnethercote:rm-Lit-token_lit, r=petrochenkov 2022-12-12 05:16:50 +00:00
rustc_attr rustc_attr remove ref patterns 2022-12-06 14:45:58 +00:00
rustc_baked_icu_data Update crate documentation of rustc_baked_icu_data crate 2022-11-18 14:46:36 -08:00
rustc_borrowck Auto merge of #106095 - estebank:pin-mut-reborrow, r=compiler-errors 2022-12-27 07:31:42 +00:00
rustc_builtin_macros Rollup merge of #105975 - jeremystucki:rustc-remove-needless-lifetimes, r=eholk 2022-12-24 00:31:41 +01:00
rustc_codegen_cranelift Auto merge of #105613 - Nilstrieb:rename-assert_uninit_valid, r=RalfJung 2022-12-21 23:20:04 +00:00
rustc_codegen_gcc Add missing anonymous lifetime 2022-12-20 22:34:42 +01:00
rustc_codegen_llvm Rollup merge of #105955 - Nilstrieb:no-trivial-opt-wrappers-we-have-field-accesses-for-that, r=cjgillot 2022-12-25 22:15:00 +01:00
rustc_codegen_ssa Auto merge of #105605 - inquisitivecrystal:attr-validation, r=cjgillot 2022-12-26 09:06:51 +00:00
rustc_const_eval Auto merge of #105085 - oli-obk:stop_promoting_all_the_things, r=RalfJung 2022-12-24 14:00:37 +00:00
rustc_data_structures fix some typos 2022-12-25 00:43:50 +01:00
rustc_driver fix more clippy::style findings 2022-12-25 17:32:26 +01:00
rustc_error_codes docs: add long-form error docs for E0461 2022-12-27 17:03:39 +13:00
rustc_error_messages Recover fn keyword as Fn trait in bounds 2022-12-27 06:14:46 +00:00
rustc_errors fix more clippy::style findings 2022-12-25 17:32:26 +01:00
rustc_expand Rollup merge of #105570 - Nilstrieb:actual-best-failure, r=compiler-errors 2022-12-28 22:22:19 +01:00
rustc_feature Rollup merge of #105484 - nbdd0121:upcast, r=compiler-errors 2022-12-28 15:51:41 +08:00
rustc_fs_util Remove useless borrows and derefs 2022-12-01 17:34:43 +00:00
rustc_graphviz Indicate anonymous lifetime 2022-12-23 15:59:53 +01:00
rustc_hir abort immediately on bad mem::zeroed/uninit 2022-12-22 16:37:42 +01:00
rustc_hir_analysis Auto merge of #106215 - matthiaskrgr:rollup-53r89ww, r=matthiaskrgr 2022-12-28 17:00:00 +00:00
rustc_hir_pretty more clippy::complexity fixes 2022-12-15 00:09:10 +01:00
rustc_hir_typeck Rollup merge of #106199 - estebank:quiet-type-err-in-binding, r=compiler-errors 2022-12-28 14:40:03 +01:00
rustc_incremental rustc: Remove needless lifetimes 2022-12-20 22:10:40 +01:00
rustc_index A few small cleanups for newtype_index 2022-12-18 21:47:28 +01:00
rustc_infer Auto merge of #106129 - compiler-errors:compare_method-tweaks, r=BoxyUwU 2022-12-28 13:07:30 +00:00
rustc_interface Auto merge of #105812 - ojeda:no-jump-tables, r=nikic 2022-12-21 17:38:38 +00:00
rustc_lexer Recover fn keyword as Fn trait in bounds 2022-12-27 06:14:46 +00:00
rustc_lint Rollup merge of #105484 - nbdd0121:upcast, r=compiler-errors 2022-12-28 15:51:41 +08:00
rustc_lint_defs fix some typos 2022-12-25 00:43:50 +01:00
rustc_llvm llvm-wrapper: adapt for LLVM API changes 2022-12-11 09:14:50 +00:00
rustc_log
rustc_macros rustc: Remove needless lifetimes 2022-12-20 22:10:40 +01:00
rustc_metadata Auto merge of #106129 - compiler-errors:compare_method-tweaks, r=BoxyUwU 2022-12-28 13:07:30 +00:00
rustc_middle Auto merge of #106129 - compiler-errors:compare_method-tweaks, r=BoxyUwU 2022-12-28 13:07:30 +00:00
rustc_mir_build Rollup merge of #105975 - jeremystucki:rustc-remove-needless-lifetimes, r=eholk 2022-12-24 00:31:41 +01:00
rustc_mir_dataflow rustc: Remove needless lifetimes 2022-12-20 22:10:40 +01:00
rustc_mir_transform Rollup merge of #105975 - jeremystucki:rustc-remove-needless-lifetimes, r=eholk 2022-12-24 00:31:41 +01:00
rustc_monomorphize Auto merge of #106143 - matthiaskrgr:rollup-3kpy1dc, r=matthiaskrgr 2022-12-25 23:47:11 +00:00
rustc_parse Rollup merge of #105570 - Nilstrieb:actual-best-failure, r=compiler-errors 2022-12-28 22:22:19 +01:00
rustc_parse_format Auto merge of #103828 - cassaundra:fix-format-args-span2, r=cjgillot 2022-12-26 12:03:47 +00:00
rustc_passes fix more clippy::style findings 2022-12-25 17:32:26 +01:00
rustc_plugin_impl
rustc_privacy Prevent the creation of TraitRef without dedicated methods 2022-12-14 15:36:39 +00:00
rustc_query_impl Rollup merge of #105975 - jeremystucki:rustc-remove-needless-lifetimes, r=eholk 2022-12-24 00:31:41 +01:00
rustc_query_system Rollup merge of #105975 - jeremystucki:rustc-remove-needless-lifetimes, r=eholk 2022-12-24 00:31:41 +01:00
rustc_resolve Make resolve suggestion more generic 2022-12-27 12:16:25 -08:00
rustc_save_analysis rustc: Remove needless lifetimes 2022-12-20 22:10:40 +01:00
rustc_serialize compiler: remove unnecessary imports and qualified paths 2022-12-10 18:45:34 +01:00
rustc_session Rollup merge of #105955 - Nilstrieb:no-trivial-opt-wrappers-we-have-field-accesses-for-that, r=cjgillot 2022-12-25 22:15:00 +01:00
rustc_smir
rustc_span Rollup merge of #106172 - estebank:suggest-impl-trait, r=compiler-errors 2022-12-28 14:40:00 +01:00
rustc_symbol_mangling rustc: Remove needless lifetimes 2022-12-20 22:10:40 +01:00
rustc_target fix some typos 2022-12-25 00:43:50 +01:00
rustc_trait_selection Auto merge of #106129 - compiler-errors:compare_method-tweaks, r=BoxyUwU 2022-12-28 13:07:30 +00:00
rustc_traits rustc: Remove needless lifetimes 2022-12-20 22:10:40 +01:00
rustc_transmute Rollup merge of #105864 - matthiaskrgr:compl, r=Nilstrieb 2022-12-19 14:41:35 +05:30
rustc_ty_utils Rename some compare_method functions 2022-12-24 21:36:58 +00:00
rustc_type_ir A few small cleanups for newtype_index 2022-12-18 21:47:28 +01:00