bjoernager/rust: Empowering everyone to build reliable and efficient software. Gabriel's commits.

Empowering everyone to build reliable and efficient software. Gabriel's commits. https://www.rust-lang.org/

Find a file

bors 8bf5a8d12f Auto merge of #132833 - est31:stabilize_let_chains, r=fee1-dead Stabilize let chains in the 2024 edition # Stabilization report This proposes the stabilization of `let_chains` ([tracking issue], [RFC 2497]) in the [2024 edition] of Rust. [tracking issue]: https://github.com/rust-lang/rust/issues/53667 [RFC 2497]: https://github.com/rust-lang/rfcs/pull/2497 [2024 edition]: https://doc.rust-lang.org/nightly/edition-guide/rust-2024/index.html ## What is being stabilized The ability to `&&`-chain `let` statements inside `if` and `while` is being stabilized, allowing intermixture with boolean expressions. The patterns inside the `let` sub-expressions can be irrefutable or refutable. ```Rust struct FnCall<'a> { fn_name: &'a str, args: Vec<i32>, } fn is_legal_ident(s: &str) -> bool { s.chars() .all(\|c\| ('a'..='z').contains(&c) \|\| ('A'..='Z').contains(&c)) } impl<'a> FnCall<'a> { fn parse(s: &'a str) -> Option<Self> { if let Some((fn_name, after_name)) = s.split_once("(") && !fn_name.is_empty() && is_legal_ident(fn_name) && let Some((args_str, "")) = after_name.rsplit_once(")") { let args = args_str .split(',') .map(\|arg\| arg.parse()) .collect::<Result<Vec<_>, _>>(); args.ok().map(\|args\| FnCall { fn_name, args }) } else { None } } fn exec(&self) -> Option<i32> { let iter = self.args.iter().copied(); match self.fn_name { "sum" => Some(iter.sum()), "max" => iter.max(), "min" => iter.min(), _ => None, } } } fn main() { println!("{:?}", FnCall::parse("sum(1,2,3)").unwrap().exec()); println!("{:?}", FnCall::parse("max(4,5)").unwrap().exec()); } ``` The feature will only be stabilized for the 2024 edition and future editions. Users of past editions will get an error with a hint to update the edition. closes #53667 ## Why 2024 edition? Rust generally tries to ship new features to all editions. So even the oldest editions receive the newest features. However, sometimes a feature requires a breaking change so much that offering the feature without the breaking change makes no sense. This occurs rarely, but has happened in the 2018 edition already with `async` and `await` syntax. It required an edition boundary in order for `async`/`await` to become keywords, and the entire feature foots on those keywords. In the instance of let chains, the issue is the drop order of `if let` chains. If we want `if let` chains to be compatible with `if let`, drop order makes it hard for us to [generate correct MIR]. It would be strange to have different behaviour for `if let ... {}` and `if true && let ... {}`. So it's better to [stay consistent with `if let`]. In edition 2024, [drop order changes] have been introduced to make `if let` temporaries be lived more shortly. These changes also affected `if let` chains. These changes make sense even if you don't take the `if let` chains MIR generation problem into account. But if we want to use them as the solution to the MIR generation problem, we need to restrict let chains to edition 2024 and beyond: for let chains, it's not just a change towards more sensible behaviour, but one required for correct function. [generate correct MIR]: https://github.com/rust-lang/rust/issues/104843 [stay consistent with `if let`]: https://github.com/rust-lang/rust/pull/103293#issuecomment-1293408574 [drop order changes]: https://github.com/rust-lang/rust/issues/124085 ## Introduction considerations As edition 2024 is very new, this stabilization PR only makes it possible to use let chains on 2024 without that feature gate, it doesn't mark that feature gate as stable/removed. I would propose to continue offering the `let_chains` feature (behind a feature gate) for a limited time (maybe 3 months after stabilization?) on older editions to allow nightly users to adopt edition 2024 at their own pace. After that, the feature gate shall be marked as stabilized, not removed, and replaced by an error on editions 2021 and below. ## Implementation history * History from before March 14, 2022 can be found in the [original stabilization PR] that was reverted. * https://github.com/rust-lang/rust/pull/94927 * https://github.com/rust-lang/rust/pull/94951 * https://github.com/rust-lang/rust/pull/94974 * https://github.com/rust-lang/rust/pull/95008 * https://github.com/rust-lang/rust/pull/97295 * https://github.com/rust-lang/rust/pull/98633 * https://github.com/rust-lang/rust/pull/99731 * https://github.com/rust-lang/rust/pull/102394 * https://github.com/rust-lang/rust/pull/100526 * https://github.com/rust-lang/rust/pull/100538 * https://github.com/rust-lang/rust/pull/102998 * https://github.com/rust-lang/rust/pull/103405 * https://github.com/rust-lang/rust/pull/103293 * https://github.com/rust-lang/rust/pull/107251 * https://github.com/rust-lang/rust/pull/110568 * https://github.com/rust-lang/rust/pull/115677 * https://github.com/rust-lang/rust/pull/117743 * https://github.com/rust-lang/rust/pull/117770 * https://github.com/rust-lang/rust/pull/118191 * https://github.com/rust-lang/rust/pull/119554 * https://github.com/rust-lang/rust/pull/129394 * https://github.com/rust-lang/rust/pull/132828 * https://github.com/rust-lang/reference/pull/1179 * https://github.com/rust-lang/reference/pull/1251 * https://github.com/rust-lang/rustfmt/pull/5910 [original stabilization PR]: https://github.com/rust-lang/rust/pull/94927 ## Adoption history ### In the compiler * History before March 14, 2022 can be found in the [original stabilization PR]. * https://github.com/rust-lang/rust/pull/115983 * https://github.com/rust-lang/rust/pull/116549 * https://github.com/rust-lang/rust/pull/116688 ### Outside of the compiler * https://github.com/rust-lang/rust-clippy/pull/11750 * [rspack](https://github.com/web-infra-dev/rspack) * [risingwave](https://github.com/risingwavelabs/risingwave) * [dylint](https://github.com/trailofbits/dylint) * [convex-backend](https://github.com/get-convex/convex-backend) * [tikv](https://github.com/tikv/tikv) * [Daft](https://github.com/Eventual-Inc/Daft) * [greptimedb](https://github.com/GreptimeTeam/greptimedb) ## Tests <details> ### Intentional restrictions [`partially-macro-expanded.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2294-if-let-guard/partially-macro-expanded.rs`), [`macro-expanded.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2294-if-let-guard/macro-expanded.rs`): it is possible to use macros to expand to both the pattern and the expression inside a let chain, but not to the entire `let pat = expr` operand. [`parens.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2294-if-let-guard/parens.rs`): `if (let pat = expr)` is not allowed in chains [`ensure-that-let-else-does-not-interact-with-let-chains.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2497-if-let-chains/ensure-that-let-else-does-not-interact-with-let-chains.rs`): `let...else` doesn't support chaining. ### Overlap with match guards [`move-guard-if-let-chain.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2294-if-let-guard/move-guard-if-let-chain.rs`): test for the `use moved value` error working well in match guards. could maybe be extended with let chains that have more than one `let` [`shadowing.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2294-if-let-guard/shadowing.rs`): shadowing in if let guards works as expected [`ast-validate-guards.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2497-if-let-chains/ast-validate-guards.rs`): let chains in match guards require the match guards feature gate ### Simple cases from the early days PR #88642 has added some tests with very simple usages of `let else`, mostly as regression tests to early bugs. [`then-else-blocks.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2497-if-let-chains/then-else-blocks.rs`) [`ast-lowering-does-not-wrap-let-chains.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2497-if-let-chains/ast-lowering-does-not-wrap-let-chains.rs`) [`issue-90722.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2497-if-let-chains/issue-90722.rs`) [`issue-92145.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2497-if-let-chains/issue-92145.rs`) ### Drop order/MIR scoping tests [`issue-100276.rs`](`4adafcf40a/tests/ui/drop/issue-100276.rs`): let expressions on RHS aren't terminating scopes [`drop_order.rs`](`4adafcf40a/tests/ui/drop/drop_order.rs`): exhaustive temporary drop order test for various Rust constructs, including let chains [`scope.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2294-if-let-guard/scope.rs`): match guard scoping test [`drop-scope.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2294-if-let-guard/drop-scope.rs`): another match guard scoping test, ensuring that temporaries in if-let guards live for the arm [`drop_order_if_let_rescope.rs`](`4adafcf40a/tests/ui/drop/drop_order_if_let_rescope.rs`): if let rescoping on edition 2024, including chains [`mir_let_chains_drop_order.rs`](`4adafcf40a/tests/ui/mir/mir_let_chains_drop_order.rs`): comprehensive drop order test for let chains, distinguishes editions 2021 and 2024. [`issue-99938.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2497-if-let-chains/issue-99938.rs`), [`issue-99852.rs`](`4adafcf40a/tests/ui/mir/issue-99852.rs`) both bad MIR ICEs fixed by #102394 ### Linting [`irrefutable-lets.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2497-if-let-chains/irrefutable-lets.rs`): trailing and leading irrefutable let patterns get linted for, others don't. The lint is turned off for `else if`. [`issue-121070-let-range.rs`](`4adafcf40a/tests/ui/lint/issue-121070-let-range.rs`): regression test for false positive of the unused parens lint, precedence requires the `()`s here ### Parser: intentional restrictions [`disallowed-positions.rs`](`2128d8df0e/tests/ui/rfcs/rfc-2497-if-let-chains/disallowed-positions.rs`): `let` in expression context is rejected everywhere except at the top level [`invalid-let-in-a-valid-let-context.rs`](`4adafcf40a/tests/ui/rfcs/rfc-2497-if-let-chains/invalid-let-in-a-valid-let-context.rs`): nested `let` is not allowed (let's are no legal expressions just because they are allowed in `if` and `while`). ### Parser: recovery [`issue-103381.rs`](`4adafcf40a/tests/ui/parser/issues/issue-103381.rs`): Graceful recovery of incorrect chaining of `if` and `if let` [`semi-in-let-chain.rs`](`4adafcf40a/tests/ui/parser/semi-in-let-chain.rs`): Ensure that stray `;`s in let chains give nice errors (`if_chain!` users might be accustomed to `;`s) [`deli-ident-issue-1.rs`](`4adafcf40a/tests/ui/parser/deli-ident-issue-1.rs`), [`brace-in-let-chain.rs`](`4adafcf40a/tests/ui/parser/brace-in-let-chain.rs`): Ensure that stray unclosed `{`s in let chains give nice errors and hints ### Misc [`conflicting_bindings.rs`](`4adafcf40a/tests/ui/pattern/usefulness/conflicting_bindings.rs`): the conflicting bindings check also works in let chains. Personally, I'd extend it to chains with multiple let's as well. [`let-chains-attr.rs`](`4adafcf40a/tests/ui/expr/if/attrs/let-chains-attr.rs`): attributes work on let chains ### Tangential tests with `#![feature(let_chains)]` [`if-let.rs`](`4adafcf40a/tests/coverage/branch/if-let.rs`): MC/DC coverage tests for let chains [`logical_or_in_conditional.rs`](`4adafcf40a/tests/mir-opt/building/logical_or_in_conditional.rs`): not really about let chains, more about dropping/scoping behaviour of `\|\|` [`stringify.rs`](`4adafcf40a/tests/ui/macros/stringify.rs`): exhaustive test of the `stringify` macro [`expanded-interpolation.rs`](`4adafcf40a/tests/ui/unpretty/expanded-interpolation.rs`), [`expanded-exhaustive.rs`](`4adafcf40a/tests/ui/unpretty/expanded-exhaustive.rs`): Exhaustive test of `-Zunpretty` [`diverges-not.rs`](`4adafcf40a/tests/ui/rfcs/rfc-0000-never_patterns/diverges-not.rs`): Never type, mostly tangential to let chains </details> ## Possible future work * There is proposals to allow `if let Pat(bindings) = expr {}` to be written as `if expr is Pat(bindings) {}` ([RFC 3573]). `if let` chains are a natural extension of the already existing `if let` syntax, and I'd argue orthogonal towards `is` syntax. * https://github.com/rust-lang/lang-team/issues/297 * One could have similar chaining inside `let ... else` statements. There is no proposed RFC for this however, nor is it implemented on nightly. * Match guards have the `if` keyword as well, but on stable Rust, they don't support `let`. The functionality is available via an unstable feature ([`if_let_guard` tracking issue]). Stabilization of let chains affects this feature in so far as match guards containing let chains now only need the `if_let_guard` feature gate be present instead of also the `let_chains` feature (NOTE: this PR doesn't implement this simplification, it's left for future work). [RFC 3573]: https://github.com/rust-lang/rfcs/pull/3573 [`if_let_guard` tracking issue]: https://github.com/rust-lang/rust/issues/51114 ## Open questions / blockers - [ ] bad recovery if you don't put a `let` (I don't think this is a blocker): [#117977](https://github.com/rust-lang/rust/issues/117977) - [x] An instance where a temporary lives shorter than with nested ifs, breaking compilation: [#103476](https://github.com/rust-lang/rust/issues/103476). Personally I don't think this is a blocker either, as it's an edge case. Edit: turns out to not reproduce in edition 2025 any more, due to let rescoping. regression test added in #133093 - [x] One should probably extend the tests for `move-guard-if-let-chain.rs` and `conflicting_bindings.rs` to have chains with multiple let's: done in 133093 - [x] Parsing rejection tests: addressed by https://github.com/rust-lang/rust/pull/132828 - [x] [Style](https://rust-lang.zulipchat.com/#narrow/channel/346005-t-style/topic/let.20chains.20stabilization.20and.20formatting): https://github.com/rust-lang/rust/pull/139456 - [x] https://github.com/rust-lang/rust/issues/86730 explicitly mentions `let_else`. I think we can live with `let pat = expr` not evaluating as `expr` for macro_rules macros, especially given that `let pat = expr` is not a legal expression anywhere except inside `if` and `while`. - [x] Documentation in the reference: https://github.com/rust-lang/reference/pull/1740 - [x] Add chapter to the Rust 2024 [edition guide]: https://github.com/rust-lang/edition-guide/pull/337 - [x] Resolve open questions on desired drop order. [original reference PR]: https://github.com/rust-lang/reference/pull/1179 [edition guide]: https://github.com/rust-lang/edition-guide		2025-04-22 07:54:10 +00:00
.github	Use `rust-cache` to speed-up `citool` compilation	2025-04-15 10:04:25 +02:00
compiler	Auto merge of #132833 - est31:stabilize_let_chains, r=fee1-dead	2025-04-22 07:54:10 +00:00
library	Rollup merge of #140081 - Berrysoft:update-libc-172, r=tgross35	2025-04-22 01:22:13 +00:00
LICENSES	Synchronize Unicode license text from unicode.org	2024-11-20 00:54:12 -08:00
src	Auto merge of #140138 - ChrisDenton:rollup-zw7jibi, r=ChrisDenton	2025-04-22 04:44:13 +00:00
tests	Auto merge of #132833 - est31:stabilize_let_chains, r=fee1-dead	2025-04-22 07:54:10 +00:00
.clang-format	Add `.clang-format`	2024-06-26 05:56:00 +08:00
.editorconfig	Don't apply editorconfig to llvm	2025-02-09 16:21:14 -05:00
.git-blame-ignore-revs	git: ignore `60600a6fa4` for blame purposes	2025-04-17 11:50:24 +08:00
.gitattributes	Mark .pp files as Rust	2025-03-29 12:39:06 +01:00
.gitignore	change config.toml to bootstrap.toml for bootstrap module	2025-03-17 12:56:41 +05:30
.gitmodules	move autodiff from EnzymeAD/Enzyme to our rust-lang/Enzyme soft-fork	2025-04-01 17:17:39 -04:00
.ignore	change config.toml to bootstrap.toml for bootstrap module	2025-03-17 12:56:41 +05:30
.mailmap	Add myself to mailmap	2025-04-14 14:27:15 +01:00
bootstrap.example.toml	apply nit notes	2025-04-15 11:33:11 +03:00
Cargo.lock	Auto merge of #139727 - rust-lang:cargo_update, r=Mark-Simulacrum	2025-04-21 12:07:02 +00:00
Cargo.toml	Alphabetize the root workspace members	2025-03-13 12:21:14 -07:00
CODE_OF_CONDUCT.md
configure	Ensure `./configure` works when `configure.py` path contains spaces	2024-02-16 18:57:22 +00:00
CONTRIBUTING.md	Fix some typos	2025-03-04 16:05:32 +08:00
COPYRIGHT	dist: Re-work how we describe the licence of Rust in our distributions	2024-12-09 10:18:55 +00:00
INSTALL.md	change config.toml to bootstrap.toml for bootstrap module	2025-03-17 12:56:41 +05:30
LICENSE-APACHE
license-metadata.json	Update license metadata	2025-02-15 16:48:37 +01:00
LICENSE-MIT	dist: Re-work how we describe the licence of Rust in our distributions	2024-12-09 10:18:55 +00:00
README.md	Update Rust Foundation links in Readme	2025-03-16 19:03:40 -07:00
RELEASES.md	Apply suggestions from code review	2025-03-30 15:45:44 -07:00
REUSE.toml	change config.toml to bootstrap.toml for bootstrap module	2025-03-17 12:56:41 +05:30
rust-bors.toml	Increase timeout for new bors bot	2024-03-13 08:31:07 +01:00
rustfmt.toml	rustfmt does not support use closures yet	2025-04-07 16:53:11 -03:00
triagebot.toml	Add option for stable backport poll	2025-04-19 18:13:34 +02:00
x	Look for `python3` first on MacOS, not `py`	2025-02-13 10:24:54 -05:00
x.ps1
x.py	Reformat Python code with `ruff`	2024-12-04 23:03:44 +01:00

README.md

Website | Getting started | Learn | Documentation | Contributing

This is the main source code repository for Rust. It contains the compiler, standard library, and documentation.

Why Rust?

Performance: Fast and memory-efficient, suitable for critical services, embedded devices, and easily integrated with other languages.
Reliability: Our rich type system and ownership model ensure memory and thread safety, reducing bugs at compile-time.
Productivity: Comprehensive documentation, a compiler committed to providing great diagnostics, and advanced tooling including package manager and build tool (Cargo), auto-formatter (rustfmt), linter (Clippy) and editor support (rust-analyzer).

Quick Start

Read "Installation" from The Book.

Installing from Source

If you really want to install from source (though this is not recommended), see INSTALL.md.

Getting Help

See https://www.rust-lang.org/community for a list of chat platforms and forums.

Contributing

See CONTRIBUTING.md.

License

Rust is primarily distributed under the terms of both the MIT license and the Apache License (Version 2.0), with portions covered by various BSD-like licenses.

See LICENSE-APACHE, LICENSE-MIT, and COPYRIGHT for details.

Trademark

The Rust Foundation owns and protects the Rust and Cargo trademarks and logos (the "Rust Trademarks").

If you want to use these names or brands, please read the Rust language trademark policy.

Third-party logos may be subject to third-party copyrights and trademarks. See Licenses for details.