1
Fork 0
rust/compiler/rustc_trait_selection/src/solve
bors aca749eefc Auto merge of #121801 - zetanumbers:async_drop_glue, r=oli-obk
Add simple async drop glue generation

This is a prototype of the async drop glue generation for some simple types. Async drop glue is intended to behave very similar to the regular drop glue except for being asynchronous. Currently it does not execute synchronous drops but only calls user implementations of `AsyncDrop::async_drop` associative function and awaits the returned future. It is not complete as it only recurses into arrays, slices, tuples, and structs and does not have same sensible restrictions as the old `Drop` trait implementation like having the same bounds as the type definition, while code assumes their existence (requires a future work).

This current design uses a workaround as it does not create any custom async destructor state machine types for ADTs, but instead uses types defined in the std library called future combinators (deferred_async_drop, chain, ready_unit).

Also I recommend reading my [explainer](https://zetanumbers.github.io/book/async-drop-design.html).

This is a part of the [MCP: Low level components for async drop](https://github.com/rust-lang/compiler-team/issues/727) work.

Feature completeness:

 - [x] `AsyncDrop` trait
 - [ ] `async_drop_in_place_raw`/async drop glue generation support for
   - [x] Trivially destructible types (integers, bools, floats, string slices, pointers, references, etc.)
   - [x] Arrays and slices (array pointer is unsized into slice pointer)
   - [x] ADTs (enums, structs, unions)
   - [x] tuple-like types (tuples, closures)
   - [ ] Dynamic types (`dyn Trait`, see explainer's [proposed design](https://github.com/zetanumbers/posts/blob/main/async-drop-design.md#async-drop-glue-for-dyn-trait))
   - [ ] coroutines (https://github.com/rust-lang/rust/pull/123948)
 - [x] Async drop glue includes sync drop glue code
 - [x] Cleanup branch generation for `async_drop_in_place_raw`
 - [ ] Union rejects non-trivially async destructible fields
 - [ ] `AsyncDrop` implementation requires same bounds as type definition
 - [ ] Skip trivially destructible fields (optimization)
 - [ ] New [`TyKind::AdtAsyncDestructor`](https://github.com/zetanumbers/posts/blob/main/async-drop-design.md#adt-async-destructor-types) and get rid of combinators
 - [ ] [Synchronously undroppable types](https://github.com/zetanumbers/posts/blob/main/async-drop-design.md#exclusively-async-drop)
 - [ ] Automatic async drop at the end of the scope in async context
2024-04-23 02:10:23 +00:00
..
assembly Add simple async drop glue generation 2024-04-16 20:45:07 +03:00
eval_ctxt Remove ConstVariableOriginKind 2024-04-15 16:52:12 -04:00
inspect normalizes-to change from '1' to '0 to inf' steps 2024-04-04 12:39:58 +02:00
normalizes_to Fix copy-paste typo in the comment within consider_builtin_async_destruct_candidate 2024-04-22 15:42:07 +03:00
alias_relate.rs normalizes-to change from '1' to '0 to inf' steps 2024-04-04 12:39:58 +02:00
fulfill.rs avoid collecting into vecs in some places 2024-03-02 14:18:47 +01:00
mod.rs Eliminate DefiningAnchor now that is just a single-variant enum 2024-04-08 15:00:27 +00:00
normalize.rs Auto merge of #123537 - compiler-errors:shallow, r=lcnr 2024-04-16 21:59:36 +00:00
project_goals.rs track the source of nested goals 2023-12-18 08:47:29 +01:00
search_graph.rs NormalizesTo return nested goals 2024-03-18 15:53:16 +01:00
trait_goals.rs Add simple async drop glue generation 2024-04-16 20:45:07 +03:00