rust/compiler
Matthias Krüger 3fb1230adc
Rollup merge of #138992 - dianne:simplify-byte-string-to-pat, r=oli-obk
literal pattern lowering: use the pattern's type instead of the literal's in `const_to_pat`

This has two purposes:
- First, it enables removing the `treat_byte_string_as_slice` fields from `TypeckResults` and `ConstToPat`. A byte string pattern's type will be `&[u8]` when matching on a slice reference, so `const_to_pat` will lower it to a slice ref pattern. I believe this is tested by `tests/ui/match/pattern-deref-miscompile.rs`.
- Second, it will simplify the implementation of byte string literals in deref patterns. If byte string patterns can be given the type `[u8; N]` or `[u8]` during HIR typeck, then nothing needs to be changed in `const_to_pat` in order to lower the patterns `deref!(b"..."): Vec<u8>` and `deref!(b"..."): Box<[u8; 3]>`.

Implementation-wise, this uses `lit_to_const` to make a const with the pattern's type and the literal's valtree; that feels to me like the best way to make sure that the valtree representations of the pattern type and literal are the same. Though it may necessitate later changes to `lit_to_const` to accommodate giving byte string literal patterns non-reference types—would that be reasonable?

This unfortunately doesn't work for the `string_deref_patterns` feature (since that gives string literal patterns the `String` type), so I added a workaround for that. However, once `deref_patterns` supports string literals, it may be able to replace `string_deref_patterns`; the special case for `String` can removed at that point.

r? ``@oli-obk``
2025-04-02 19:44:12 +02:00
..
rustc Revert "Use workspace lints for crates in compiler/ #138084" 2025-03-10 18:12:47 +08:00
rustc_abi BackendRepr::is_signed: comment why this may panics 2025-03-29 12:21:51 +01:00
rustc_arena Remove #![warn(unreachable_pub)] from all compiler/ crates. 2025-03-11 13:14:21 +11:00
rustc_ast Fix a problem with metavars and inner attributes. 2025-04-02 06:21:18 +11:00
rustc_ast_ir Use -Wunused_crate_dependencies for compiler crates. 2025-03-20 08:59:43 +11:00
rustc_ast_lowering Move ast::Item::ident into ast::ItemKind. 2025-04-01 14:08:57 +11:00
rustc_ast_passes Auto merge of #138492 - lcnr:rm-inline_const_pat, r=oli-obk 2025-04-01 14:20:46 +00:00
rustc_ast_pretty Move ast::Item::ident into ast::ItemKind. 2025-04-01 14:08:57 +11:00
rustc_attr_data_structures add rustc_macro_edition_2021 2025-03-19 17:37:35 +01:00
rustc_attr_parsing Avoid kw::Empty when dealing with rustc_allowed_through_unstable_modules. 2025-03-25 16:48:03 +11:00
rustc_baked_icu_data Add unreachable_pub to RUSTC_LINT_FLAGS for compiler/ crates. 2025-03-11 13:14:21 +11:00
rustc_borrowck simplify Interner opaque types API 2025-04-01 23:24:28 +02:00
rustc_builtin_macros Address review comments. 2025-04-01 16:07:23 +11:00
rustc_codegen_cranelift Allow formatting example/gen_block_iterate.rs 2025-04-01 14:49:15 +00:00
rustc_codegen_gcc Auto merge of #138503 - bjorn3:string_merging, r=tmiasko 2025-03-28 10:18:32 +00:00
rustc_codegen_llvm Rollup merge of #138003 - sayantn:new-amx, r=Amanieu 2025-04-02 13:10:36 +11:00
rustc_codegen_ssa Store only a metadata stub into rlibs and dylibs with -Zembed-metadata=no 2025-03-31 09:44:41 +02:00
rustc_const_eval Rollup merge of #138713 - RalfJung:memory-hook-pointers, r=oli-obk 2025-03-21 06:56:47 +01:00
rustc_data_structures Add TyCtx::env_var_os 2025-03-26 15:46:05 +01:00
rustc_driver Revert "Use workspace lints for crates in compiler/ #138084" 2025-03-10 18:12:47 +08:00
rustc_driver_impl Implement supported-crate-types print request 2025-03-23 19:08:54 +08:00
rustc_error_codes Avoid kw::Empty when dealing with rustc_allowed_through_unstable_modules. 2025-03-25 16:48:03 +11:00
rustc_error_messages Rollup merge of #138404 - bjorn3:sysroot_handling_cleanup, r=petrochenkov,jieyouxu 2025-03-13 11:28:35 +01:00
rustc_errors Use abs_diff where applicable 2025-03-27 18:29:06 +00:00
rustc_expand Remove NtExpr and NtLiteral. 2025-04-02 06:20:35 +11:00
rustc_feature Rollup merge of #138003 - sayantn:new-amx, r=Amanieu 2025-04-02 13:10:36 +11:00
rustc_fluent_macro Remove #![warn(unreachable_pub)] from all compiler/ crates. 2025-03-11 13:14:21 +11:00
rustc_fs_util Revert "Use workspace lints for crates in compiler/ #138084" 2025-03-10 18:12:47 +08:00
rustc_graphviz Remove #![warn(unreachable_pub)] from all compiler/ crates. 2025-03-11 13:14:21 +11:00
rustc_hashes Revert "Use workspace lints for crates in compiler/ #138084" 2025-03-10 18:12:47 +08:00
rustc_hir Encode synthetic by-move coroutine body with a different DefPathData 2025-03-30 22:53:21 +00:00
rustc_hir_analysis Auto merge of #139018 - oli-obk:incremental-trait-impls, r=compiler-errors 2025-04-02 10:10:50 +00:00
rustc_hir_pretty Improve hir_pretty for struct expressions. 2025-03-30 11:21:51 +02:00
rustc_hir_typeck Rollup merge of #138992 - dianne:simplify-byte-string-to-pat, r=oli-obk 2025-04-02 19:44:12 +02:00
rustc_incremental Auto merge of #138629 - Zoxc:graph-anon-hashmap, r=oli-obk 2025-03-24 15:02:09 +00:00
rustc_index Use {Decodable,Encodable}_NoContext in type_ir 2025-03-15 06:34:36 +00:00
rustc_index_macros Add unreachable_pub to RUSTC_LINT_FLAGS for compiler/ crates. 2025-03-11 13:14:21 +11:00
rustc_infer simplify Interner opaque types API 2025-04-01 23:24:28 +02:00
rustc_interface Add -Zembed-metadata CLI option 2025-03-31 09:44:40 +02:00
rustc_lexer Revert "Rollup merge of #136355 - GuillaumeGomez:proc-macro_add_value_retrieval_methods, r=Amanieu" 2025-03-18 13:28:56 +01:00
rustc_lint Move ast::Item::ident into ast::ItemKind. 2025-04-01 14:08:57 +11:00
rustc_lint_defs add FCW to warn about wasm ABI transition 2025-03-25 08:22:35 +01:00
rustc_llvm PassWrapper: adapt for llvm/llvm-project@94122d58fc 2025-03-31 15:47:26 -04:00
rustc_log Use -Wunused_crate_dependencies for compiler crates. 2025-03-20 08:59:43 +11:00
rustc_macros Move codec module back into middle 2025-03-15 06:42:48 +00:00
rustc_metadata Auto merge of #139018 - oli-obk:incremental-trait-impls, r=compiler-errors 2025-04-02 10:10:50 +00:00
rustc_middle Rollup merge of #138992 - dianne:simplify-byte-string-to-pat, r=oli-obk 2025-04-02 19:44:12 +02:00
rustc_mir_build Rollup merge of #138992 - dianne:simplify-byte-string-to-pat, r=oli-obk 2025-04-02 19:44:12 +02:00
rustc_mir_dataflow Auto merge of #138414 - matthiaskrgr:rollup-9ablqdb, r=matthiaskrgr 2025-03-12 17:27:43 +00:00
rustc_mir_transform Auto merge of #139018 - oli-obk:incremental-trait-impls, r=compiler-errors 2025-04-02 10:10:50 +00:00
rustc_monomorphize Make missing optimized MIR error more informative 2025-04-01 09:25:12 +00:00
rustc_next_trait_solver simplify Interner opaque types API 2025-04-01 23:24:28 +02:00
rustc_parse Fix problem causing rusqlite compilation to OOM. 2025-04-02 06:21:18 +11:00
rustc_parse_format Slim rustc_parse_format dependencies down 2025-03-23 07:30:18 +01:00
rustc_passes Auto merge of #139018 - oli-obk:incremental-trait-impls, r=compiler-errors 2025-04-02 10:10:50 +00:00
rustc_pattern_analysis Auto merge of #133889 - compiler-errors:inh-unstable, r=Nadrieril 2025-03-20 14:31:34 +00:00
rustc_privacy privacy: Visit types and traits in impls in type privacy lints 2025-03-25 12:40:02 +03:00
rustc_query_impl Use a function to create QueryStackDeferred to ensure context is Copy 2025-03-26 13:09:36 +01:00
rustc_query_system Encode synthetic by-move coroutine body with a different DefPathData 2025-03-30 22:53:21 +00:00
rustc_resolve Rollup merge of #138790 - xizheyin:issue-138626, r=compiler-errors 2025-04-01 20:25:21 +02:00
rustc_sanitizers Encode synthetic by-move coroutine body with a different DefPathData 2025-03-30 22:53:21 +00:00
rustc_serialize Convert rustc_serialize integration tests to unit tests. 2025-03-20 08:59:50 +11:00
rustc_session Add -Zembed-metadata CLI option 2025-03-31 09:44:40 +02:00
rustc_smir Use -Wunused_crate_dependencies for compiler crates. 2025-03-20 08:59:43 +11:00
rustc_span Rollup merge of #138003 - sayantn:new-amx, r=Amanieu 2025-04-02 13:10:36 +11:00
rustc_symbol_mangling Encode synthetic by-move coroutine body with a different DefPathData 2025-03-30 22:53:21 +00:00
rustc_target Rollup merge of #138823 - a4lg:riscv-feature-addition-base-i, r=Amanieu 2025-04-02 13:10:37 +11:00
rustc_trait_selection Auto merge of #139018 - oli-obk:incremental-trait-impls, r=compiler-errors 2025-04-02 10:10:50 +00:00
rustc_traits Rollup merge of #138394 - lcnr:yeet-variant, r=compiler-errors 2025-03-12 10:19:32 -07:00
rustc_transmute Add #[cfg(test)] for Transition in dfa 2025-03-18 07:17:16 +00:00
rustc_ty_utils Don't ICE when encountering placeholders in layout computation 2025-03-24 16:57:07 +00:00
rustc_type_ir Implement lint against using Interner and InferCtxtLike in random compiler crates 2025-03-26 04:39:38 +00:00
rustc_type_ir_macros Fold visit into ty 2025-03-15 06:34:36 +00:00
stable_mir use try_fold instead of fold 2025-03-28 12:14:09 +00:00