ce45663e14
Implement `#[must_not_suspend]` implements #83310 Some notes on the impl: 1. The code that searches for the attribute on the ADT is basically copied from the `must_use` lint. It's not shared, as the logic did diverge 2. The RFC does specify that the attribute can be placed on fn's (and fn-like objects), like `must_use`. I think this is a direct copy from the `must_use` reference definition. This implementation does NOT support this, as I felt that ADT's (+ `impl Trait` + `dyn Trait`) cover the usecase's people actually want on the RFC, and adding an imp for the fn call case would be significantly harder. The `must_use` impl can do a single check at fn call stmt time, but `must_not_suspend` would need to answer the question: "for some value X with type T, find any fn call that COULD have produced this value". That would require significant changes to `generator_interior.rs`, and I would need mentorship on that. `@eholk` and I are discussing it. 3. `@estebank` do you know a way I can make the user-provided `reason` note pop out? right now it seems quite hidden Also, I am not sure if we should run perf on this r? `@nikomatsakis` |
||
|---|---|---|
| .. | ||
| nonstandard_style | ||
| array_into_iter.rs | ||
| builtin.rs | ||
| context.rs | ||
| early.rs | ||
| internal.rs | ||
| late.rs | ||
| levels.rs | ||
| lib.rs | ||
| methods.rs | ||
| non_ascii_idents.rs | ||
| non_fmt_panic.rs | ||
| nonstandard_style.rs | ||
| noop_method_call.rs | ||
| passes.rs | ||
| redundant_semicolon.rs | ||
| tests.rs | ||
| traits.rs | ||
| types.rs | ||
| unused.rs | ||