1
Fork 0
rust/compiler/rustc_errors/src
Matthias Krüger dfc5ffacd3
Rollup merge of #118756 - jyn514:colors, r=estebank
use bold magenta instead of bold white for highlighting

according to a poll of gay people in my phone, purple is the most popular color to use for highlighting

| color      | percentage |
| ---------- | ---------- |
| bold white | 6%         |
| blue       | 14%        |
| cyan       | 26%        |
| purple     | 37%        |
| magenta    | 17%        |

unfortunately, purple is not supported by 16-color terminals, which rustc apparently wants to support for some reason.
until we require support for full 256-color terms (e.g. by doing the same feature detection as we currently do for urls), we can't use it.

instead, i have collapsed the purple votes into magenta on the theory that they're close, and also because magenta is pretty.

before:
![image](9a89eee2-8b89-422e-8554-812827bb2a23)

after:
![image](5bf3a917-8a20-4afd-af3e-f9491d0d57f5)

other colors for comparison:
blue: ![image](6f199c7b-d598-4009-8ffc-6b7b1d0d1f8c)
cyan: ![image](a77e4fe3-563e-4aa5-ae92-745bb67287d1)
purple: ![image](ffe603fb-d811-4106-95a9-4dd4c955924c)
magenta without bolding: ![image](cf927e5f-8b25-4dc2-b8e7-32905a11a459)

r? ``@estebank``
2023-12-12 06:52:49 +01:00
..
json remove redundant imports 2023-12-10 10:56:22 +08:00
markdown remove redundant imports 2023-12-10 10:56:22 +08:00
annotate_snippet_emitter_writer.rs Fix clippy::needless_borrow in the compiler 2023-11-21 20:13:40 +01:00
diagnostic.rs Rollup merge of #118057 - bvanjoi:fix-118048, r=cjgillot 2023-12-09 14:05:09 +01:00
diagnostic_builder.rs Use DiagnosticBuilder::new more. 2023-12-04 18:57:42 +11:00
diagnostic_impls.rs Prevent promotion of const fn calls in inline consts 2023-09-21 09:00:22 +00:00
emitter.rs use magenta instead of bold for highlighting 2023-12-08 14:30:48 -05:00
error.rs Make translate_message return result and add tests 2023-01-08 23:35:43 +01:00
json.rs Update some more cases of "type" -> "$message_type" 2023-11-20 16:02:59 -08:00
lib.rs Inline and remove fatal_no_raise. 2023-12-04 18:57:42 +11:00
lock.rs bump windows crate 0.46 -> 0.48 in workspace 2023-05-09 18:20:13 +03:00
registry.rs refactor: statically guarantee that current error codes are documented 2023-02-26 20:12:36 +13:00
snippet.rs Create AnnotationColumn struct to fix hard tab column numbers in errors 2023-03-28 09:18:55 -04:00
styled_buffer.rs Replace some _ == _ || _ == _s with matches!(_, _ | _)s 2023-01-30 12:26:26 +00:00
tests.rs Format all the let chains in compiler 2023-10-13 08:59:36 +00:00
translation.rs Restore behavior when primary bundle is missing 2023-02-23 01:14:10 +01:00