1
Fork 0
rust/compiler/rustc_hir_analysis/src/check
bors ed43cbcb88 Auto merge of #134299 - RalfJung:remove-start, r=compiler-errors
remove support for the (unstable) #[start] attribute

As explained by `@Noratrieb:`
`#[start]` should be deleted. It's nothing but an accidentally leaked implementation detail that's a not very useful mix between "portable" entrypoint logic and bad abstraction.

I think the way the stable user-facing entrypoint should work (and works today on stable) is pretty simple:
- `std`-using cross-platform programs should use `fn main()`. the compiler, together with `std`, will then ensure that code ends up at `main` (by having a platform-specific entrypoint that gets directed through `lang_start` in `std` to `main` - but that's just an implementation detail)
- `no_std` platform-specific programs should use `#![no_main]` and define their own platform-specific entrypoint symbol with `#[no_mangle]`, like `main`, `_start`, `WinMain` or `my_embedded_platform_wants_to_start_here`. most of them only support a single platform anyways, and need cfg for the different platform's ways of passing arguments or other things *anyways*

`#[start]` is in a super weird position of being neither of those two. It tries to pretend that it's cross-platform, but its signature is  a total lie. Those arguments are just stubbed out to zero on ~~Windows~~ wasm, for example. It also only handles the platform-specific entrypoints for a few platforms that are supported by `std`, like Windows or Unix-likes. `my_embedded_platform_wants_to_start_here` can't use it, and neither could a libc-less Linux program.
So we have an attribute that only works in some cases anyways, that has a signature that's a total lie (and a signature that, as I might want to add, has changed recently, and that I definitely would not be comfortable giving *any* stability guarantees on), and where there's a pretty easy way to get things working without it in the first place.

Note that this feature has **not** been RFCed in the first place.

*This comment was posted [in May](https://github.com/rust-lang/rust/issues/29633#issuecomment-2088596042) and so far nobody spoke up in that issue with a usecase that would require keeping the attribute.*

Closes https://github.com/rust-lang/rust/issues/29633

try-job: x86_64-gnu-nopt
try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
try-job: test-various
2025-01-21 19:46:20 +00:00
..
compare_impl_item introduce LateParamRegionKind 2024-12-18 16:05:44 +01:00
check.rs remove unnecessary assertion for reference error 2025-01-17 15:41:05 +08:00
compare_impl_item.rs Report impl has stricter requirements even when RPITIT inference gets in the way 2025-01-03 02:45:29 +00:00
dropck.rs TypingMode 🤔 2024-10-29 17:01:24 +01:00
entry.rs remove support for the #[start] attribute 2025-01-21 06:59:15 -07:00
intrinsic.rs Rollup merge of #135046 - RalfJung:rustc_box_intrinsic, r=compiler-errors 2025-01-04 07:57:33 -08:00
intrinsicck.rs Clarify why a type is rejected for asm! 2024-12-11 20:17:37 +00:00
mod.rs rename BitSet to DenseBitSet 2025-01-11 11:34:01 +00:00
region.rs Rename RegionResolutionVisitor to ScopeResolutionVisitor 2025-01-09 22:17:10 +00:00
wfcheck.rs Remove some unnecessary .into() calls 2025-01-08 21:19:28 +00:00