bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity
rust/compiler/rustc_middle/src
History
bors c84d5e7078 Auto merge of #112346 - saethlin:no-comment, r=oli-obk 
Remove comments from mir-opt MIR dumps

See 363849874

In https://github.com/rust-lang/rust/pull/99780 there is mention that "there has been a zulip conversation about disabling line numbers with mixed opinions" which to me means that some people opposed this. I can't find the referenced conversation so... here we go.

The current situation is quite chaotic. It's not hard to find MIR diffs which contain

* Absolute line numbers
* Relative line numbers
* Substituted line numbers (LL)
For example: 408bbd0406/tests/mir-opt/inline/inline_shims.drop.Inline.diff (L10-L17)

And sometimes adding a comment at the top of a mir-opt test generates a diff in the test because a line number changed: https://github.com/rust-lang/rust/pull/98112/files#diff-b8cf4bcce95078e6a3faf075e9abf6864872fb28a64d95c04f04513b9e3bbd81

And irrelevant changes to the standard library can generate diffs in mir-opt tests: https://github.com/rust-lang/rust/pull/110694/files#diff-bf96b0e7c67b8b272814536888fd9428c314991e155beae1f0a2a67f0ac47b2c
769886cc35

I think we should, specifically in mir-opt tests, completely remove the comments, or insert placeholders for all line and column numbers.
2023-06-16 01:55:34 +00:00
..
dep_graph Allow LocalDefId as the argument to def_path_str 2023-04-21 22:27:20 +00:00
hir Separate AnonConst from ConstBlock in HIR. 2023-06-02 21:25:18 +00:00
infer Remove redundant InferCtxtExt::fresh_item_substs 2023-06-05 20:05:08 +00:00
middle Remove const eval limit and implement an exponential backoff lint instead 2023-05-31 10:24:17 +00:00
mir Remove comments from mir-opt MIR dumps 2023-06-15 15:19:11 -04:00
query Auto merge of #109005 - Nilstrieb:dont-forgor-too-much-from-cfg, r=petrochenkov 2023-06-07 17:38:57 +00:00
thir offset_of 2023-04-21 02:14:02 -07:00
traits Rollup merge of #112165 - fee1-dead-contrib:rn-defualtness, r=compiler-errors 2023-06-02 18:12:45 +02:00
ty change std::marker::Sized to just Sized 2023-06-15 12:01:38 +02:00
util Move expansion of query macros in rustc_middle to rustc_middle::query 2023-05-15 08:49:13 +02:00
arena.rs Remember names of cfg-ed out items to mention them in diagnostics 2023-06-01 19:17:19 +02:00
error.rs Use translatable diagnostics in rustc_const_eval 2023-06-01 14:45:18 +00:00
lib.rs s/drain_filter/extract_if/ for Vec, Btree{Map,Set} and LinkedList 2023-06-14 09:28:54 +02:00
lint.rs Use Cow in {D,Subd}iagnosticMessage. 2023-05-29 09:23:43 +10:00
macros.rs Simplify CloneLiftImpls and TrivialTypeTraversalImpls. 2023-04-16 14:19:50 +10:00
metadata.rs rustc_metadata: Remove Span from ModChild 2023-04-18 17:25:04 +03:00
tests.rs
thir.rs Remove unused TypeFoldable/TypeVisitable impls. 2023-04-26 15:19:50 +10:00
values.rs EarlyBinder::new -> EarlyBinder::bind 2023-05-29 13:46:10 +02:00