d82219a4fa
Previously, we unconditionally set the bitwidth to 128-bits, the largest an discrimnator would possibly be. Then, LLVM would cut down the constant by chopping off leading zeroes before emitting the DWARF. LLVM only supported 64-bit descriminators, so this would also have occasionally resulted in truncated data (or an assert) if more than 64-bits were used. LLVM added support for 128-bit enumerators in llvm/llvm-project#125578 That patchset also trusts the constant to describe how wide the variant tag is. As a result, we went from emitting tags that looked like: DW_AT_discr_value (0xfe) (`form1`) to emitting tags that looked like: DW_AT_discr_value (<0x10> fe ff ff ff 00 00 00 00 00 00 00 00 00 00 00 00 ) This makes the `DW_AT_discr_value` encode at the bitwidth of the tag, which: 1. Is probably closer to our intentions in terms of describing the data. 2. Doesn't invoke the 128-bit support which may not be supported by all debuggers / downstream tools. 3. Will result in smaller debug information.
47 lines
1.2 KiB
Rust
47 lines
1.2 KiB
Rust
//! This tests that optimized enum debug info accurately reflects the enum layout.
|
|
//! This is ignored for the fallback mode on MSVC due to problems with PDB.
|
|
//!
|
|
//@ compile-flags: -g -C no-prepopulate-passes
|
|
//@ ignore-msvc
|
|
//
|
|
// CHECK: {{.*}}DICompositeType{{.*}}tag: DW_TAG_variant_part,{{.*}}size: 32,{{.*}}
|
|
// CHECK: {{.*}}DIDerivedType{{.*}}tag: DW_TAG_member,{{.*}}name: "Placeholder",{{.*}}extraData: i32 -1{{[,)].*}}
|
|
// CHECK: {{.*}}DIDerivedType{{.*}}tag: DW_TAG_member,{{.*}}name: "Error",{{.*}}extraData: i32 0{{[,)].*}}
|
|
#![feature(never_type)]
|
|
|
|
#[derive(Copy, Clone)]
|
|
pub struct Entity {
|
|
private: std::num::NonZero<u32>,
|
|
}
|
|
|
|
#[derive(Copy, Clone, PartialEq, Eq)]
|
|
pub struct Declaration;
|
|
|
|
impl TypeFamily for Declaration {
|
|
type Base = Base;
|
|
type Placeholder = !;
|
|
|
|
fn intern_base_data(_: BaseKind<Self>) {}
|
|
}
|
|
|
|
#[derive(Copy, Clone)]
|
|
pub struct Base;
|
|
|
|
pub trait TypeFamily: Copy + 'static {
|
|
type Base: Copy;
|
|
type Placeholder: Copy;
|
|
|
|
fn intern_base_data(_: BaseKind<Self>);
|
|
}
|
|
|
|
#[derive(Copy, Clone)]
|
|
pub enum BaseKind<F: TypeFamily> {
|
|
Named(Entity),
|
|
Placeholder(F::Placeholder),
|
|
Error,
|
|
}
|
|
|
|
pub fn main() {
|
|
let x = BaseKind::Error::<Declaration>;
|
|
let y = 7;
|
|
}
|