fee1-dead
99529b0cd2
Rollup merge of #106549 - wcampbell0x2a:use-fmt-named-parameters-borrowck, r=estebank
...
Use fmt named parameters in rustc_borrowck
2023-01-09 23:35:31 +08:00
wcampbell
d0cf7e3bf5
Use fmt named parameters in rustc_borrowck
2023-01-06 19:34:45 -05:00
Esteban Küber
ce6b7179af
Detect closures assigned to binding in block
...
Fix #58497 .
2023-01-05 21:29:36 +00:00
Michael Goulet
5ce6311f34
Rollup merge of #106403 - compiler-errors:rename-hir-methods, r=cjgillot
...
Rename `hir::Map::{get_,find_}parent_node` to `hir::Map::{,opt_}parent_id`, and add `hir::Map::{get,find}_parent`
The `hir::Map::get_parent_node` function doesn't return a `Node`, and I think that's quite confusing. Let's rename it to something that sounds more like something that gets the parent hir id => `hir::Map::parent_id`. Same with `find_parent_node` => `opt_parent_id`.
Also, combine `hir.get(hir.parent_id(hir_id))` and similar `hir.find(hir.parent_id(hir_id))` function into new functions that actually retrieve the parent node in one call. This last commit is the only one that might need to be looked at closely.
2023-01-04 20:36:28 -08:00
Michael Goulet
2baee88bdb
Address comments
2023-01-04 00:51:50 +00:00
Michael Goulet
7690fe3bc6
Simplify some iterator combinators
2023-01-04 00:48:07 +00:00
Michael Goulet
a313ef05a7
rename get_parent_node to parent_id
2023-01-04 00:43:13 +00:00
Nilstrieb
9067e4417e
Rename Rptr to Ref in AST and HIR
...
The name makes a lot more sense, and `ty::TyKind` calls it `Ref` already
as well.
2022-12-28 18:52:36 +01:00
bors
0ca50032ce
Auto merge of #106095 - estebank:pin-mut-reborrow, r=compiler-errors
...
Suggest `Pin::as_mut` when encountering borrow error
Fix #65409 for `Pin<&mut T>`.
2022-12-27 07:31:42 +00:00
Esteban Küber
bd890f9cd1
Remove redundant clone suggestion
2022-12-25 17:16:54 -08:00
Matthias Krüger
3af7df91fc
use &str / String literals instead of format!()
2022-12-18 16:17:46 +01:00
Oli Scherer
a5cd3bde95
Ensure no one constructs AliasTys themselves
2022-12-14 15:36:39 +00:00
Michael Goulet
61adaf8187
Combine projection and opaque into alias
2022-12-13 17:48:55 +00:00
Michael Goulet
c13bd83528
squash OpaqueTy and ProjectionTy into AliasTy
2022-12-13 17:40:27 +00:00
Michael Goulet
7f3af72606
Use ty::OpaqueTy everywhere
2022-12-13 17:29:26 +00:00
Takayuki Maeda
ee40a67cd9
remove unnecessary uses of clone
2022-12-13 02:06:24 +09:00
Maybe Waffle
c75817fb1b
rustc_borrowck: remove ref patterns
2022-12-06 14:45:58 +00:00
Bruno A. Muciño
7a378dd0fb
Avoid ICE if the Clone trait is not found while building error suggestions
2022-11-27 20:50:13 -06:00
bors
454784afba
Auto merge of #104048 - cjgillot:split-lifetime, r=compiler-errors
...
Separate lifetime ident from lifetime resolution in HIR
Drive-by: change how suggested generic args are computed.
Fixes https://github.com/rust-lang/rust/issues/103815
I recommend reviewing commit-by-commit.
2022-11-27 14:30:19 +00:00
Guillaume Gomez
a2e485c25c
Rollup merge of #104786 - WaffleLapkin:amp-mut-help, r=compiler-errors
...
Use the power of adding helper function to simplify code w/ `Mutability`
r? `@compiler-errors`
2022-11-26 17:47:23 +01:00
Santiago Pastorino
974e2837bb
Introduce PredicateKind::Clause
2022-11-25 00:04:54 -03:00
Esteban Küber
78b8d126db
Fix rebase
2022-11-23 13:06:27 -08:00
Maybe Waffle
4439f1f6a6
Add Mutability::mutably_str
2022-11-23 20:39:16 +00:00
Maybe Waffle
da40965300
Add Mutability::{is_mut,is_not}
2022-11-23 20:26:31 +00:00
Esteban Küber
0da4c44190
Account for closures
2022-11-23 12:17:48 -08:00
Esteban Küber
3a471b5fd8
Account for x @ y and suggest ref x @ ref y
2022-11-23 12:17:48 -08:00
Esteban Küber
3c905d4ccd
review comments: inline bindings and fix typo
2022-11-23 12:17:48 -08:00
Esteban Küber
5993f5d0f8
Tweak output to account for alternative bindings in the same pattern
2022-11-23 12:17:47 -08:00
Esteban Küber
e6e7a6db28
Fix wording
2022-11-23 12:17:47 -08:00
Esteban Küber
d687d46f68
Tweak output in for loops
...
Do not suggest `.clone()` as we already suggest borrowing the iterated
value.
2022-11-23 12:17:47 -08:00
Esteban Küber
c0e481731b
Remove logic duplication
2022-11-23 12:17:47 -08:00
Esteban Küber
42d7174bbc
Extract suggestion logic to its own method
2022-11-23 12:17:47 -08:00
Esteban Küber
14a3d572e6
Use type_implements_trait
2022-11-23 12:17:47 -08:00
Esteban Küber
4a51f37bcb
Do not suggest ref multiple times for the same binding
2022-11-23 12:17:47 -08:00
Esteban Küber
9e72e35ceb
Suggest .clone() or ref binding on E0382
2022-11-23 12:17:47 -08:00
Maybe Waffle
8195e12dd9
Add Mutability::ref_prefix_str, order Mutability, simplify code
2022-11-23 19:36:27 +00:00
Camille GILLOT
fb7d25e978
Separate lifetime ident from resolution in HIR.
2022-11-23 19:33:06 +00:00
Maybe Waffle
b80356a5ab
Use tcx.require_lang_item instead of unwrapping
2022-11-22 17:19:19 +00:00
Oli Scherer
7658e0fccf
Stop passing the self-type as a separate argument.
2022-11-21 20:39:46 +00:00
Manish Goregaokar
a13809ae51
Rollup merge of #103960 - AndyJado:var_path_only_diag, r=davidtwco
...
piece of diagnostic migrate
r? `@davidtwco`
2022-11-11 12:12:30 -05:00
Manish Goregaokar
46bc12c95a
Rollup merge of #103307 - b4den:master, r=estebank
...
Add context to compiler error message
Changed `creates a temporary which is freed while still in use` to `creates a temporary value which is freed while still in use`.
2022-11-09 15:39:02 -05:00
AndyJado
057d8e5c43
struct error E0505
2022-11-09 21:15:31 +08:00
AndyJado
abf259cc54
var_subdiag refinement
...
trim old
2022-11-09 21:15:29 +08:00
AndyJado
a0cee0ab90
remove old var_span_path_only
...
doc comment
2022-11-09 20:51:43 +08:00
AndyJado
e49d10db14
first move on a nested span_label
...
Apply suggestions from code review
Co-authored-by: David Wood <agile.lion3441@fuligin.ink>
2022-11-05 19:43:48 +08:00
Michael Goulet
41e4218d2a
Use TraitEngine less
2022-11-02 04:11:05 +00:00
Michael Goulet
dce44faf5b
Revert "Make ClosureOutlivesRequirement not rely on an unresolved type"
...
This reverts commit a6b5f95fb0
2022-10-27 16:15:11 +00:00
b4den
c87567cbfa
Add context to compiler error message
...
Changed `creates a temporary which is freed while still in use` to
`creates a temporary value which is freed while still in use`
2022-10-20 15:44:25 +01:00
bors
542febd2d3
Auto merge of #103290 - matthiaskrgr:rollup-ngozai3, r=matthiaskrgr
...
Rollup of 6 pull requests
Successful merges:
- #103197 (Stabilize proc_macro::Span::source_text)
- #103251 (Fix item declaration highlighting)
- #103262 (Adjusting test to needs-unwind, with linking issue)
- #103268 (rustdoc: remove no-op CSS `nav.sub { font-size: 1rem }`)
- #103272 (Remove extra spaces in docs)
- #103276 (Erase regions before checking for `Default` in uninitialized binding error)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2022-10-20 13:33:50 +00:00
Michael Goulet
c5c9f74829
Erase regions before checking for default in uninitialized binding error
2022-10-19 23:36:28 +00:00
