许杰友 Jieyou Xu (Joe)
1f1bf4c71b
run_make_support: use fs
internally, but rfs
to tests
2024-07-17 13:32:29 +00:00
许杰友 Jieyou Xu (Joe)
a00b860bfc
tests: update rustdoc test for renamed assert_dirs_are_equal
2024-07-17 13:32:29 +00:00
许杰友 Jieyou Xu (Joe)
30bdc4a309
run_make_support: rename assert_recursive_eq
to assert_dirs_are_equal
2024-07-17 13:32:29 +00:00
许杰友 Jieyou Xu (Joe)
57a2f76557
run_make_support: moved some helpers into string
module
2024-07-17 13:32:29 +00:00
许杰友 Jieyou Xu (Joe)
0dfecb3855
run_make_support: move some helpers from assertion to path
2024-07-17 13:32:29 +00:00
许杰友 Jieyou Xu (Joe)
636be91cc0
tests: update for renamed fs
module in run_make_support
2024-07-17 13:32:29 +00:00
许杰友 Jieyou Xu (Joe)
e1569fde3e
run_make_support: coalesce fs helpers into single fs
module
...
There were *two* `read_dir` helpers, one being a simple
`std::fs::read_dir` wrapper, the other has a different callback-based
signature. We also rename the callback-based `read_dir` as
`read_dir_entries`.
Also don't top-level re-export most `fs::*` helpers.
2024-07-17 13:32:28 +00:00
bors
08cdc2fa1a
Auto merge of #127851 - tgross35:rollup-i39um74, r=tgross35
...
Rollup of 4 pull requests
Successful merges:
- #127763 (Make more Windows functions `#![deny(unsafe_op_in_unsafe_fn)]`)
- #127813 (Prevent double reference in generic futex)
- #127847 (Reviewer on vacation)
- #127850 (bootstrap: open `llvm-config` as r+w)
r? `@ghost`
`@rustbot` modify labels: rollup
2024-07-17 13:20:54 +00:00
许杰友 Jieyou Xu (Joe)
13a1751061
run_make_support: rename cygpath_windows
to get_windows_path
and move under external_deps
as private
2024-07-17 12:48:23 +00:00
许杰友 Jieyou Xu (Joe)
a443dc4ecd
run_make_support: rename env_checked
-> env
2024-07-17 12:48:22 +00:00
许杰友 Jieyou Xu (Joe)
b7f7205212
run_make_support: move build_native_static_lib
under external_deps
...
And fix some `ar`-related rebase mishaps.
2024-07-17 12:48:22 +00:00
许杰友 Jieyou Xu (Joe)
aadd08576d
run_make_support: make set_host_rpath
private and move into util
2024-07-17 12:48:22 +00:00
许杰友 Jieyou Xu (Joe)
e956808c6c
run_make_support: move handle_failed_output
into util
module
2024-07-17 12:48:22 +00:00
许杰友 Jieyou Xu (Joe)
88fd1df017
run_make_support: move assert_recursive_eq
into assertion_helpers
2024-07-17 12:48:22 +00:00
许杰友 Jieyou Xu (Joe)
56cbfa8749
tests: update rustdoc test for renamed assert_recursive_eq
2024-07-17 12:48:22 +00:00
许杰友 Jieyou Xu (Joe)
230804dc3a
run_make_support: rename recursive_diff
to assert_recursive_eq
2024-07-17 12:48:22 +00:00
许杰友 Jieyou Xu (Joe)
f66d3d33e4
run_make_support: move assertions and helpers into own module
2024-07-17 12:48:22 +00:00
许杰友 Jieyou Xu (Joe)
66cef19d11
run_make_support: move run_in_tmpdir
and test_while_readonly
to scoped_run
module
2024-07-17 12:48:22 +00:00
许杰友 Jieyou Xu (Joe)
17212abd1a
run_make_support: move fs helpers to own module
2024-07-17 12:48:22 +00:00
许杰友 Jieyou Xu (Joe)
dc9531533c
run_make_support: move path-related helpers into own module
2024-07-17 12:48:22 +00:00
许杰友 Jieyou Xu (Joe)
483328d401
run_make_support: move artifact name helpers into artifact_names
module
2024-07-17 12:48:22 +00:00
许杰友 Jieyou Xu (Joe)
439c6f60c7
run_make_support: move ar
into own module
2024-07-17 12:48:22 +00:00
许杰友 Jieyou Xu (Joe)
f042e72d1e
run_make_support: cleanup and document some lib.rs reexports
2024-07-17 12:48:22 +00:00
许杰友 Jieyou Xu (Joe)
288c572745
run_make_support: move external deps to external_deps
module
2024-07-17 12:48:21 +00:00
许杰友 Jieyou Xu (Joe)
a02008edac
run_make_support: move env_var{,_os}
into env_checked
module
2024-07-17 12:48:21 +00:00
许杰友 Jieyou Xu (Joe)
544dda3828
run_make_support: move target checks into targets
module
2024-07-17 12:48:21 +00:00
许杰友 Jieyou Xu (Joe)
427cf94106
run_make_support: move impl_common_helpers
into own macros
module
2024-07-17 12:48:21 +00:00
Tobias Bucher
2162f3f34b
Mention how you can go from BorrowedFd
to OwnedFd
and back
2024-07-17 14:34:00 +02:00
Tobias Bucher
538b31e977
Make language around ToOwned
for BorrowedFd
more precise
2024-07-17 14:33:39 +02:00
Kriskras99
99f879c32f
Document the column numbers for the dbg! macro
...
The line numbers were also made consistent, some examples used the line numbers as shown on the playground while others used the line numbers that you would expect when just seeing the documentation.
The second option was chosen to make everything consistent.
2024-07-17 14:10:41 +02:00
Ralf Jung
f9c0d3370f
ptr::metadata: update comment on vtable_ptr work-around
2024-07-17 13:56:25 +02:00
Ralf Jung
21dc49c587
ptr::metadata: avoid references to extern types
2024-07-17 13:50:01 +02:00
yukang
2c2ef6ce9d
add chenyukang to review rotation
2024-07-17 19:12:05 +08:00
yukang
40e07a3ab1
Remove invalid further restricting for type bound
2024-07-17 19:08:37 +08:00
bors
3de0a7c716
Auto merge of #127602 - onur-ozkan:calling-order, r=Kobzol
...
maintain the given order on step execution
Previously step execution disregarded the CLI order and this change executes the given steps in the order specified on CLI.
For example, running `x $kind a b c` will execute `$kind` step for `a`, then `b`, then `c` crates in the specified order.
Fixes #126165
cc `@matthiaskrgr`
2024-07-17 10:57:17 +00:00
onur-ozkan
4ad753af91
maintain the given order on step execution
...
Previously step execution disregarded the CLI order and this change executes the given
steps in the order specified on CLI.
For example, running `x $kind a b c` will execute `$kind` step for `a`, then `b`, then `c` crates
in the specified order.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
2024-07-17 12:37:36 +03:00
Trevor Gross
f99f61b272
Rollup merge of #127850 - jieyouxu:bootstrap-llvm-config, r=onur-ozkan
...
bootstrap: open `llvm-config` as r+w
This previously failed on Windows and prevented building on Windows for compiler stuff because the `llvm-config` file was open as read-only.
Tested locally on a Windows machine.
Fixes #127849 .
2024-07-17 04:06:01 -05:00
Trevor Gross
5d7466efb8
Rollup merge of #127847 - ChrisDenton:vacation, r=jhpratt
...
Reviewer on vacation
``@jhpratt`` asked to be set as on vacation
2024-07-17 04:06:00 -05:00
Trevor Gross
599d32414b
Rollup merge of #127813 - ChrisDenton:win-futex, r=joboet
...
Prevent double reference in generic futex
In the Windows futex implementation we were a little lax at allowing references to references (i.e. `&&`) which can lead to deadlocks due to reading the wrong memory address. This uses a trait to tighten the constraints and ensure this doesn't happen.
r? libs
2024-07-17 04:05:59 -05:00
Trevor Gross
56f95559da
Rollup merge of #127763 - ChrisDenton:safe-unsafe-unsafe, r=tgross35
...
Make more Windows functions `#![deny(unsafe_op_in_unsafe_fn)]`
As part of #127747 , I've evaluated some more Windows functions and added `unsafe` blocks where necessary. Some are just trivial wrappers that "inherit" the full unsafety of their function, but for others I've added some safety comments. A few functions weren't actually unsafe at all. I think they were just using `unsafe fn` to avoid an `unsafe {}` block.
I'm not touching `c.rs` yet because that is partially being addressed by another PR and also I have plans to further reduce the number of wrapper functions we have in there.
r? libs
2024-07-17 04:05:59 -05:00
许杰友 Jieyou Xu (Joe)
3bee50736d
bootstrap: open llvm_config as r+w
...
This previously failed on Windows because the `llvm_config` file was
open as read-only.
2024-07-17 17:00:06 +08:00
Chris Denton
a216a34ef3
jhpratt on vacation
2024-07-17 07:53:02 +00:00
Jubilee Young
d47cb26ddd
unix: unsafe-wrap install_main_guard_default
2024-07-17 00:08:05 -07:00
Jubilee Young
6ed563d491
unix: clean up install_main_guard_freebsd
...
This just was a mess.
2024-07-17 00:06:27 -07:00
Jubilee Young
e285c95cee
unix: stack_start_aligned is a safe fn
...
This function is purely informative, answering where a stack starts.
This is a safe operation, even if an answer requires unsafe code,
and even if the result is some unsafe code decides to trust the answer.
It also doesn't need to fetch the PAGE_SIZE when its caller just did so!
Let's complicate its signature and in doing so simplify its operation.
This allows sprinkling around #[forbid(unsafe_op_in_unsafe_fn)]
2024-07-16 23:46:03 -07:00
Jubilee Young
17c70a9aac
unix: split stack_overflow::install_main_guard by os
2024-07-16 23:32:02 -07:00
Chris Denton
0585c4a23e
Prevent double reference in generic futex
2024-07-17 05:57:39 +00:00
bors
cb12b52f16
Auto merge of #127838 - weihanglo:update-cargo, r=weihanglo
...
Update cargo
31 commits in 154fdac39ae9629954e19e9986fd2cf2cdd8d964..a2b58c3dad4d554ba01ed6c45c41ff85390560f2
2024-07-07 01:28:23 +0000 to 2024-07-16 00:52:02 +0000
- chore(ci): bump CI tools (rust-lang/cargo#14257 )
- test: migrate fetch and list_availables to snapbox (rust-lang/cargo#14214 )
- chore: downgrade to jobserver@0.1.28 (rust-lang/cargo#14254 )
- perf(source): Don't `du` on every git source load (rust-lang/cargo#14252 )
- fix(source): Don't warn about unreferenced duplicate packages (rust-lang/cargo#14239 )
- feat(test): Add cargo_test to test-support prelude (rust-lang/cargo#14243 )
- Add workflow to publish Cargo automatically (rust-lang/cargo#14202 )
- test: migrate implicit_features to snapbox (rust-lang/cargo#14245 )
- test: migrate build-std/main to snapbox (rust-lang/cargo#14241 )
- test: migrate check_cfg to snapbox (rust-lang/cargo#14235 )
- refactor(source): More RecursivePathSource clean up (rust-lang/cargo#14231 )
- Add more profiling traces (rust-lang/cargo#14238 )
- fix(overrides): Don't warn on duplicate packages from using '..' (rust-lang/cargo#14234 )
- fix(test): Redact elapsed time in the minutes time frame (rust-lang/cargo#14233 )
- test: Migrate lto tests to snapbox (rust-lang/cargo#14209 )
- fix: Ensure dep/feature activates the dependency on 2024 (rust-lang/cargo#14221 )
- chore(docs): update index of reference (rust-lang/cargo#14228 )
- test: migrate test to snapbox (rust-lang/cargo#14226 )
- chore: remove duplicate words (rust-lang/cargo#14229 )
- docs(contrib): Document things I look for in RFCs (rust-lang/cargo#14222 )
- docs(ref): Note MSRV for features in the docs (rust-lang/cargo#14224 )
- test(progress): Resolve flakiness (rust-lang/cargo#14223 )
- fix(test): Reduce over-prescription to the caller (rust-lang/cargo#14217 )
- refactor: move get_source_id out of registry (rust-lang/cargo#14218 )
- fix: rename to `rustdoc::broken_intra_doc_links` (rust-lang/cargo#14215 )
- test: migrate member_errors, multitarget and new to snapbox (rust-lang/cargo#14210 )
- test: migrate generate_lockfile and glob_targets to snapbox (rust-lang/cargo#14200 )
- test: Ensure --list test works with cargo-bloat (rust-lang/cargo#14213 )
- dont make new constant InternedString in hot path (rust-lang/cargo#14211 )
- Fix compatible_with_older_cargo test. (rust-lang/cargo#14212 )
- test: migrate metabuild, metadata and net_config to snapbox (rust-lang/cargo#14162 )
2024-07-17 05:55:06 +00:00
Chris Denton
2043de12a3
Narrow the scope of the ReadFile unsafe block
2024-07-17 05:53:20 +00:00
Chris Denton
a33abbba98
forbid(unsafe_op_in_unsafe_fn) in sys/os_str
2024-07-17 05:52:38 +00:00