AndyJado
a0cee0ab90
remove old var_span_path_only
...
doc comment
2022-11-09 20:51:43 +08:00
AndyJado
e49d10db14
first move on a nested span_label
...
Apply suggestions from code review
Co-authored-by: David Wood <agile.lion3441@fuligin.ink>
2022-11-05 19:43:48 +08:00
Michael Goulet
41e4218d2a
Use TraitEngine less
2022-11-02 04:11:05 +00:00
Michael Goulet
dce44faf5b
Revert "Make ClosureOutlivesRequirement not rely on an unresolved type"
...
This reverts commit a6b5f95fb0
.
2022-10-27 16:15:11 +00:00
bors
542febd2d3
Auto merge of #103290 - matthiaskrgr:rollup-ngozai3, r=matthiaskrgr
...
Rollup of 6 pull requests
Successful merges:
- #103197 (Stabilize proc_macro::Span::source_text)
- #103251 (Fix item declaration highlighting)
- #103262 (Adjusting test to needs-unwind, with linking issue)
- #103268 (rustdoc: remove no-op CSS `nav.sub { font-size: 1rem }`)
- #103272 (Remove extra spaces in docs)
- #103276 (Erase regions before checking for `Default` in uninitialized binding error)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2022-10-20 13:33:50 +00:00
Michael Goulet
c5c9f74829
Erase regions before checking for default in uninitialized binding error
2022-10-19 23:36:28 +00:00
Michael Goulet
a6b5f95fb0
Make ClosureOutlivesRequirement not rely on an unresolved type
2022-10-19 17:10:59 +00:00
Cameron Steffen
283abbf0e7
Change InferCtxtBuilder from enter to build
2022-10-07 07:10:40 -05:00
bors
84946fe241
Auto merge of #102184 - chenyukang:fix-102087-add-binding-sugg, r=nagisa
...
Suggest Default::default() when binding isn't initialized
Fixes #102087
2022-09-26 11:41:58 +00:00
yukang
672e3f4d77
fix #102087 , Suggest Default::default() when binding isn't initialized
2022-09-26 07:56:26 +08:00
fee1-dead
084029f39d
Rollup merge of #101431 - compiler-errors:move-place-ty-for-move-place-sugg, r=cjgillot
...
Look at move place's type when suggesting mutable reborrow
Not sure why we are looking at the use site's ty instead of the move site's ty in order to suggest reborrowing the move site, but it was suppressing a perfectly valid reborrow suggestion.
r? `@estebank` who i think touched this last in 520461f1fb
, though that was quite a while ago so feel free to reassign.
2022-09-25 22:06:37 +08:00
bors
4136b59b7d
Auto merge of #99806 - oli-obk:unconstrained_opaque_type, r=estebank
...
Allow patterns to constrain the hidden type of opaque types
fixes #96572
reverts a revert as original PR was a perf regression that was fixed by reverting it: https://github.com/rust-lang/rust/pull/99368#issuecomment-1186587864 )
TODO:
* check if https://github.com/rust-lang/rust/issues/99685 is avoided
2022-09-20 12:09:52 +00:00
lcnr
647052fc04
remove the Subst
trait, always use EarlyBinder
2022-09-19 11:37:27 +02:00
Oli Scherer
40e2de8c41
Revert "Revert "Rollup merge of #98582 - oli-obk:unconstrained_opaque_type, r=estebank""
...
This reverts commit 4a742a691e
.
2022-09-16 11:36:39 +00:00
Michael Goulet
7e226e6d3f
Look at move place's type when suggesting mutable reborrow
2022-09-05 05:00:33 +00:00
Michael Goulet
41d4ea2314
Don't suggest reborrow if usage is inside a closure
2022-09-05 04:27:07 +00:00
Jack Huey
8033c3c27d
Various changes to logging of borrowck-related code
2022-08-29 10:59:21 -04:00
Michael Goulet
a2b6744af0
Use &mut Diagnostic instead of &mut DiagnosticBuilder unless needed
2022-08-10 03:45:42 +00:00
Matthias Krüger
01ccde5ec8
Rollup merge of #100095 - jackh726:early-binder, r=lcnr
...
More EarlyBinder cleanups
Each commit is independent
r? types
2022-08-04 22:25:04 +02:00
klensy
0548e8ed06
fix trailing whitespace in error message
2022-08-03 15:46:34 +03:00
Jack Huey
e21624dc80
Add bound_predicates_of and bound_explicit_predicates_of
2022-08-02 22:44:08 -04:00
Obei Sideg
86dd457e6a
Improve cannot move out of
error message
2022-07-31 21:06:43 +03:00
Dylan DPC
403c1b3802
Rollup merge of #99186 - camsteffen:closure-localdefid, r=cjgillot
...
Use LocalDefId for closures more
2022-07-31 17:36:40 +05:30
Cameron Steffen
cf2433a74f
Use LocalDefId for closures more
2022-07-30 15:59:17 -05:00
Miguel Guarniz
25bdc8965e
Change maybe_body_owned_by to take local def id
...
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
2022-07-29 18:25:58 -04:00
Oli Scherer
4a742a691e
Revert "Rollup merge of #98582 - oli-obk:unconstrained_opaque_type, r=estebank"
...
This reverts commit 6f8fb911ad
, reversing
changes made to 7210e46dc6
.
2022-07-20 07:55:58 +00:00
Matthias Krüger
6277ac2fb8
Rollup merge of #99342 - TaKO8Ki:avoid-symbol-to-string-conversions, r=compiler-errors
...
Avoid some `Symbol` to `String` conversions
This patch removes some Symbol to String conversions.
2022-07-16 22:30:56 +02:00
Matthias Krüger
984ef421fd
Rollup merge of #99258 - estebank:suggest-let, r=wesleywiser
...
Provide structured suggestion for dropped temp value
2022-07-16 22:30:49 +02:00
Takayuki Maeda
c54d4ada26
avoid some Symbol
to String
conversions
2022-07-17 04:09:20 +09:00
Esteban Küber
3ee4e5f704
Fix rebase
2022-07-15 11:14:06 -07:00
Esteban Küber
635c38187b
Avoid incorrect suggestion
...
We check that there's a single level of block nesting to ensure always
correct suggestions. If we don't, then we only provide a free-form
message to avoid misleading users in cases like
`src/test/ui/nll/borrowed-temporary-error.rs`.
We could expand the analysis to suggest hoising all of the relevant
parts of the users' code to make the code compile, but that could be
too much.
2022-07-15 11:04:45 -07:00
Esteban Küber
20b5aaf111
Provide structured suggestion for dropped temp value
2022-07-15 11:04:45 -07:00
Oli Scherer
84a444a1f4
Introduce opaque type to hidden type projection
2022-07-15 15:49:22 +00:00
Takayuki Maeda
5188bdbccd
remove an unnecessary span_to_snippet
2022-07-13 13:24:06 +09:00
Takayuki Maeda
018155c3a2
rename a method
2022-07-11 16:51:19 +09:00
Takayuki Maeda
12d11e9a35
implement is_accessible_span
2022-07-11 11:36:15 +09:00
Esteban Küber
d09851cfba
Wording tweak
2022-07-07 12:25:56 -07:00
Esteban Küber
5f91614d12
Fix label on uninit binding field assignment
2022-07-07 12:25:56 -07:00
Esteban Küber
a86fa4fa38
Avoid misleading message/label in match-cfg-fake-edges.rs
test
2022-07-07 12:25:56 -07:00
Esteban Küber
95923d1676
Review comments: wording
2022-07-07 12:25:56 -07:00
Esteban Küber
9cb1874cd6
Tweak wording and spans
2022-07-07 12:25:56 -07:00
Esteban Küber
29e2aa12ff
On partial uninit error point at where we need init
...
When a binding is declared without a value, borrowck verifies that all
codepaths have *one* assignment to them to initialize them fully. If
there are any cases where a condition can be met that leaves the binding
uninitialized or we attempt to initialize a field of an unitialized
binding, we emit E0381.
We now look at all the statements that initialize the binding, and use
them to explore branching code paths that *don't* and point at them. If
we find *no* potential places where an assignment to the binding might
be missing, we display the spans of all the existing initializers to
provide some context.
2022-07-07 12:25:55 -07:00
Tomasz Miąsko
39d9c1cb1f
Move predecessors
from Body to BasicBlocks
2022-07-07 08:11:49 +02:00
Takayuki Maeda
77d6176e69
remove unnecessary to_string
and String::new
2022-06-13 15:48:40 +09:00
b-naber
99fa572ab1
add def_id and substs to ConstraintCategory::CallArgument
2022-05-25 18:13:03 +02:00
Jakob Degen
09b0936db2
Refactor call terminator to always hold a destination place
2022-05-23 17:49:04 -04:00
Michael Goulet
1784634a39
Lifetime variance fixes for rustc
2022-05-22 14:29:32 -07:00
Jack Huey
319575ae8c
Introduce EarlyBinder
2022-05-10 22:47:18 -04:00
Elliot Roberts
7907385999
fix most compiler/ doctests
2022-05-02 17:40:30 -07:00
SparrowLii
a34e1b58cb
make classify_drop_access_kind
iterate
2022-04-24 17:27:05 +08:00