Matthias Krüger
4b21ad26df
Rollup merge of #99508 - TaKO8Ki:avoid-symbol-to-string-conversion-in-BuiltinLintDiagnostics, r=compiler-errors
...
Avoid `Symbol` to `String` conversions
follow-up to #99342
2022-07-20 18:58:20 +02:00
miam-miam100
f8dfc4bf35
Fix off by one error and add ui test.
2022-07-20 13:40:45 +01:00
Takayuki Maeda
57a155b9fa
avoid a Symbol to String conversion
2022-07-20 18:19:25 +09:00
Michael Goulet
2902b92769
Only suggest if span is not erroneous
2022-07-15 17:32:34 +00:00
Michael Goulet
b71a09fda0
Fix ICE in named_arguments_used_positionally lint
2022-07-15 17:32:34 +00:00
Preston From
1219f72f90
Emit warning when named arguments are used positionally in format
...
Addresses Issue 98466 by emitting a warning if a named argument
is used like a position argument (i.e. the name is not used in
the string to be formatted).
Fixes rust-lang#98466
2022-07-13 15:34:10 -06:00
Nicholas Nethercote
7586e79af8
Rename some ExtCtxt methods.
...
The new names are more accurate.
Co-authored-by: Scott McMurray <scottmcm@users.noreply.github.com>
2022-06-23 11:10:43 +10:00
Takayuki Maeda
fd1290a631
remove unnecessary to_string and String::new for tool_only_span_suggestion
2022-06-13 16:01:16 +09:00
bjorn3
d33140d2dc
Make rustc_parse_format compile on stable
...
This allows it to be used by lightweight formatting systems and may
allow it to be used by rust-analyzer.
2022-05-03 11:26:58 +02:00
David Wood
c45f29595d
span: move MultiSpan
...
`MultiSpan` contains labels, which are more complicated with the
introduction of diagnostic translation and will use types from
`rustc_errors` - however, `rustc_errors` depends on `rustc_span` so
`rustc_span` cannot use types like `DiagnosticMessage` without
dependency cycles. Introduce a new `rustc_error_messages` crate that can
contain `DiagnosticMessage` and `MultiSpan`.
Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-05 07:01:00 +01:00
Eduard-Mihai Burtescu
b7e95dee65
rustc_errors: let DiagnosticBuilder::emit return a "guarantee of emission".
2022-02-23 06:38:52 +00:00
Chayim Refael Friedman
91adb6ccd6
Correctly mark the span of captured arguments in format_args!()
...
It should only include the identifier, or misspelling suggestions will be wrong.
2022-02-16 07:34:06 +00:00
Mara Bos
4445a8ff84
Rollup merge of #93394 - m-ou-se:fix-93378, r=estebank
...
Don't allow {} to refer to implicit captures in format_args.
Fixes #93378
2022-02-07 14:08:33 +00:00
Matthias Krüger
c1e2948c21
Rollup merge of #93461 - dtolnay:fmtyield, r=davidtwco
...
Accommodate yield points in the format_args expansion
Fixes #93274 .
For the case `println!("{} {:?}", "", async {}.await)` in the issue, the expansion before:
```rust
::std::io::_print(
::core::fmt::Arguments::new_v1(
&["", " ", "\n"],
&[
::core::fmt::ArgumentV1::new(&"", ::core::fmt::Display::fmt),
::core::fmt::ArgumentV1::new(&async {}.await, ::core::fmt::Debug::fmt),
],
),
);
```
After:
```rust
::std::io::_print(
::core::fmt::Arguments::new_v1(
&["", " ", "\n"],
&match (&"", &async {}.await) {
_args => [
::core::fmt::ArgumentV1::new(_args.0, ::core::fmt::Display::fmt),
::core::fmt::ArgumentV1::new(_args.1, ::core::fmt::Debug::fmt),
],
},
),
);
```
2022-01-31 07:00:42 +01:00
bors
e58e7b10e1
Auto merge of #90891 - nbdd0121:format, r=Mark-Simulacrum
...
Create `core::fmt::ArgumentV1` with generics instead of fn pointer
Split from (and prerequisite of) #90488 , as this seems to have perf implication.
`@rustbot` label: +T-libs
2022-01-31 00:04:46 +00:00
David Tolnay
858d6a0711
Mac calls
2022-01-30 11:53:12 -08:00
David Tolnay
47f92a58a4
Accommodate yield points in the format_args expansion
2022-01-30 11:53:11 -08:00
David Tolnay
6667d785d8
Rename _args -> args in format_args expansion
2022-01-29 12:44:41 -08:00
Gary Guo
a832f5f7bc
Create core::fmt::ArgumentV1 with generics instead of fn pointer
2022-01-29 13:52:19 +00:00
Mara Bos
9b8e4c63de
Don't allow {} to refer to implicit captures in format_args.
2022-01-28 00:20:25 +01:00
David Tolnay
730249d3d0
Fix comment about spans during borrowck per PR 91359 review
2022-01-17 10:38:30 -08:00
David Tolnay
1b5ff95edb
Replace confusing is_sorted_by in format_args implementation
2022-01-17 10:38:30 -08:00
David Tolnay
abf1d94b1a
Emit simpler code from format_args
2022-01-17 10:38:30 -08:00
Nicholas Nethercote
056d48a2c9
Remove unnecessary sigils around Symbol::as_str() calls.
2021-12-15 17:32:14 +11:00
Matthias Krüger
40988591ec
Rollup merge of #91625 - est31:remove_indexes, r=oli-obk
...
Remove redundant [..]s
2021-12-10 22:40:36 +01:00
Michael Goulet
99bd24e9a3
Fix span calculation on secondary_label as well
2021-12-09 09:09:39 -08:00
est31
15de4cbc4b
Remove redundant [..]s
2021-12-09 00:01:29 +01:00
Matthias Krüger
7df49eff10
Rollup merge of #91327 - dtolnay:exact, r=michaelwoerister
...
Delete an unreachable codepath from format_args implementation
2021-11-29 10:41:36 +01:00
Matthias Krüger
9715724006
Rollup merge of #90131 - camsteffen:fmt-args-span-fix, r=cjgillot
...
Fix a format_args span to be expansion
I found this while exploring solutions for rust-lang/rust-clippy#7843 .
r? `@m-ou-se`
2021-11-28 23:45:15 +01:00
David Tolnay
cc53f1356d
Delete an unreachable codepath from format_args implementation
2021-11-28 11:52:38 -08:00
Josh Triplett
8c9bfaa5f3
Stabilize format_args_capture
...
Works as expected, and there are widespread reports of success with it,
as well as interest in it.
2021-11-15 10:14:29 +01:00
Cameron Steffen
9f6a58e86b
Factor out some Vecs
2021-11-06 14:28:08 -05:00
Cameron Steffen
a9a24d5106
Don't destructure args tuple in format_args!
2021-11-06 14:28:08 -05:00
Cameron Steffen
4cfb7add77
Fix a format_args span to be expansion
2021-10-29 17:13:15 -05:00
Fabian Wolff
6490ed30e1
Improve error message for printf-style format strings
2021-09-29 02:02:45 +02:00
bors
a0648eab36
Auto merge of #88835 - FabianWolff:issue-88770, r=petrochenkov
...
Fix error recovery in format macro parsing
Fixes #88770 . Basically, the assumption in the following comment is incorrect:
b69fe57261/compiler/rustc_builtin_macros/src/format.rs (L167-L172)b69fe57261/compiler/rustc_builtin_macros/src/format.rs (L164)b69fe57261/compiler/rustc_parse/src/parser/mod.rs (L487-L498)#88770 .
2021-09-24 11:54:29 +00:00
Cameron Steffen
09b37d7433
Use ZST for fmt unsafety
...
This allows the format_args! macro to keep the pre-expansion code out of
the unsafe block without doing gymnastics with nested `match`
expressions. This reduces codegen.
2021-09-21 10:04:44 -05:00
Fabian Wolff
a8421cacfe
Fix error recovery in format macro parsing
2021-09-10 22:33:44 +02:00
Manish Goregaokar
358a018292
Rollup merge of #87441 - ibraheemdev:i-86865, r=cjgillot
...
Emit suggestion when passing byte literal to format macro
Closes #86865
2021-09-10 08:23:15 -07:00
Esteban Kuber
12ce6e9c60
Detect bare blocks with type ascription that were meant to be a struct literal
...
Address part of #34255 .
Potential improvement: silence the other knock down errors in
`issue-34255-1.rs`.
2021-09-03 14:43:04 +00:00
ibraheemdev
f56034ec3e
emit suggestion byte literal is passed to format!
2021-08-31 17:29:42 -04:00
Cameron Steffen
975bc18481
Make Arguments constructors unsafe
2021-08-16 16:28:16 +00:00
Fabian Wolff
14f3ec2815
Fix span calculation in format strings
2021-06-07 17:42:42 +02:00
Matthias Krüger
4390a61b64
avoid full-slicing slices
...
If we already have a slice, there is no need to get another full-range slice from that, just use the original.
clippy::redundant_slicing
2021-02-16 00:31:11 +01:00
Matthias Krüger
d12a358673
use matches!() macro in more places
2020-12-24 13:35:12 +01:00
Esteban Küber
2ac89ff994
Point at named argument not found when using format_args_capture instead of whole format string
2020-09-08 10:10:45 -07:00
Sasha
3524c3ef43
Improve recovery on malformed format call
...
If a comma in a format call is replaced with a similar token, then we
emit an error and continue parsing, instead of stopping at this point.
2020-09-02 13:18:19 +02:00
Sasha
f6d18db402
Use string literal directly when available in format
...
Previous implementation used the `Parser::parse_expr` function in order
to extract the format expression. If the first comma following the
format expression was mistakenly replaced with a dot, then the next
format expression was eaten by the function, because it looked as a
syntactically valid expression, which resulted in incorrectly spanned
error messages.
The way the format expression is exctracted is changed: we first look at
the first available token in the first argument supplied to the
`format!` macro call. If it is a string literal, then it is promoted as
a format expression immediatly, otherwise we fall back to the original
`parse_expr`-related method.
This allows us to ensure that the parser won't consume too much tokens
when a typo is made.
A test has been created so that it is ensured that the issue is properly
fixed.
2020-08-30 22:09:58 +02:00
mark
9e5f7d5631
mv compiler to compiler/
2020-08-30 18:45:07 +03:00
