bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #127607 - Zalathar:normalize-hint, r=wesleywiser

Browse source 
compiletest: Better error message for bad `normalize-*` headers

Follow-up to #126777.

Example of the new error message in context:
```text
---- [ui] tests/ui/rfcs/rfc-2632-const-trait-impl/effects/minicore.rs stdout ----
thread '[ui] tests/ui/rfcs/rfc-2632-const-trait-impl/effects/minicore.rs' panicked at src/tools/compiletest/src/header.rs:1001:13:
couldn't parse custom normalization rule: `normalize-stderr-test ".*note: .*\n\n" -> ""`
help: expected syntax is: `normalize-stderr-test: "REGEX" -> "REPLACEMENT"`
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
This commit is contained in:
Matthias Krüger 2024-07-12 03:43:35 +02:00 • committed by GitHub
commit fe564c10ab
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/tools/compiletest/src/header.rs
View file

@ -991,13 +991,19 @@ impl Config {
} }
fn parse_custom_normalization(&self, line: &str, prefix: &str) -> Option<(String, String)> { fn parse_custom_normalization(&self, line: &str, prefix: &str) -> Option<(String, String)> {
if parse_cfg_name_directive(self, line, prefix).outcome == MatchOutcome::Match { let parsed = parse_cfg_name_directive(self, line, prefix);
let (regex, replacement) = parse_normalize_rule(line) if parsed.outcome != MatchOutcome::Match {
.unwrap_or_else(|| panic!("couldn't parse custom normalization rule: `{line}`")); return None;
Some((regex, replacement))
} else {
None
} }
let name = parsed.name.expect("successful match always has a name");
let Some((regex, replacement)) = parse_normalize_rule(line) else {
panic!(
"couldn't parse custom normalization rule: `{line}`\n\
help: expected syntax is: `{prefix}-{name}: \"REGEX\" -> \"REPLACEMENT\"`"
);
};
Some((regex, replacement))
} }
fn parse_name_directive(&self, line: &str, directive: &str) -> bool { fn parse_name_directive(&self, line: &str, directive: &str) -> bool {