bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

lint: port unused delimiter diagnostics

Browse source 
Signed-off-by: David Wood <david.wood@huawei.com>
This commit is contained in:
David Wood 2022-06-28 10:28:57 +01:00
parent 2829f519a0
commit fc4f8d9bc2
2 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
compiler/rustc_error_messages/locales/en-US/lint.ftl
View file

@ -278,3 +278,6 @@ lint-path-statement-drop = path statement drops value
.suggestion = use `drop` to clarify the intent .suggestion = use `drop` to clarify the intent
lint-path-statement-no-effect = path statement with no effect lint-path-statement-no-effect = path statement with no effect
lint-unused-delim = unnecessary {$delim} around {$item}
.suggestion = remove these {$delim}

14
compiler/rustc_lint/src/unused.rs
View file

@ -544,15 +544,19 @@ trait UnusedDelimLint {
} }
cx.struct_span_lint(self.lint(), MultiSpan::from(vec![spans.0, spans.1]), |lint| { cx.struct_span_lint(self.lint(), MultiSpan::from(vec![spans.0, spans.1]), |lint| {
let span_msg = format!("unnecessary {} around {}", Self::DELIM_STR, msg);
let mut err = lint.build(&span_msg);
let replacement = vec![ let replacement = vec![
(spans.0, if keep_space.0 { " ".into() } else { "".into() }), (spans.0, if keep_space.0 { " ".into() } else { "".into() }),
(spans.1, if keep_space.1 { " ".into() } else { "".into() }), (spans.1, if keep_space.1 { " ".into() } else { "".into() }),
]; ];
let suggestion = format!("remove these {}", Self::DELIM_STR); lint.build(fluent::lint::unused_delim)
err.multipart_suggestion(&suggestion, replacement, Applicability::MachineApplicable); .set_arg("delim", Self::DELIM_STR)
err.emit(); .set_arg("item", msg)
.multipart_suggestion(
fluent::lint::suggestion,
replacement,
Applicability::MachineApplicable,
)
.emit();
}); });
} }