bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

add note for non-exhaustive matches with guards

Browse source
This commit is contained in:
Eric Mark Martin 2023-06-22 01:52:31 -04:00
parent 6b46c996e1
commit fbd1e0252f
8 changed files with 60 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/rustc_mir_build/src/thir/pattern/check_match.rs
View file

@ -830,6 +830,11 @@ fn non_exhaustive_match<'p, 'tcx>(
_ => " or multiple match arms",
},
);
let all_arms_have_guards = arms.iter().all(|arm_id| thir[*arm_id].guard.is_some());
if !is_empty_match && all_arms_have_guards {
err.note("match arms with guards don't count towards exhaustivity");
}
if let Some((span, sugg)) = suggestion {
err.span_suggestion_verbose(span, msg, sugg, Applicability::HasPlaceholders);
} else {