Filter out RPITITs in object_safety_violations_for_trait
This commit is contained in:
parent
b2f3198608
commit
fa421ec454
4 changed files with 33 additions and 3 deletions
|
@ -157,6 +157,7 @@ fn object_safety_violations_for_trait(
|
||||||
.in_definition_order()
|
.in_definition_order()
|
||||||
.filter(|item| item.kind == ty::AssocKind::Type)
|
.filter(|item| item.kind == ty::AssocKind::Type)
|
||||||
.filter(|item| !tcx.generics_of(item.def_id).params.is_empty())
|
.filter(|item| !tcx.generics_of(item.def_id).params.is_empty())
|
||||||
|
.filter(|item| tcx.opt_rpitit_info(item.def_id).is_none())
|
||||||
.map(|item| {
|
.map(|item| {
|
||||||
let ident = item.ident(tcx);
|
let ident = item.ident(tcx);
|
||||||
ObjectSafetyViolation::GAT(ident.name, ident.span)
|
ObjectSafetyViolation::GAT(ident.name, ident.span)
|
||||||
|
|
|
@ -1,5 +1,5 @@
|
||||||
warning: the feature `async_fn_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes
|
warning: the feature `async_fn_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes
|
||||||
--> $DIR/object-safety.rs:3:12
|
--> $DIR/object-safety.rs:5:12
|
||||||
|
|
|
|
||||||
LL | #![feature(async_fn_in_trait)]
|
LL | #![feature(async_fn_in_trait)]
|
||||||
| ^^^^^^^^^^^^^^^^^
|
| ^^^^^^^^^^^^^^^^^
|
||||||
|
@ -8,13 +8,13 @@ LL | #![feature(async_fn_in_trait)]
|
||||||
= note: `#[warn(incomplete_features)]` on by default
|
= note: `#[warn(incomplete_features)]` on by default
|
||||||
|
|
||||||
error[E0038]: the trait `Foo` cannot be made into an object
|
error[E0038]: the trait `Foo` cannot be made into an object
|
||||||
--> $DIR/object-safety.rs:11:12
|
--> $DIR/object-safety.rs:13:12
|
||||||
|
|
|
|
||||||
LL | let x: &dyn Foo = todo!();
|
LL | let x: &dyn Foo = todo!();
|
||||||
| ^^^^^^^^ `Foo` cannot be made into an object
|
| ^^^^^^^^ `Foo` cannot be made into an object
|
||||||
|
|
|
|
||||||
note: for a trait to be "object safe" it needs to allow building a vtable to allow the call to be resolvable dynamically; for more information visit <https://doc.rust-lang.org/reference/items/traits.html#object-safety>
|
note: for a trait to be "object safe" it needs to allow building a vtable to allow the call to be resolvable dynamically; for more information visit <https://doc.rust-lang.org/reference/items/traits.html#object-safety>
|
||||||
--> $DIR/object-safety.rs:7:14
|
--> $DIR/object-safety.rs:9:14
|
||||||
|
|
|
|
||||||
LL | trait Foo {
|
LL | trait Foo {
|
||||||
| --- this trait cannot be made into an object...
|
| --- this trait cannot be made into an object...
|
27
tests/ui/async-await/in-trait/object-safety.next.stderr
Normal file
27
tests/ui/async-await/in-trait/object-safety.next.stderr
Normal file
|
@ -0,0 +1,27 @@
|
||||||
|
warning: the feature `async_fn_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes
|
||||||
|
--> $DIR/object-safety.rs:5:12
|
||||||
|
|
|
||||||
|
LL | #![feature(async_fn_in_trait)]
|
||||||
|
| ^^^^^^^^^^^^^^^^^
|
||||||
|
|
|
||||||
|
= note: see issue #91611 <https://github.com/rust-lang/rust/issues/91611> for more information
|
||||||
|
= note: `#[warn(incomplete_features)]` on by default
|
||||||
|
|
||||||
|
error[E0038]: the trait `Foo` cannot be made into an object
|
||||||
|
--> $DIR/object-safety.rs:13:12
|
||||||
|
|
|
||||||
|
LL | let x: &dyn Foo = todo!();
|
||||||
|
| ^^^^^^^^ `Foo` cannot be made into an object
|
||||||
|
|
|
||||||
|
note: for a trait to be "object safe" it needs to allow building a vtable to allow the call to be resolvable dynamically; for more information visit <https://doc.rust-lang.org/reference/items/traits.html#object-safety>
|
||||||
|
--> $DIR/object-safety.rs:9:14
|
||||||
|
|
|
||||||
|
LL | trait Foo {
|
||||||
|
| --- this trait cannot be made into an object...
|
||||||
|
LL | async fn foo(&self);
|
||||||
|
| ^^^ ...because method `foo` is `async`
|
||||||
|
= help: consider moving `foo` to another trait
|
||||||
|
|
||||||
|
error: aborting due to previous error; 1 warning emitted
|
||||||
|
|
||||||
|
For more information about this error, try `rustc --explain E0038`.
|
|
@ -1,4 +1,6 @@
|
||||||
// edition:2021
|
// edition:2021
|
||||||
|
// [next] compile-flags: -Zlower-impl-trait-in-trait-to-assoc-ty
|
||||||
|
// revisions: current next
|
||||||
|
|
||||||
#![feature(async_fn_in_trait)]
|
#![feature(async_fn_in_trait)]
|
||||||
//~^ WARN the feature `async_fn_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes
|
//~^ WARN the feature `async_fn_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue