bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #130758 - compiler-errors:ctype-recursion-limit, r=jieyouxu

Browse source 
Revert "Add recursion limit to FFI safety lint"

It's not necessarily clear if warning when we hit the recursion limit is the right thing to do, first of all.

**More importantly**, this PR was implemented incorrectly in the first place; it was not decrementing the recursion limit when stepping out of a type, so it would trigger when a ctype has more than RECURSION_LIMIT fields *anywhere* in the type's set of recursively reachable fields.

Reverts #130598
Reopens #130310
Fixes #130757
This commit is contained in:
Michael Goulet 2024-09-23 23:49:13 -04:00 • committed by GitHub
commit fa1bd9b06a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 50 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_lint/messages.ftl
View file

@ -395,8 +395,6 @@ lint_improper_ctypes_opaque = opaque types have no C equivalent
lint_improper_ctypes_pat_help = consider using the base type instead
lint_improper_ctypes_pat_reason = pattern types have no C equivalent
lint_improper_ctypes_recursion_limit_reached = type is infinitely recursive
lint_improper_ctypes_slice_help = consider using a raw pointer instead
lint_improper_ctypes_slice_reason = slices have no C equivalent