bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Auto merge of #87739 - Aaron1011:remove-used-attrs, r=wesleywiser

Browse source 
Remove `Session.used_attrs` and move logic to `CheckAttrVisitor`

Instead of updating global state to mark attributes as used,
we now explicitly emit a warning when an attribute is used in
an unsupported position. As a side effect, we are to emit more
detailed warning messages (instead of just a generic "unused" message).

`Session.check_name` is removed, since its only purpose was to mark
the attribute as used. All of the callers are modified to use
`Attribute.has_name`

Additionally, `AttributeType::AssumedUsed` is removed - an 'assumed
used' attribute is implemented by simply not performing any checks
in `CheckAttrVisitor` for a particular attribute.

We no longer emit unused attribute warnings for the `#[rustc_dummy]`
attribute - it's an internal attribute used for tests, so it doesn't
mark sense to treat it as 'unused'.

With this commit, a large source of global untracked state is removed.
This commit is contained in:
bors 2021-08-24 03:58:22 +00:00
commit f66e825f73
64 changed files with 1109 additions and 1598 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_mir/src/dataflow/framework/engine.rs
View file

@ -338,7 +338,7 @@ impl RustcMirAttrs {
let rustc_mir_attrs = attrs
.iter()
.filter(|attr| tcx.sess.check_name(attr, sym::rustc_mir))
.filter(|attr| attr.has_name(sym::rustc_mir))
.flat_map(|attr| attr.meta_item_list().into_iter().flat_map(|v| v.into_iter()));
for attr in rustc_mir_attrs {

4
compiler/rustc_mir/src/dataflow/mod.rs
View file

@ -30,12 +30,12 @@ pub struct MoveDataParamEnv<'tcx> {
}
pub(crate) fn has_rustc_mir_with(
sess: &Session,
_sess: &Session,
attrs: &[ast::Attribute],
name: Symbol,
) -> Option<MetaItem> {
for attr in attrs {
if sess.check_name(attr, sym::rustc_mir) {
if attr.has_name(sym::rustc_mir) {
let items = attr.meta_item_list();
for item in items.iter().flat_map(|l| l.iter()) {
match item.meta_item() {

6
compiler/rustc_mir/src/monomorphize/polymorphize.rs
View file

@ -204,11 +204,7 @@ fn emit_unused_generic_params_error<'tcx>(
unused_parameters: &FiniteBitSet<u32>,
) {
let base_def_id = tcx.closure_base_def_id(def_id);
if !tcx
.get_attrs(base_def_id)
.iter()
.any(|a| tcx.sess.check_name(a, sym::rustc_polymorphize_error))
{
if !tcx.get_attrs(base_def_id).iter().any(|a| a.has_name(sym::rustc_polymorphize_error)) {
return;
}