bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

printf type correctness

Browse source 
The %.*s format specifier requires an int for the maximum size, but StringRef::size is a size_t

cc @shepmaster
This commit is contained in:
Robin Kruppe 2016-12-07 17:02:34 +01:00
parent 85dc08e525
commit f58e553001
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/rustllvm/PassWrapper.cpp
View file

@ -533,8 +533,11 @@ LLVMRustPrintPasses() {
StringRef PassArg = info->getPassArgument(); StringRef PassArg = info->getPassArgument();
StringRef PassName = info->getPassName(); StringRef PassName = info->getPassName();
if (!PassArg.empty()) { if (!PassArg.empty()) {
printf("%15.*s - %.*s\n", PassArg.size(), PassArg.data(), // These unsigned->signed casts could theoretically overflow, but
PassName.size(), PassName.data()); // realistically never will (and even if, the result is implementation
// defined rather plain UB).
printf("%15.*s - %.*s\n", (int)PassArg.size(), PassArg.data(),
(int)PassName.size(), PassName.data());
} }
#else #else
if (info->getPassArgument() && *info->getPassArgument()) { if (info->getPassArgument() && *info->getPassArgument()) {