bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

emit suggestion byte literal is passed to format!

Browse source
This commit is contained in:
ibraheemdev 2021-07-24 17:34:58 -04:00
parent e1d49aaad4
commit f56034ec3e
5 changed files with 61 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

16
compiler/rustc_builtin_macros/src/format.rs
View file

@ -946,17 +946,19 @@ pub fn expand_preparsed_format_args(
}
Ok(fmt) => fmt,
Err(err) => {
if let Some(mut err) = err {
if let Some((mut err, suggested)) = err {
let sugg_fmt = match args.len() {
0 => "{}".to_string(),
_ => format!("{}{{}}", "{} ".repeat(args.len())),
};
err.span_suggestion(
fmt_sp.shrink_to_lo(),
"you might be missing a string literal to format with",
format!("\"{}\", ", sugg_fmt),
Applicability::MaybeIncorrect,
);
if !suggested {
err.span_suggestion(
fmt_sp.shrink_to_lo(),
"you might be missing a string literal to format with",
format!("\"{}\", ", sugg_fmt),
Applicability::MaybeIncorrect,
);
}
err.emit();
}
return DummyResult::raw_expr(sp, true);