bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Add tests and support two more noop methods

Browse source
This commit is contained in:
Ryan Levick 2021-01-05 16:14:39 +01:00 • committed by Ryan Levick
parent 040735c110
commit f49ed7a6b7
7 changed files with 89 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
compiler/rustc_lint/src/noop_method_call.rs
View file

@ -54,11 +54,19 @@ impl<'tcx> LateLintPass<'tcx> for NoopMethodCall {
// Resolve the trait method instance
if let Ok(Some(i)) = ty::Instance::resolve(cx.tcx, param_env, did, substs) {
// Check that it implements the noop diagnostic
if cx.tcx.is_diagnostic_item(sym::ref_clone_method, i.def_id()) {
tracing::debug!("Resolves to: {:?}", i.def_id());
if [
sym::noop_method_borrow,
sym::noop_method_clone,
sym::noop_method_deref,
]
.iter()
.any(|s| cx.tcx.is_diagnostic_item(*s, i.def_id()))
{
let span = expr.span;
cx.struct_span_lint(NOOP_METHOD_CALL, span, |lint| {
let message = "Call to noop method";
let message = "call to noop method";
lint.build(&message).emit()
});
}