bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Return early on an error path in parse_item_impl.

Browse source 
Currently the code continues, using an empty path, but it doesn't need
to.
This commit is contained in:
Nicholas Nethercote 2025-04-09 09:30:51 +10:00
parent d4f880f8ce
commit f419b18d16
1 changed files with 3 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

14
compiler/rustc_parse/src/parser/item.rs
View file

@ -602,21 +602,13 @@ impl<'a> Parser<'a> {
let polarity = self.parse_polarity(); let polarity = self.parse_polarity();
// Parse both types and traits as a type, then reinterpret if necessary. // Parse both types and traits as a type, then reinterpret if necessary.
let err_path = |span| ast::Path::from_ident(Ident::new(kw::Empty, span));
let ty_first = if self.token.is_keyword(kw::For) && self.look_ahead(1, |t| t != &token::Lt) let ty_first = if self.token.is_keyword(kw::For) && self.look_ahead(1, |t| t != &token::Lt)
{ {
let span = self.prev_token.span.between(self.token.span); let span = self.prev_token.span.between(self.token.span);
self.dcx().emit_err(errors::MissingTraitInTraitImpl { return Err(self.dcx().create_err(errors::MissingTraitInTraitImpl {
span, span,
for_span: span.to(self.token.span), for_span: span.to(self.token.span),
}); }));
P(Ty {
kind: TyKind::Path(None, err_path(span)),
span,
id: DUMMY_NODE_ID,
tokens: None,
})
} else { } else {
self.parse_ty_with_generics_recovery(&generics)? self.parse_ty_with_generics_recovery(&generics)?
}; };
@ -671,7 +663,7 @@ impl<'a> Parser<'a> {
span: ty_first.span, span: ty_first.span,
}); });
} }
err_path(ty_first.span) ast::Path::from_ident(Ident::new(kw::Empty, ty_first.span))
} }
}; };
let trait_ref = TraitRef { path, ref_id: ty_first.id }; let trait_ref = TraitRef { path, ref_id: ty_first.id };