bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Add the "consider importing it directly" label to public imports as well

Browse source
This commit is contained in:
Vadim Petrochenkov 2020-03-11 21:17:23 +03:00
parent 580c6a29d4
commit f4083c6455
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/librustc_resolve/diagnostics.rs
View file

@ -987,7 +987,7 @@ impl<'a> Resolver<'a> {
); );
let def_span = self.session.source_map().def_span(binding.span); let def_span = self.session.source_map().def_span(binding.span);
let mut note_span = MultiSpan::from_span(def_span); let mut note_span = MultiSpan::from_span(def_span);
if !first && next_binding.is_none() && binding.vis == ty::Visibility::Public { if !first && binding.vis == ty::Visibility::Public {
note_span.push_span_label(def_span, "consider importing it directly".into()); note_span.push_span_label(def_span, "consider importing it directly".into());
} }
err.span_note(note_span, &msg); err.span_note(note_span, &msg);

4
src/test/ui/imports/issue-55884-2.stderr
View file

@ -13,12 +13,12 @@ note: ...and refers to the struct import `ParseOptions` which is defined here...
--> $DIR/issue-55884-2.rs:12:9 --> $DIR/issue-55884-2.rs:12:9
| |
LL | pub use parser::ParseOptions; LL | pub use parser::ParseOptions;
| ^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^ consider importing it directly
note: ...and refers to the struct import `ParseOptions` which is defined here... note: ...and refers to the struct import `ParseOptions` which is defined here...
--> $DIR/issue-55884-2.rs:6:13 --> $DIR/issue-55884-2.rs:6:13
| |
LL | pub use options::*; LL | pub use options::*;
| ^^^^^^^^^^ | ^^^^^^^^^^ consider importing it directly
note: ...and refers to the struct `ParseOptions` which is defined here note: ...and refers to the struct `ParseOptions` which is defined here
--> $DIR/issue-55884-2.rs:2:5 --> $DIR/issue-55884-2.rs:2:5
| |