bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

suggest constraining param for unary ops when missing trait impl

Browse source
This commit is contained in:
Frank King 2022-03-22 12:17:30 +08:00
parent 051d1176b7
commit f28d8b13df
3 changed files with 57 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

21
compiler/rustc_typeck/src/check/op.rs
View file

@ -672,6 +672,27 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
ex.span,
format!("cannot apply unary operator `{}`", op.as_str()),
);
let missing_trait = match op {
hir::UnOp::Deref => unreachable!("check unary op `-` or `!` only"),
hir::UnOp::Not => "std::ops::Not",
hir::UnOp::Neg => "std::ops::Neg",
};
let mut visitor = TypeParamVisitor(vec![]);
visitor.visit_ty(operand_ty);
if let [ty] = &visitor.0[..] {
if let ty::Param(p) = *operand_ty.kind() {
suggest_constraining_param(
self.tcx,
self.body_id,
&mut err,
*ty,
operand_ty,
missing_trait,
p,
true,
);
}
}
let sp = self.tcx.sess.source_map().start_point(ex.span);
if let Some(sp) =