1
Fork 0

Rollup merge of #53434 - alexcrichton:remove-strip-debug, r=yurydelendik

wasm: Remove --strip-debug argument to LLD

Originally added in #52887 this commit disables passing `--strip-debug` to LLD
when optimized. This bring back the original bug of emitting broken debuginfo
but currently it *also* strips the `name` section which makes it very difficult
to inspect the final binary. A real fix is happening at
https://reviews.llvm.org/D50729 and we can reevaluate once we've updated LLD to
have that commit.
This commit is contained in:
Corey Farwell 2018-08-17 08:23:45 -07:00 committed by GitHub
commit f2146667af
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -1006,18 +1006,6 @@ impl<'a> Linker for WasmLd<'a> {
OptLevel::Size => "-O2", OptLevel::Size => "-O2",
OptLevel::SizeMin => "-O2" OptLevel::SizeMin => "-O2"
}); });
match self.sess.opts.optimize {
OptLevel::No => (),
OptLevel::Less |
OptLevel::Default |
OptLevel::Aggressive |
OptLevel::Size |
OptLevel::SizeMin => {
// LLD generates incorrect debugging information when
// optimization is applied: strip debug sections.
self.cmd.arg("--strip-debug");
}
}
} }
fn pgo_gen(&mut self) { fn pgo_gen(&mut self) {