bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Don't sort span_suggestions, leave that to caller

Browse source
This commit is contained in:
Esteban Küber 2023-11-08 18:24:49 +00:00
parent 42aa1273b0
commit f1ae02f4bd
10 changed files with 31 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

7
compiler/rustc_errors/src/diagnostic.rs
View file

@ -759,9 +759,6 @@ impl Diagnostic {
suggestions: impl IntoIterator<Item = String>,
applicability: Applicability,
) -> &mut Self {
let mut suggestions: Vec<_> = suggestions.into_iter().collect();
suggestions.sort();
self.span_suggestions_with_style(
sp,
msg,
@ -771,9 +768,7 @@ impl Diagnostic {
)
}
/// [`Diagnostic::span_suggestions()`] but you can set the [`SuggestionStyle`]. This version
/// *doesn't* sort the suggestions, so the caller has control of the order in which they are
/// presented.
/// [`Diagnostic::span_suggestions()`] but you can set the [`SuggestionStyle`].
pub fn span_suggestions_with_style(
&mut self,
sp: Span,