bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Show diff suggestion format on verbose replacement

Browse source 
```
error[E0610]: `{integer}` is a primitive type and therefore doesn't have fields
  --> $DIR/attempted-access-non-fatal.rs:7:15
   |
LL |     let _ = 2.l;
   |               ^
   |
help: if intended to be a floating point literal, consider adding a `0` after the period and a `f64` suffix
   |
LL -     let _ = 2.l;
LL +     let _ = 2.0f64;
   |
```
This commit is contained in:
Esteban Küber 2024-07-09 22:30:26 +00:00
parent 8c04e39595
commit f0845adb0c
1017 changed files with 10364 additions and 6943 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_errors/src/emitter.rs
View file

@ -1982,7 +1982,7 @@ impl HumanEmitter {
{
debug!(?complete, ?parts, ?highlights);
let has_deletion = parts.iter().any(|p| p.is_deletion(sm));
let has_deletion = parts.iter().any(|p| p.is_deletion(sm) || p.is_replacement(sm));
let is_multiline = complete.lines().count() > 1;
if i == 0 {

31
src/tools/clippy/tests/ui-toml/dbg_macro/dbg_macro.stderr
View file

@ -8,8 +8,9 @@ LL | if let Some(n) = dbg!(n.checked_sub(4)) { n } else { n }
= help: to override `-D warnings` add `#[allow(clippy::dbg_macro)]`
help: remove the invocation before committing it to a version control system
|
LL | if let Some(n) = n.checked_sub(4) { n } else { n }
| ~~~~~~~~~~~~~~~~
LL - if let Some(n) = dbg!(n.checked_sub(4)) { n } else { n }
LL + if let Some(n) = n.checked_sub(4) { n } else { n }
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui-toml/dbg_macro/dbg_macro.rs:10:8
@ -19,8 +20,9 @@ LL | if dbg!(n <= 1) {
|
help: remove the invocation before committing it to a version control system
|
LL | if n <= 1 {
| ~~~~~~
LL - if dbg!(n <= 1) {
LL + if n <= 1 {
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui-toml/dbg_macro/dbg_macro.rs:11:9
@ -30,7 +32,8 @@ LL | dbg!(1)
|
help: remove the invocation before committing it to a version control system
|
LL | 1
LL - dbg!(1)
LL + 1
|
error: the `dbg!` macro is intended as a debugging tool
@ -41,7 +44,8 @@ LL | dbg!(n * factorial(n - 1))
|
help: remove the invocation before committing it to a version control system
|
LL | n * factorial(n - 1)
LL - dbg!(n * factorial(n - 1))
LL + n * factorial(n - 1)
|
error: the `dbg!` macro is intended as a debugging tool
@ -52,8 +56,9 @@ LL | dbg!(42);
|
help: remove the invocation before committing it to a version control system
|
LL | 42;
| ~~
LL - dbg!(42);
LL + 42;
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui-toml/dbg_macro/dbg_macro.rs:19:14
@ -63,8 +68,9 @@ LL | foo(3) + dbg!(factorial(4));
|
help: remove the invocation before committing it to a version control system
|
LL | foo(3) + factorial(4);
| ~~~~~~~~~~~~
LL - foo(3) + dbg!(factorial(4));
LL + foo(3) + factorial(4);
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui-toml/dbg_macro/dbg_macro.rs:20:5
@ -74,8 +80,9 @@ LL | dbg!(1, 2, 3, 4, 5);
|
help: remove the invocation before committing it to a version control system
|
LL | (1, 2, 3, 4, 5);
| ~~~~~~~~~~~~~~~
LL - dbg!(1, 2, 3, 4, 5);
LL + (1, 2, 3, 4, 5);
|
error: aborting due to 7 previous errors

5
src/tools/clippy/tests/ui-toml/doc_valid_idents_append/doc_markdown.stderr
View file

@ -8,8 +8,9 @@ LL | /// TestItemThingyOfCoolness might sound cool but is not on the list and sh
= help: to override `-D warnings` add `#[allow(clippy::doc_markdown)]`
help: try
|
LL | /// `TestItemThingyOfCoolness` might sound cool but is not on the list and should be linted.
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - /// TestItemThingyOfCoolness might sound cool but is not on the list and should be linted.
LL + /// `TestItemThingyOfCoolness` might sound cool but is not on the list and should be linted.
|
error: aborting due to 1 previous error

15
src/tools/clippy/tests/ui-toml/doc_valid_idents_replace/doc_markdown.stderr
View file

@ -8,8 +8,9 @@ LL | /// OAuth and LaTeX are inside Clippy's default list.
= help: to override `-D warnings` add `#[allow(clippy::doc_markdown)]`
help: try
|
LL | /// `OAuth` and LaTeX are inside Clippy's default list.
| ~~~~~~~
LL - /// OAuth and LaTeX are inside Clippy's default list.
LL + /// `OAuth` and LaTeX are inside Clippy's default list.
|
error: item in documentation is missing backticks
--> tests/ui-toml/doc_valid_idents_replace/doc_markdown.rs:6:15
@ -19,8 +20,9 @@ LL | /// OAuth and LaTeX are inside Clippy's default list.
|
help: try
|
LL | /// OAuth and `LaTeX` are inside Clippy's default list.
| ~~~~~~~
LL - /// OAuth and LaTeX are inside Clippy's default list.
LL + /// OAuth and `LaTeX` are inside Clippy's default list.
|
error: item in documentation is missing backticks
--> tests/ui-toml/doc_valid_idents_replace/doc_markdown.rs:9:5
@ -30,8 +32,9 @@ LL | /// TestItemThingyOfCoolness might sound cool but is not on the list and sh
|
help: try
|
LL | /// `TestItemThingyOfCoolness` might sound cool but is not on the list and should be linted.
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - /// TestItemThingyOfCoolness might sound cool but is not on the list and should be linted.
LL + /// `TestItemThingyOfCoolness` might sound cool but is not on the list and should be linted.
|
error: aborting due to 3 previous errors

5
src/tools/clippy/tests/ui-toml/enum_variant_size/enum_variant_size.stderr
View file

@ -14,8 +14,9 @@ LL | | }
= help: to override `-D warnings` add `#[allow(clippy::large_enum_variant)]`
help: consider boxing the large fields to reduce the total size of the enum
|
LL | B(Box<[u8; 501]>),
| ~~~~~~~~~~~~~~
LL - B([u8; 501]),
LL + B(Box<[u8; 501]>),
|
error: aborting due to 1 previous error

5
src/tools/clippy/tests/ui-toml/renamed_function_params/renamed_function_params.default.stderr
View file

@ -33,8 +33,9 @@ LL | fn hash_slice<H: Hasher>(date: &[Self], states: &mut H) {
|
help: consider using the default names
|
LL | fn hash_slice<H: Hasher>(data: &[Self], state: &mut H) {
| ~~~~ ~~~~~
LL - fn hash_slice<H: Hasher>(date: &[Self], states: &mut H) {
LL + fn hash_slice<H: Hasher>(data: &[Self], state: &mut H) {
|
error: renamed function parameter of trait impl
--> tests/ui-toml/renamed_function_params/renamed_function_params.rs:80:18

5
src/tools/clippy/tests/ui-toml/renamed_function_params/renamed_function_params.extend.stderr
View file

@ -27,8 +27,9 @@ LL | fn hash_slice<H: Hasher>(date: &[Self], states: &mut H) {
|
help: consider using the default names
|
LL | fn hash_slice<H: Hasher>(data: &[Self], state: &mut H) {
| ~~~~ ~~~~~
LL - fn hash_slice<H: Hasher>(date: &[Self], states: &mut H) {
LL + fn hash_slice<H: Hasher>(data: &[Self], state: &mut H) {
|
error: aborting due to 4 previous errors

75
src/tools/clippy/tests/ui-toml/unwrap_used/unwrap_used.stderr
View file

@ -8,8 +8,9 @@ LL | let _ = boxed_slice.get(1).unwrap();
= help: to override `-D warnings` add `#[allow(clippy::get_unwrap)]`
help: using `[]` is clearer and more concise
|
LL | let _ = &boxed_slice[1];
| ~~~~~~~~~~~~~~~
LL - let _ = boxed_slice.get(1).unwrap();
LL + let _ = &boxed_slice[1];
|
error: used `unwrap()` on an `Option` value
--> tests/ui-toml/unwrap_used/unwrap_used.rs:38:17
@ -30,8 +31,9 @@ LL | let _ = some_slice.get(0).unwrap();
|
help: using `[]` is clearer and more concise
|
LL | let _ = &some_slice[0];
| ~~~~~~~~~~~~~~
LL - let _ = some_slice.get(0).unwrap();
LL + let _ = &some_slice[0];
|
error: used `unwrap()` on an `Option` value
--> tests/ui-toml/unwrap_used/unwrap_used.rs:39:17
@ -50,8 +52,9 @@ LL | let _ = some_vec.get(0).unwrap();
|
help: using `[]` is clearer and more concise
|
LL | let _ = &some_vec[0];
| ~~~~~~~~~~~~
LL - let _ = some_vec.get(0).unwrap();
LL + let _ = &some_vec[0];
|
error: used `unwrap()` on an `Option` value
--> tests/ui-toml/unwrap_used/unwrap_used.rs:40:17
@ -70,8 +73,9 @@ LL | let _ = some_vecdeque.get(0).unwrap();
|
help: using `[]` is clearer and more concise
|
LL | let _ = &some_vecdeque[0];
| ~~~~~~~~~~~~~~~~~
LL - let _ = some_vecdeque.get(0).unwrap();
LL + let _ = &some_vecdeque[0];
|
error: used `unwrap()` on an `Option` value
--> tests/ui-toml/unwrap_used/unwrap_used.rs:41:17
@ -90,8 +94,9 @@ LL | let _ = some_hashmap.get(&1).unwrap();
|
help: using `[]` is clearer and more concise
|
LL | let _ = &some_hashmap[&1];
| ~~~~~~~~~~~~~~~~~
LL - let _ = some_hashmap.get(&1).unwrap();
LL + let _ = &some_hashmap[&1];
|
error: used `unwrap()` on an `Option` value
--> tests/ui-toml/unwrap_used/unwrap_used.rs:42:17
@ -110,8 +115,9 @@ LL | let _ = some_btreemap.get(&1).unwrap();
|
help: using `[]` is clearer and more concise
|
LL | let _ = &some_btreemap[&1];
| ~~~~~~~~~~~~~~~~~~
LL - let _ = some_btreemap.get(&1).unwrap();
LL + let _ = &some_btreemap[&1];
|
error: used `unwrap()` on an `Option` value
--> tests/ui-toml/unwrap_used/unwrap_used.rs:43:17
@ -130,8 +136,9 @@ LL | let _: u8 = *boxed_slice.get(1).unwrap();
|
help: using `[]` is clearer and more concise
|
LL | let _: u8 = boxed_slice[1];
| ~~~~~~~~~~~~~~
LL - let _: u8 = *boxed_slice.get(1).unwrap();
LL + let _: u8 = boxed_slice[1];
|
error: used `unwrap()` on an `Option` value
--> tests/ui-toml/unwrap_used/unwrap_used.rs:47:22
@ -150,8 +157,9 @@ LL | *boxed_slice.get_mut(0).unwrap() = 1;
|
help: using `[]` is clearer and more concise
|
LL | boxed_slice[0] = 1;
| ~~~~~~~~~~~~~~
LL - *boxed_slice.get_mut(0).unwrap() = 1;
LL + boxed_slice[0] = 1;
|
error: used `unwrap()` on an `Option` value
--> tests/ui-toml/unwrap_used/unwrap_used.rs:52:10
@ -170,8 +178,9 @@ LL | *some_slice.get_mut(0).unwrap() = 1;
|
help: using `[]` is clearer and more concise
|
LL | some_slice[0] = 1;
| ~~~~~~~~~~~~~
LL - *some_slice.get_mut(0).unwrap() = 1;
LL + some_slice[0] = 1;
|
error: used `unwrap()` on an `Option` value
--> tests/ui-toml/unwrap_used/unwrap_used.rs:53:10
@ -190,8 +199,9 @@ LL | *some_vec.get_mut(0).unwrap() = 1;
|
help: using `[]` is clearer and more concise
|
LL | some_vec[0] = 1;
| ~~~~~~~~~~~
LL - *some_vec.get_mut(0).unwrap() = 1;
LL + some_vec[0] = 1;
|
error: used `unwrap()` on an `Option` value
--> tests/ui-toml/unwrap_used/unwrap_used.rs:54:10
@ -210,8 +220,9 @@ LL | *some_vecdeque.get_mut(0).unwrap() = 1;
|
help: using `[]` is clearer and more concise
|
LL | some_vecdeque[0] = 1;
| ~~~~~~~~~~~~~~~~
LL - *some_vecdeque.get_mut(0).unwrap() = 1;
LL + some_vecdeque[0] = 1;
|
error: used `unwrap()` on an `Option` value
--> tests/ui-toml/unwrap_used/unwrap_used.rs:55:10
@ -230,8 +241,9 @@ LL | let _ = some_vec.get(0..1).unwrap().to_vec();
|
help: using `[]` is clearer and more concise
|
LL | let _ = some_vec[0..1].to_vec();
| ~~~~~~~~~~~~~~
LL - let _ = some_vec.get(0..1).unwrap().to_vec();
LL + let _ = some_vec[0..1].to_vec();
|
error: used `unwrap()` on an `Option` value
--> tests/ui-toml/unwrap_used/unwrap_used.rs:67:17
@ -250,8 +262,9 @@ LL | let _ = some_vec.get_mut(0..1).unwrap().to_vec();
|
help: using `[]` is clearer and more concise
|
LL | let _ = some_vec[0..1].to_vec();
| ~~~~~~~~~~~~~~
LL - let _ = some_vec.get_mut(0..1).unwrap().to_vec();
LL + let _ = some_vec[0..1].to_vec();
|
error: used `unwrap()` on an `Option` value
--> tests/ui-toml/unwrap_used/unwrap_used.rs:68:17
@ -270,8 +283,9 @@ LL | let _ = boxed_slice.get(1).unwrap();
|
help: using `[]` is clearer and more concise
|
LL | let _ = &boxed_slice[1];
| ~~~~~~~~~~~~~~~
LL - let _ = boxed_slice.get(1).unwrap();
LL + let _ = &boxed_slice[1];
|
error: called `.get().unwrap()` on a slice
--> tests/ui-toml/unwrap_used/unwrap_used.rs:94:17
@ -281,8 +295,9 @@ LL | let _ = Box::new([0]).get(1).unwrap();
|
help: using `[]` is clearer and more concise
|
LL | let _ = &Box::new([0])[1];
| ~~~~~~~~~~~~~~~~~
LL - let _ = Box::new([0]).get(1).unwrap();
LL + let _ = &Box::new([0])[1];
|
error: aborting due to 28 previous errors

90
src/tools/clippy/tests/ui/assign_ops2.stderr
View file

@ -8,12 +8,14 @@ LL | a += a + 1;
= help: to override `-D warnings` add `#[allow(clippy::misrefactored_assign_op)]`
help: did you mean `a = a + 1` or `a = a + a + 1`? Consider replacing it with
|
LL | a += 1;
| ~~~~~~
LL - a += a + 1;
LL + a += 1;
|
help: or
|
LL | a = a + a + 1;
| ~~~~~~~~~~~~~
LL - a += a + 1;
LL + a = a + a + 1;
|
error: variable appears on both sides of an assignment operation
--> tests/ui/assign_ops2.rs:11:5
@ -23,12 +25,14 @@ LL | a += 1 + a;
|
help: did you mean `a = a + 1` or `a = a + 1 + a`? Consider replacing it with
|
LL | a += 1;
| ~~~~~~
LL - a += 1 + a;
LL + a += 1;
|
help: or
|
LL | a = a + 1 + a;
| ~~~~~~~~~~~~~
LL - a += 1 + a;
LL + a = a + 1 + a;
|
error: variable appears on both sides of an assignment operation
--> tests/ui/assign_ops2.rs:13:5
@ -38,12 +42,14 @@ LL | a -= a - 1;
|
help: did you mean `a = a - 1` or `a = a - (a - 1)`? Consider replacing it with
|
LL | a -= 1;
| ~~~~~~
LL - a -= a - 1;
LL + a -= 1;
|
help: or
|
LL | a = a - (a - 1);
| ~~~~~~~~~~~~~~~
LL - a -= a - 1;
LL + a = a - (a - 1);
|
error: variable appears on both sides of an assignment operation
--> tests/ui/assign_ops2.rs:15:5
@ -53,12 +59,14 @@ LL | a *= a * 99;
|
help: did you mean `a = a * 99` or `a = a * a * 99`? Consider replacing it with
|
LL | a *= 99;
| ~~~~~~~
LL - a *= a * 99;
LL + a *= 99;
|
help: or
|
LL | a = a * a * 99;
| ~~~~~~~~~~~~~~
LL - a *= a * 99;
LL + a = a * a * 99;
|
error: variable appears on both sides of an assignment operation
--> tests/ui/assign_ops2.rs:17:5
@ -68,12 +76,14 @@ LL | a *= 42 * a;
|
help: did you mean `a = a * 42` or `a = a * 42 * a`? Consider replacing it with
|
LL | a *= 42;
| ~~~~~~~
LL - a *= 42 * a;
LL + a *= 42;
|
help: or
|
LL | a = a * 42 * a;
| ~~~~~~~~~~~~~~
LL - a *= 42 * a;
LL + a = a * 42 * a;
|
error: variable appears on both sides of an assignment operation
--> tests/ui/assign_ops2.rs:19:5
@ -83,12 +93,14 @@ LL | a /= a / 2;
|
help: did you mean `a = a / 2` or `a = a / (a / 2)`? Consider replacing it with
|
LL | a /= 2;
| ~~~~~~
LL - a /= a / 2;
LL + a /= 2;
|
help: or
|
LL | a = a / (a / 2);
| ~~~~~~~~~~~~~~~
LL - a /= a / 2;
LL + a = a / (a / 2);
|
error: variable appears on both sides of an assignment operation
--> tests/ui/assign_ops2.rs:21:5
@ -98,12 +110,14 @@ LL | a %= a % 5;
|
help: did you mean `a = a % 5` or `a = a % (a % 5)`? Consider replacing it with
|
LL | a %= 5;
| ~~~~~~
LL - a %= a % 5;
LL + a %= 5;
|
help: or
|
LL | a = a % (a % 5);
| ~~~~~~~~~~~~~~~
LL - a %= a % 5;
LL + a = a % (a % 5);
|
error: variable appears on both sides of an assignment operation
--> tests/ui/assign_ops2.rs:23:5
@ -113,12 +127,14 @@ LL | a &= a & 1;
|
help: did you mean `a = a & 1` or `a = a & a & 1`? Consider replacing it with
|
LL | a &= 1;
| ~~~~~~
LL - a &= a & 1;
LL + a &= 1;
|
help: or
|
LL | a = a & a & 1;
| ~~~~~~~~~~~~~
LL - a &= a & 1;
LL + a = a & a & 1;
|
error: variable appears on both sides of an assignment operation
--> tests/ui/assign_ops2.rs:25:5
@ -128,12 +144,14 @@ LL | a *= a * a;
|
help: did you mean `a = a * a` or `a = a * a * a`? Consider replacing it with
|
LL | a *= a;
| ~~~~~~
LL - a *= a * a;
LL + a *= a;
|
help: or
|
LL | a = a * a * a;
| ~~~~~~~~~~~~~
LL - a *= a * a;
LL + a = a * a * a;
|
error: manual implementation of an assign operation
--> tests/ui/assign_ops2.rs:63:5

20
src/tools/clippy/tests/ui/bind_instead_of_map_multipart.stderr
View file

@ -11,8 +11,9 @@ LL | #![deny(clippy::bind_instead_of_map)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: use `map` instead
|
LL | let _ = Some("42").map(|s| if s.len() < 42 { 0 } else { s.len() });
| ~~~ ~ ~~~~~~~
LL - let _ = Some("42").and_then(|s| if s.len() < 42 { Some(0) } else { Some(s.len()) });
LL + let _ = Some("42").map(|s| if s.len() < 42 { 0 } else { s.len() });
|
error: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)`
--> tests/ui/bind_instead_of_map_multipart.rs:8:13
@ -22,8 +23,9 @@ LL | let _ = Ok::<_, ()>("42").and_then(|s| if s.len() < 42 { Ok(0) } else {
|
help: use `map` instead
|
LL | let _ = Ok::<_, ()>("42").map(|s| if s.len() < 42 { 0 } else { s.len() });
| ~~~ ~ ~~~~~~~
LL - let _ = Ok::<_, ()>("42").and_then(|s| if s.len() < 42 { Ok(0) } else { Ok(s.len()) });
LL + let _ = Ok::<_, ()>("42").map(|s| if s.len() < 42 { 0 } else { s.len() });
|
error: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
--> tests/ui/bind_instead_of_map_multipart.rs:11:13
@ -33,8 +35,9 @@ LL | let _ = Err::<(), _>("42").or_else(|s| if s.len() < 42 { Err(s.len() +
|
help: use `map_err` instead
|
LL | let _ = Err::<(), _>("42").map_err(|s| if s.len() < 42 { s.len() + 20 } else { s.len() });
| ~~~~~~~ ~~~~~~~~~~~~ ~~~~~~~
LL - let _ = Err::<(), _>("42").or_else(|s| if s.len() < 42 { Err(s.len() + 20) } else { Err(s.len()) });
LL + let _ = Err::<(), _>("42").map_err(|s| if s.len() < 42 { s.len() + 20 } else { s.len() });
|
error: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
--> tests/ui/bind_instead_of_map_multipart.rs:19:5
@ -83,8 +86,9 @@ LL | let _ = Some("").and_then(|s| if s.len() == 20 { Some(m!()) } else { So
|
help: use `map` instead
|
LL | let _ = Some("").map(|s| if s.len() == 20 { m!() } else { Some(20) });
| ~~~ ~~~~ ~~~~~~~~
LL - let _ = Some("").and_then(|s| if s.len() == 20 { Some(m!()) } else { Some(Some(20)) });
LL + let _ = Some("").map(|s| if s.len() == 20 { m!() } else { Some(20) });
|
error: aborting due to 5 previous errors

10
src/tools/clippy/tests/ui/borrow_deref_ref_unfixable.stderr
View file

@ -8,12 +8,14 @@ LL | let x: &str = &*s;
= help: to override `-D warnings` add `#[allow(clippy::borrow_deref_ref)]`
help: if you would like to reborrow, try removing `&*`
|
LL | let x: &str = s;
| ~
LL - let x: &str = &*s;
LL + let x: &str = s;
|
help: if you would like to deref, try using `&**`
|
LL | let x: &str = &**s;
| ~~~~
LL - let x: &str = &*s;
LL + let x: &str = &**s;
|
error: aborting due to 1 previous error

103
src/tools/clippy/tests/ui/cast.stderr
View file

@ -81,8 +81,9 @@ LL | 1i32 as i8;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | i8::try_from(1i32);
| ~~~~~~~~~~~~~~~~~~
LL - 1i32 as i8;
LL + i8::try_from(1i32);
|
error: casting `i32` to `u8` may truncate the value
--> tests/ui/cast.rs:52:5
@ -93,8 +94,9 @@ LL | 1i32 as u8;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | u8::try_from(1i32);
| ~~~~~~~~~~~~~~~~~~
LL - 1i32 as u8;
LL + u8::try_from(1i32);
|
error: casting `f64` to `isize` may truncate the value
--> tests/ui/cast.rs:54:5
@ -127,8 +129,9 @@ LL | 1f32 as u32 as u16;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | u16::try_from(1f32 as u32);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - 1f32 as u32 as u16;
LL + u16::try_from(1f32 as u32);
|
error: casting `f32` to `u32` may truncate the value
--> tests/ui/cast.rs:59:5
@ -153,8 +156,9 @@ LL | let _x: i8 = 1i32 as _;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | let _x: i8 = 1i32.try_into();
| ~~~~~~~~~~~~~~~
LL - let _x: i8 = 1i32 as _;
LL + let _x: i8 = 1i32.try_into();
|
error: casting `f32` to `i32` may truncate the value
--> tests/ui/cast.rs:66:9
@ -228,8 +232,9 @@ LL | 1usize as i8;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | i8::try_from(1usize);
| ~~~~~~~~~~~~~~~~~~~~
LL - 1usize as i8;
LL + i8::try_from(1usize);
|
error: casting `usize` to `i16` may truncate the value
--> tests/ui/cast.rs:90:5
@ -240,8 +245,9 @@ LL | 1usize as i16;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | i16::try_from(1usize);
| ~~~~~~~~~~~~~~~~~~~~~
LL - 1usize as i16;
LL + i16::try_from(1usize);
|
error: casting `usize` to `i16` may wrap around the value on targets with 16-bit wide pointers
--> tests/ui/cast.rs:90:5
@ -261,8 +267,9 @@ LL | 1usize as i32;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | i32::try_from(1usize);
| ~~~~~~~~~~~~~~~~~~~~~
LL - 1usize as i32;
LL + i32::try_from(1usize);
|
error: casting `usize` to `i32` may wrap around the value on targets with 32-bit wide pointers
--> tests/ui/cast.rs:95:5
@ -300,8 +307,9 @@ LL | 1u64 as isize;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | isize::try_from(1u64);
| ~~~~~~~~~~~~~~~~~~~~~
LL - 1u64 as isize;
LL + isize::try_from(1u64);
|
error: casting `u64` to `isize` may wrap around the value on targets with 64-bit wide pointers
--> tests/ui/cast.rs:111:5
@ -360,8 +368,9 @@ LL | (-99999999999i64).min(1) as i8;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | i8::try_from((-99999999999i64).min(1));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - (-99999999999i64).min(1) as i8;
LL + i8::try_from((-99999999999i64).min(1));
|
error: casting `u64` to `u8` may truncate the value
--> tests/ui/cast.rs:222:5
@ -372,8 +381,9 @@ LL | 999999u64.clamp(0, 256) as u8;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | u8::try_from(999999u64.clamp(0, 256));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - 999999u64.clamp(0, 256) as u8;
LL + u8::try_from(999999u64.clamp(0, 256));
|
error: casting `main::E2` to `u8` may truncate the value
--> tests/ui/cast.rs:245:21
@ -384,8 +394,9 @@ LL | let _ = self as u8;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | let _ = u8::try_from(self);
| ~~~~~~~~~~~~~~~~~~
LL - let _ = self as u8;
LL + let _ = u8::try_from(self);
|
error: casting `main::E2::B` to `u8` will truncate the value
--> tests/ui/cast.rs:247:21
@ -405,8 +416,9 @@ LL | let _ = self as i8;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | let _ = i8::try_from(self);
| ~~~~~~~~~~~~~~~~~~
LL - let _ = self as i8;
LL + let _ = i8::try_from(self);
|
error: casting `main::E5::A` to `i8` will truncate the value
--> tests/ui/cast.rs:291:21
@ -423,8 +435,9 @@ LL | let _ = self as i16;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | let _ = i16::try_from(self);
| ~~~~~~~~~~~~~~~~~~~
LL - let _ = self as i16;
LL + let _ = i16::try_from(self);
|
error: casting `main::E7` to `usize` may truncate the value on targets with 32-bit wide pointers
--> tests/ui/cast.rs:327:21
@ -435,8 +448,9 @@ LL | let _ = self as usize;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | let _ = usize::try_from(self);
| ~~~~~~~~~~~~~~~~~~~~~
LL - let _ = self as usize;
LL + let _ = usize::try_from(self);
|
error: casting `main::E10` to `u16` may truncate the value
--> tests/ui/cast.rs:374:21
@ -447,8 +461,9 @@ LL | let _ = self as u16;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | let _ = u16::try_from(self);
| ~~~~~~~~~~~~~~~~~~~
LL - let _ = self as u16;
LL + let _ = u16::try_from(self);
|
error: casting `u32` to `u8` may truncate the value
--> tests/ui/cast.rs:385:13
@ -459,8 +474,9 @@ LL | let c = (q >> 16) as u8;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | let c = u8::try_from(q >> 16);
| ~~~~~~~~~~~~~~~~~~~~~
LL - let c = (q >> 16) as u8;
LL + let c = u8::try_from(q >> 16);
|
error: casting `u32` to `u8` may truncate the value
--> tests/ui/cast.rs:389:13
@ -471,8 +487,9 @@ LL | let c = (q / 1000) as u8;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | let c = u8::try_from(q / 1000);
| ~~~~~~~~~~~~~~~~~~~~~~
LL - let c = (q / 1000) as u8;
LL + let c = u8::try_from(q / 1000);
|
error: casting `i32` to `u32` may lose the sign of the value
--> tests/ui/cast.rs:401:9
@ -674,8 +691,9 @@ LL | m!();
= note: this error originates in the macro `m` (in Nightly builds, run with -Z macro-backtrace for more info)
help: ... or use `try_from` and handle the error accordingly
|
LL | let _ = u8::try_from(u32::MAX); // cast_possible_truncation
| ~~~~~~~~~~~~~~~~~~~~~~
LL - let _ = u32::MAX as u8; // cast_possible_truncation
LL + let _ = u8::try_from(u32::MAX); // cast_possible_truncation
|
error: casting `f64` to `f32` may truncate the value
--> tests/ui/cast.rs:474:21
@ -698,7 +716,8 @@ LL | bar.unwrap().unwrap() as usize
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | usize::try_from(bar.unwrap().unwrap())
LL - bar.unwrap().unwrap() as usize
LL + usize::try_from(bar.unwrap().unwrap())
|
error: casting `i64` to `usize` may lose the sign of the value
@ -716,8 +735,9 @@ LL | (256 & 999999u64) as u8;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | u8::try_from(256 & 999999u64);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - (256 & 999999u64) as u8;
LL + u8::try_from(256 & 999999u64);
|
error: casting `u64` to `u8` may truncate the value
--> tests/ui/cast.rs:500:5
@ -728,8 +748,9 @@ LL | (255 % 999999u64) as u8;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | u8::try_from(255 % 999999u64);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - (255 % 999999u64) as u8;
LL + u8::try_from(255 % 999999u64);
|
error: aborting due to 92 previous errors

75
src/tools/clippy/tests/ui/cast_lossless_bool.stderr
View file

@ -9,8 +9,9 @@ LL | let _ = true as u8;
= help: to override `-D warnings` add `#[allow(clippy::cast_lossless)]`
help: use `u8::from` instead
|
LL | let _ = u8::from(true);
| ~~~~~~~~~~~~~~
LL - let _ = true as u8;
LL + let _ = u8::from(true);
|
error: casts from `bool` to `u16` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_bool.rs:9:13
@ -21,8 +22,9 @@ LL | let _ = true as u16;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u16::from` instead
|
LL | let _ = u16::from(true);
| ~~~~~~~~~~~~~~~
LL - let _ = true as u16;
LL + let _ = u16::from(true);
|
error: casts from `bool` to `u32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_bool.rs:10:13
@ -33,8 +35,9 @@ LL | let _ = true as u32;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u32::from` instead
|
LL | let _ = u32::from(true);
| ~~~~~~~~~~~~~~~
LL - let _ = true as u32;
LL + let _ = u32::from(true);
|
error: casts from `bool` to `u64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_bool.rs:11:13
@ -45,8 +48,9 @@ LL | let _ = true as u64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u64::from` instead
|
LL | let _ = u64::from(true);
| ~~~~~~~~~~~~~~~
LL - let _ = true as u64;
LL + let _ = u64::from(true);
|
error: casts from `bool` to `u128` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_bool.rs:12:13
@ -57,8 +61,9 @@ LL | let _ = true as u128;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u128::from` instead
|
LL | let _ = u128::from(true);
| ~~~~~~~~~~~~~~~~
LL - let _ = true as u128;
LL + let _ = u128::from(true);
|
error: casts from `bool` to `usize` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_bool.rs:13:13
@ -69,8 +74,9 @@ LL | let _ = true as usize;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `usize::from` instead
|
LL | let _ = usize::from(true);
| ~~~~~~~~~~~~~~~~~
LL - let _ = true as usize;
LL + let _ = usize::from(true);
|
error: casts from `bool` to `i8` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_bool.rs:15:13
@ -81,8 +87,9 @@ LL | let _ = true as i8;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i8::from` instead
|
LL | let _ = i8::from(true);
| ~~~~~~~~~~~~~~
LL - let _ = true as i8;
LL + let _ = i8::from(true);
|
error: casts from `bool` to `i16` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_bool.rs:16:13
@ -93,8 +100,9 @@ LL | let _ = true as i16;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i16::from` instead
|
LL | let _ = i16::from(true);
| ~~~~~~~~~~~~~~~
LL - let _ = true as i16;
LL + let _ = i16::from(true);
|
error: casts from `bool` to `i32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_bool.rs:17:13
@ -105,8 +113,9 @@ LL | let _ = true as i32;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i32::from` instead
|
LL | let _ = i32::from(true);
| ~~~~~~~~~~~~~~~
LL - let _ = true as i32;
LL + let _ = i32::from(true);
|
error: casts from `bool` to `i64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_bool.rs:18:13
@ -117,8 +126,9 @@ LL | let _ = true as i64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i64::from` instead
|
LL | let _ = i64::from(true);
| ~~~~~~~~~~~~~~~
LL - let _ = true as i64;
LL + let _ = i64::from(true);
|
error: casts from `bool` to `i128` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_bool.rs:19:13
@ -129,8 +139,9 @@ LL | let _ = true as i128;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i128::from` instead
|
LL | let _ = i128::from(true);
| ~~~~~~~~~~~~~~~~
LL - let _ = true as i128;
LL + let _ = i128::from(true);
|
error: casts from `bool` to `isize` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_bool.rs:20:13
@ -141,8 +152,9 @@ LL | let _ = true as isize;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `isize::from` instead
|
LL | let _ = isize::from(true);
| ~~~~~~~~~~~~~~~~~
LL - let _ = true as isize;
LL + let _ = isize::from(true);
|
error: casts from `bool` to `u16` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_bool.rs:23:13
@ -153,8 +165,9 @@ LL | let _ = (true | false) as u16;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u16::from` instead
|
LL | let _ = u16::from(true | false);
| ~~~~~~~~~~~~~~~~~~~~~~~
LL - let _ = (true | false) as u16;
LL + let _ = u16::from(true | false);
|
error: casts from `bool` to `u8` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_bool.rs:25:13
@ -165,8 +178,9 @@ LL | let _ = true as U8;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `U8::from` instead
|
LL | let _ = U8::from(true);
| ~~~~~~~~~~~~~~
LL - let _ = true as U8;
LL + let _ = U8::from(true);
|
error: casts from `bool` to `u8` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_bool.rs:53:13
@ -177,8 +191,9 @@ LL | let _ = true as u8;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u8::from` instead
|
LL | let _ = u8::from(true);
| ~~~~~~~~~~~~~~
LL - let _ = true as u8;
LL + let _ = u8::from(true);
|
error: aborting due to 15 previous errors

65
src/tools/clippy/tests/ui/cast_lossless_float.stderr
View file

@ -9,8 +9,9 @@ LL | let _ = x0 as f32;
= help: to override `-D warnings` add `#[allow(clippy::cast_lossless)]`
help: use `f32::from` instead
|
LL | let _ = f32::from(x0);
| ~~~~~~~~~~~~~
LL - let _ = x0 as f32;
LL + let _ = f32::from(x0);
|
error: casts from `i8` to `f64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_float.rs:13:13
@ -21,8 +22,9 @@ LL | let _ = x0 as f64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `f64::from` instead
|
LL | let _ = f64::from(x0);
| ~~~~~~~~~~~~~
LL - let _ = x0 as f64;
LL + let _ = f64::from(x0);
|
error: casts from `i8` to `f32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_float.rs:14:13
@ -33,8 +35,9 @@ LL | let _ = x0 as F32;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `F32::from` instead
|
LL | let _ = F32::from(x0);
| ~~~~~~~~~~~~~
LL - let _ = x0 as F32;
LL + let _ = F32::from(x0);
|
error: casts from `i8` to `f64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_float.rs:15:13
@ -45,8 +48,9 @@ LL | let _ = x0 as F64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `F64::from` instead
|
LL | let _ = F64::from(x0);
| ~~~~~~~~~~~~~
LL - let _ = x0 as F64;
LL + let _ = F64::from(x0);
|
error: casts from `u8` to `f32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_float.rs:17:13
@ -57,8 +61,9 @@ LL | let _ = x1 as f32;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `f32::from` instead
|
LL | let _ = f32::from(x1);
| ~~~~~~~~~~~~~
LL - let _ = x1 as f32;
LL + let _ = f32::from(x1);
|
error: casts from `u8` to `f64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_float.rs:18:13
@ -69,8 +74,9 @@ LL | let _ = x1 as f64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `f64::from` instead
|
LL | let _ = f64::from(x1);
| ~~~~~~~~~~~~~
LL - let _ = x1 as f64;
LL + let _ = f64::from(x1);
|
error: casts from `i16` to `f32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_float.rs:20:13
@ -81,8 +87,9 @@ LL | let _ = x2 as f32;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `f32::from` instead
|
LL | let _ = f32::from(x2);
| ~~~~~~~~~~~~~
LL - let _ = x2 as f32;
LL + let _ = f32::from(x2);
|
error: casts from `i16` to `f64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_float.rs:21:13
@ -93,8 +100,9 @@ LL | let _ = x2 as f64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `f64::from` instead
|
LL | let _ = f64::from(x2);
| ~~~~~~~~~~~~~
LL - let _ = x2 as f64;
LL + let _ = f64::from(x2);
|
error: casts from `u16` to `f32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_float.rs:23:13
@ -105,8 +113,9 @@ LL | let _ = x3 as f32;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `f32::from` instead
|
LL | let _ = f32::from(x3);
| ~~~~~~~~~~~~~
LL - let _ = x3 as f32;
LL + let _ = f32::from(x3);
|
error: casts from `u16` to `f64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_float.rs:24:13
@ -117,8 +126,9 @@ LL | let _ = x3 as f64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `f64::from` instead
|
LL | let _ = f64::from(x3);
| ~~~~~~~~~~~~~
LL - let _ = x3 as f64;
LL + let _ = f64::from(x3);
|
error: casts from `i32` to `f64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_float.rs:26:13
@ -129,8 +139,9 @@ LL | let _ = x4 as f64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `f64::from` instead
|
LL | let _ = f64::from(x4);
| ~~~~~~~~~~~~~
LL - let _ = x4 as f64;
LL + let _ = f64::from(x4);
|
error: casts from `u32` to `f64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_float.rs:28:13
@ -141,8 +152,9 @@ LL | let _ = x5 as f64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `f64::from` instead
|
LL | let _ = f64::from(x5);
| ~~~~~~~~~~~~~
LL - let _ = x5 as f64;
LL + let _ = f64::from(x5);
|
error: casts from `f32` to `f64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_float.rs:31:13
@ -153,8 +165,9 @@ LL | let _ = 1.0f32 as f64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `f64::from` instead
|
LL | let _ = f64::from(1.0f32);
| ~~~~~~~~~~~~~~~~~
LL - let _ = 1.0f32 as f64;
LL + let _ = f64::from(1.0f32);
|
error: aborting due to 13 previous errors

198
src/tools/clippy/tests/ui/cast_lossless_integer.stderr
View file

@ -9,8 +9,9 @@ LL | 0u8 as u16;
= help: to override `-D warnings` add `#[allow(clippy::cast_lossless)]`
help: use `u16::from` instead
|
LL | u16::from(0u8);
| ~~~~~~~~~~~~~~
LL - 0u8 as u16;
LL + u16::from(0u8);
|
error: casts from `u8` to `i16` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:10:5
@ -21,8 +22,9 @@ LL | 0u8 as i16;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i16::from` instead
|
LL | i16::from(0u8);
| ~~~~~~~~~~~~~~
LL - 0u8 as i16;
LL + i16::from(0u8);
|
error: casts from `u8` to `u32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:12:5
@ -33,8 +35,9 @@ LL | 0u8 as u32;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u32::from` instead
|
LL | u32::from(0u8);
| ~~~~~~~~~~~~~~
LL - 0u8 as u32;
LL + u32::from(0u8);
|
error: casts from `u8` to `i32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:14:5
@ -45,8 +48,9 @@ LL | 0u8 as i32;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i32::from` instead
|
LL | i32::from(0u8);
| ~~~~~~~~~~~~~~
LL - 0u8 as i32;
LL + i32::from(0u8);
|
error: casts from `u8` to `u64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:16:5
@ -57,8 +61,9 @@ LL | 0u8 as u64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u64::from` instead
|
LL | u64::from(0u8);
| ~~~~~~~~~~~~~~
LL - 0u8 as u64;
LL + u64::from(0u8);
|
error: casts from `u8` to `i64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:18:5
@ -69,8 +74,9 @@ LL | 0u8 as i64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i64::from` instead
|
LL | i64::from(0u8);
| ~~~~~~~~~~~~~~
LL - 0u8 as i64;
LL + i64::from(0u8);
|
error: casts from `u8` to `u128` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:20:5
@ -81,8 +87,9 @@ LL | 0u8 as u128;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u128::from` instead
|
LL | u128::from(0u8);
| ~~~~~~~~~~~~~~~
LL - 0u8 as u128;
LL + u128::from(0u8);
|
error: casts from `u8` to `i128` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:22:5
@ -93,8 +100,9 @@ LL | 0u8 as i128;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i128::from` instead
|
LL | i128::from(0u8);
| ~~~~~~~~~~~~~~~
LL - 0u8 as i128;
LL + i128::from(0u8);
|
error: casts from `u16` to `u32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:25:5
@ -105,8 +113,9 @@ LL | 0u16 as u32;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u32::from` instead
|
LL | u32::from(0u16);
| ~~~~~~~~~~~~~~~
LL - 0u16 as u32;
LL + u32::from(0u16);
|
error: casts from `u16` to `i32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:27:5
@ -117,8 +126,9 @@ LL | 0u16 as i32;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i32::from` instead
|
LL | i32::from(0u16);
| ~~~~~~~~~~~~~~~
LL - 0u16 as i32;
LL + i32::from(0u16);
|
error: casts from `u16` to `u64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:29:5
@ -129,8 +139,9 @@ LL | 0u16 as u64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u64::from` instead
|
LL | u64::from(0u16);
| ~~~~~~~~~~~~~~~
LL - 0u16 as u64;
LL + u64::from(0u16);
|
error: casts from `u16` to `i64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:31:5
@ -141,8 +152,9 @@ LL | 0u16 as i64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i64::from` instead
|
LL | i64::from(0u16);
| ~~~~~~~~~~~~~~~
LL - 0u16 as i64;
LL + i64::from(0u16);
|
error: casts from `u16` to `u128` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:33:5
@ -153,8 +165,9 @@ LL | 0u16 as u128;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u128::from` instead
|
LL | u128::from(0u16);
| ~~~~~~~~~~~~~~~~
LL - 0u16 as u128;
LL + u128::from(0u16);
|
error: casts from `u16` to `i128` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:35:5
@ -165,8 +178,9 @@ LL | 0u16 as i128;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i128::from` instead
|
LL | i128::from(0u16);
| ~~~~~~~~~~~~~~~~
LL - 0u16 as i128;
LL + i128::from(0u16);
|
error: casts from `u32` to `u64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:38:5
@ -177,8 +191,9 @@ LL | 0u32 as u64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u64::from` instead
|
LL | u64::from(0u32);
| ~~~~~~~~~~~~~~~
LL - 0u32 as u64;
LL + u64::from(0u32);
|
error: casts from `u32` to `i64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:40:5
@ -189,8 +204,9 @@ LL | 0u32 as i64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i64::from` instead
|
LL | i64::from(0u32);
| ~~~~~~~~~~~~~~~
LL - 0u32 as i64;
LL + i64::from(0u32);
|
error: casts from `u32` to `u128` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:42:5
@ -201,8 +217,9 @@ LL | 0u32 as u128;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u128::from` instead
|
LL | u128::from(0u32);
| ~~~~~~~~~~~~~~~~
LL - 0u32 as u128;
LL + u128::from(0u32);
|
error: casts from `u32` to `i128` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:44:5
@ -213,8 +230,9 @@ LL | 0u32 as i128;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i128::from` instead
|
LL | i128::from(0u32);
| ~~~~~~~~~~~~~~~~
LL - 0u32 as i128;
LL + i128::from(0u32);
|
error: casts from `u64` to `u128` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:47:5
@ -225,8 +243,9 @@ LL | 0u64 as u128;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u128::from` instead
|
LL | u128::from(0u64);
| ~~~~~~~~~~~~~~~~
LL - 0u64 as u128;
LL + u128::from(0u64);
|
error: casts from `u64` to `i128` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:49:5
@ -237,8 +256,9 @@ LL | 0u64 as i128;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i128::from` instead
|
LL | i128::from(0u64);
| ~~~~~~~~~~~~~~~~
LL - 0u64 as i128;
LL + i128::from(0u64);
|
error: casts from `i8` to `i16` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:52:5
@ -249,8 +269,9 @@ LL | 0i8 as i16;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i16::from` instead
|
LL | i16::from(0i8);
| ~~~~~~~~~~~~~~
LL - 0i8 as i16;
LL + i16::from(0i8);
|
error: casts from `i8` to `i32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:54:5
@ -261,8 +282,9 @@ LL | 0i8 as i32;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i32::from` instead
|
LL | i32::from(0i8);
| ~~~~~~~~~~~~~~
LL - 0i8 as i32;
LL + i32::from(0i8);
|
error: casts from `i8` to `i64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:56:5
@ -273,8 +295,9 @@ LL | 0i8 as i64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i64::from` instead
|
LL | i64::from(0i8);
| ~~~~~~~~~~~~~~
LL - 0i8 as i64;
LL + i64::from(0i8);
|
error: casts from `i8` to `i128` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:58:5
@ -285,8 +308,9 @@ LL | 0i8 as i128;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i128::from` instead
|
LL | i128::from(0i8);
| ~~~~~~~~~~~~~~~
LL - 0i8 as i128;
LL + i128::from(0i8);
|
error: casts from `i16` to `i32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:61:5
@ -297,8 +321,9 @@ LL | 0i16 as i32;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i32::from` instead
|
LL | i32::from(0i16);
| ~~~~~~~~~~~~~~~
LL - 0i16 as i32;
LL + i32::from(0i16);
|
error: casts from `i16` to `i64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:63:5
@ -309,8 +334,9 @@ LL | 0i16 as i64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i64::from` instead
|
LL | i64::from(0i16);
| ~~~~~~~~~~~~~~~
LL - 0i16 as i64;
LL + i64::from(0i16);
|
error: casts from `i16` to `i128` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:65:5
@ -321,8 +347,9 @@ LL | 0i16 as i128;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i128::from` instead
|
LL | i128::from(0i16);
| ~~~~~~~~~~~~~~~~
LL - 0i16 as i128;
LL + i128::from(0i16);
|
error: casts from `i32` to `i64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:68:5
@ -333,8 +360,9 @@ LL | 0i32 as i64;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i64::from` instead
|
LL | i64::from(0i32);
| ~~~~~~~~~~~~~~~
LL - 0i32 as i64;
LL + i64::from(0i32);
|
error: casts from `i32` to `i128` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:70:5
@ -345,8 +373,9 @@ LL | 0i32 as i128;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i128::from` instead
|
LL | i128::from(0i32);
| ~~~~~~~~~~~~~~~~
LL - 0i32 as i128;
LL + i128::from(0i32);
|
error: casts from `i64` to `i128` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:73:5
@ -357,8 +386,9 @@ LL | 0i64 as i128;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i128::from` instead
|
LL | i128::from(0i64);
| ~~~~~~~~~~~~~~~~
LL - 0i64 as i128;
LL + i128::from(0i64);
|
error: casts from `u8` to `u16` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:77:13
@ -369,8 +399,9 @@ LL | let _ = (1u8 + 1u8) as u16;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `u16::from` instead
|
LL | let _ = u16::from(1u8 + 1u8);
| ~~~~~~~~~~~~~~~~~~~~
LL - let _ = (1u8 + 1u8) as u16;
LL + let _ = u16::from(1u8 + 1u8);
|
error: casts from `i8` to `i64` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:80:13
@ -381,8 +412,9 @@ LL | let _ = 1i8 as I64Alias;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `I64Alias::from` instead
|
LL | let _ = I64Alias::from(1i8);
| ~~~~~~~~~~~~~~~~~~~
LL - let _ = 1i8 as I64Alias;
LL + let _ = I64Alias::from(1i8);
|
error: casts from `u8` to `u16` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:83:18
@ -393,8 +425,9 @@ LL | let _: u16 = 0u8 as _;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `Into::into` instead
|
LL | let _: u16 = 0u8.into();
| ~~~~~~~~~~
LL - let _: u16 = 0u8 as _;
LL + let _: u16 = 0u8.into();
|
error: casts from `i8` to `i16` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:85:18
@ -405,8 +438,9 @@ LL | let _: i16 = -1i8 as _;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `Into::into` instead
|
LL | let _: i16 = (-1i8).into();
| ~~~~~~~~~~~~~
LL - let _: i16 = -1i8 as _;
LL + let _: i16 = (-1i8).into();
|
error: casts from `u8` to `u16` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:87:18
@ -417,8 +451,9 @@ LL | let _: u16 = (1u8 + 2) as _;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `Into::into` instead
|
LL | let _: u16 = (1u8 + 2).into();
| ~~~~~~~~~~~~~~~~
LL - let _: u16 = (1u8 + 2) as _;
LL + let _: u16 = (1u8 + 2).into();
|
error: casts from `u16` to `u32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:89:18
@ -429,8 +464,9 @@ LL | let _: u32 = 1i8 as u16 as _;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `Into::into` instead
|
LL | let _: u32 = (1i8 as u16).into();
| ~~~~~~~~~~~~~~~~~~~
LL - let _: u32 = 1i8 as u16 as _;
LL + let _: u32 = (1i8 as u16).into();
|
error: casts from `i8` to `i32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:124:13
@ -441,8 +477,9 @@ LL | let _ = sign_cast!(x, u8, i8) as i32;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i32::from` instead
|
LL | let _ = i32::from(sign_cast!(x, u8, i8));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _ = sign_cast!(x, u8, i8) as i32;
LL + let _ = i32::from(sign_cast!(x, u8, i8));
|
error: casts from `i8` to `i32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:126:13
@ -453,8 +490,9 @@ LL | let _ = (sign_cast!(x, u8, i8) + 1) as i32;
= help: an `as` cast can become silently lossy if the types change in the future
help: use `i32::from` instead
|
LL | let _ = i32::from(sign_cast!(x, u8, i8) + 1);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _ = (sign_cast!(x, u8, i8) + 1) as i32;
LL + let _ = i32::from(sign_cast!(x, u8, i8) + 1);
|
error: casts from `u8` to `u32` can be expressed infallibly using `From`
--> tests/ui/cast_lossless_integer.rs:133:13
@ -469,7 +507,8 @@ LL | let _ = in_macro!();
= note: this error originates in the macro `in_macro` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `u32::from` instead
|
LL | u32::from(1u8)
LL - 1u8 as u32
LL + u32::from(1u8)
|
error: casts from `u8` to `u32` can be expressed infallibly using `From`
@ -481,8 +520,9 @@ LL | let _ = 0u8 as ty!();
= help: an `as` cast can become silently lossy if the types change in the future
help: use `<ty!()>::from` instead
|
LL | let _ = <ty!()>::from(0u8);
| ~~~~~~~~~~~~~~~~~~
LL - let _ = 0u8 as ty!();
LL + let _ = <ty!()>::from(0u8);
|
error: aborting due to 40 previous errors

45
src/tools/clippy/tests/ui/cast_size.64bit.stderr
View file

@ -9,8 +9,9 @@ LL | 1isize as i8;
= help: to override `-D warnings` add `#[allow(clippy::cast_possible_truncation)]`
help: ... or use `try_from` and handle the error accordingly
|
LL | i8::try_from(1isize);
| ~~~~~~~~~~~~~~~~~~~~
LL - 1isize as i8;
LL + i8::try_from(1isize);
|
error: casting `isize` to `f32` causes a loss of precision (`isize` is 32 or 64 bits wide, but `f32`'s mantissa is only 23 bits wide)
--> tests/ui/cast_size.rs:21:5
@ -48,8 +49,9 @@ LL | 1isize as i32;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | i32::try_from(1isize);
| ~~~~~~~~~~~~~~~~~~~~~
LL - 1isize as i32;
LL + i32::try_from(1isize);
|
error: casting `isize` to `u32` may truncate the value on targets with 64-bit wide pointers
--> tests/ui/cast_size.rs:29:5
@ -60,8 +62,9 @@ LL | 1isize as u32;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | u32::try_from(1isize);
| ~~~~~~~~~~~~~~~~~~~~~
LL - 1isize as u32;
LL + u32::try_from(1isize);
|
error: casting `usize` to `u32` may truncate the value on targets with 64-bit wide pointers
--> tests/ui/cast_size.rs:30:5
@ -72,8 +75,9 @@ LL | 1usize as u32;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | u32::try_from(1usize);
| ~~~~~~~~~~~~~~~~~~~~~
LL - 1usize as u32;
LL + u32::try_from(1usize);
|
error: casting `usize` to `i32` may truncate the value on targets with 64-bit wide pointers
--> tests/ui/cast_size.rs:31:5
@ -84,8 +88,9 @@ LL | 1usize as i32;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | i32::try_from(1usize);
| ~~~~~~~~~~~~~~~~~~~~~
LL - 1usize as i32;
LL + i32::try_from(1usize);
|
error: casting `usize` to `i32` may wrap around the value on targets with 32-bit wide pointers
--> tests/ui/cast_size.rs:31:5
@ -105,8 +110,9 @@ LL | 1i64 as isize;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | isize::try_from(1i64);
| ~~~~~~~~~~~~~~~~~~~~~
LL - 1i64 as isize;
LL + isize::try_from(1i64);
|
error: casting `i64` to `usize` may truncate the value on targets with 32-bit wide pointers
--> tests/ui/cast_size.rs:33:5
@ -117,8 +123,9 @@ LL | 1i64 as usize;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | usize::try_from(1i64);
| ~~~~~~~~~~~~~~~~~~~~~
LL - 1i64 as usize;
LL + usize::try_from(1i64);
|
error: casting `u64` to `isize` may truncate the value on targets with 32-bit wide pointers
--> tests/ui/cast_size.rs:34:5
@ -129,8 +136,9 @@ LL | 1u64 as isize;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | isize::try_from(1u64);
| ~~~~~~~~~~~~~~~~~~~~~
LL - 1u64 as isize;
LL + isize::try_from(1u64);
|
error: casting `u64` to `isize` may wrap around the value on targets with 64-bit wide pointers
--> tests/ui/cast_size.rs:34:5
@ -147,8 +155,9 @@ LL | 1u64 as usize;
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
help: ... or use `try_from` and handle the error accordingly
|
LL | usize::try_from(1u64);
| ~~~~~~~~~~~~~~~~~~~~~
LL - 1u64 as usize;
LL + usize::try_from(1u64);
|
error: casting `u32` to `isize` may wrap around the value on targets with 32-bit wide pointers
--> tests/ui/cast_size.rs:36:5

10
src/tools/clippy/tests/ui/create_dir.stderr
View file

@ -8,8 +8,9 @@ LL | std::fs::create_dir("foo");
= help: to override `-D warnings` add `#[allow(clippy::create_dir)]`
help: consider calling `std::fs::create_dir_all` instead
|
LL | create_dir_all("foo");
| ~~~~~~~~~~~~~~~~~~~~~
LL - std::fs::create_dir("foo");
LL + create_dir_all("foo");
|
error: calling `std::fs::create_dir` where there may be a better way
--> tests/ui/create_dir.rs:11:5
@ -19,8 +20,9 @@ LL | std::fs::create_dir("bar").unwrap();
|
help: consider calling `std::fs::create_dir_all` instead
|
LL | create_dir_all("bar").unwrap();
| ~~~~~~~~~~~~~~~~~~~~~
LL - std::fs::create_dir("bar").unwrap();
LL + create_dir_all("bar").unwrap();
|
error: aborting due to 2 previous errors

81
src/tools/clippy/tests/ui/dbg_macro/dbg_macro.stderr
View file

@ -8,8 +8,9 @@ LL | if let Some(n) = dbg!(n.checked_sub(4)) { n } else { n }
= help: to override `-D warnings` add `#[allow(clippy::dbg_macro)]`
help: remove the invocation before committing it to a version control system
|
LL | if let Some(n) = n.checked_sub(4) { n } else { n }
| ~~~~~~~~~~~~~~~~
LL - if let Some(n) = dbg!(n.checked_sub(4)) { n } else { n }
LL + if let Some(n) = n.checked_sub(4) { n } else { n }
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro.rs:11:8
@ -19,8 +20,9 @@ LL | if dbg!(n <= 1) {
|
help: remove the invocation before committing it to a version control system
|
LL | if n <= 1 {
| ~~~~~~
LL - if dbg!(n <= 1) {
LL + if n <= 1 {
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro.rs:13:9
@ -30,7 +32,8 @@ LL | dbg!(1)
|
help: remove the invocation before committing it to a version control system
|
LL | 1
LL - dbg!(1)
LL + 1
|
error: the `dbg!` macro is intended as a debugging tool
@ -41,7 +44,8 @@ LL | dbg!(n * factorial(n - 1))
|
help: remove the invocation before committing it to a version control system
|
LL | n * factorial(n - 1)
LL - dbg!(n * factorial(n - 1))
LL + n * factorial(n - 1)
|
error: the `dbg!` macro is intended as a debugging tool
@ -52,8 +56,9 @@ LL | dbg!(42);
|
help: remove the invocation before committing it to a version control system
|
LL | 42;
| ~~
LL - dbg!(42);
LL + 42;
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro.rs:24:14
@ -63,8 +68,9 @@ LL | foo(3) + dbg!(factorial(4));
|
help: remove the invocation before committing it to a version control system
|
LL | foo(3) + factorial(4);
| ~~~~~~~~~~~~
LL - foo(3) + dbg!(factorial(4));
LL + foo(3) + factorial(4);
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro.rs:26:5
@ -74,8 +80,9 @@ LL | dbg!(1, 2, 3, 4, 5);
|
help: remove the invocation before committing it to a version control system
|
LL | (1, 2, 3, 4, 5);
| ~~~~~~~~~~~~~~~
LL - dbg!(1, 2, 3, 4, 5);
LL + (1, 2, 3, 4, 5);
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro.rs:48:5
@ -96,8 +103,9 @@ LL | let _ = dbg!();
|
help: remove the invocation before committing it to a version control system
|
LL | let _ = ();
| ~~
LL - let _ = dbg!();
LL + let _ = ();
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro.rs:53:9
@ -107,8 +115,9 @@ LL | bar(dbg!());
|
help: remove the invocation before committing it to a version control system
|
LL | bar(());
| ~~
LL - bar(dbg!());
LL + bar(());
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro.rs:55:10
@ -118,8 +127,9 @@ LL | foo!(dbg!());
|
help: remove the invocation before committing it to a version control system
|
LL | foo!(());
| ~~
LL - foo!(dbg!());
LL + foo!(());
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro.rs:57:16
@ -129,8 +139,9 @@ LL | foo2!(foo!(dbg!()));
|
help: remove the invocation before committing it to a version control system
|
LL | foo2!(foo!(()));
| ~~
LL - foo2!(foo!(dbg!()));
LL + foo2!(foo!(()));
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro.rs:43:13
@ -155,8 +166,9 @@ LL | dbg!(2);
|
help: remove the invocation before committing it to a version control system
|
LL | 2;
| ~
LL - dbg!(2);
LL + 2;
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro.rs:86:5
@ -166,8 +178,9 @@ LL | dbg!(1);
|
help: remove the invocation before committing it to a version control system
|
LL | 1;
| ~
LL - dbg!(1);
LL + 1;
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro.rs:92:5
@ -177,8 +190,9 @@ LL | dbg!(1);
|
help: remove the invocation before committing it to a version control system
|
LL | 1;
| ~
LL - dbg!(1);
LL + 1;
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro.rs:99:9
@ -188,8 +202,9 @@ LL | dbg!(1);
|
help: remove the invocation before committing it to a version control system
|
LL | 1;
| ~
LL - dbg!(1);
LL + 1;
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro.rs:106:31
@ -199,8 +214,9 @@ LL | println!("dbg: {:?}", dbg!(s));
|
help: remove the invocation before committing it to a version control system
|
LL | println!("dbg: {:?}", s);
| ~
LL - println!("dbg: {:?}", dbg!(s));
LL + println!("dbg: {:?}", s);
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro.rs:108:22
@ -210,8 +226,9 @@ LL | print!("{}", dbg!(s));
|
help: remove the invocation before committing it to a version control system
|
LL | print!("{}", s);
| ~
LL - print!("{}", dbg!(s));
LL + print!("{}", s);
|
error: aborting due to 19 previous errors

25
src/tools/clippy/tests/ui/dbg_macro/dbg_macro_unfixable.stderr
View file

@ -19,8 +19,9 @@ LL | dbg!(dbg!(dbg!(42)));
|
help: remove the invocation before committing it to a version control system
|
LL | dbg!(dbg!(42));
| ~~~~~~~~~~~~~~
LL - dbg!(dbg!(dbg!(42)));
LL + dbg!(dbg!(42));
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro_unfixable.rs:8:10
@ -30,8 +31,9 @@ LL | dbg!(dbg!(dbg!(42)));
|
help: remove the invocation before committing it to a version control system
|
LL | dbg!(dbg!(42));
| ~~~~~~~~
LL - dbg!(dbg!(dbg!(42)));
LL + dbg!(dbg!(42));
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro_unfixable.rs:8:15
@ -41,8 +43,9 @@ LL | dbg!(dbg!(dbg!(42)));
|
help: remove the invocation before committing it to a version control system
|
LL | dbg!(dbg!(42));
| ~~
LL - dbg!(dbg!(dbg!(42)));
LL + dbg!(dbg!(42));
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro_unfixable.rs:10:5
@ -52,8 +55,9 @@ LL | dbg!(1, 2, dbg!(3, 4));
|
help: remove the invocation before committing it to a version control system
|
LL | (1, 2, dbg!(3, 4));
| ~~~~~~~~~~~~~~~~~~
LL - dbg!(1, 2, dbg!(3, 4));
LL + (1, 2, dbg!(3, 4));
|
error: the `dbg!` macro is intended as a debugging tool
--> tests/ui/dbg_macro/dbg_macro_unfixable.rs:10:16
@ -63,8 +67,9 @@ LL | dbg!(1, 2, dbg!(3, 4));
|
help: remove the invocation before committing it to a version control system
|
LL | dbg!(1, 2, (3, 4));
| ~~~~~~
LL - dbg!(1, 2, dbg!(3, 4));
LL + dbg!(1, 2, (3, 4));
|
error: aborting due to 6 previous errors

161
src/tools/clippy/tests/ui/doc/doc-fixable.stderr
View file

@ -8,8 +8,9 @@ LL | /// The foo_bar function does _nothing_. See also foo::bar. (note the dot t
= help: to override `-D warnings` add `#[allow(clippy::doc_markdown)]`
help: try
|
LL | /// The `foo_bar` function does _nothing_. See also foo::bar. (note the dot there)
| ~~~~~~~~~
LL - /// The foo_bar function does _nothing_. See also foo::bar. (note the dot there)
LL + /// The `foo_bar` function does _nothing_. See also foo::bar. (note the dot there)
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:9:51
@ -19,8 +20,9 @@ LL | /// The foo_bar function does _nothing_. See also foo::bar. (note the dot t
|
help: try
|
LL | /// The foo_bar function does _nothing_. See also `foo::bar`. (note the dot there)
| ~~~~~~~~~~
LL - /// The foo_bar function does _nothing_. See also foo::bar. (note the dot there)
LL + /// The foo_bar function does _nothing_. See also `foo::bar`. (note the dot there)
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:10:83
@ -30,8 +32,9 @@ LL | /// Markdown is _weird_. I mean _really weird_. This \_ is ok. So is `_`. B
|
help: try
|
LL | /// Markdown is _weird_. I mean _really weird_. This \_ is ok. So is `_`. But not `Foo::some_fun`
| ~~~~~~~~~~~~~~~
LL - /// Markdown is _weird_. I mean _really weird_. This \_ is ok. So is `_`. But not Foo::some_fun
LL + /// Markdown is _weird_. I mean _really weird_. This \_ is ok. So is `_`. But not `Foo::some_fun`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:12:13
@ -41,8 +44,9 @@ LL | /// Here be ::a::global:path, and _::another::global::path_. :: is not a p
|
help: try
|
LL | /// Here be `::a::global:path`, and _::another::global::path_. :: is not a path though.
| ~~~~~~~~~~~~~~~~~~
LL - /// Here be ::a::global:path, and _::another::global::path_. :: is not a path though.
LL + /// Here be `::a::global:path`, and _::another::global::path_. :: is not a path though.
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:12:36
@ -52,8 +56,9 @@ LL | /// Here be ::a::global:path, and _::another::global::path_. :: is not a p
|
help: try
|
LL | /// Here be ::a::global:path, and _`::another::global::path`_. :: is not a path though.
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - /// Here be ::a::global:path, and _::another::global::path_. :: is not a path though.
LL + /// Here be ::a::global:path, and _`::another::global::path`_. :: is not a path though.
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:13:25
@ -63,8 +68,9 @@ LL | /// Import an item from ::awesome::global::blob:: (Intended postfix)
|
help: try
|
LL | /// Import an item from `::awesome::global::blob::` (Intended postfix)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - /// Import an item from ::awesome::global::blob:: (Intended postfix)
LL + /// Import an item from `::awesome::global::blob::` (Intended postfix)
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:14:31
@ -74,8 +80,9 @@ LL | /// These are the options for ::Cat: (Intended trailing single colon, shoul
|
help: try
|
LL | /// These are the options for `::Cat`: (Intended trailing single colon, shouldn't be linted)
| ~~~~~~~
LL - /// These are the options for ::Cat: (Intended trailing single colon, shouldn't be linted)
LL + /// These are the options for `::Cat`: (Intended trailing single colon, shouldn't be linted)
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:15:22
@ -85,8 +92,9 @@ LL | /// That's not code ~NotInCodeBlock~.
|
help: try
|
LL | /// That's not code ~`NotInCodeBlock`~.
| ~~~~~~~~~~~~~~~~
LL - /// That's not code ~NotInCodeBlock~.
LL + /// That's not code ~`NotInCodeBlock`~.
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:16:5
@ -96,8 +104,9 @@ LL | /// be_sure_we_got_to_the_end_of_it
|
help: try
|
LL | /// `be_sure_we_got_to_the_end_of_it`
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - /// be_sure_we_got_to_the_end_of_it
LL + /// `be_sure_we_got_to_the_end_of_it`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:30:5
@ -107,8 +116,9 @@ LL | /// be_sure_we_got_to_the_end_of_it
|
help: try
|
LL | /// `be_sure_we_got_to_the_end_of_it`
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - /// be_sure_we_got_to_the_end_of_it
LL + /// `be_sure_we_got_to_the_end_of_it`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:37:5
@ -118,8 +128,9 @@ LL | /// be_sure_we_got_to_the_end_of_it
|
help: try
|
LL | /// `be_sure_we_got_to_the_end_of_it`
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - /// be_sure_we_got_to_the_end_of_it
LL + /// `be_sure_we_got_to_the_end_of_it`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:51:5
@ -129,8 +140,9 @@ LL | /// be_sure_we_got_to_the_end_of_it
|
help: try
|
LL | /// `be_sure_we_got_to_the_end_of_it`
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - /// be_sure_we_got_to_the_end_of_it
LL + /// `be_sure_we_got_to_the_end_of_it`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:79:5
@ -140,8 +152,9 @@ LL | /// be_sure_we_got_to_the_end_of_it
|
help: try
|
LL | /// `be_sure_we_got_to_the_end_of_it`
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - /// be_sure_we_got_to_the_end_of_it
LL + /// `be_sure_we_got_to_the_end_of_it`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:96:5
@ -151,8 +164,9 @@ LL | /// be_sure_we_got_to_the_end_of_it
|
help: try
|
LL | /// `be_sure_we_got_to_the_end_of_it`
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - /// be_sure_we_got_to_the_end_of_it
LL + /// `be_sure_we_got_to_the_end_of_it`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:104:8
@ -162,8 +176,9 @@ LL | /// ## CamelCaseThing
|
help: try
|
LL | /// ## `CamelCaseThing`
| ~~~~~~~~~~~~~~~~
LL - /// ## CamelCaseThing
LL + /// ## `CamelCaseThing`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:107:7
@ -173,8 +188,9 @@ LL | /// # CamelCaseThing
|
help: try
|
LL | /// # `CamelCaseThing`
| ~~~~~~~~~~~~~~~~
LL - /// # CamelCaseThing
LL + /// # `CamelCaseThing`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:109:22
@ -184,8 +200,9 @@ LL | /// Not a title #897 CamelCaseThing
|
help: try
|
LL | /// Not a title #897 `CamelCaseThing`
| ~~~~~~~~~~~~~~~~
LL - /// Not a title #897 CamelCaseThing
LL + /// Not a title #897 `CamelCaseThing`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:110:5
@ -195,8 +212,9 @@ LL | /// be_sure_we_got_to_the_end_of_it
|
help: try
|
LL | /// `be_sure_we_got_to_the_end_of_it`
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - /// be_sure_we_got_to_the_end_of_it
LL + /// `be_sure_we_got_to_the_end_of_it`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:117:5
@ -206,8 +224,9 @@ LL | /// be_sure_we_got_to_the_end_of_it
|
help: try
|
LL | /// `be_sure_we_got_to_the_end_of_it`
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - /// be_sure_we_got_to_the_end_of_it
LL + /// `be_sure_we_got_to_the_end_of_it`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:130:5
@ -217,8 +236,9 @@ LL | /// be_sure_we_got_to_the_end_of_it
|
help: try
|
LL | /// `be_sure_we_got_to_the_end_of_it`
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - /// be_sure_we_got_to_the_end_of_it
LL + /// `be_sure_we_got_to_the_end_of_it`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:141:43
@ -228,8 +248,9 @@ LL | /** E.g., serialization of an empty list: FooBar
|
help: try
|
LL | /** E.g., serialization of an empty list: `FooBar`
| ~~~~~~~~
LL - /** E.g., serialization of an empty list: FooBar
LL + /** E.g., serialization of an empty list: `FooBar`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:146:5
@ -239,8 +260,9 @@ LL | And BarQuz too.
|
help: try
|
LL | And `BarQuz` too.
| ~~~~~~~~
LL - And BarQuz too.
LL + And `BarQuz` too.
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:147:1
@ -250,7 +272,8 @@ LL | be_sure_we_got_to_the_end_of_it
|
help: try
|
LL | `be_sure_we_got_to_the_end_of_it`
LL - be_sure_we_got_to_the_end_of_it
LL + `be_sure_we_got_to_the_end_of_it`
|
error: item in documentation is missing backticks
@ -261,8 +284,9 @@ LL | /** E.g., serialization of an empty list: FooBar
|
help: try
|
LL | /** E.g., serialization of an empty list: `FooBar`
| ~~~~~~~~
LL - /** E.g., serialization of an empty list: FooBar
LL + /** E.g., serialization of an empty list: `FooBar`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:157:5
@ -272,8 +296,9 @@ LL | And BarQuz too.
|
help: try
|
LL | And `BarQuz` too.
| ~~~~~~~~
LL - And BarQuz too.
LL + And `BarQuz` too.
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:158:1
@ -283,7 +308,8 @@ LL | be_sure_we_got_to_the_end_of_it
|
help: try
|
LL | `be_sure_we_got_to_the_end_of_it`
LL - be_sure_we_got_to_the_end_of_it
LL + `be_sure_we_got_to_the_end_of_it`
|
error: item in documentation is missing backticks
@ -294,8 +320,9 @@ LL | /// be_sure_we_got_to_the_end_of_it
|
help: try
|
LL | /// `be_sure_we_got_to_the_end_of_it`
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - /// be_sure_we_got_to_the_end_of_it
LL + /// `be_sure_we_got_to_the_end_of_it`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:188:22
@ -305,8 +332,9 @@ LL | /// An iterator over mycrate::Collection's values.
|
help: try
|
LL | /// An iterator over `mycrate::Collection`'s values.
| ~~~~~~~~~~~~~~~~~~~~~
LL - /// An iterator over mycrate::Collection's values.
LL + /// An iterator over `mycrate::Collection`'s values.
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:212:34
@ -316,8 +344,9 @@ LL | /// Foo \[bar\] \[baz\] \[qux\]. DocMarkdownLint
|
help: try
|
LL | /// Foo \[bar\] \[baz\] \[qux\]. `DocMarkdownLint`
| ~~~~~~~~~~~~~~~~~
LL - /// Foo \[bar\] \[baz\] \[qux\]. DocMarkdownLint
LL + /// Foo \[bar\] \[baz\] \[qux\]. `DocMarkdownLint`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:235:22
@ -327,8 +356,9 @@ LL | /// There is no try (do() or do_not()).
|
help: try
|
LL | /// There is no try (`do()` or do_not()).
| ~~~~~~
LL - /// There is no try (do() or do_not()).
LL + /// There is no try (`do()` or do_not()).
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:235:30
@ -338,8 +368,9 @@ LL | /// There is no try (do() or do_not()).
|
help: try
|
LL | /// There is no try (do() or `do_not()`).
| ~~~~~~~~~~
LL - /// There is no try (do() or do_not()).
LL + /// There is no try (do() or `do_not()`).
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:238:5
@ -349,8 +380,9 @@ LL | /// ABes
|
help: try
|
LL | /// `ABes`
| ~~~~~~
LL - /// ABes
LL + /// `ABes`
|
error: item in documentation is missing backticks
--> tests/ui/doc/doc-fixable.rs:244:9
@ -360,8 +392,9 @@ LL | /// foo()
|
help: try
|
LL | /// `foo()`
| ~~~~~~~
LL - /// foo()
LL + /// `foo()`
|
error: you should put bare URLs between `<`/`>` or make a proper Markdown link
--> tests/ui/doc/doc-fixable.rs:248:5

5
src/tools/clippy/tests/ui/doc/doc_markdown-issue_13097.stderr
View file

@ -11,8 +11,9 @@ LL | #![deny(clippy::doc_markdown)]
| ^^^^^^^^^^^^^^^^^^^^
help: try
|
LL | /// `HumaNified`
| ~~~~~~~~~~~~
LL - /// HumaNified
LL + /// `HumaNified`
|
error: aborting due to 1 previous error

5
src/tools/clippy/tests/ui/doc/issue_10262.stderr
View file

@ -8,8 +8,9 @@ LL | /// AviSynth documentation:
= help: to override `-D warnings` add `#[allow(clippy::doc_markdown)]`
help: try
|
LL | /// `AviSynth` documentation:
| ~~~~~~~~~~
LL - /// AviSynth documentation:
LL + /// `AviSynth` documentation:
|
error: aborting due to 1 previous error

20
src/tools/clippy/tests/ui/doc/issue_12795.stderr
View file

@ -8,8 +8,9 @@ LL | //! A comment with a_b(x) and a_c in it and (a_b((c)) ) too and (maybe a_b(
= help: to override `-D warnings` add `#[allow(clippy::doc_markdown)]`
help: try
|
LL | //! A comment with `a_b(x)` and a_c in it and (a_b((c)) ) too and (maybe a_b((c)))
| ~~~~~~~~
LL - //! A comment with a_b(x) and a_c in it and (a_b((c)) ) too and (maybe a_b((c)))
LL + //! A comment with `a_b(x)` and a_c in it and (a_b((c)) ) too and (maybe a_b((c)))
|
error: item in documentation is missing backticks
--> tests/ui/doc/issue_12795.rs:3:31
@ -19,8 +20,9 @@ LL | //! A comment with a_b(x) and a_c in it and (a_b((c)) ) too and (maybe a_b(
|
help: try
|
LL | //! A comment with a_b(x) and `a_c` in it and (a_b((c)) ) too and (maybe a_b((c)))
| ~~~~~
LL - //! A comment with a_b(x) and a_c in it and (a_b((c)) ) too and (maybe a_b((c)))
LL + //! A comment with a_b(x) and `a_c` in it and (a_b((c)) ) too and (maybe a_b((c)))
|
error: item in documentation is missing backticks
--> tests/ui/doc/issue_12795.rs:3:46
@ -30,8 +32,9 @@ LL | //! A comment with a_b(x) and a_c in it and (a_b((c)) ) too and (maybe a_b(
|
help: try
|
LL | //! A comment with a_b(x) and a_c in it and (`a_b((c))` ) too and (maybe a_b((c)))
| ~~~~~~~~~~
LL - //! A comment with a_b(x) and a_c in it and (a_b((c)) ) too and (maybe a_b((c)))
LL + //! A comment with a_b(x) and a_c in it and (`a_b((c))` ) too and (maybe a_b((c)))
|
error: item in documentation is missing backticks
--> tests/ui/doc/issue_12795.rs:3:72
@ -41,8 +44,9 @@ LL | //! A comment with a_b(x) and a_c in it and (a_b((c)) ) too and (maybe a_b(
|
help: try
|
LL | //! A comment with a_b(x) and a_c in it and (a_b((c)) ) too and (maybe `a_b((c))`)
| ~~~~~~~~~~
LL - //! A comment with a_b(x) and a_c in it and (a_b((c)) ) too and (maybe a_b((c)))
LL + //! A comment with a_b(x) and a_c in it and (a_b((c)) ) too and (maybe `a_b((c))`)
|
error: aborting due to 4 previous errors

5
src/tools/clippy/tests/ui/doc/issue_9473.stderr
View file

@ -8,8 +8,9 @@ LL | /// Blah blah blah <code>[FooBar]&lt;[FooBar]&gt;</code>[FooBar].
= help: to override `-D warnings` add `#[allow(clippy::doc_markdown)]`
help: try
|
LL | /// Blah blah blah <code>[FooBar]&lt;[FooBar]&gt;</code>[`FooBar`].
| ~~~~~~~~
LL - /// Blah blah blah <code>[FooBar]&lt;[FooBar]&gt;</code>[FooBar].
LL + /// Blah blah blah <code>[FooBar]&lt;[FooBar]&gt;</code>[`FooBar`].
|
error: aborting due to 1 previous error

15
src/tools/clippy/tests/ui/doc/unbalanced_ticks.stderr
View file

@ -29,8 +29,9 @@ LL | /// This paragraph is fine and should_be linted normally.
|
help: try
|
LL | /// This paragraph is fine and `should_be` linted normally.
| ~~~~~~~~~~~
LL - /// This paragraph is fine and should_be linted normally.
LL + /// This paragraph is fine and `should_be` linted normally.
|
error: backticks are unbalanced
--> tests/ui/doc/unbalanced_ticks.rs:20:5
@ -48,8 +49,9 @@ LL | /// ## not_fine
|
help: try
|
LL | /// ## `not_fine`
| ~~~~~~~~~~
LL - /// ## not_fine
LL + /// ## `not_fine`
|
error: backticks are unbalanced
--> tests/ui/doc/unbalanced_ticks.rs:37:5
@ -75,8 +77,9 @@ LL | /// - This item needs backticks_here
|
help: try
|
LL | /// - This item needs `backticks_here`
| ~~~~~~~~~~~~~~~~
LL - /// - This item needs backticks_here
LL + /// - This item needs `backticks_here`
|
error: backticks are unbalanced
--> tests/ui/doc/unbalanced_ticks.rs:53:5

85
src/tools/clippy/tests/ui/eager_transmute.stderr
View file

@ -8,8 +8,9 @@ LL | (op < 4).then_some(unsafe { std::mem::transmute(op) })
= help: to override `-D warnings` add `#[allow(clippy::eager_transmute)]`
help: consider using `bool::then` to only transmute if the condition holds
|
LL | (op < 4).then(|| unsafe { std::mem::transmute(op) })
| ~~~~ ++
LL - (op < 4).then_some(unsafe { std::mem::transmute(op) })
LL + (op < 4).then(|| unsafe { std::mem::transmute(op) })
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:27:33
@ -19,8 +20,9 @@ LL | (op < 4).then_some(unsafe { std::mem::transmute::<_, Opcode>(op) });
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | (op < 4).then(|| unsafe { std::mem::transmute::<_, Opcode>(op) });
| ~~~~ ++
LL - (op < 4).then_some(unsafe { std::mem::transmute::<_, Opcode>(op) });
LL + (op < 4).then(|| unsafe { std::mem::transmute::<_, Opcode>(op) });
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:28:33
@ -30,8 +32,9 @@ LL | (op > 4).then_some(unsafe { std::mem::transmute::<_, Opcode>(op) });
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | (op > 4).then(|| unsafe { std::mem::transmute::<_, Opcode>(op) });
| ~~~~ ++
LL - (op > 4).then_some(unsafe { std::mem::transmute::<_, Opcode>(op) });
LL + (op > 4).then(|| unsafe { std::mem::transmute::<_, Opcode>(op) });
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:29:34
@ -41,8 +44,9 @@ LL | (op == 0).then_some(unsafe { std::mem::transmute::<_, Opcode>(op) });
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | (op == 0).then(|| unsafe { std::mem::transmute::<_, Opcode>(op) });
| ~~~~ ++
LL - (op == 0).then_some(unsafe { std::mem::transmute::<_, Opcode>(op) });
LL + (op == 0).then(|| unsafe { std::mem::transmute::<_, Opcode>(op) });
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:31:68
@ -52,8 +56,9 @@ LL | let _: Option<Opcode> = (op > 0 && op < 10).then_some(unsafe { std::mem
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | let _: Option<Opcode> = (op > 0 && op < 10).then(|| unsafe { std::mem::transmute(op) });
| ~~~~ ++
LL - let _: Option<Opcode> = (op > 0 && op < 10).then_some(unsafe { std::mem::transmute(op) });
LL + let _: Option<Opcode> = (op > 0 && op < 10).then(|| unsafe { std::mem::transmute(op) });
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:32:86
@ -63,8 +68,9 @@ LL | let _: Option<Opcode> = (op > 0 && op < 10 && unrelated == 0).then_some
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | let _: Option<Opcode> = (op > 0 && op < 10 && unrelated == 0).then(|| unsafe { std::mem::transmute(op) });
| ~~~~ ++
LL - let _: Option<Opcode> = (op > 0 && op < 10 && unrelated == 0).then_some(unsafe { std::mem::transmute(op) });
LL + let _: Option<Opcode> = (op > 0 && op < 10 && unrelated == 0).then(|| unsafe { std::mem::transmute(op) });
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:35:84
@ -74,8 +80,9 @@ LL | let _: Option<Opcode> = (op2.foo[0] > 0 && op2.foo[0] < 10).then_some(u
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | let _: Option<Opcode> = (op2.foo[0] > 0 && op2.foo[0] < 10).then(|| unsafe { std::mem::transmute(op2.foo[0]) });
| ~~~~ ++
LL - let _: Option<Opcode> = (op2.foo[0] > 0 && op2.foo[0] < 10).then_some(unsafe { std::mem::transmute(op2.foo[0]) });
LL + let _: Option<Opcode> = (op2.foo[0] > 0 && op2.foo[0] < 10).then(|| unsafe { std::mem::transmute(op2.foo[0]) });
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:47:70
@ -85,8 +92,9 @@ LL | let _: Option<Opcode> = (1..=3).contains(&op).then_some(unsafe { std::m
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | let _: Option<Opcode> = (1..=3).contains(&op).then(|| unsafe { std::mem::transmute(op) });
| ~~~~ ++
LL - let _: Option<Opcode> = (1..=3).contains(&op).then_some(unsafe { std::mem::transmute(op) });
LL + let _: Option<Opcode> = (1..=3).contains(&op).then(|| unsafe { std::mem::transmute(op) });
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:48:83
@ -96,8 +104,9 @@ LL | let _: Option<Opcode> = ((1..=3).contains(&op) || op == 4).then_some(un
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | let _: Option<Opcode> = ((1..=3).contains(&op) || op == 4).then(|| unsafe { std::mem::transmute(op) });
| ~~~~ ++
LL - let _: Option<Opcode> = ((1..=3).contains(&op) || op == 4).then_some(unsafe { std::mem::transmute(op) });
LL + let _: Option<Opcode> = ((1..=3).contains(&op) || op == 4).then(|| unsafe { std::mem::transmute(op) });
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:49:69
@ -107,8 +116,9 @@ LL | let _: Option<Opcode> = (1..3).contains(&op).then_some(unsafe { std::me
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | let _: Option<Opcode> = (1..3).contains(&op).then(|| unsafe { std::mem::transmute(op) });
| ~~~~ ++
LL - let _: Option<Opcode> = (1..3).contains(&op).then_some(unsafe { std::mem::transmute(op) });
LL + let _: Option<Opcode> = (1..3).contains(&op).then(|| unsafe { std::mem::transmute(op) });
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:50:68
@ -118,8 +128,9 @@ LL | let _: Option<Opcode> = (1..).contains(&op).then_some(unsafe { std::mem
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | let _: Option<Opcode> = (1..).contains(&op).then(|| unsafe { std::mem::transmute(op) });
| ~~~~ ++
LL - let _: Option<Opcode> = (1..).contains(&op).then_some(unsafe { std::mem::transmute(op) });
LL + let _: Option<Opcode> = (1..).contains(&op).then(|| unsafe { std::mem::transmute(op) });
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:51:68
@ -129,8 +140,9 @@ LL | let _: Option<Opcode> = (..3).contains(&op).then_some(unsafe { std::mem
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | let _: Option<Opcode> = (..3).contains(&op).then(|| unsafe { std::mem::transmute(op) });
| ~~~~ ++
LL - let _: Option<Opcode> = (..3).contains(&op).then_some(unsafe { std::mem::transmute(op) });
LL + let _: Option<Opcode> = (..3).contains(&op).then(|| unsafe { std::mem::transmute(op) });
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:52:69
@ -140,8 +152,9 @@ LL | let _: Option<Opcode> = (..=3).contains(&op).then_some(unsafe { std::me
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | let _: Option<Opcode> = (..=3).contains(&op).then(|| unsafe { std::mem::transmute(op) });
| ~~~~ ++
LL - let _: Option<Opcode> = (..=3).contains(&op).then_some(unsafe { std::mem::transmute(op) });
LL + let _: Option<Opcode> = (..=3).contains(&op).then(|| unsafe { std::mem::transmute(op) });
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:61:24
@ -151,8 +164,9 @@ LL | (op < 4).then_some(std::mem::transmute::<_, Opcode>(op));
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | (op < 4).then(|| std::mem::transmute::<_, Opcode>(op));
| ~~~~ ++
LL - (op < 4).then_some(std::mem::transmute::<_, Opcode>(op));
LL + (op < 4).then(|| std::mem::transmute::<_, Opcode>(op));
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:90:62
@ -162,8 +176,9 @@ LL | let _: Option<NonZero<u8>> = (v1 > 0).then_some(unsafe { std::mem::tran
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | let _: Option<NonZero<u8>> = (v1 > 0).then(|| unsafe { std::mem::transmute(v1) });
| ~~~~ ++
LL - let _: Option<NonZero<u8>> = (v1 > 0).then_some(unsafe { std::mem::transmute(v1) });
LL + let _: Option<NonZero<u8>> = (v1 > 0).then(|| unsafe { std::mem::transmute(v1) });
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:96:86
@ -173,8 +188,9 @@ LL | let _: Option<NonMaxU8> = (v2 < NonZero::new(255u8).unwrap()).then_some
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | let _: Option<NonMaxU8> = (v2 < NonZero::new(255u8).unwrap()).then(|| unsafe { std::mem::transmute(v2) });
| ~~~~ ++
LL - let _: Option<NonMaxU8> = (v2 < NonZero::new(255u8).unwrap()).then_some(unsafe { std::mem::transmute(v2) });
LL + let _: Option<NonMaxU8> = (v2 < NonZero::new(255u8).unwrap()).then(|| unsafe { std::mem::transmute(v2) });
|
error: this transmute is always evaluated eagerly, even if the condition is false
--> tests/ui/eager_transmute.rs:102:93
@ -184,8 +200,9 @@ LL | let _: Option<NonZeroNonMaxU8> = (v2 < NonZero::new(255u8).unwrap()).th
|
help: consider using `bool::then` to only transmute if the condition holds
|
LL | let _: Option<NonZeroNonMaxU8> = (v2 < NonZero::new(255u8).unwrap()).then(|| unsafe { std::mem::transmute(v2) });
| ~~~~ ++
LL - let _: Option<NonZeroNonMaxU8> = (v2 < NonZero::new(255u8).unwrap()).then_some(unsafe { std::mem::transmute(v2) });
LL + let _: Option<NonZeroNonMaxU8> = (v2 < NonZero::new(255u8).unwrap()).then(|| unsafe { std::mem::transmute(v2) });
|
error: aborting due to 17 previous errors

5
src/tools/clippy/tests/ui/empty_line_after/doc_comments.stderr
View file

@ -131,8 +131,9 @@ LL | fn first_in_module() {}
= help: if the empty line is unintentional, remove it
help: if the comment should document the parent module use an inner doc comment
|
LL | /*!
| ~
LL - /**
LL + /*!
|
error: empty line after doc comment
--> tests/ui/empty_line_after/doc_comments.rs:85:5

80
src/tools/clippy/tests/ui/excessive_precision.stderr
View file

@ -8,8 +8,9 @@ LL | const BAD32_1: f32 = 0.123_456_789_f32;
= help: to override `-D warnings` add `#[allow(clippy::excessive_precision)]`
help: consider changing the type or truncating it to
|
LL | const BAD32_1: f32 = 0.123_456_79_f32;
| ~~~~~~~~~~~~~~~~
LL - const BAD32_1: f32 = 0.123_456_789_f32;
LL + const BAD32_1: f32 = 0.123_456_79_f32;
|
error: float has excessive precision
--> tests/ui/excessive_precision.rs:21:26
@ -19,8 +20,9 @@ LL | const BAD32_2: f32 = 0.123_456_789;
|
help: consider changing the type or truncating it to
|
LL | const BAD32_2: f32 = 0.123_456_79;
| ~~~~~~~~~~~~
LL - const BAD32_2: f32 = 0.123_456_789;
LL + const BAD32_2: f32 = 0.123_456_79;
|
error: float has excessive precision
--> tests/ui/excessive_precision.rs:22:26
@ -30,8 +32,9 @@ LL | const BAD32_3: f32 = 0.100_000_000_000_1;
|
help: consider changing the type or truncating it to
|
LL | const BAD32_3: f32 = 0.1;
| ~~~
LL - const BAD32_3: f32 = 0.100_000_000_000_1;
LL + const BAD32_3: f32 = 0.1;
|
error: float has excessive precision
--> tests/ui/excessive_precision.rs:23:29
@ -41,8 +44,9 @@ LL | const BAD32_EDGE: f32 = 1.000_000_9;
|
help: consider changing the type or truncating it to
|
LL | const BAD32_EDGE: f32 = 1.000_001;
| ~~~~~~~~~
LL - const BAD32_EDGE: f32 = 1.000_000_9;
LL + const BAD32_EDGE: f32 = 1.000_001;
|
error: float has excessive precision
--> tests/ui/excessive_precision.rs:27:26
@ -52,8 +56,9 @@ LL | const BAD64_3: f64 = 0.100_000_000_000_000_000_1;
|
help: consider changing the type or truncating it to
|
LL | const BAD64_3: f64 = 0.1;
| ~~~
LL - const BAD64_3: f64 = 0.100_000_000_000_000_000_1;
LL + const BAD64_3: f64 = 0.1;
|
error: float has excessive precision
--> tests/ui/excessive_precision.rs:30:22
@ -63,8 +68,9 @@ LL | println!("{:?}", 8.888_888_888_888_888_888_888);
|
help: consider changing the type or truncating it to
|
LL | println!("{:?}", 8.888_888_888_888_89);
| ~~~~~~~~~~~~~~~~~~~~
LL - println!("{:?}", 8.888_888_888_888_888_888_888);
LL + println!("{:?}", 8.888_888_888_888_89);
|
error: float has excessive precision
--> tests/ui/excessive_precision.rs:41:22
@ -74,8 +80,9 @@ LL | let bad32: f32 = 1.123_456_789;
|
help: consider changing the type or truncating it to
|
LL | let bad32: f32 = 1.123_456_8;
| ~~~~~~~~~~~
LL - let bad32: f32 = 1.123_456_789;
LL + let bad32: f32 = 1.123_456_8;
|
error: float has excessive precision
--> tests/ui/excessive_precision.rs:42:26
@ -85,8 +92,9 @@ LL | let bad32_suf: f32 = 1.123_456_789_f32;
|
help: consider changing the type or truncating it to
|
LL | let bad32_suf: f32 = 1.123_456_8_f32;
| ~~~~~~~~~~~~~~~
LL - let bad32_suf: f32 = 1.123_456_789_f32;
LL + let bad32_suf: f32 = 1.123_456_8_f32;
|
error: float has excessive precision
--> tests/ui/excessive_precision.rs:43:21
@ -96,8 +104,9 @@ LL | let bad32_inf = 1.123_456_789_f32;
|
help: consider changing the type or truncating it to
|
LL | let bad32_inf = 1.123_456_8_f32;
| ~~~~~~~~~~~~~~~
LL - let bad32_inf = 1.123_456_789_f32;
LL + let bad32_inf = 1.123_456_8_f32;
|
error: float has excessive precision
--> tests/ui/excessive_precision.rs:53:36
@ -107,8 +116,9 @@ LL | let bad_vec32: Vec<f32> = vec![0.123_456_789];
|
help: consider changing the type or truncating it to
|
LL | let bad_vec32: Vec<f32> = vec![0.123_456_79];
| ~~~~~~~~~~~~
LL - let bad_vec32: Vec<f32> = vec![0.123_456_789];
LL + let bad_vec32: Vec<f32> = vec![0.123_456_79];
|
error: float has excessive precision
--> tests/ui/excessive_precision.rs:54:36
@ -118,8 +128,9 @@ LL | let bad_vec64: Vec<f64> = vec![0.123_456_789_123_456_789];
|
help: consider changing the type or truncating it to
|
LL | let bad_vec64: Vec<f64> = vec![0.123_456_789_123_456_78];
| ~~~~~~~~~~~~~~~~~~~~~~~~
LL - let bad_vec64: Vec<f64> = vec![0.123_456_789_123_456_789];
LL + let bad_vec64: Vec<f64> = vec![0.123_456_789_123_456_78];
|
error: float has excessive precision
--> tests/ui/excessive_precision.rs:58:24
@ -129,8 +140,9 @@ LL | let bad_e32: f32 = 1.123_456_788_888e-10;
|
help: consider changing the type or truncating it to
|
LL | let bad_e32: f32 = 1.123_456_8e-10;
| ~~~~~~~~~~~~~~~
LL - let bad_e32: f32 = 1.123_456_788_888e-10;
LL + let bad_e32: f32 = 1.123_456_8e-10;
|
error: float has excessive precision
--> tests/ui/excessive_precision.rs:61:27
@ -140,8 +152,9 @@ LL | let bad_bige32: f32 = 1.123_456_788_888E-10;
|
help: consider changing the type or truncating it to
|
LL | let bad_bige32: f32 = 1.123_456_8E-10;
| ~~~~~~~~~~~~~~~
LL - let bad_bige32: f32 = 1.123_456_788_888E-10;
LL + let bad_bige32: f32 = 1.123_456_8E-10;
|
error: float has excessive precision
--> tests/ui/excessive_precision.rs:70:13
@ -151,8 +164,9 @@ LL | let _ = 2.225_073_858_507_201_1e-308_f64;
|
help: consider changing the type or truncating it to
|
LL | let _ = 2.225_073_858_507_201e-308_f64;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _ = 2.225_073_858_507_201_1e-308_f64;
LL + let _ = 2.225_073_858_507_201e-308_f64;
|
error: float has excessive precision
--> tests/ui/excessive_precision.rs:73:13
@ -162,8 +176,9 @@ LL | let _ = 1.000_000_000_000_001e-324_f64;
|
help: consider changing the type or truncating it to
|
LL | let _ = 0_f64;
| ~~~~~
LL - let _ = 1.000_000_000_000_001e-324_f64;
LL + let _ = 0_f64;
|
error: float has excessive precision
--> tests/ui/excessive_precision.rs:83:20
@ -173,8 +188,9 @@ LL | const _: f64 = 3.0000000000000000e+00;
|
help: consider changing the type or truncating it to
|
LL | const _: f64 = 3.0;
| ~~~
LL - const _: f64 = 3.0000000000000000e+00;
LL + const _: f64 = 3.0;
|
error: aborting due to 16 previous errors

81
src/tools/clippy/tests/ui/fn_to_numeric_cast_any.stderr
View file

@ -8,8 +8,9 @@ LL | let _ = foo as i8;
= help: to override `-D warnings` add `#[allow(clippy::fn_to_numeric_cast_any)]`
help: did you mean to invoke the function?
|
LL | let _ = foo() as i8;
| ~~~~~~~~~~~
LL - let _ = foo as i8;
LL + let _ = foo() as i8;
|
error: casting function pointer `foo` to `i16`
--> tests/ui/fn_to_numeric_cast_any.rs:26:13
@ -19,8 +20,9 @@ LL | let _ = foo as i16;
|
help: did you mean to invoke the function?
|
LL | let _ = foo() as i16;
| ~~~~~~~~~~~~
LL - let _ = foo as i16;
LL + let _ = foo() as i16;
|
error: casting function pointer `foo` to `i32`
--> tests/ui/fn_to_numeric_cast_any.rs:28:13
@ -30,8 +32,9 @@ LL | let _ = foo as i32;
|
help: did you mean to invoke the function?
|
LL | let _ = foo() as i32;
| ~~~~~~~~~~~~
LL - let _ = foo as i32;
LL + let _ = foo() as i32;
|
error: casting function pointer `foo` to `i64`
--> tests/ui/fn_to_numeric_cast_any.rs:30:13
@ -41,8 +44,9 @@ LL | let _ = foo as i64;
|
help: did you mean to invoke the function?
|
LL | let _ = foo() as i64;
| ~~~~~~~~~~~~
LL - let _ = foo as i64;
LL + let _ = foo() as i64;
|
error: casting function pointer `foo` to `i128`
--> tests/ui/fn_to_numeric_cast_any.rs:32:13
@ -52,8 +56,9 @@ LL | let _ = foo as i128;
|
help: did you mean to invoke the function?
|
LL | let _ = foo() as i128;
| ~~~~~~~~~~~~~
LL - let _ = foo as i128;
LL + let _ = foo() as i128;
|
error: casting function pointer `foo` to `isize`
--> tests/ui/fn_to_numeric_cast_any.rs:34:13
@ -63,8 +68,9 @@ LL | let _ = foo as isize;
|
help: did you mean to invoke the function?
|
LL | let _ = foo() as isize;
| ~~~~~~~~~~~~~~
LL - let _ = foo as isize;
LL + let _ = foo() as isize;
|
error: casting function pointer `foo` to `u8`
--> tests/ui/fn_to_numeric_cast_any.rs:37:13
@ -74,8 +80,9 @@ LL | let _ = foo as u8;
|
help: did you mean to invoke the function?
|
LL | let _ = foo() as u8;
| ~~~~~~~~~~~
LL - let _ = foo as u8;
LL + let _ = foo() as u8;
|
error: casting function pointer `foo` to `u16`
--> tests/ui/fn_to_numeric_cast_any.rs:39:13
@ -85,8 +92,9 @@ LL | let _ = foo as u16;
|
help: did you mean to invoke the function?
|
LL | let _ = foo() as u16;
| ~~~~~~~~~~~~
LL - let _ = foo as u16;
LL + let _ = foo() as u16;
|
error: casting function pointer `foo` to `u32`
--> tests/ui/fn_to_numeric_cast_any.rs:41:13
@ -96,8 +104,9 @@ LL | let _ = foo as u32;
|
help: did you mean to invoke the function?
|
LL | let _ = foo() as u32;
| ~~~~~~~~~~~~
LL - let _ = foo as u32;
LL + let _ = foo() as u32;
|
error: casting function pointer `foo` to `u64`
--> tests/ui/fn_to_numeric_cast_any.rs:43:13
@ -107,8 +116,9 @@ LL | let _ = foo as u64;
|
help: did you mean to invoke the function?
|
LL | let _ = foo() as u64;
| ~~~~~~~~~~~~
LL - let _ = foo as u64;
LL + let _ = foo() as u64;
|
error: casting function pointer `foo` to `u128`
--> tests/ui/fn_to_numeric_cast_any.rs:45:13
@ -118,8 +128,9 @@ LL | let _ = foo as u128;
|
help: did you mean to invoke the function?
|
LL | let _ = foo() as u128;
| ~~~~~~~~~~~~~
LL - let _ = foo as u128;
LL + let _ = foo() as u128;
|
error: casting function pointer `foo` to `usize`
--> tests/ui/fn_to_numeric_cast_any.rs:47:13
@ -129,8 +140,9 @@ LL | let _ = foo as usize;
|
help: did you mean to invoke the function?
|
LL | let _ = foo() as usize;
| ~~~~~~~~~~~~~~
LL - let _ = foo as usize;
LL + let _ = foo() as usize;
|
error: casting function pointer `Struct::static_method` to `usize`
--> tests/ui/fn_to_numeric_cast_any.rs:52:13
@ -140,8 +152,9 @@ LL | let _ = Struct::static_method as usize;
|
help: did you mean to invoke the function?
|
LL | let _ = Struct::static_method() as usize;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _ = Struct::static_method as usize;
LL + let _ = Struct::static_method() as usize;
|
error: casting function pointer `f` to `usize`
--> tests/ui/fn_to_numeric_cast_any.rs:57:5
@ -151,7 +164,8 @@ LL | f as usize
|
help: did you mean to invoke the function?
|
LL | f() as usize
LL - f as usize
LL + f() as usize
|
error: casting function pointer `T::static_method` to `usize`
@ -162,7 +176,8 @@ LL | T::static_method as usize
|
help: did you mean to invoke the function?
|
LL | T::static_method() as usize
LL - T::static_method as usize
LL + T::static_method() as usize
|
error: casting function pointer `(clos as fn(u32) -> u32)` to `usize`
@ -173,8 +188,9 @@ LL | let _ = (clos as fn(u32) -> u32) as usize;
|
help: did you mean to invoke the function?
|
LL | let _ = (clos as fn(u32) -> u32)() as usize;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _ = (clos as fn(u32) -> u32) as usize;
LL + let _ = (clos as fn(u32) -> u32)() as usize;
|
error: casting function pointer `foo` to `*const ()`
--> tests/ui/fn_to_numeric_cast_any.rs:74:13
@ -184,8 +200,9 @@ LL | let _ = foo as *const ();
|
help: did you mean to invoke the function?
|
LL | let _ = foo() as *const ();
| ~~~~~~~~~~~~~~~~~~
LL - let _ = foo as *const ();
LL + let _ = foo() as *const ();
|
error: aborting due to 17 previous errors

30
src/tools/clippy/tests/ui/for_kv_map.stderr
View file

@ -8,8 +8,9 @@ LL | for (_, v) in &m {
= help: to override `-D warnings` add `#[allow(clippy::for_kv_map)]`
help: use the corresponding method
|
LL | for v in m.values() {
| ~ ~~~~~~~~~~
LL - for (_, v) in &m {
LL + for v in m.values() {
|
error: you seem to want to iterate on a map's values
--> tests/ui/for_kv_map.rs:16:19
@ -19,8 +20,9 @@ LL | for (_, v) in &*m {
|
help: use the corresponding method
|
LL | for v in (*m).values() {
| ~ ~~~~~~~~~~~~~
LL - for (_, v) in &*m {
LL + for v in (*m).values() {
|
error: you seem to want to iterate on a map's values
--> tests/ui/for_kv_map.rs:25:19
@ -30,8 +32,9 @@ LL | for (_, v) in &mut m {
|
help: use the corresponding method
|
LL | for v in m.values_mut() {
| ~ ~~~~~~~~~~~~~~
LL - for (_, v) in &mut m {
LL + for v in m.values_mut() {
|
error: you seem to want to iterate on a map's values
--> tests/ui/for_kv_map.rs:31:19
@ -41,8 +44,9 @@ LL | for (_, v) in &mut *m {
|
help: use the corresponding method
|
LL | for v in (*m).values_mut() {
| ~ ~~~~~~~~~~~~~~~~~
LL - for (_, v) in &mut *m {
LL + for v in (*m).values_mut() {
|
error: you seem to want to iterate on a map's keys
--> tests/ui/for_kv_map.rs:38:24
@ -52,8 +56,9 @@ LL | for (k, _value) in rm {
|
help: use the corresponding method
|
LL | for k in rm.keys() {
| ~ ~~~~~~~~~
LL - for (k, _value) in rm {
LL + for k in rm.keys() {
|
error: you seem to want to iterate on a map's keys
--> tests/ui/for_kv_map.rs:45:32
@ -63,8 +68,9 @@ LL | 'label: for (k, _value) in rm {
|
help: use the corresponding method
|
LL | 'label: for k in rm.keys() {
| ~ ~~~~~~~~~
LL - 'label: for (k, _value) in rm {
LL + 'label: for k in rm.keys() {
|
error: aborting due to 6 previous errors

8
src/tools/clippy/tests/ui/four_forward_slashes.stderr
View file

@ -9,6 +9,8 @@ LL | | fn a() {}
= help: to override `-D warnings` add `#[allow(clippy::four_forward_slashes)]`
help: make this a doc comment by removing one `/`
|
LL - //// whoops
LL - fn a() {}
LL + /// whoops
|
@ -22,6 +24,8 @@ LL | | fn b() {}
|
help: make this a doc comment by removing one `/`
|
LL - //// whoops
LL - #[allow(dead_code)]
LL + /// whoops
|
@ -50,6 +54,8 @@ LL | | fn g() {}
|
help: make this a doc comment by removing one `/`
|
LL - //// between attributes
LL - #[allow(dead_code)]
LL + /// between attributes
|
@ -62,6 +68,8 @@ LL | | fn h() {}
|
help: make this a doc comment by removing one `/`
|
LL - //// not very start of contents
LL - fn h() {}
LL + /// not very start of contents
|

2
src/tools/clippy/tests/ui/four_forward_slashes_first_line.stderr
View file

@ -9,6 +9,8 @@ LL | | fn a() {}
= help: to override `-D warnings` add `#[allow(clippy::four_forward_slashes)]`
help: make this a doc comment by removing one `/`
|
LL - //// borked doc comment on the first line. doesn't combust!
LL - fn a() {}
LL + /// borked doc comment on the first line. doesn't combust!
|

85
src/tools/clippy/tests/ui/get_unwrap.stderr
View file

@ -11,8 +11,9 @@ LL | #![deny(clippy::get_unwrap)]
| ^^^^^^^^^^^^^^^^^^
help: using `[]` is clearer and more concise
|
LL | let _ = &boxed_slice[1];
| ~~~~~~~~~~~~~~~
LL - let _ = boxed_slice.get(1).unwrap();
LL + let _ = &boxed_slice[1];
|
error: used `unwrap()` on an `Option` value
--> tests/ui/get_unwrap.rs:37:17
@ -33,8 +34,9 @@ LL | let _ = some_slice.get(0).unwrap();
|
help: using `[]` is clearer and more concise
|
LL | let _ = &some_slice[0];
| ~~~~~~~~~~~~~~
LL - let _ = some_slice.get(0).unwrap();
LL + let _ = &some_slice[0];
|
error: used `unwrap()` on an `Option` value
--> tests/ui/get_unwrap.rs:38:17
@ -53,8 +55,9 @@ LL | let _ = some_vec.get(0).unwrap();
|
help: using `[]` is clearer and more concise
|
LL | let _ = &some_vec[0];
| ~~~~~~~~~~~~
LL - let _ = some_vec.get(0).unwrap();
LL + let _ = &some_vec[0];
|
error: used `unwrap()` on an `Option` value
--> tests/ui/get_unwrap.rs:39:17
@ -73,8 +76,9 @@ LL | let _ = some_vecdeque.get(0).unwrap();
|
help: using `[]` is clearer and more concise
|
LL | let _ = &some_vecdeque[0];
| ~~~~~~~~~~~~~~~~~
LL - let _ = some_vecdeque.get(0).unwrap();
LL + let _ = &some_vecdeque[0];
|
error: used `unwrap()` on an `Option` value
--> tests/ui/get_unwrap.rs:40:17
@ -93,8 +97,9 @@ LL | let _ = some_hashmap.get(&1).unwrap();
|
help: using `[]` is clearer and more concise
|
LL | let _ = &some_hashmap[&1];
| ~~~~~~~~~~~~~~~~~
LL - let _ = some_hashmap.get(&1).unwrap();
LL + let _ = &some_hashmap[&1];
|
error: used `unwrap()` on an `Option` value
--> tests/ui/get_unwrap.rs:41:17
@ -113,8 +118,9 @@ LL | let _ = some_btreemap.get(&1).unwrap();
|
help: using `[]` is clearer and more concise
|
LL | let _ = &some_btreemap[&1];
| ~~~~~~~~~~~~~~~~~~
LL - let _ = some_btreemap.get(&1).unwrap();
LL + let _ = &some_btreemap[&1];
|
error: used `unwrap()` on an `Option` value
--> tests/ui/get_unwrap.rs:42:17
@ -133,8 +139,9 @@ LL | let _: u8 = *boxed_slice.get(1).unwrap();
|
help: using `[]` is clearer and more concise
|
LL | let _: u8 = boxed_slice[1];
| ~~~~~~~~~~~~~~
LL - let _: u8 = *boxed_slice.get(1).unwrap();
LL + let _: u8 = boxed_slice[1];
|
error: used `unwrap()` on an `Option` value
--> tests/ui/get_unwrap.rs:46:22
@ -153,8 +160,9 @@ LL | *boxed_slice.get_mut(0).unwrap() = 1;
|
help: using `[]` is clearer and more concise
|
LL | boxed_slice[0] = 1;
| ~~~~~~~~~~~~~~
LL - *boxed_slice.get_mut(0).unwrap() = 1;
LL + boxed_slice[0] = 1;
|
error: used `unwrap()` on an `Option` value
--> tests/ui/get_unwrap.rs:51:10
@ -173,8 +181,9 @@ LL | *some_slice.get_mut(0).unwrap() = 1;
|
help: using `[]` is clearer and more concise
|
LL | some_slice[0] = 1;
| ~~~~~~~~~~~~~
LL - *some_slice.get_mut(0).unwrap() = 1;
LL + some_slice[0] = 1;
|
error: used `unwrap()` on an `Option` value
--> tests/ui/get_unwrap.rs:52:10
@ -193,8 +202,9 @@ LL | *some_vec.get_mut(0).unwrap() = 1;
|
help: using `[]` is clearer and more concise
|
LL | some_vec[0] = 1;
| ~~~~~~~~~~~
LL - *some_vec.get_mut(0).unwrap() = 1;
LL + some_vec[0] = 1;
|
error: used `unwrap()` on an `Option` value
--> tests/ui/get_unwrap.rs:53:10
@ -213,8 +223,9 @@ LL | *some_vecdeque.get_mut(0).unwrap() = 1;
|
help: using `[]` is clearer and more concise
|
LL | some_vecdeque[0] = 1;
| ~~~~~~~~~~~~~~~~
LL - *some_vecdeque.get_mut(0).unwrap() = 1;
LL + some_vecdeque[0] = 1;
|
error: used `unwrap()` on an `Option` value
--> tests/ui/get_unwrap.rs:54:10
@ -233,8 +244,9 @@ LL | let _ = some_vec.get(0..1).unwrap().to_vec();
|
help: using `[]` is clearer and more concise
|
LL | let _ = some_vec[0..1].to_vec();
| ~~~~~~~~~~~~~~
LL - let _ = some_vec.get(0..1).unwrap().to_vec();
LL + let _ = some_vec[0..1].to_vec();
|
error: used `unwrap()` on an `Option` value
--> tests/ui/get_unwrap.rs:66:17
@ -253,8 +265,9 @@ LL | let _ = some_vec.get_mut(0..1).unwrap().to_vec();
|
help: using `[]` is clearer and more concise
|
LL | let _ = some_vec[0..1].to_vec();
| ~~~~~~~~~~~~~~
LL - let _ = some_vec.get_mut(0..1).unwrap().to_vec();
LL + let _ = some_vec[0..1].to_vec();
|
error: used `unwrap()` on an `Option` value
--> tests/ui/get_unwrap.rs:67:17
@ -273,8 +286,9 @@ LL | let _x: &i32 = f.get(1 + 2).unwrap();
|
help: using `[]` is clearer and more concise
|
LL | let _x: &i32 = &f[1 + 2];
| ~~~~~~~~~
LL - let _x: &i32 = f.get(1 + 2).unwrap();
LL + let _x: &i32 = &f[1 + 2];
|
error: called `.get().unwrap()` on a slice
--> tests/ui/get_unwrap.rs:81:18
@ -284,8 +298,9 @@ LL | let _x = f.get(1 + 2).unwrap().to_string();
|
help: using `[]` is clearer and more concise
|
LL | let _x = f[1 + 2].to_string();
| ~~~~~~~~
LL - let _x = f.get(1 + 2).unwrap().to_string();
LL + let _x = f[1 + 2].to_string();
|
error: called `.get().unwrap()` on a slice
--> tests/ui/get_unwrap.rs:84:18
@ -295,8 +310,9 @@ LL | let _x = f.get(1 + 2).unwrap().abs();
|
help: using `[]` is clearer and more concise
|
LL | let _x = f[1 + 2].abs();
| ~~~~~~~~
LL - let _x = f.get(1 + 2).unwrap().abs();
LL + let _x = f[1 + 2].abs();
|
error: called `.get_mut().unwrap()` on a slice
--> tests/ui/get_unwrap.rs:101:33
@ -306,8 +322,9 @@ LL | let b = rest.get_mut(linidx(j, k) - linidx(i, k) -
|
help: using `[]` is clearer and more concise
|
LL | let b = &mut rest[linidx(j, k) - linidx(i, k) - 1];
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let b = rest.get_mut(linidx(j, k) - linidx(i, k) - 1).unwrap();
LL + let b = &mut rest[linidx(j, k) - linidx(i, k) - 1];
|
error: aborting due to 30 previous errors

15
src/tools/clippy/tests/ui/implicit_hasher.stderr
View file

@ -78,8 +78,9 @@ LL | pub fn map(map: &mut HashMap<i32, i32>) {}
|
help: add a type parameter for `BuildHasher`
|
LL | pub fn map<S: ::std::hash::BuildHasher>(map: &mut HashMap<i32, i32, S>) {}
| +++++++++++++++++++++++++++++ ~~~~~~~~~~~~~~~~~~~~
LL - pub fn map(map: &mut HashMap<i32, i32>) {}
LL + pub fn map<S: ::std::hash::BuildHasher>(map: &mut HashMap<i32, i32, S>) {}
|
error: parameter of type `HashSet` should be generalized over different hashers
--> tests/ui/implicit_hasher.rs:70:22
@ -89,8 +90,9 @@ LL | pub fn set(set: &mut HashSet<i32>) {}
|
help: add a type parameter for `BuildHasher`
|
LL | pub fn set<S: ::std::hash::BuildHasher>(set: &mut HashSet<i32, S>) {}
| +++++++++++++++++++++++++++++ ~~~~~~~~~~~~~~~
LL - pub fn set(set: &mut HashSet<i32>) {}
LL + pub fn set<S: ::std::hash::BuildHasher>(set: &mut HashSet<i32, S>) {}
|
error: impl for `HashMap` should be generalized over different hashers
--> tests/ui/implicit_hasher.rs:76:43
@ -114,8 +116,9 @@ LL | pub async fn election_vote(_data: HashMap<i32, i32>) {}
|
help: add a type parameter for `BuildHasher`
|
LL | pub async fn election_vote<S: ::std::hash::BuildHasher>(_data: HashMap<i32, i32, S>) {}
| +++++++++++++++++++++++++++++ ~~~~~~~~~~~~~~~~~~~~
LL - pub async fn election_vote(_data: HashMap<i32, i32>) {}
LL + pub async fn election_vote<S: ::std::hash::BuildHasher>(_data: HashMap<i32, i32, S>) {}
|
error: aborting due to 9 previous errors

67
src/tools/clippy/tests/ui/implicit_return.stderr
View file

@ -8,7 +8,8 @@ LL | true
= help: to override `-D warnings` add `#[allow(clippy::implicit_return)]`
help: add `return` as shown
|
LL | return true
LL - true
LL + return true
|
error: missing `return` statement
@ -19,8 +20,9 @@ LL | if true { true } else { false }
|
help: add `return` as shown
|
LL | if true { return true } else { false }
| ~~~~~~~~~~~
LL - if true { true } else { false }
LL + if true { return true } else { false }
|
error: missing `return` statement
--> tests/ui/implicit_return.rs:19:29
@ -30,8 +32,9 @@ LL | if true { true } else { false }
|
help: add `return` as shown
|
LL | if true { true } else { return false }
| ~~~~~~~~~~~~
LL - if true { true } else { false }
LL + if true { true } else { return false }
|
error: missing `return` statement
--> tests/ui/implicit_return.rs:25:17
@ -41,8 +44,9 @@ LL | true => false,
|
help: add `return` as shown
|
LL | true => return false,
| ~~~~~~~~~~~~
LL - true => false,
LL + true => return false,
|
error: missing `return` statement
--> tests/ui/implicit_return.rs:26:20
@ -52,8 +56,9 @@ LL | false => { true },
|
help: add `return` as shown
|
LL | false => { return true },
| ~~~~~~~~~~~
LL - false => { true },
LL + false => { return true },
|
error: missing `return` statement
--> tests/ui/implicit_return.rs:39:9
@ -63,8 +68,9 @@ LL | break true;
|
help: change `break` to `return` as shown
|
LL | return true;
| ~~~~~~~~~~~
LL - break true;
LL + return true;
|
error: missing `return` statement
--> tests/ui/implicit_return.rs:46:13
@ -74,8 +80,9 @@ LL | break true;
|
help: change `break` to `return` as shown
|
LL | return true;
| ~~~~~~~~~~~
LL - break true;
LL + return true;
|
error: missing `return` statement
--> tests/ui/implicit_return.rs:54:13
@ -85,8 +92,9 @@ LL | break true;
|
help: change `break` to `return` as shown
|
LL | return true;
| ~~~~~~~~~~~
LL - break true;
LL + return true;
|
error: missing `return` statement
--> tests/ui/implicit_return.rs:72:18
@ -96,8 +104,9 @@ LL | let _ = || { true };
|
help: add `return` as shown
|
LL | let _ = || { return true };
| ~~~~~~~~~~~
LL - let _ = || { true };
LL + let _ = || { return true };
|
error: missing `return` statement
--> tests/ui/implicit_return.rs:73:16
@ -107,8 +116,9 @@ LL | let _ = || true;
|
help: add `return` as shown
|
LL | let _ = || return true;
| ~~~~~~~~~~~
LL - let _ = || true;
LL + let _ = || return true;
|
error: missing `return` statement
--> tests/ui/implicit_return.rs:81:5
@ -118,7 +128,8 @@ LL | format!("test {}", "test")
|
help: add `return` as shown
|
LL | return format!("test {}", "test")
LL - format!("test {}", "test")
LL + return format!("test {}", "test")
|
error: missing `return` statement
@ -129,7 +140,8 @@ LL | m!(true, false)
|
help: add `return` as shown
|
LL | return m!(true, false)
LL - m!(true, false)
LL + return m!(true, false)
|
error: missing `return` statement
@ -140,8 +152,9 @@ LL | break true;
|
help: change `break` to `return` as shown
|
LL | return true;
| ~~~~~~~~~~~
LL - break true;
LL + return true;
|
error: missing `return` statement
--> tests/ui/implicit_return.rs:101:17
@ -151,8 +164,9 @@ LL | break 'outer false;
|
help: change `break` to `return` as shown
|
LL | return false;
| ~~~~~~~~~~~~
LL - break 'outer false;
LL + return false;
|
error: missing `return` statement
--> tests/ui/implicit_return.rs:116:5
@ -177,7 +191,8 @@ LL | true
|
help: add `return` as shown
|
LL | return true
LL - true
LL + return true
|
error: aborting due to 16 previous errors

40
src/tools/clippy/tests/ui/iter_nth.stderr
View file

@ -8,8 +8,9 @@ LL | let bad_vec = some_vec.iter().nth(3);
= help: to override `-D warnings` add `#[allow(clippy::iter_nth)]`
help: `get` is equivalent but more concise
|
LL | let bad_vec = some_vec.get(3);
| ~~~
LL - let bad_vec = some_vec.iter().nth(3);
LL + let bad_vec = some_vec.get(3);
|
error: called `.iter().nth()` on a slice
--> tests/ui/iter_nth.rs:35:26
@ -19,8 +20,9 @@ LL | let bad_slice = &some_vec[..].iter().nth(3);
|
help: `get` is equivalent but more concise
|
LL | let bad_slice = &some_vec[..].get(3);
| ~~~
LL - let bad_slice = &some_vec[..].iter().nth(3);
LL + let bad_slice = &some_vec[..].get(3);
|
error: called `.iter().nth()` on a slice
--> tests/ui/iter_nth.rs:36:31
@ -30,8 +32,9 @@ LL | let bad_boxed_slice = boxed_slice.iter().nth(3);
|
help: `get` is equivalent but more concise
|
LL | let bad_boxed_slice = boxed_slice.get(3);
| ~~~
LL - let bad_boxed_slice = boxed_slice.iter().nth(3);
LL + let bad_boxed_slice = boxed_slice.get(3);
|
error: called `.iter().nth()` on a `VecDeque`
--> tests/ui/iter_nth.rs:37:29
@ -41,8 +44,9 @@ LL | let bad_vec_deque = some_vec_deque.iter().nth(3);
|
help: `get` is equivalent but more concise
|
LL | let bad_vec_deque = some_vec_deque.get(3);
| ~~~
LL - let bad_vec_deque = some_vec_deque.iter().nth(3);
LL + let bad_vec_deque = some_vec_deque.get(3);
|
error: called `.iter_mut().nth()` on a `Vec`
--> tests/ui/iter_nth.rs:42:23
@ -52,8 +56,9 @@ LL | let bad_vec = some_vec.iter_mut().nth(3);
|
help: `get_mut` is equivalent but more concise
|
LL | let bad_vec = some_vec.get_mut(3);
| ~~~~~~~
LL - let bad_vec = some_vec.iter_mut().nth(3);
LL + let bad_vec = some_vec.get_mut(3);
|
error: called `.iter_mut().nth()` on a slice
--> tests/ui/iter_nth.rs:45:26
@ -63,8 +68,9 @@ LL | let bad_slice = &some_vec[..].iter_mut().nth(3);
|
help: `get_mut` is equivalent but more concise
|
LL | let bad_slice = &some_vec[..].get_mut(3);
| ~~~~~~~
LL - let bad_slice = &some_vec[..].iter_mut().nth(3);
LL + let bad_slice = &some_vec[..].get_mut(3);
|
error: called `.iter_mut().nth()` on a `VecDeque`
--> tests/ui/iter_nth.rs:48:29
@ -74,8 +80,9 @@ LL | let bad_vec_deque = some_vec_deque.iter_mut().nth(3);
|
help: `get_mut` is equivalent but more concise
|
LL | let bad_vec_deque = some_vec_deque.get_mut(3);
| ~~~~~~~
LL - let bad_vec_deque = some_vec_deque.iter_mut().nth(3);
LL + let bad_vec_deque = some_vec_deque.get_mut(3);
|
error: called `.iter().nth()` on a `Vec`
--> tests/ui/iter_nth.rs:52:5
@ -85,8 +92,9 @@ LL | vec_ref.iter().nth(3);
|
help: `get` is equivalent but more concise
|
LL | vec_ref.get(3);
| ~~~
LL - vec_ref.iter().nth(3);
LL + vec_ref.get(3);
|
error: aborting due to 8 previous errors

40
src/tools/clippy/tests/ui/join_absolute_paths.stderr
View file

@ -9,12 +9,14 @@ LL | path.join("/sh");
= help: to override `-D warnings` add `#[allow(clippy::join_absolute_paths)]`
help: if this is unintentional, try removing the starting separator
|
LL | path.join("sh");
| ~~~~
LL - path.join("/sh");
LL + path.join("sh");
|
help: if this is intentional, consider using `Path::new`
|
LL | PathBuf::from("/sh");
| ~~~~~~~~~~~~~~~~~~~~
LL - path.join("/sh");
LL + PathBuf::from("/sh");
|
error: argument to `Path::join` starts with a path separator
--> tests/ui/join_absolute_paths.rs:14:15
@ -25,12 +27,14 @@ LL | path.join("\\user");
= note: joining a path starting with separator will replace the path instead
help: if this is unintentional, try removing the starting separator
|
LL | path.join("\user");
| ~~~~~~~
LL - path.join("\\user");
LL + path.join("\user");
|
help: if this is intentional, consider using `Path::new`
|
LL | PathBuf::from("\\user");
| ~~~~~~~~~~~~~~~~~~~~~~~
LL - path.join("\\user");
LL + PathBuf::from("\\user");
|
error: argument to `Path::join` starts with a path separator
--> tests/ui/join_absolute_paths.rs:18:15
@ -41,12 +45,14 @@ LL | path.join("/sh");
= note: joining a path starting with separator will replace the path instead
help: if this is unintentional, try removing the starting separator
|
LL | path.join("sh");
| ~~~~
LL - path.join("/sh");
LL + path.join("sh");
|
help: if this is intentional, consider using `Path::new`
|
LL | PathBuf::from("/sh");
| ~~~~~~~~~~~~~~~~~~~~
LL - path.join("/sh");
LL + PathBuf::from("/sh");
|
error: argument to `Path::join` starts with a path separator
--> tests/ui/join_absolute_paths.rs:22:15
@ -57,12 +63,14 @@ LL | path.join(r#"/sh"#);
= note: joining a path starting with separator will replace the path instead
help: if this is unintentional, try removing the starting separator
|
LL | path.join(r#"sh"#);
| ~~~~~~~
LL - path.join(r#"/sh"#);
LL + path.join(r#"sh"#);
|
help: if this is intentional, consider using `Path::new`
|
LL | PathBuf::from(r#"/sh"#);
| ~~~~~~~~~~~~~~~~~~~~~~~
LL - path.join(r#"/sh"#);
LL + PathBuf::from(r#"/sh"#);
|
error: aborting due to 4 previous errors

65
src/tools/clippy/tests/ui/large_enum_variant.64bit.stderr
View file

@ -13,8 +13,9 @@ LL | | }
= help: to override `-D warnings` add `#[allow(clippy::large_enum_variant)]`
help: consider boxing the large fields to reduce the total size of the enum
|
LL | B(Box<[i32; 8000]>),
| ~~~~~~~~~~~~~~~~
LL - B([i32; 8000]),
LL + B(Box<[i32; 8000]>),
|
error: large size difference between variants
--> tests/ui/large_enum_variant.rs:35:1
@ -29,8 +30,9 @@ LL | | }
|
help: consider boxing the large fields to reduce the total size of the enum
|
LL | ContainingLargeEnum(Box<LargeEnum>),
| ~~~~~~~~~~~~~~
LL - ContainingLargeEnum(LargeEnum),
LL + ContainingLargeEnum(Box<LargeEnum>),
|
error: large size difference between variants
--> tests/ui/large_enum_variant.rs:40:1
@ -46,8 +48,9 @@ LL | | }
|
help: consider boxing the large fields to reduce the total size of the enum
|
LL | ContainingMoreThanOneField(i32, Box<[i32; 8000]>, Box<[i32; 9500]>),
| ~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~
LL - ContainingMoreThanOneField(i32, [i32; 8000], [i32; 9500]),
LL + ContainingMoreThanOneField(i32, Box<[i32; 8000]>, Box<[i32; 9500]>),
|
error: large size difference between variants
--> tests/ui/large_enum_variant.rs:46:1
@ -62,8 +65,9 @@ LL | | }
|
help: consider boxing the large fields to reduce the total size of the enum
|
LL | StructLikeLarge { x: Box<[i32; 8000]>, y: i32 },
| ~~~~~~~~~~~~~~~~
LL - StructLikeLarge { x: [i32; 8000], y: i32 },
LL + StructLikeLarge { x: Box<[i32; 8000]>, y: i32 },
|
error: large size difference between variants
--> tests/ui/large_enum_variant.rs:51:1
@ -78,8 +82,9 @@ LL | | }
|
help: consider boxing the large fields to reduce the total size of the enum
|
LL | StructLikeLarge2 { x: Box<[i32; 8000]> },
| ~~~~~~~~~~~~~~~~
LL - StructLikeLarge2 { x: [i32; 8000] },
LL + StructLikeLarge2 { x: Box<[i32; 8000]> },
|
error: large size difference between variants
--> tests/ui/large_enum_variant.rs:67:1
@ -95,8 +100,9 @@ LL | | }
|
help: consider boxing the large fields to reduce the total size of the enum
|
LL | B(Box<[u8; 1255]>),
| ~~~~~~~~~~~~~~~
LL - B([u8; 1255]),
LL + B(Box<[u8; 1255]>),
|
error: large size difference between variants
--> tests/ui/large_enum_variant.rs:73:1
@ -111,8 +117,9 @@ LL | | }
|
help: consider boxing the large fields to reduce the total size of the enum
|
LL | ContainingMoreThanOneField(Box<[i32; 8000]>, [i32; 2], Box<[i32; 9500]>, [i32; 30]),
| ~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~
LL - ContainingMoreThanOneField([i32; 8000], [i32; 2], [i32; 9500], [i32; 30]),
LL + ContainingMoreThanOneField(Box<[i32; 8000]>, [i32; 2], Box<[i32; 9500]>, [i32; 30]),
|
error: large size difference between variants
--> tests/ui/large_enum_variant.rs:78:1
@ -127,8 +134,9 @@ LL | | }
|
help: consider boxing the large fields to reduce the total size of the enum
|
LL | B(Box<Struct2>),
| ~~~~~~~~~~~~
LL - B(Struct2),
LL + B(Box<Struct2>),
|
error: large size difference between variants
--> tests/ui/large_enum_variant.rs:83:1
@ -143,8 +151,9 @@ LL | | }
|
help: consider boxing the large fields to reduce the total size of the enum
|
LL | B(Box<Struct2>),
| ~~~~~~~~~~~~
LL - B(Struct2),
LL + B(Box<Struct2>),
|
error: large size difference between variants
--> tests/ui/large_enum_variant.rs:88:1
@ -159,8 +168,9 @@ LL | | }
|
help: consider boxing the large fields to reduce the total size of the enum
|
LL | B(Box<Struct2>),
| ~~~~~~~~~~~~
LL - B(Struct2),
LL + B(Box<Struct2>),
|
error: large size difference between variants
--> tests/ui/large_enum_variant.rs:103:1
@ -241,8 +251,9 @@ LL | | }
|
help: consider boxing the large fields to reduce the total size of the enum
|
LL | Large(Box<(T, [u8; 512])>),
| ~~~~~~~~~~~~~~~~~~~
LL - Large((T, [u8; 512])),
LL + Large(Box<(T, [u8; 512])>),
|
error: large size difference between variants
--> tests/ui/large_enum_variant.rs:143:1
@ -257,8 +268,9 @@ LL | | }
|
help: consider boxing the large fields to reduce the total size of the enum
|
LL | Large(Box<[Foo<u64>; 64]>),
| ~~~~~~~~~~~~~~~~~~~
LL - Large([Foo<u64>; 64]),
LL + Large(Box<[Foo<u64>; 64]>),
|
error: large size difference between variants
--> tests/ui/large_enum_variant.rs:153:1
@ -273,8 +285,9 @@ LL | | }
|
help: consider boxing the large fields to reduce the total size of the enum
|
LL | Error(Box<PossiblyLargeEnumWithConst<256>>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - Error(PossiblyLargeEnumWithConst<256>),
LL + Error(Box<PossiblyLargeEnumWithConst<256>>),
|
error: aborting due to 16 previous errors

80
src/tools/clippy/tests/ui/legacy_numeric_constants.stderr
View file

@ -8,8 +8,9 @@ LL | std::f32::EPSILON;
= help: to override `-D warnings` add `#[allow(clippy::legacy_numeric_constants)]`
help: use the associated constant instead
|
LL | f32::EPSILON;
| ~~~~~~~~~~~~
LL - std::f32::EPSILON;
LL + f32::EPSILON;
|
error: usage of a legacy numeric constant
--> tests/ui/legacy_numeric_constants.rs:34:5
@ -19,8 +20,9 @@ LL | std::u8::MIN;
|
help: use the associated constant instead
|
LL | u8::MIN;
| ~~~~~~~
LL - std::u8::MIN;
LL + u8::MIN;
|
error: usage of a legacy numeric constant
--> tests/ui/legacy_numeric_constants.rs:37:5
@ -30,8 +32,9 @@ LL | std::usize::MIN;
|
help: use the associated constant instead
|
LL | usize::MIN;
| ~~~~~~~~~~
LL - std::usize::MIN;
LL + usize::MIN;
|
error: usage of a legacy numeric constant
--> tests/ui/legacy_numeric_constants.rs:40:5
@ -41,8 +44,9 @@ LL | std::u32::MAX;
|
help: use the associated constant instead
|
LL | u32::MAX;
| ~~~~~~~~
LL - std::u32::MAX;
LL + u32::MAX;
|
error: usage of a legacy numeric constant
--> tests/ui/legacy_numeric_constants.rs:43:5
@ -52,8 +56,9 @@ LL | core::u32::MAX;
|
help: use the associated constant instead
|
LL | u32::MAX;
| ~~~~~~~~
LL - core::u32::MAX;
LL + u32::MAX;
|
error: usage of a legacy numeric constant
--> tests/ui/legacy_numeric_constants.rs:46:5
@ -63,8 +68,9 @@ LL | MAX;
|
help: use the associated constant instead
|
LL | u32::MAX;
| ~~~~~~~~
LL - MAX;
LL + u32::MAX;
|
error: usage of a legacy numeric method
--> tests/ui/legacy_numeric_constants.rs:49:10
@ -74,8 +80,9 @@ LL | i32::max_value();
|
help: use the associated constant instead
|
LL | i32::MAX;
| ~~~
LL - i32::max_value();
LL + i32::MAX;
|
error: usage of a legacy numeric method
--> tests/ui/legacy_numeric_constants.rs:52:9
@ -85,8 +92,9 @@ LL | u8::max_value();
|
help: use the associated constant instead
|
LL | u8::MAX;
| ~~~
LL - u8::max_value();
LL + u8::MAX;
|
error: usage of a legacy numeric method
--> tests/ui/legacy_numeric_constants.rs:55:9
@ -96,8 +104,9 @@ LL | u8::min_value();
|
help: use the associated constant instead
|
LL | u8::MIN;
| ~~~
LL - u8::min_value();
LL + u8::MIN;
|
error: usage of a legacy numeric constant
--> tests/ui/legacy_numeric_constants.rs:58:5
@ -107,8 +116,9 @@ LL | ::std::u8::MIN;
|
help: use the associated constant instead
|
LL | u8::MIN;
| ~~~~~~~
LL - ::std::u8::MIN;
LL + u8::MIN;
|
error: usage of a legacy numeric method
--> tests/ui/legacy_numeric_constants.rs:61:27
@ -118,8 +128,9 @@ LL | ::std::primitive::u8::min_value();
|
help: use the associated constant instead
|
LL | ::std::primitive::u8::MIN;
| ~~~
LL - ::std::primitive::u8::min_value();
LL + ::std::primitive::u8::MIN;
|
error: usage of a legacy numeric method
--> tests/ui/legacy_numeric_constants.rs:64:26
@ -129,8 +140,9 @@ LL | std::primitive::i32::max_value();
|
help: use the associated constant instead
|
LL | std::primitive::i32::MAX;
| ~~~
LL - std::primitive::i32::max_value();
LL + std::primitive::i32::MAX;
|
error: usage of a legacy numeric constant
--> tests/ui/legacy_numeric_constants.rs:67:5
@ -140,8 +152,9 @@ LL | self::a::u128::MAX;
|
help: use the associated constant instead
|
LL | u128::MAX;
| ~~~~~~~~~
LL - self::a::u128::MAX;
LL + u128::MAX;
|
error: usage of a legacy numeric constant
--> tests/ui/legacy_numeric_constants.rs:17:25
@ -155,8 +168,9 @@ LL | b!();
= note: this error originates in the macro `b` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use the associated constant instead
|
LL | let x = u64::MAX;
| ~~~~~~~~
LL - let x = std::u64::MAX;
LL + let x = u64::MAX;
|
error: usage of a legacy numeric constant
--> tests/ui/legacy_numeric_constants.rs:81:14
@ -166,8 +180,9 @@ LL | [(0, "", std::i128::MAX)];
|
help: use the associated constant instead
|
LL | [(0, "", i128::MAX)];
| ~~~~~~~~~
LL - [(0, "", std::i128::MAX)];
LL + [(0, "", i128::MAX)];
|
error: usage of a legacy numeric constant
--> tests/ui/legacy_numeric_constants.rs:115:5
@ -177,8 +192,9 @@ LL | std::u32::MAX;
|
help: use the associated constant instead
|
LL | u32::MAX;
| ~~~~~~~~
LL - std::u32::MAX;
LL + u32::MAX;
|
error: aborting due to 16 previous errors

35
src/tools/clippy/tests/ui/literals.stderr
View file

@ -71,12 +71,14 @@ LL | let fail_multi_zero = 000_123usize;
= help: to override `-D warnings` add `#[allow(clippy::zero_prefixed_literal)]`
help: if you mean to use a decimal constant, remove the `0` to avoid confusion
|
LL | let fail_multi_zero = 123usize;
| ~~~~~~~~
LL - let fail_multi_zero = 000_123usize;
LL + let fail_multi_zero = 123usize;
|
help: if you mean to use an octal constant, use `0o`
|
LL | let fail_multi_zero = 0o123usize;
| ~~~~~~~~~~
LL - let fail_multi_zero = 000_123usize;
LL + let fail_multi_zero = 0o123usize;
|
error: integer type suffix should not be separated by an underscore
--> tests/ui/literals.rs:36:16
@ -92,12 +94,14 @@ LL | let fail8 = 0123;
|
help: if you mean to use a decimal constant, remove the `0` to avoid confusion
|
LL | let fail8 = 123;
| ~~~
LL - let fail8 = 0123;
LL + let fail8 = 123;
|
help: if you mean to use an octal constant, use `0o`
|
LL | let fail8 = 0o123;
| ~~~~~
LL - let fail8 = 0123;
LL + let fail8 = 0o123;
|
error: integer type suffix should not be separated by an underscore
--> tests/ui/literals.rs:48:16
@ -143,8 +147,9 @@ LL | let _ = 08;
|
help: if you mean to use a decimal constant, remove the `0` to avoid confusion
|
LL | let _ = 8;
| ~
LL - let _ = 08;
LL + let _ = 8;
|
error: this is a decimal constant
--> tests/ui/literals.rs:72:13
@ -154,8 +159,9 @@ LL | let _ = 09;
|
help: if you mean to use a decimal constant, remove the `0` to avoid confusion
|
LL | let _ = 9;
| ~
LL - let _ = 09;
LL + let _ = 9;
|
error: this is a decimal constant
--> tests/ui/literals.rs:74:13
@ -165,8 +171,9 @@ LL | let _ = 089;
|
help: if you mean to use a decimal constant, remove the `0` to avoid confusion
|
LL | let _ = 89;
| ~~
LL - let _ = 089;
LL + let _ = 89;
|
error: aborting due to 20 previous errors

55
src/tools/clippy/tests/ui/lossy_float_literal.stderr
View file

@ -8,8 +8,9 @@ LL | let _: f32 = 16_777_217.0;
= help: to override `-D warnings` add `#[allow(clippy::lossy_float_literal)]`
help: consider changing the type or replacing it with
|
LL | let _: f32 = 16_777_216.0;
| ~~~~~~~~~~~~
LL - let _: f32 = 16_777_217.0;
LL + let _: f32 = 16_777_216.0;
|
error: literal cannot be represented as the underlying type without loss of precision
--> tests/ui/lossy_float_literal.rs:15:18
@ -19,8 +20,9 @@ LL | let _: f32 = 16_777_219.0;
|
help: consider changing the type or replacing it with
|
LL | let _: f32 = 16_777_220.0;
| ~~~~~~~~~~~~
LL - let _: f32 = 16_777_219.0;
LL + let _: f32 = 16_777_220.0;
|
error: literal cannot be represented as the underlying type without loss of precision
--> tests/ui/lossy_float_literal.rs:16:18
@ -30,8 +32,9 @@ LL | let _: f32 = 16_777_219.;
|
help: consider changing the type or replacing it with
|
LL | let _: f32 = 16_777_220.0;
| ~~~~~~~~~~~~
LL - let _: f32 = 16_777_219.;
LL + let _: f32 = 16_777_220.0;
|
error: literal cannot be represented as the underlying type without loss of precision
--> tests/ui/lossy_float_literal.rs:17:18
@ -41,8 +44,9 @@ LL | let _: f32 = 16_777_219.000;
|
help: consider changing the type or replacing it with
|
LL | let _: f32 = 16_777_220.0;
| ~~~~~~~~~~~~
LL - let _: f32 = 16_777_219.000;
LL + let _: f32 = 16_777_220.0;
|
error: literal cannot be represented as the underlying type without loss of precision
--> tests/ui/lossy_float_literal.rs:18:13
@ -52,8 +56,9 @@ LL | let _ = 16_777_219f32;
|
help: consider changing the type or replacing it with
|
LL | let _ = 16_777_220_f32;
| ~~~~~~~~~~~~~~
LL - let _ = 16_777_219f32;
LL + let _ = 16_777_220_f32;
|
error: literal cannot be represented as the underlying type without loss of precision
--> tests/ui/lossy_float_literal.rs:19:19
@ -63,8 +68,9 @@ LL | let _: f32 = -16_777_219.0;
|
help: consider changing the type or replacing it with
|
LL | let _: f32 = -16_777_220.0;
| ~~~~~~~~~~~~
LL - let _: f32 = -16_777_219.0;
LL + let _: f32 = -16_777_220.0;
|
error: literal cannot be represented as the underlying type without loss of precision
--> tests/ui/lossy_float_literal.rs:21:18
@ -74,8 +80,9 @@ LL | let _: f64 = 9_007_199_254_740_993.0;
|
help: consider changing the type or replacing it with
|
LL | let _: f64 = 9_007_199_254_740_992.0;
| ~~~~~~~~~~~~~~~~~~~~~~~
LL - let _: f64 = 9_007_199_254_740_993.0;
LL + let _: f64 = 9_007_199_254_740_992.0;
|
error: literal cannot be represented as the underlying type without loss of precision
--> tests/ui/lossy_float_literal.rs:22:18
@ -85,8 +92,9 @@ LL | let _: f64 = 9_007_199_254_740_993.;
|
help: consider changing the type or replacing it with
|
LL | let _: f64 = 9_007_199_254_740_992.0;
| ~~~~~~~~~~~~~~~~~~~~~~~
LL - let _: f64 = 9_007_199_254_740_993.;
LL + let _: f64 = 9_007_199_254_740_992.0;
|
error: literal cannot be represented as the underlying type without loss of precision
--> tests/ui/lossy_float_literal.rs:23:18
@ -96,8 +104,9 @@ LL | let _: f64 = 9_007_199_254_740_993.00;
|
help: consider changing the type or replacing it with
|
LL | let _: f64 = 9_007_199_254_740_992.0;
| ~~~~~~~~~~~~~~~~~~~~~~~
LL - let _: f64 = 9_007_199_254_740_993.00;
LL + let _: f64 = 9_007_199_254_740_992.0;
|
error: literal cannot be represented as the underlying type without loss of precision
--> tests/ui/lossy_float_literal.rs:24:13
@ -107,8 +116,9 @@ LL | let _ = 9_007_199_254_740_993f64;
|
help: consider changing the type or replacing it with
|
LL | let _ = 9_007_199_254_740_992_f64;
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _ = 9_007_199_254_740_993f64;
LL + let _ = 9_007_199_254_740_992_f64;
|
error: literal cannot be represented as the underlying type without loss of precision
--> tests/ui/lossy_float_literal.rs:25:19
@ -118,8 +128,9 @@ LL | let _: f64 = -9_007_199_254_740_993.0;
|
help: consider changing the type or replacing it with
|
LL | let _: f64 = -9_007_199_254_740_992.0;
| ~~~~~~~~~~~~~~~~~~~~~~~
LL - let _: f64 = -9_007_199_254_740_993.0;
LL + let _: f64 = -9_007_199_254_740_992.0;
|
error: aborting due to 11 previous errors

10
src/tools/clippy/tests/ui/manual_assert.edition2018.stderr
View file

@ -79,7 +79,15 @@ LL | | }
|
help: try instead
|
LL | assert!(!(a > 2), "panic with comment");
LL - if a > 2 {
LL - // comment
LL - /* this is a
LL - multiline
LL - comment */
LL - /// Doc comment
LL - panic!("panic with comment") // comment after `panic!`
LL - }
LL + assert!(!(a > 2), "panic with comment");
|
error: only a `panic!` in `if`-then statement

10
src/tools/clippy/tests/ui/manual_assert.edition2021.stderr
View file

@ -79,7 +79,15 @@ LL | | }
|
help: try instead
|
LL | assert!(!(a > 2), "panic with comment");
LL - if a > 2 {
LL - // comment
LL - /* this is a
LL - multiline
LL - comment */
LL - /// Doc comment
LL - panic!("panic with comment") // comment after `panic!`
LL - }
LL + assert!(!(a > 2), "panic with comment");
|
error: only a `panic!` in `if`-then statement

60
src/tools/clippy/tests/ui/manual_async_fn.stderr
View file

@ -8,8 +8,9 @@ LL | fn fut() -> impl Future<Output = i32> {
= help: to override `-D warnings` add `#[allow(clippy::manual_async_fn)]`
help: make the function `async` and return the output of the future directly
|
LL | async fn fut() -> i32 { 42 }
| ~~~~~~~~~~~~~~~~~~~~~ ~~~~~~
LL - fn fut() -> impl Future<Output = i32> {
LL + async fn fut() -> i32 { 42 }
|
error: this function can be simplified using the `async fn` syntax
--> tests/ui/manual_async_fn.rs:11:1
@ -19,8 +20,9 @@ LL | fn fut2() ->impl Future<Output = i32> {
|
help: make the function `async` and return the output of the future directly
|
LL | async fn fut2() -> i32 { 42 }
| ~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~
LL - fn fut2() ->impl Future<Output = i32> {
LL + async fn fut2() -> i32 { 42 }
|
error: this function can be simplified using the `async fn` syntax
--> tests/ui/manual_async_fn.rs:16:1
@ -30,8 +32,9 @@ LL | fn fut3()-> impl Future<Output = i32> {
|
help: make the function `async` and return the output of the future directly
|
LL | async fn fut3() -> i32 { 42 }
| ~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~
LL - fn fut3()-> impl Future<Output = i32> {
LL + async fn fut3() -> i32 { 42 }
|
error: this function can be simplified using the `async fn` syntax
--> tests/ui/manual_async_fn.rs:20:1
@ -41,8 +44,9 @@ LL | fn empty_fut() -> impl Future<Output = ()> {
|
help: make the function `async` and return the output of the future directly
|
LL | async fn empty_fut() {}
| ~~~~~~~~~~~~~~~~~~~~ ~~
LL - fn empty_fut() -> impl Future<Output = ()> {
LL + async fn empty_fut() {}
|
error: this function can be simplified using the `async fn` syntax
--> tests/ui/manual_async_fn.rs:25:1
@ -52,8 +56,9 @@ LL | fn empty_fut2() ->impl Future<Output = ()> {
|
help: make the function `async` and return the output of the future directly
|
LL | async fn empty_fut2() {}
| ~~~~~~~~~~~~~~~~~~~~~ ~~
LL - fn empty_fut2() ->impl Future<Output = ()> {
LL + async fn empty_fut2() {}
|
error: this function can be simplified using the `async fn` syntax
--> tests/ui/manual_async_fn.rs:30:1
@ -63,8 +68,9 @@ LL | fn empty_fut3()-> impl Future<Output = ()> {
|
help: make the function `async` and return the output of the future directly
|
LL | async fn empty_fut3() {}
| ~~~~~~~~~~~~~~~~~~~~~ ~~
LL - fn empty_fut3()-> impl Future<Output = ()> {
LL + async fn empty_fut3() {}
|
error: this function can be simplified using the `async fn` syntax
--> tests/ui/manual_async_fn.rs:34:1
@ -74,8 +80,9 @@ LL | fn core_fut() -> impl core::future::Future<Output = i32> {
|
help: make the function `async` and return the output of the future directly
|
LL | async fn core_fut() -> i32 { 42 }
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~
LL - fn core_fut() -> impl core::future::Future<Output = i32> {
LL + async fn core_fut() -> i32 { 42 }
|
error: this function can be simplified using the `async fn` syntax
--> tests/ui/manual_async_fn.rs:56:5
@ -108,8 +115,9 @@ LL | fn elided(_: &i32) -> impl Future<Output = i32> + '_ {
|
help: make the function `async` and return the output of the future directly
|
LL | async fn elided(_: &i32) -> i32 { 42 }
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~
LL - fn elided(_: &i32) -> impl Future<Output = i32> + '_ {
LL + async fn elided(_: &i32) -> i32 { 42 }
|
error: this function can be simplified using the `async fn` syntax
--> tests/ui/manual_async_fn.rs:101:1
@ -119,8 +127,9 @@ LL | fn explicit<'a, 'b>(_: &'a i32, _: &'b i32) -> impl Future<Output = i32> +
|
help: make the function `async` and return the output of the future directly
|
LL | async fn explicit<'a, 'b>(_: &'a i32, _: &'b i32) -> i32 { 42 }
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~
LL - fn explicit<'a, 'b>(_: &'a i32, _: &'b i32) -> impl Future<Output = i32> + 'a + 'b {
LL + async fn explicit<'a, 'b>(_: &'a i32, _: &'b i32) -> i32 { 42 }
|
error: this function can be simplified using the `async fn` syntax
--> tests/ui/manual_async_fn.rs:130:1
@ -130,8 +139,9 @@ LL | pub fn issue_10450() -> impl Future<Output = i32> {
|
help: make the function `async` and return the output of the future directly
|
LL | pub async fn issue_10450() -> i32 { 42 }
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~
LL - pub fn issue_10450() -> impl Future<Output = i32> {
LL + pub async fn issue_10450() -> i32 { 42 }
|
error: this function can be simplified using the `async fn` syntax
--> tests/ui/manual_async_fn.rs:134:1
@ -141,8 +151,9 @@ LL | pub(crate) fn issue_10450_2() -> impl Future<Output = i32> {
|
help: make the function `async` and return the output of the future directly
|
LL | pub(crate) async fn issue_10450_2() -> i32 { 42 }
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~
LL - pub(crate) fn issue_10450_2() -> impl Future<Output = i32> {
LL + pub(crate) async fn issue_10450_2() -> i32 { 42 }
|
error: this function can be simplified using the `async fn` syntax
--> tests/ui/manual_async_fn.rs:138:1
@ -152,8 +163,9 @@ LL | pub(self) fn issue_10450_3() -> impl Future<Output = i32> {
|
help: make the function `async` and return the output of the future directly
|
LL | pub(self) async fn issue_10450_3() -> i32 { 42 }
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~
LL - pub(self) fn issue_10450_3() -> impl Future<Output = i32> {
LL + pub(self) async fn issue_10450_3() -> i32 { 42 }
|
error: aborting due to 13 previous errors

45
src/tools/clippy/tests/ui/manual_float_methods.stderr
View file

@ -17,16 +17,19 @@ LL | if x != f32::INFINITY && x != f32::NEG_INFINITY {}
= help: to override `-D warnings` add `#[allow(clippy::manual_is_finite)]`
help: use the dedicated method instead
|
LL | if x.is_finite() {}
| ~~~~~~~~~~~~~
LL - if x != f32::INFINITY && x != f32::NEG_INFINITY {}
LL + if x.is_finite() {}
|
help: this will alter how it handles NaN; if that is a problem, use instead
|
LL | if x.is_finite() || x.is_nan() {}
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - if x != f32::INFINITY && x != f32::NEG_INFINITY {}
LL + if x.is_finite() || x.is_nan() {}
|
help: or, for conciseness
|
LL | if !x.is_infinite() {}
| ~~~~~~~~~~~~~~~~
LL - if x != f32::INFINITY && x != f32::NEG_INFINITY {}
LL + if !x.is_infinite() {}
|
error: manually checking if a float is infinite
--> tests/ui/manual_float_methods.rs:26:8
@ -42,16 +45,19 @@ LL | if x != INFINITE && x != NEG_INFINITE {}
|
help: use the dedicated method instead
|
LL | if x.is_finite() {}
| ~~~~~~~~~~~~~
LL - if x != INFINITE && x != NEG_INFINITE {}
LL + if x.is_finite() {}
|
help: this will alter how it handles NaN; if that is a problem, use instead
|
LL | if x.is_finite() || x.is_nan() {}
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - if x != INFINITE && x != NEG_INFINITE {}
LL + if x.is_finite() || x.is_nan() {}
|
help: or, for conciseness
|
LL | if !x.is_infinite() {}
| ~~~~~~~~~~~~~~~~
LL - if x != INFINITE && x != NEG_INFINITE {}
LL + if !x.is_infinite() {}
|
error: manually checking if a float is infinite
--> tests/ui/manual_float_methods.rs:29:8
@ -67,16 +73,19 @@ LL | if x != f64::INFINITY && x != f64::NEG_INFINITY {}
|
help: use the dedicated method instead
|
LL | if x.is_finite() {}
| ~~~~~~~~~~~~~
LL - if x != f64::INFINITY && x != f64::NEG_INFINITY {}
LL + if x.is_finite() {}
|
help: this will alter how it handles NaN; if that is a problem, use instead
|
LL | if x.is_finite() || x.is_nan() {}
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - if x != f64::INFINITY && x != f64::NEG_INFINITY {}
LL + if x.is_finite() || x.is_nan() {}
|
help: or, for conciseness
|
LL | if !x.is_infinite() {}
| ~~~~~~~~~~~~~~~~
LL - if x != f64::INFINITY && x != f64::NEG_INFINITY {}
LL + if !x.is_infinite() {}
|
error: manually checking if a float is infinite
--> tests/ui/manual_float_methods.rs:44:12

245
src/tools/clippy/tests/ui/manual_ignore_case_cmp.stderr
View file

@ -11,8 +11,9 @@ LL | #![deny(clippy::manual_ignore_case_cmp)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | if a.eq_ignore_ascii_case(b) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - if a.to_ascii_lowercase() == b.to_ascii_lowercase() {
LL + if a.eq_ignore_ascii_case(b) {
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:12:8
@ -22,8 +23,9 @@ LL | if a.to_ascii_uppercase() == b.to_ascii_uppercase() {
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | if a.eq_ignore_ascii_case(b) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - if a.to_ascii_uppercase() == b.to_ascii_uppercase() {
LL + if a.eq_ignore_ascii_case(b) {
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:15:13
@ -33,8 +35,9 @@ LL | let r = a.to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | let r = a.eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let r = a.to_ascii_lowercase() == b.to_ascii_lowercase();
LL + let r = a.eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:16:18
@ -44,8 +47,9 @@ LL | let r = r || a.to_ascii_uppercase() == b.to_ascii_uppercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | let r = r || a.eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let r = r || a.to_ascii_uppercase() == b.to_ascii_uppercase();
LL + let r = r || a.eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:17:10
@ -55,8 +59,9 @@ LL | r && a.to_ascii_lowercase() == b.to_uppercase().to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | r && a.eq_ignore_ascii_case(&b.to_uppercase());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - r && a.to_ascii_lowercase() == b.to_uppercase().to_ascii_lowercase();
LL + r && a.eq_ignore_ascii_case(&b.to_uppercase());
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:19:8
@ -66,8 +71,9 @@ LL | if a.to_ascii_lowercase() != b.to_ascii_lowercase() {
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | if !a.eq_ignore_ascii_case(b) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - if a.to_ascii_lowercase() != b.to_ascii_lowercase() {
LL + if !a.eq_ignore_ascii_case(b) {
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:22:8
@ -77,8 +83,9 @@ LL | if a.to_ascii_uppercase() != b.to_ascii_uppercase() {
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | if !a.eq_ignore_ascii_case(b) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - if a.to_ascii_uppercase() != b.to_ascii_uppercase() {
LL + if !a.eq_ignore_ascii_case(b) {
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:25:13
@ -88,8 +95,9 @@ LL | let r = a.to_ascii_lowercase() != b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | let r = !a.eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let r = a.to_ascii_lowercase() != b.to_ascii_lowercase();
LL + let r = !a.eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:26:18
@ -99,8 +107,9 @@ LL | let r = r || a.to_ascii_uppercase() != b.to_ascii_uppercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | let r = r || !a.eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let r = r || a.to_ascii_uppercase() != b.to_ascii_uppercase();
LL + let r = r || !a.eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:27:10
@ -110,8 +119,9 @@ LL | r && a.to_ascii_lowercase() != b.to_uppercase().to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | r && !a.eq_ignore_ascii_case(&b.to_uppercase());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - r && a.to_ascii_lowercase() != b.to_uppercase().to_ascii_lowercase();
LL + r && !a.eq_ignore_ascii_case(&b.to_uppercase());
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:38:5
@ -121,8 +131,9 @@ LL | a.to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case(&b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == b.to_ascii_lowercase();
LL + a.eq_ignore_ascii_case(&b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:41:5
@ -132,8 +143,9 @@ LL | a.to_ascii_lowercase() == 'a';
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case(&'a');
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == 'a';
LL + a.eq_ignore_ascii_case(&'a');
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:42:5
@ -143,8 +155,9 @@ LL | 'a' == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | 'a'.eq_ignore_ascii_case(&b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - 'a' == b.to_ascii_lowercase();
LL + 'a'.eq_ignore_ascii_case(&b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:45:5
@ -154,8 +167,9 @@ LL | a.to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case(&b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == b.to_ascii_lowercase();
LL + a.eq_ignore_ascii_case(&b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:46:5
@ -165,8 +179,9 @@ LL | a.to_ascii_lowercase() == b'a';
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case(&b'a');
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == b'a';
LL + a.eq_ignore_ascii_case(&b'a');
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:47:5
@ -176,8 +191,9 @@ LL | b'a' == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | b'a'.eq_ignore_ascii_case(&b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - b'a' == b.to_ascii_lowercase();
LL + b'a'.eq_ignore_ascii_case(&b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:50:5
@ -187,8 +203,9 @@ LL | a.to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == b.to_ascii_lowercase();
LL + a.eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:51:5
@ -198,8 +215,9 @@ LL | a.to_uppercase().to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.to_uppercase().eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_uppercase().to_ascii_lowercase() == b.to_ascii_lowercase();
LL + a.to_uppercase().eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:52:5
@ -209,8 +227,9 @@ LL | a.to_ascii_lowercase() == "a";
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case("a");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == "a";
LL + a.eq_ignore_ascii_case("a");
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:53:5
@ -220,8 +239,9 @@ LL | "a" == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | "a".eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - "a" == b.to_ascii_lowercase();
LL + "a".eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:56:5
@ -231,8 +251,9 @@ LL | a.to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == b.to_ascii_lowercase();
LL + a.eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:57:5
@ -242,8 +263,9 @@ LL | a.to_uppercase().to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.to_uppercase().eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_uppercase().to_ascii_lowercase() == b.to_ascii_lowercase();
LL + a.to_uppercase().eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:58:5
@ -253,8 +275,9 @@ LL | a.to_ascii_lowercase() == "a";
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case("a");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == "a";
LL + a.eq_ignore_ascii_case("a");
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:59:5
@ -264,8 +287,9 @@ LL | "a" == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | "a".eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - "a" == b.to_ascii_lowercase();
LL + "a".eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:62:5
@ -275,8 +299,9 @@ LL | a.to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case(&b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == b.to_ascii_lowercase();
LL + a.eq_ignore_ascii_case(&b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:63:5
@ -286,8 +311,9 @@ LL | a.to_ascii_lowercase() == "a";
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case("a");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == "a";
LL + a.eq_ignore_ascii_case("a");
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:64:5
@ -297,8 +323,9 @@ LL | "a" == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | "a".eq_ignore_ascii_case(&b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - "a" == b.to_ascii_lowercase();
LL + "a".eq_ignore_ascii_case(&b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:67:5
@ -308,8 +335,9 @@ LL | a.to_ascii_lowercase() == "a";
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case("a");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == "a";
LL + a.eq_ignore_ascii_case("a");
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:68:5
@ -319,8 +347,9 @@ LL | "a" == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | "a".eq_ignore_ascii_case(&b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - "a" == b.to_ascii_lowercase();
LL + "a".eq_ignore_ascii_case(&b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:71:5
@ -330,8 +359,9 @@ LL | a.to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == b.to_ascii_lowercase();
LL + a.eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:72:5
@ -341,8 +371,9 @@ LL | a.to_ascii_lowercase() == "a";
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case("a");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == "a";
LL + a.eq_ignore_ascii_case("a");
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:73:5
@ -352,8 +383,9 @@ LL | "a" == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | "a".eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - "a" == b.to_ascii_lowercase();
LL + "a".eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:75:5
@ -363,8 +395,9 @@ LL | b.to_ascii_lowercase() == a.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | b.eq_ignore_ascii_case(&a);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - b.to_ascii_lowercase() == a.to_ascii_lowercase();
LL + b.eq_ignore_ascii_case(&a);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:76:5
@ -374,8 +407,9 @@ LL | b.to_ascii_lowercase() == "a";
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | b.eq_ignore_ascii_case("a");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - b.to_ascii_lowercase() == "a";
LL + b.eq_ignore_ascii_case("a");
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:77:5
@ -385,8 +419,9 @@ LL | "a" == a.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | "a".eq_ignore_ascii_case(&a);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - "a" == a.to_ascii_lowercase();
LL + "a".eq_ignore_ascii_case(&a);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:80:5
@ -396,8 +431,9 @@ LL | a.to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == b.to_ascii_lowercase();
LL + a.eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:81:5
@ -407,8 +443,9 @@ LL | a.to_ascii_lowercase() == "a";
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case("a");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == "a";
LL + a.eq_ignore_ascii_case("a");
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:82:5
@ -418,8 +455,9 @@ LL | "a" == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | "a".eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - "a" == b.to_ascii_lowercase();
LL + "a".eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:84:5
@ -429,8 +467,9 @@ LL | b.to_ascii_lowercase() == a.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | b.eq_ignore_ascii_case(&a);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - b.to_ascii_lowercase() == a.to_ascii_lowercase();
LL + b.eq_ignore_ascii_case(&a);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:85:5
@ -440,8 +479,9 @@ LL | b.to_ascii_lowercase() == "a";
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | b.eq_ignore_ascii_case("a");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - b.to_ascii_lowercase() == "a";
LL + b.eq_ignore_ascii_case("a");
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:86:5
@ -451,8 +491,9 @@ LL | "a" == a.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | "a".eq_ignore_ascii_case(&a);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - "a" == a.to_ascii_lowercase();
LL + "a".eq_ignore_ascii_case(&a);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:89:5
@ -462,8 +503,9 @@ LL | a.to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == b.to_ascii_lowercase();
LL + a.eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:92:5
@ -473,8 +515,9 @@ LL | a.to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case(&b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == b.to_ascii_lowercase();
LL + a.eq_ignore_ascii_case(&b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:95:5
@ -484,8 +527,9 @@ LL | a.to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == b.to_ascii_lowercase();
LL + a.eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:96:5
@ -495,8 +539,9 @@ LL | b.to_ascii_lowercase() == a.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | b.eq_ignore_ascii_case(&a);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - b.to_ascii_lowercase() == a.to_ascii_lowercase();
LL + b.eq_ignore_ascii_case(&a);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:99:5
@ -506,8 +551,9 @@ LL | a.to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == b.to_ascii_lowercase();
LL + a.eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:102:5
@ -517,8 +563,9 @@ LL | a.to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == b.to_ascii_lowercase();
LL + a.eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:105:5
@ -528,8 +575,9 @@ LL | a.to_ascii_lowercase() == b.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | a.eq_ignore_ascii_case(b);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - a.to_ascii_lowercase() == b.to_ascii_lowercase();
LL + a.eq_ignore_ascii_case(b);
|
error: manual case-insensitive ASCII comparison
--> tests/ui/manual_ignore_case_cmp.rs:106:5
@ -539,8 +587,9 @@ LL | b.to_ascii_lowercase() == a.to_ascii_lowercase();
|
help: consider using `.eq_ignore_ascii_case()` instead
|
LL | b.eq_ignore_ascii_case(a);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - b.to_ascii_lowercase() == a.to_ascii_lowercase();
LL + b.eq_ignore_ascii_case(a);
|
error: aborting due to 49 previous errors

20
src/tools/clippy/tests/ui/manual_is_ascii_check.stderr
View file

@ -153,8 +153,9 @@ LL | take_while(|c| ('A'..='Z').contains(&c));
|
help: try
|
LL | take_while(|c: char| c.is_ascii_uppercase());
| ~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
LL - take_while(|c| ('A'..='Z').contains(&c));
LL + take_while(|c: char| c.is_ascii_uppercase());
|
error: manual check for common ascii range
--> tests/ui/manual_is_ascii_check.rs:82:20
@ -164,8 +165,9 @@ LL | take_while(|c| (b'A'..=b'Z').contains(&c));
|
help: try
|
LL | take_while(|c: u8| c.is_ascii_uppercase());
| ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
LL - take_while(|c| (b'A'..=b'Z').contains(&c));
LL + take_while(|c: u8| c.is_ascii_uppercase());
|
error: manual check for common ascii range
--> tests/ui/manual_is_ascii_check.rs:83:26
@ -181,8 +183,9 @@ LL | let digits: Vec<&char> = ['1', 'A'].iter().take_while(|c| ('0'..='9').c
|
help: try
|
LL | let digits: Vec<&char> = ['1', 'A'].iter().take_while(|c: &&char| c.is_ascii_digit()).collect();
| ~~~~~~~~~ ~~~~~~~~~~~~~~~~~~
LL - let digits: Vec<&char> = ['1', 'A'].iter().take_while(|c| ('0'..='9').contains(c)).collect();
LL + let digits: Vec<&char> = ['1', 'A'].iter().take_while(|c: &&char| c.is_ascii_digit()).collect();
|
error: manual check for common ascii range
--> tests/ui/manual_is_ascii_check.rs:88:71
@ -192,8 +195,9 @@ LL | let digits: Vec<&mut char> = ['1', 'A'].iter_mut().take_while(|c| ('0'.
|
help: try
|
LL | let digits: Vec<&mut char> = ['1', 'A'].iter_mut().take_while(|c: &&mut char| c.is_ascii_digit()).collect();
| ~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~
LL - let digits: Vec<&mut char> = ['1', 'A'].iter_mut().take_while(|c| ('0'..='9').contains(c)).collect();
LL + let digits: Vec<&mut char> = ['1', 'A'].iter_mut().take_while(|c: &&mut char| c.is_ascii_digit()).collect();
|
error: aborting due to 29 previous errors

10
src/tools/clippy/tests/ui/map_all_any_identity.stderr
View file

@ -8,8 +8,9 @@ LL | let _ = ["foo"].into_iter().map(|s| s == "foo").any(|a| a);
= help: to override `-D warnings` add `#[allow(clippy::map_all_any_identity)]`
help: use `.any(...)` instead
|
LL | let _ = ["foo"].into_iter().any(|s| s == "foo");
| ~~~~~~~~~~~~~~~~~~~
LL - let _ = ["foo"].into_iter().map(|s| s == "foo").any(|a| a);
LL + let _ = ["foo"].into_iter().any(|s| s == "foo");
|
error: usage of `.map(...).all(identity)`
--> tests/ui/map_all_any_identity.rs:6:33
@ -19,8 +20,9 @@ LL | let _ = ["foo"].into_iter().map(|s| s == "foo").all(std::convert::ident
|
help: use `.all(...)` instead
|
LL | let _ = ["foo"].into_iter().all(|s| s == "foo");
| ~~~~~~~~~~~~~~~~~~~
LL - let _ = ["foo"].into_iter().map(|s| s == "foo").all(std::convert::identity);
LL + let _ = ["foo"].into_iter().all(|s| s == "foo");
|
error: aborting due to 2 previous errors

10
src/tools/clippy/tests/ui/map_with_unused_argument_over_ranges.stderr
View file

@ -68,8 +68,9 @@ LL | (0..10).map(|_| 3);
|
help: remove the explicit range and use `repeat_n`
|
LL | std::iter::repeat_n(3, 10);
| ~~~~~~~~~~~~~~~~~~~ ~~~~~
LL - (0..10).map(|_| 3);
LL + std::iter::repeat_n(3, 10);
|
error: map of a closure that does not depend on its parameter over a range
--> tests/ui/map_with_unused_argument_over_ranges.rs:31:5
@ -216,8 +217,9 @@ LL | (0..10).map(|_| 3);
|
help: remove the explicit range and use `repeat` and `take`
|
LL | std::iter::repeat(3).take(10);
| ~~~~~~~~~~~~~~~~~ ~ +++++++++
LL - (0..10).map(|_| 3);
LL + std::iter::repeat(3).take(10);
|
error: aborting due to 18 previous errors

5
src/tools/clippy/tests/ui/map_with_unused_argument_over_ranges_nostd.stderr
View file

@ -8,8 +8,9 @@ LL | let _: Vec<_> = (0..10).map(|_| 3 + 1).collect();
= help: to override `-D warnings` add `#[allow(clippy::map_with_unused_argument_over_ranges)]`
help: remove the explicit range and use `repeat_n`
|
LL | let _: Vec<_> = core::iter::repeat_n(3 + 1, 10).collect();
| ~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~
LL - let _: Vec<_> = (0..10).map(|_| 3 + 1).collect();
LL + let _: Vec<_> = core::iter::repeat_n(3 + 1, 10).collect();
|
error: aborting due to 1 previous error

15
src/tools/clippy/tests/ui/match_result_ok.stderr
View file

@ -8,8 +8,9 @@ LL | if let Some(y) = x.parse().ok() { y } else { 0 }
= help: to override `-D warnings` add `#[allow(clippy::match_result_ok)]`
help: consider matching on `Ok(y)` and removing the call to `ok` instead
|
LL | if let Ok(y) = x.parse() { y } else { 0 }
| ~~~~~~~~~~~~~~~~~~~~~~~~
LL - if let Some(y) = x.parse().ok() { y } else { 0 }
LL + if let Ok(y) = x.parse() { y } else { 0 }
|
error: matching on `Some` with `ok()` is redundant
--> tests/ui/match_result_ok.rs:23:9
@ -19,8 +20,9 @@ LL | if let Some(y) = x . parse() . ok () {
|
help: consider matching on `Ok(y)` and removing the call to `ok` instead
|
LL | if let Ok(y) = x . parse() {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - if let Some(y) = x . parse() . ok () {
LL + if let Ok(y) = x . parse() {
|
error: matching on `Some` with `ok()` is redundant
--> tests/ui/match_result_ok.rs:49:5
@ -30,8 +32,9 @@ LL | while let Some(a) = wat.next().ok() {
|
help: consider matching on `Ok(a)` and removing the call to `ok` instead
|
LL | while let Ok(a) = wat.next() {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - while let Some(a) = wat.next().ok() {
LL + while let Ok(a) = wat.next() {
|
error: aborting due to 3 previous errors

35
src/tools/clippy/tests/ui/match_str_case_mismatch.stderr
View file

@ -8,8 +8,9 @@ LL | "Bar" => {},
= help: to override `-D warnings` add `#[allow(clippy::match_str_case_mismatch)]`
help: consider changing the case of this arm to respect `to_ascii_lowercase`
|
LL | "bar" => {},
| ~~~~~
LL - "Bar" => {},
LL + "bar" => {},
|
error: this `match` arm has a differing case than its expression
--> tests/ui/match_str_case_mismatch.rs:122:9
@ -19,8 +20,9 @@ LL | "~!@#$%^&*()-_=+Foo" => {},
|
help: consider changing the case of this arm to respect `to_ascii_lowercase` (notice the capitalization difference)
|
LL | "~!@#$%^&*()-_=+foo" => {},
| ~~~~~~~~~~~~~~~~~~~~
LL - "~!@#$%^&*()-_=+Foo" => {},
LL + "~!@#$%^&*()-_=+foo" => {},
|
error: this `match` arm has a differing case than its expression
--> tests/ui/match_str_case_mismatch.rs:134:9
@ -30,8 +32,9 @@ LL | "Воды" => {},
|
help: consider changing the case of this arm to respect `to_lowercase`
|
LL | "воды" => {},
| ~~~~~~
LL - "Воды" => {},
LL + "воды" => {},
|
error: this `match` arm has a differing case than its expression
--> tests/ui/match_str_case_mismatch.rs:145:9
@ -41,8 +44,9 @@ LL | "barDz" => {},
|
help: consider changing the case of this arm to respect `to_lowercase`
|
LL | "bardz" => {},
| ~~~~~~
LL - "barDz" => {},
LL + "bardz" => {},
|
error: this `match` arm has a differing case than its expression
--> tests/ui/match_str_case_mismatch.rs:155:9
@ -52,8 +56,9 @@ LL | "bARʁ" => {},
|
help: consider changing the case of this arm to respect `to_uppercase`
|
LL | "BARʁ" => {},
| ~~~~~~
LL - "bARʁ" => {},
LL + "BARʁ" => {},
|
error: this `match` arm has a differing case than its expression
--> tests/ui/match_str_case_mismatch.rs:165:9
@ -63,8 +68,9 @@ LL | "Bar" => {},
|
help: consider changing the case of this arm to respect `to_ascii_lowercase`
|
LL | "bar" => {},
| ~~~~~
LL - "Bar" => {},
LL + "bar" => {},
|
error: this `match` arm has a differing case than its expression
--> tests/ui/match_str_case_mismatch.rs:180:9
@ -74,8 +80,9 @@ LL | "bAR" => {},
|
help: consider changing the case of this arm to respect `to_ascii_uppercase`
|
LL | "BAR" => {},
| ~~~~~
LL - "bAR" => {},
LL + "BAR" => {},
|
error: aborting due to 7 previous errors

10
src/tools/clippy/tests/ui/needless_borrow_pat.stderr
View file

@ -15,8 +15,9 @@ LL | Some(ref x) => *x,
|
help: try
|
LL | Some(x) => x,
| ~ ~
LL - Some(ref x) => *x,
LL + Some(x) => x,
|
error: this pattern creates a reference to a reference
--> tests/ui/needless_borrow_pat.rs:74:14
@ -71,8 +72,9 @@ LL | E::A(ref x) | E::B(ref x) => *x,
|
help: try
|
LL | E::A(x) | E::B(x) => x,
| ~ ~ ~
LL - E::A(ref x) | E::B(ref x) => *x,
LL + E::A(x) | E::B(x) => x,
|
error: this pattern creates a reference to a reference
--> tests/ui/needless_borrow_pat.rs:126:21

5
src/tools/clippy/tests/ui/needless_for_each_unfixable.stderr
View file

@ -25,8 +25,9 @@ LL + }
|
help: ...and replace `return` with `continue`
|
LL | continue;
| ~~~~~~~~
LL - return;
LL + continue;
|
error: aborting due to 1 previous error

20
src/tools/clippy/tests/ui/needless_pass_by_value.stderr
View file

@ -63,12 +63,14 @@ LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
help: consider changing the type to
|
LL | fn issue_2114(s: String, t: &str, u: Vec<i32>, v: Vec<i32>) {
| ~~~~
LL - fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
LL + fn issue_2114(s: String, t: &str, u: Vec<i32>, v: Vec<i32>) {
|
help: change `t.clone()` to
|
LL | let _ = t.to_string();
| ~~~~~~~~~~~~~
LL - let _ = t.clone();
LL + let _ = t.to_string();
|
error: this argument is passed by value, but not consumed in the function body
--> tests/ui/needless_pass_by_value.rs:91:40
@ -84,12 +86,14 @@ LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
help: consider changing the type to
|
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: &[i32]) {
| ~~~~~~
LL - fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
LL + fn issue_2114(s: String, t: String, u: Vec<i32>, v: &[i32]) {
|
help: change `v.clone()` to
|
LL | let _ = v.to_owned();
| ~~~~~~~~~~~~
LL - let _ = v.clone();
LL + let _ = v.to_owned();
|
error: this argument is passed by value, but not consumed in the function body
--> tests/ui/needless_pass_by_value.rs:108:12

70
src/tools/clippy/tests/ui/needless_range_loop.stderr
View file

@ -8,8 +8,9 @@ LL | for i in 0..vec.len() {
= help: to override `-D warnings` add `#[allow(clippy::needless_range_loop)]`
help: consider using an iterator
|
LL | for <item> in &vec {
| ~~~~~~ ~~~~
LL - for i in 0..vec.len() {
LL + for <item> in &vec {
|
error: the loop variable `i` is only used to index `vec`
--> tests/ui/needless_range_loop.rs:27:14
@ -19,8 +20,9 @@ LL | for i in 0..vec.len() {
|
help: consider using an iterator
|
LL | for <item> in &vec {
| ~~~~~~ ~~~~
LL - for i in 0..vec.len() {
LL + for <item> in &vec {
|
error: the loop variable `j` is only used to index `STATIC`
--> tests/ui/needless_range_loop.rs:33:14
@ -30,8 +32,9 @@ LL | for j in 0..4 {
|
help: consider using an iterator
|
LL | for <item> in &STATIC {
| ~~~~~~ ~~~~~~~
LL - for j in 0..4 {
LL + for <item> in &STATIC {
|
error: the loop variable `j` is only used to index `CONST`
--> tests/ui/needless_range_loop.rs:38:14
@ -41,8 +44,9 @@ LL | for j in 0..4 {
|
help: consider using an iterator
|
LL | for <item> in &CONST {
| ~~~~~~ ~~~~~~
LL - for j in 0..4 {
LL + for <item> in &CONST {
|
error: the loop variable `i` is used to index `vec`
--> tests/ui/needless_range_loop.rs:43:14
@ -52,8 +56,9 @@ LL | for i in 0..vec.len() {
|
help: consider using an iterator and enumerate()
|
LL | for (i, <item>) in vec.iter().enumerate() {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
LL - for i in 0..vec.len() {
LL + for (i, <item>) in vec.iter().enumerate() {
|
error: the loop variable `i` is only used to index `vec2`
--> tests/ui/needless_range_loop.rs:52:14
@ -63,8 +68,9 @@ LL | for i in 0..vec.len() {
|
help: consider using an iterator
|
LL | for <item> in vec2.iter().take(vec.len()) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - for i in 0..vec.len() {
LL + for <item> in vec2.iter().take(vec.len()) {
|
error: the loop variable `i` is only used to index `vec`
--> tests/ui/needless_range_loop.rs:57:14
@ -74,8 +80,9 @@ LL | for i in 5..vec.len() {
|
help: consider using an iterator
|
LL | for <item> in vec.iter().skip(5) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~
LL - for i in 5..vec.len() {
LL + for <item> in vec.iter().skip(5) {
|
error: the loop variable `i` is only used to index `vec`
--> tests/ui/needless_range_loop.rs:62:14
@ -85,8 +92,9 @@ LL | for i in 0..MAX_LEN {
|
help: consider using an iterator
|
LL | for <item> in vec.iter().take(MAX_LEN) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
LL - for i in 0..MAX_LEN {
LL + for <item> in vec.iter().take(MAX_LEN) {
|
error: the loop variable `i` is only used to index `vec`
--> tests/ui/needless_range_loop.rs:67:14
@ -96,8 +104,9 @@ LL | for i in 0..=MAX_LEN {
|
help: consider using an iterator
|
LL | for <item> in vec.iter().take(MAX_LEN + 1) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - for i in 0..=MAX_LEN {
LL + for <item> in vec.iter().take(MAX_LEN + 1) {
|
error: the loop variable `i` is only used to index `vec`
--> tests/ui/needless_range_loop.rs:72:14
@ -107,8 +116,9 @@ LL | for i in 5..10 {
|
help: consider using an iterator
|
LL | for <item> in vec.iter().take(10).skip(5) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - for i in 5..10 {
LL + for <item> in vec.iter().take(10).skip(5) {
|
error: the loop variable `i` is only used to index `vec`
--> tests/ui/needless_range_loop.rs:77:14
@ -118,8 +128,9 @@ LL | for i in 5..=10 {
|
help: consider using an iterator
|
LL | for <item> in vec.iter().take(10 + 1).skip(5) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - for i in 5..=10 {
LL + for <item> in vec.iter().take(10 + 1).skip(5) {
|
error: the loop variable `i` is used to index `vec`
--> tests/ui/needless_range_loop.rs:82:14
@ -129,8 +140,9 @@ LL | for i in 5..vec.len() {
|
help: consider using an iterator and enumerate()
|
LL | for (i, <item>) in vec.iter().enumerate().skip(5) {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - for i in 5..vec.len() {
LL + for (i, <item>) in vec.iter().enumerate().skip(5) {
|
error: the loop variable `i` is used to index `vec`
--> tests/ui/needless_range_loop.rs:87:14
@ -140,8 +152,9 @@ LL | for i in 5..10 {
|
help: consider using an iterator and enumerate()
|
LL | for (i, <item>) in vec.iter().enumerate().take(10).skip(5) {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - for i in 5..10 {
LL + for (i, <item>) in vec.iter().enumerate().take(10).skip(5) {
|
error: the loop variable `i` is used to index `vec`
--> tests/ui/needless_range_loop.rs:93:14
@ -151,8 +164,9 @@ LL | for i in 0..vec.len() {
|
help: consider using an iterator and enumerate()
|
LL | for (i, <item>) in vec.iter_mut().enumerate() {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - for i in 0..vec.len() {
LL + for (i, <item>) in vec.iter_mut().enumerate() {
|
error: aborting due to 14 previous errors

40
src/tools/clippy/tests/ui/needless_range_loop2.stderr
View file

@ -8,8 +8,9 @@ LL | for i in 3..10 {
= help: to override `-D warnings` add `#[allow(clippy::needless_range_loop)]`
help: consider using an iterator
|
LL | for <item> in ns.iter().take(10).skip(3) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - for i in 3..10 {
LL + for <item> in ns.iter().take(10).skip(3) {
|
error: the loop variable `i` is only used to index `ms`
--> tests/ui/needless_range_loop2.rs:34:14
@ -19,8 +20,9 @@ LL | for i in 0..ms.len() {
|
help: consider using an iterator
|
LL | for <item> in &mut ms {
| ~~~~~~ ~~~~~~~
LL - for i in 0..ms.len() {
LL + for <item> in &mut ms {
|
error: the loop variable `i` is only used to index `ms`
--> tests/ui/needless_range_loop2.rs:41:14
@ -30,8 +32,9 @@ LL | for i in 0..ms.len() {
|
help: consider using an iterator
|
LL | for <item> in &mut ms {
| ~~~~~~ ~~~~~~~
LL - for i in 0..ms.len() {
LL + for <item> in &mut ms {
|
error: the loop variable `i` is only used to index `vec`
--> tests/ui/needless_range_loop2.rs:66:14
@ -41,8 +44,9 @@ LL | for i in x..x + 4 {
|
help: consider using an iterator
|
LL | for <item> in vec.iter_mut().skip(x).take(4) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - for i in x..x + 4 {
LL + for <item> in vec.iter_mut().skip(x).take(4) {
|
error: the loop variable `i` is only used to index `vec`
--> tests/ui/needless_range_loop2.rs:74:14
@ -52,8 +56,9 @@ LL | for i in x..=x + 4 {
|
help: consider using an iterator
|
LL | for <item> in vec.iter_mut().skip(x).take(4 + 1) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - for i in x..=x + 4 {
LL + for <item> in vec.iter_mut().skip(x).take(4 + 1) {
|
error: the loop variable `i` is only used to index `arr`
--> tests/ui/needless_range_loop2.rs:81:14
@ -63,8 +68,9 @@ LL | for i in 0..3 {
|
help: consider using an iterator
|
LL | for <item> in &arr {
| ~~~~~~ ~~~~
LL - for i in 0..3 {
LL + for <item> in &arr {
|
error: the loop variable `i` is only used to index `arr`
--> tests/ui/needless_range_loop2.rs:86:14
@ -74,8 +80,9 @@ LL | for i in 0..2 {
|
help: consider using an iterator
|
LL | for <item> in arr.iter().take(2) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~
LL - for i in 0..2 {
LL + for <item> in arr.iter().take(2) {
|
error: the loop variable `i` is only used to index `arr`
--> tests/ui/needless_range_loop2.rs:91:14
@ -85,8 +92,9 @@ LL | for i in 1..3 {
|
help: consider using an iterator
|
LL | for <item> in arr.iter().skip(1) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~
LL - for i in 1..3 {
LL + for <item> in arr.iter().skip(1) {
|
error: aborting due to 8 previous errors

50
src/tools/clippy/tests/ui/needless_return.stderr
View file

@ -80,8 +80,9 @@ LL | true => return false,
|
help: remove `return`
|
LL | true => false,
| ~~~~~
LL - true => return false,
LL + true => false,
|
error: unneeded `return` statement
--> tests/ui/needless_return.rs:58:13
@ -115,8 +116,9 @@ LL | let _ = || return true;
|
help: remove `return`
|
LL | let _ = || true;
| ~~~~
LL - let _ = || return true;
LL + let _ = || true;
|
error: unneeded `return` statement
--> tests/ui/needless_return.rs:71:5
@ -183,8 +185,9 @@ LL | _ => return,
|
help: replace `return` with a unit value
|
LL | _ => (),
| ~~
LL - _ => return,
LL + _ => (),
|
error: unneeded `return` statement
--> tests/ui/needless_return.rs:97:24
@ -209,8 +212,9 @@ LL | _ => return,
|
help: replace `return` with a unit value
|
LL | _ => (),
| ~~
LL - _ => return,
LL + _ => (),
|
error: unneeded `return` statement
--> tests/ui/needless_return.rs:113:9
@ -244,8 +248,9 @@ LL | bar.unwrap_or_else(|_| return)
|
help: replace `return` with an empty block
|
LL | bar.unwrap_or_else(|_| {})
| ~~
LL - bar.unwrap_or_else(|_| return)
LL + bar.unwrap_or_else(|_| {})
|
error: unneeded `return` statement
--> tests/ui/needless_return.rs:141:21
@ -270,8 +275,9 @@ LL | let _ = || return;
|
help: replace `return` with an empty block
|
LL | let _ = || {};
| ~~
LL - let _ = || return;
LL + let _ = || {};
|
error: unneeded `return` statement
--> tests/ui/needless_return.rs:150:32
@ -281,8 +287,9 @@ LL | res.unwrap_or_else(|_| return Foo)
|
help: remove `return`
|
LL | res.unwrap_or_else(|_| Foo)
| ~~~
LL - res.unwrap_or_else(|_| return Foo)
LL + res.unwrap_or_else(|_| Foo)
|
error: unneeded `return` statement
--> tests/ui/needless_return.rs:159:5
@ -340,8 +347,9 @@ LL | true => return false,
|
help: remove `return`
|
LL | true => false,
| ~~~~~
LL - true => return false,
LL + true => false,
|
error: unneeded `return` statement
--> tests/ui/needless_return.rs:178:13
@ -375,8 +383,9 @@ LL | let _ = || return true;
|
help: remove `return`
|
LL | let _ = || true;
| ~~~~
LL - let _ = || return true;
LL + let _ = || true;
|
error: unneeded `return` statement
--> tests/ui/needless_return.rs:191:5
@ -443,8 +452,9 @@ LL | _ => return,
|
help: replace `return` with a unit value
|
LL | _ => (),
| ~~
LL - _ => return,
LL + _ => (),
|
error: unneeded `return` statement
--> tests/ui/needless_return.rs:222:9

10
src/tools/clippy/tests/ui/never_loop.stderr
View file

@ -77,8 +77,9 @@ LL | | }
|
help: if you need the first element of the iterator, try writing
|
LL | if let Some(x) = (0..10).next() {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - for x in 0..10 {
LL + if let Some(x) = (0..10).next() {
|
error: this loop never actually loops
--> tests/ui/never_loop.rs:167:5
@ -145,8 +146,9 @@ LL | | }
|
help: if you need the first element of the iterator, try writing
|
LL | if let Some(_) = (0..20).next() {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - for _ in 0..20 {
LL + if let Some(_) = (0..20).next() {
|
error: this loop never actually loops
--> tests/ui/never_loop.rs:378:13

5
src/tools/clippy/tests/ui/non_canonical_partial_ord_impl.stderr
View file

@ -25,8 +25,9 @@ LL | | }
|
help: change this to
|
LL | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { Some(self.cmp(other)) }
| ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - fn partial_cmp(&self, _: &Self) -> Option<Ordering> {
LL + fn partial_cmp(&self, other: &Self) -> Option<Ordering> { Some(self.cmp(other)) }
|
error: aborting due to 2 previous errors

15
src/tools/clippy/tests/ui/non_std_lazy_static/non_std_lazy_static_fixable.stderr
View file

@ -8,8 +8,9 @@ LL | static LAZY_FOO: Lazy<String> = Lazy::new(|| "foo".to_uppercase());
= help: to override `-D warnings` add `#[allow(clippy::non_std_lazy_statics)]`
help: use `std::sync::LazyLock` instead
|
LL | static LAZY_FOO: std::sync::LazyLock<String> = std::sync::LazyLock::new(|| "foo".to_uppercase());
| ~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
LL - static LAZY_FOO: Lazy<String> = Lazy::new(|| "foo".to_uppercase());
LL + static LAZY_FOO: std::sync::LazyLock<String> = std::sync::LazyLock::new(|| "foo".to_uppercase());
|
error: this type has been superceded by `LazyLock` in the standard library
--> tests/ui/non_std_lazy_static/non_std_lazy_static_fixable.rs:13:18
@ -19,8 +20,9 @@ LL | static LAZY_BAR: Lazy<String> = Lazy::new(|| {
|
help: use `std::sync::LazyLock` instead
|
LL | static LAZY_BAR: std::sync::LazyLock<String> = std::sync::LazyLock::new(|| {
| ~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
LL - static LAZY_BAR: Lazy<String> = Lazy::new(|| {
LL + static LAZY_BAR: std::sync::LazyLock<String> = std::sync::LazyLock::new(|| {
|
error: this type has been superceded by `LazyLock` in the standard library
--> tests/ui/non_std_lazy_static/non_std_lazy_static_fixable.rs:18:18
@ -30,8 +32,9 @@ LL | static LAZY_BAZ: Lazy<String> = { Lazy::new(|| "baz".to_uppercase()) };
|
help: use `std::sync::LazyLock` instead
|
LL | static LAZY_BAZ: std::sync::LazyLock<String> = { std::sync::LazyLock::new(|| "baz".to_uppercase()) };
| ~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
LL - static LAZY_BAZ: Lazy<String> = { Lazy::new(|| "baz".to_uppercase()) };
LL + static LAZY_BAZ: std::sync::LazyLock<String> = { std::sync::LazyLock::new(|| "baz".to_uppercase()) };
|
error: this type has been superceded by `LazyLock` in the standard library
--> tests/ui/non_std_lazy_static/non_std_lazy_static_fixable.rs:20:18

15
src/tools/clippy/tests/ui/non_std_lazy_static/non_std_lazy_static_unfixable.stderr
View file

@ -37,8 +37,9 @@ LL | static LAZY_FOO: Lazy<String> = Lazy::new(|| "foo".to_uppercase());
|
help: use `std::sync::LazyLock` instead
|
LL | static LAZY_FOO: std::sync::LazyLock<String> = std::sync::LazyLock::new(|| "foo".to_uppercase());
| ~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
LL - static LAZY_FOO: Lazy<String> = Lazy::new(|| "foo".to_uppercase());
LL + static LAZY_FOO: std::sync::LazyLock<String> = std::sync::LazyLock::new(|| "foo".to_uppercase());
|
error: this type has been superceded by `LazyLock` in the standard library
--> tests/ui/non_std_lazy_static/non_std_lazy_static_unfixable.rs:13:26
@ -48,8 +49,9 @@ LL | static mut LAZY_BAR: Lazy<String> = Lazy::new(|| "bar".to_uppercase());
|
help: use `std::sync::LazyLock` instead
|
LL | static mut LAZY_BAR: std::sync::LazyLock<String> = std::sync::LazyLock::new(|| "bar".to_uppercase());
| ~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
LL - static mut LAZY_BAR: Lazy<String> = Lazy::new(|| "bar".to_uppercase());
LL + static mut LAZY_BAR: std::sync::LazyLock<String> = std::sync::LazyLock::new(|| "bar".to_uppercase());
|
error: this type has been superceded by `LazyLock` in the standard library
--> tests/ui/non_std_lazy_static/non_std_lazy_static_unfixable.rs:15:26
@ -59,8 +61,9 @@ LL | static mut LAZY_BAZ: Lazy<String> = Lazy::new(|| "baz".to_uppercase());
|
help: use `std::sync::LazyLock` instead
|
LL | static mut LAZY_BAZ: std::sync::LazyLock<String> = std::sync::LazyLock::new(|| "baz".to_uppercase());
| ~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
LL - static mut LAZY_BAZ: Lazy<String> = Lazy::new(|| "baz".to_uppercase());
LL + static mut LAZY_BAZ: std::sync::LazyLock<String> = std::sync::LazyLock::new(|| "baz".to_uppercase());
|
error: aborting due to 6 previous errors

50
src/tools/clippy/tests/ui/nonminimal_bool.stderr
View file

@ -51,10 +51,12 @@ LL | let _ = a == b && c == 5 && a == b;
|
help: try
|
LL | let _ = !(a != b || c != 5);
| ~~~~~~~~~~~~~~~~~~~
LL | let _ = a == b && c == 5;
| ~~~~~~~~~~~~~~~~
LL - let _ = a == b && c == 5 && a == b;
LL + let _ = !(a != b || c != 5);
|
LL - let _ = a == b && c == 5 && a == b;
LL + let _ = a == b && c == 5;
|
error: this boolean expression can be simplified
--> tests/ui/nonminimal_bool.rs:44:13
@ -64,10 +66,12 @@ LL | let _ = a == b || c == 5 || a == b;
|
help: try
|
LL | let _ = !(a != b && c != 5);
| ~~~~~~~~~~~~~~~~~~~
LL | let _ = a == b || c == 5;
| ~~~~~~~~~~~~~~~~
LL - let _ = a == b || c == 5 || a == b;
LL + let _ = !(a != b && c != 5);
|
LL - let _ = a == b || c == 5 || a == b;
LL + let _ = a == b || c == 5;
|
error: this boolean expression can be simplified
--> tests/ui/nonminimal_bool.rs:46:13
@ -77,10 +81,12 @@ LL | let _ = a == b && c == 5 && b == a;
|
help: try
|
LL | let _ = !(a != b || c != 5);
| ~~~~~~~~~~~~~~~~~~~
LL | let _ = a == b && c == 5;
| ~~~~~~~~~~~~~~~~
LL - let _ = a == b && c == 5 && b == a;
LL + let _ = !(a != b || c != 5);
|
LL - let _ = a == b && c == 5 && b == a;
LL + let _ = a == b && c == 5;
|
error: this boolean expression can be simplified
--> tests/ui/nonminimal_bool.rs:48:13
@ -90,10 +96,12 @@ LL | let _ = a != b || !(a != b || c == d);
|
help: try
|
LL | let _ = !(a == b && c == d);
| ~~~~~~~~~~~~~~~~~~~
LL | let _ = a != b || c != d;
| ~~~~~~~~~~~~~~~~
LL - let _ = a != b || !(a != b || c == d);
LL + let _ = !(a == b && c == d);
|
LL - let _ = a != b || !(a != b || c == d);
LL + let _ = a != b || c != d;
|
error: this boolean expression can be simplified
--> tests/ui/nonminimal_bool.rs:50:13
@ -103,10 +111,12 @@ LL | let _ = a != b && !(a != b && c == d);
|
help: try
|
LL | let _ = !(a == b || c == d);
| ~~~~~~~~~~~~~~~~~~~
LL | let _ = a != b && c != d;
| ~~~~~~~~~~~~~~~~
LL - let _ = a != b && !(a != b && c == d);
LL + let _ = !(a == b || c == d);
|
LL - let _ = a != b && !(a != b && c == d);
LL + let _ = a != b && c != d;
|
error: this boolean expression can be simplified
--> tests/ui/nonminimal_bool.rs:81:8

110
src/tools/clippy/tests/ui/octal_escapes.stderr
View file

@ -9,12 +9,14 @@ LL | let _bad1 = "\033[0m";
= help: to override `-D warnings` add `#[allow(clippy::octal_escapes)]`
help: if an octal escape is intended, use a hex escape instead
|
LL | let _bad1 = "\x1b[0m";
| ~~~~
LL - let _bad1 = "\033[0m";
LL + let _bad1 = "\x1b[0m";
|
help: if a null escape is intended, disambiguate using
|
LL | let _bad1 = "\x0033[0m";
| ~~~~~~
LL - let _bad1 = "\033[0m";
LL + let _bad1 = "\x0033[0m";
|
error: octal-looking escape in a literal
--> tests/ui/octal_escapes.rs:6:19
@ -24,12 +26,14 @@ LL | let _bad2 = b"\033[0m";
|
help: if an octal escape is intended, use a hex escape instead
|
LL | let _bad2 = b"\x1b[0m";
| ~~~~
LL - let _bad2 = b"\033[0m";
LL + let _bad2 = b"\x1b[0m";
|
help: if a null escape is intended, disambiguate using
|
LL | let _bad2 = b"\x0033[0m";
| ~~~~~~
LL - let _bad2 = b"\033[0m";
LL + let _bad2 = b"\x0033[0m";
|
error: octal-looking escape in a literal
--> tests/ui/octal_escapes.rs:7:20
@ -39,12 +43,14 @@ LL | let _bad3 = "\\\033[0m";
|
help: if an octal escape is intended, use a hex escape instead
|
LL | let _bad3 = "\\\x1b[0m";
| ~~~~
LL - let _bad3 = "\\\033[0m";
LL + let _bad3 = "\\\x1b[0m";
|
help: if a null escape is intended, disambiguate using
|
LL | let _bad3 = "\\\x0033[0m";
| ~~~~~~
LL - let _bad3 = "\\\033[0m";
LL + let _bad3 = "\\\x0033[0m";
|
error: octal-looking escape in a literal
--> tests/ui/octal_escapes.rs:9:18
@ -54,12 +60,14 @@ LL | let _bad4 = "\01234567";
|
help: if an octal escape is intended, use a hex escape instead
|
LL | let _bad4 = "\x0a34567";
| ~~~~
LL - let _bad4 = "\01234567";
LL + let _bad4 = "\x0a34567";
|
help: if a null escape is intended, disambiguate using
|
LL | let _bad4 = "\x001234567";
| ~~~~~~
LL - let _bad4 = "\01234567";
LL + let _bad4 = "\x001234567";
|
error: octal-looking escape in a literal
--> tests/ui/octal_escapes.rs:10:20
@ -69,12 +77,14 @@ LL | let _bad5 = "\0\03";
|
help: if an octal escape is intended, use a hex escape instead
|
LL | let _bad5 = "\0\x03";
| ~~~~
LL - let _bad5 = "\0\03";
LL + let _bad5 = "\0\x03";
|
help: if a null escape is intended, disambiguate using
|
LL | let _bad5 = "\0\x0003";
| ~~~~~~
LL - let _bad5 = "\0\03";
LL + let _bad5 = "\0\x0003";
|
error: octal-looking escape in a literal
--> tests/ui/octal_escapes.rs:11:23
@ -84,12 +94,14 @@ LL | let _bad6 = "Text-\055\077-MoreText";
|
help: if an octal escape is intended, use a hex escape instead
|
LL | let _bad6 = "Text-\x2d\077-MoreText";
| ~~~~
LL - let _bad6 = "Text-\055\077-MoreText";
LL + let _bad6 = "Text-\x2d\077-MoreText";
|
help: if a null escape is intended, disambiguate using
|
LL | let _bad6 = "Text-\x0055\077-MoreText";
| ~~~~~~
LL - let _bad6 = "Text-\055\077-MoreText";
LL + let _bad6 = "Text-\x0055\077-MoreText";
|
error: octal-looking escape in a literal
--> tests/ui/octal_escapes.rs:11:27
@ -99,12 +111,14 @@ LL | let _bad6 = "Text-\055\077-MoreText";
|
help: if an octal escape is intended, use a hex escape instead
|
LL | let _bad6 = "Text-\055\x3f-MoreText";
| ~~~~
LL - let _bad6 = "Text-\055\077-MoreText";
LL + let _bad6 = "Text-\055\x3f-MoreText";
|
help: if a null escape is intended, disambiguate using
|
LL | let _bad6 = "Text-\055\x0077-MoreText";
| ~~~~~~
LL - let _bad6 = "Text-\055\077-MoreText";
LL + let _bad6 = "Text-\055\x0077-MoreText";
|
error: octal-looking escape in a literal
--> tests/ui/octal_escapes.rs:14:31
@ -114,12 +128,14 @@ LL | let _bad7 = "EvenMoreText-\01\02-ShortEscapes";
|
help: if an octal escape is intended, use a hex escape instead
|
LL | let _bad7 = "EvenMoreText-\x01\02-ShortEscapes";
| ~~~~
LL - let _bad7 = "EvenMoreText-\01\02-ShortEscapes";
LL + let _bad7 = "EvenMoreText-\x01\02-ShortEscapes";
|
help: if a null escape is intended, disambiguate using
|
LL | let _bad7 = "EvenMoreText-\x0001\02-ShortEscapes";
| ~~~~~~
LL - let _bad7 = "EvenMoreText-\01\02-ShortEscapes";
LL + let _bad7 = "EvenMoreText-\x0001\02-ShortEscapes";
|
error: octal-looking escape in a literal
--> tests/ui/octal_escapes.rs:14:34
@ -129,12 +145,14 @@ LL | let _bad7 = "EvenMoreText-\01\02-ShortEscapes";
|
help: if an octal escape is intended, use a hex escape instead
|
LL | let _bad7 = "EvenMoreText-\01\x02-ShortEscapes";
| ~~~~
LL - let _bad7 = "EvenMoreText-\01\02-ShortEscapes";
LL + let _bad7 = "EvenMoreText-\01\x02-ShortEscapes";
|
help: if a null escape is intended, disambiguate using
|
LL | let _bad7 = "EvenMoreText-\01\x0002-ShortEscapes";
| ~~~~~~
LL - let _bad7 = "EvenMoreText-\01\02-ShortEscapes";
LL + let _bad7 = "EvenMoreText-\01\x0002-ShortEscapes";
|
error: octal-looking escape in a literal
--> tests/ui/octal_escapes.rs:17:19
@ -144,12 +162,14 @@ LL | let _bad8 = "锈\01锈";
|
help: if an octal escape is intended, use a hex escape instead
|
LL | let _bad8 = "锈\x01锈";
| ~~~~
LL - let _bad8 = "锈\01锈";
LL + let _bad8 = "锈\x01锈";
|
help: if a null escape is intended, disambiguate using
|
LL | let _bad8 = "锈\x0001锈";
| ~~~~~~
LL - let _bad8 = "锈\01锈";
LL + let _bad8 = "锈\x0001锈";
|
error: octal-looking escape in a literal
--> tests/ui/octal_escapes.rs:18:19
@ -159,12 +179,14 @@ LL | let _bad9 = "锈\011锈";
|
help: if an octal escape is intended, use a hex escape instead
|
LL | let _bad9 = "锈\x09锈";
| ~~~~
LL - let _bad9 = "锈\011锈";
LL + let _bad9 = "锈\x09锈";
|
help: if a null escape is intended, disambiguate using
|
LL | let _bad9 = "锈\x0011锈";
| ~~~~~~
LL - let _bad9 = "锈\011锈";
LL + let _bad9 = "锈\x0011锈";
|
error: aborting due to 11 previous errors

5
src/tools/clippy/tests/ui/op_ref.stderr
View file

@ -8,8 +8,9 @@ LL | let foo = &5 - &6;
= help: to override `-D warnings` add `#[allow(clippy::op_ref)]`
help: use the values directly
|
LL | let foo = 5 - 6;
| ~ ~
LL - let foo = &5 - &6;
LL + let foo = 5 - 6;
|
error: taken reference of right operand
--> tests/ui/op_ref.rs:58:13

15
src/tools/clippy/tests/ui/option_as_ref_cloned.stderr
View file

@ -8,8 +8,9 @@ LL | let _: Option<String> = x.as_ref().cloned();
= help: to override `-D warnings` add `#[allow(clippy::option_as_ref_cloned)]`
help: this can be written more concisely by cloning the `Option<_>` directly
|
LL | let _: Option<String> = x.clone();
| ~~~~~
LL - let _: Option<String> = x.as_ref().cloned();
LL + let _: Option<String> = x.clone();
|
error: cloning an `Option<_>` using `.as_mut().cloned()`
--> tests/ui/option_as_ref_cloned.rs:8:31
@ -19,8 +20,9 @@ LL | let _: Option<String> = x.as_mut().cloned();
|
help: this can be written more concisely by cloning the `Option<_>` directly
|
LL | let _: Option<String> = x.clone();
| ~~~~~
LL - let _: Option<String> = x.as_mut().cloned();
LL + let _: Option<String> = x.clone();
|
error: cloning an `Option<_>` using `.as_ref().cloned()`
--> tests/ui/option_as_ref_cloned.rs:11:32
@ -30,8 +32,9 @@ LL | let _: Option<&String> = y.as_ref().cloned();
|
help: this can be written more concisely by cloning the `Option<_>` directly
|
LL | let _: Option<&String> = y.clone();
| ~~~~~
LL - let _: Option<&String> = y.as_ref().cloned();
LL + let _: Option<&String> = y.clone();
|
error: aborting due to 3 previous errors

5
src/tools/clippy/tests/ui/redundant_guards.stderr
View file

@ -44,8 +44,9 @@ LL | Some(x) if matches!(x, Some(1) if true) => ..,
|
help: try
|
LL | Some(Some(1)) if true => ..,
| ~~~~~~~ ~~~~~~~
LL - Some(x) if matches!(x, Some(1) if true) => ..,
LL + Some(Some(1)) if true => ..,
|
error: redundant guard
--> tests/ui/redundant_guards.rs:50:20

10
src/tools/clippy/tests/ui/ref_binding_to_reference.stderr
View file

@ -8,8 +8,9 @@ LL | Some(ref x) => x,
= help: to override `-D warnings` add `#[allow(clippy::ref_binding_to_reference)]`
help: try
|
LL | Some(x) => &x,
| ~ ~~
LL - Some(ref x) => x,
LL + Some(x) => &x,
|
error: this pattern creates a reference to a reference
--> tests/ui/ref_binding_to_reference.rs:38:14
@ -34,8 +35,9 @@ LL | Some(ref x) => m2!(x),
|
help: try
|
LL | Some(x) => m2!(&x),
| ~ ~~
LL - Some(ref x) => m2!(x),
LL + Some(x) => m2!(&x),
|
error: this pattern creates a reference to a reference
--> tests/ui/ref_binding_to_reference.rs:55:15

10
src/tools/clippy/tests/ui/ref_option/ref_option.all.stderr
View file

@ -55,8 +55,9 @@ LL | fn mult_string(a: &Option<String>, b: &Option<Vec<u8>>) {}
|
help: change this to
|
LL | fn mult_string(a: Option<&String>, b: Option<&Vec<u8>>) {}
| ~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~
LL - fn mult_string(a: &Option<String>, b: &Option<Vec<u8>>) {}
LL + fn mult_string(a: Option<&String>, b: Option<&Vec<u8>>) {}
|
error: it is more idiomatic to use `Option<&T>` instead of `&Option<T>`
--> tests/ui/ref_option/ref_option.rs:18:1
@ -85,8 +86,9 @@ LL | pub fn pub_mult_string(a: &Option<String>, b: &Option<Vec<u8>>) {}
|
help: change this to
|
LL | pub fn pub_mult_string(a: Option<&String>, b: Option<&Vec<u8>>) {}
| ~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~
LL - pub fn pub_mult_string(a: &Option<String>, b: &Option<Vec<u8>>) {}
LL + pub fn pub_mult_string(a: Option<&String>, b: Option<&Vec<u8>>) {}
|
error: it is more idiomatic to use `Option<&T>` instead of `&Option<T>`
--> tests/ui/ref_option/ref_option.rs:26:5

5
src/tools/clippy/tests/ui/ref_option/ref_option.private.stderr
View file

@ -55,8 +55,9 @@ LL | fn mult_string(a: &Option<String>, b: &Option<Vec<u8>>) {}
|
help: change this to
|
LL | fn mult_string(a: Option<&String>, b: Option<&Vec<u8>>) {}
| ~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~
LL - fn mult_string(a: &Option<String>, b: &Option<Vec<u8>>) {}
LL + fn mult_string(a: Option<&String>, b: Option<&Vec<u8>>) {}
|
error: it is more idiomatic to use `Option<&T>` instead of `&Option<T>`
--> tests/ui/ref_option/ref_option.rs:18:1

15
src/tools/clippy/tests/ui/repeat_vec_with_capacity.stderr
View file

@ -9,8 +9,9 @@ LL | vec![Vec::<()>::with_capacity(42); 123];
= help: to override `-D warnings` add `#[allow(clippy::repeat_vec_with_capacity)]`
help: if you intended to initialize multiple `Vec`s with an initial capacity, try
|
LL | (0..123).map(|_| Vec::<()>::with_capacity(42)).collect::<Vec<_>>();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - vec![Vec::<()>::with_capacity(42); 123];
LL + (0..123).map(|_| Vec::<()>::with_capacity(42)).collect::<Vec<_>>();
|
error: repeating `Vec::with_capacity` using `vec![x; n]`, which does not retain capacity
--> tests/ui/repeat_vec_with_capacity.rs:12:9
@ -21,8 +22,9 @@ LL | vec![Vec::<()>::with_capacity(42); n];
= note: only the last `Vec` will have the capacity
help: if you intended to initialize multiple `Vec`s with an initial capacity, try
|
LL | (0..n).map(|_| Vec::<()>::with_capacity(42)).collect::<Vec<_>>();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - vec![Vec::<()>::with_capacity(42); n];
LL + (0..n).map(|_| Vec::<()>::with_capacity(42)).collect::<Vec<_>>();
|
error: repeating `Vec::with_capacity` using `iter::repeat`, which does not retain capacity
--> tests/ui/repeat_vec_with_capacity.rs:27:9
@ -33,8 +35,9 @@ LL | std::iter::repeat(Vec::<()>::with_capacity(42));
= note: none of the yielded `Vec`s will have the requested capacity
help: if you intended to create an iterator that yields `Vec`s with an initial capacity, try
|
LL | std::iter::repeat_with(|| Vec::<()>::with_capacity(42));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - std::iter::repeat(Vec::<()>::with_capacity(42));
LL + std::iter::repeat_with(|| Vec::<()>::with_capacity(42));
|
error: aborting due to 3 previous errors

5
src/tools/clippy/tests/ui/repeat_vec_with_capacity_nostd.stderr
View file

@ -9,8 +9,9 @@ LL | let _: Vec<Vec<u8>> = iter::repeat(Vec::with_capacity(42)).take(123).co
= help: to override `-D warnings` add `#[allow(clippy::repeat_vec_with_capacity)]`
help: if you intended to create an iterator that yields `Vec`s with an initial capacity, try
|
LL | let _: Vec<Vec<u8>> = core::iter::repeat_with(|| Vec::with_capacity(42)).take(123).collect();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _: Vec<Vec<u8>> = iter::repeat(Vec::with_capacity(42)).take(123).collect();
LL + let _: Vec<Vec<u8>> = core::iter::repeat_with(|| Vec::with_capacity(42)).take(123).collect();
|
error: aborting due to 1 previous error

20
src/tools/clippy/tests/ui/reversed_empty_ranges_fixable.stderr
View file

@ -8,8 +8,9 @@ LL | (42..=21).for_each(|x| println!("{}", x));
= help: to override `-D warnings` add `#[allow(clippy::reversed_empty_ranges)]`
help: consider using the following if you are attempting to iterate over this range in reverse
|
LL | (21..=42).rev().for_each(|x| println!("{}", x));
| ~~~~~~~~~~~~~~~
LL - (42..=21).for_each(|x| println!("{}", x));
LL + (21..=42).rev().for_each(|x| println!("{}", x));
|
error: this range is empty so it will yield no values
--> tests/ui/reversed_empty_ranges_fixable.rs:10:13
@ -19,8 +20,9 @@ LL | let _ = (ANSWER..21).filter(|x| x % 2 == 0).take(10).collect::<Vec<_>>(
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
LL | let _ = (21..ANSWER).rev().filter(|x| x % 2 == 0).take(10).collect::<Vec<_>>();
| ~~~~~~~~~~~~~~~~~~
LL - let _ = (ANSWER..21).filter(|x| x % 2 == 0).take(10).collect::<Vec<_>>();
LL + let _ = (21..ANSWER).rev().filter(|x| x % 2 == 0).take(10).collect::<Vec<_>>();
|
error: this range is empty so it will yield no values
--> tests/ui/reversed_empty_ranges_fixable.rs:12:14
@ -30,8 +32,9 @@ LL | for _ in -21..=-42 {}
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
LL | for _ in (-42..=-21).rev() {}
| ~~~~~~~~~~~~~~~~~
LL - for _ in -21..=-42 {}
LL + for _ in (-42..=-21).rev() {}
|
error: this range is empty so it will yield no values
--> tests/ui/reversed_empty_ranges_fixable.rs:13:14
@ -41,8 +44,9 @@ LL | for _ in 42u32..21u32 {}
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
LL | for _ in (21u32..42u32).rev() {}
| ~~~~~~~~~~~~~~~~~~~~
LL - for _ in 42u32..21u32 {}
LL + for _ in (21u32..42u32).rev() {}
|
error: aborting due to 4 previous errors

30
src/tools/clippy/tests/ui/reversed_empty_ranges_loops_fixable.stderr
View file

@ -8,8 +8,9 @@ LL | for i in 10..0 {
= help: to override `-D warnings` add `#[allow(clippy::reversed_empty_ranges)]`
help: consider using the following if you are attempting to iterate over this range in reverse
|
LL | for i in (0..10).rev() {
| ~~~~~~~~~~~~~
LL - for i in 10..0 {
LL + for i in (0..10).rev() {
|
error: this range is empty so it will yield no values
--> tests/ui/reversed_empty_ranges_loops_fixable.rs:11:14
@ -19,8 +20,9 @@ LL | for i in 10..=0 {
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
LL | for i in (0..=10).rev() {
| ~~~~~~~~~~~~~~
LL - for i in 10..=0 {
LL + for i in (0..=10).rev() {
|
error: this range is empty so it will yield no values
--> tests/ui/reversed_empty_ranges_loops_fixable.rs:15:14
@ -30,8 +32,9 @@ LL | for i in MAX_LEN..0 {
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
LL | for i in (0..MAX_LEN).rev() {
| ~~~~~~~~~~~~~~~~~~
LL - for i in MAX_LEN..0 {
LL + for i in (0..MAX_LEN).rev() {
|
error: this range is empty so it will yield no values
--> tests/ui/reversed_empty_ranges_loops_fixable.rs:34:14
@ -41,8 +44,9 @@ LL | for i in (10..0).map(|x| x * 2) {
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
LL | for i in (0..10).rev().map(|x| x * 2) {
| ~~~~~~~~~~~~~
LL - for i in (10..0).map(|x| x * 2) {
LL + for i in (0..10).rev().map(|x| x * 2) {
|
error: this range is empty so it will yield no values
--> tests/ui/reversed_empty_ranges_loops_fixable.rs:39:14
@ -52,8 +56,9 @@ LL | for i in 10..5 + 4 {
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
LL | for i in (5 + 4..10).rev() {
| ~~~~~~~~~~~~~~~~~
LL - for i in 10..5 + 4 {
LL + for i in (5 + 4..10).rev() {
|
error: this range is empty so it will yield no values
--> tests/ui/reversed_empty_ranges_loops_fixable.rs:43:14
@ -63,8 +68,9 @@ LL | for i in (5 + 2)..(3 - 1) {
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
LL | for i in ((3 - 1)..(5 + 2)).rev() {
| ~~~~~~~~~~~~~~~~~~~~~~~~
LL - for i in (5 + 2)..(3 - 1) {
LL + for i in ((3 - 1)..(5 + 2)).rev() {
|
error: aborting due to 6 previous errors

90
src/tools/clippy/tests/ui/single_range_in_vec_init.stderr
View file

@ -8,12 +8,14 @@ LL | [0..200];
= help: to override `-D warnings` add `#[allow(clippy::single_range_in_vec_init)]`
help: if you wanted a `Vec` that contains the entire range, try
|
LL | (0..200).collect::<std::vec::Vec<i32>>();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - [0..200];
LL + (0..200).collect::<std::vec::Vec<i32>>();
|
help: if you wanted an array of len 200, try
|
LL | [0; 200];
| ~~~~~~
LL - [0..200];
LL + [0; 200];
|
error: a `Vec` of `Range` that is only one element
--> tests/ui/single_range_in_vec_init.rs:27:5
@ -23,12 +25,14 @@ LL | vec![0..200];
|
help: if you wanted a `Vec` that contains the entire range, try
|
LL | (0..200).collect::<std::vec::Vec<i32>>();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - vec![0..200];
LL + (0..200).collect::<std::vec::Vec<i32>>();
|
help: if you wanted a `Vec` of len 200, try
|
LL | vec![0; 200];
| ~~~~~~
LL - vec![0..200];
LL + vec![0; 200];
|
error: an array of `Range` that is only one element
--> tests/ui/single_range_in_vec_init.rs:28:5
@ -38,12 +42,14 @@ LL | [0u8..200];
|
help: if you wanted a `Vec` that contains the entire range, try
|
LL | (0u8..200).collect::<std::vec::Vec<u8>>();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - [0u8..200];
LL + (0u8..200).collect::<std::vec::Vec<u8>>();
|
help: if you wanted an array of len 200, try
|
LL | [0u8; 200];
| ~~~~~~~~
LL - [0u8..200];
LL + [0u8; 200];
|
error: an array of `Range` that is only one element
--> tests/ui/single_range_in_vec_init.rs:29:5
@ -53,12 +59,14 @@ LL | [0usize..200];
|
help: if you wanted a `Vec` that contains the entire range, try
|
LL | (0usize..200).collect::<std::vec::Vec<usize>>();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - [0usize..200];
LL + (0usize..200).collect::<std::vec::Vec<usize>>();
|
help: if you wanted an array of len 200, try
|
LL | [0usize; 200];
| ~~~~~~~~~~~
LL - [0usize..200];
LL + [0usize; 200];
|
error: an array of `Range` that is only one element
--> tests/ui/single_range_in_vec_init.rs:30:5
@ -68,12 +76,14 @@ LL | [0..200usize];
|
help: if you wanted a `Vec` that contains the entire range, try
|
LL | (0..200usize).collect::<std::vec::Vec<usize>>();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - [0..200usize];
LL + (0..200usize).collect::<std::vec::Vec<usize>>();
|
help: if you wanted an array of len 200usize, try
|
LL | [0; 200usize];
| ~~~~~~~~~~~
LL - [0..200usize];
LL + [0; 200usize];
|
error: a `Vec` of `Range` that is only one element
--> tests/ui/single_range_in_vec_init.rs:31:5
@ -83,12 +93,14 @@ LL | vec![0u8..200];
|
help: if you wanted a `Vec` that contains the entire range, try
|
LL | (0u8..200).collect::<std::vec::Vec<u8>>();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - vec![0u8..200];
LL + (0u8..200).collect::<std::vec::Vec<u8>>();
|
help: if you wanted a `Vec` of len 200, try
|
LL | vec![0u8; 200];
| ~~~~~~~~
LL - vec![0u8..200];
LL + vec![0u8; 200];
|
error: a `Vec` of `Range` that is only one element
--> tests/ui/single_range_in_vec_init.rs:32:5
@ -98,12 +110,14 @@ LL | vec![0usize..200];
|
help: if you wanted a `Vec` that contains the entire range, try
|
LL | (0usize..200).collect::<std::vec::Vec<usize>>();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - vec![0usize..200];
LL + (0usize..200).collect::<std::vec::Vec<usize>>();
|
help: if you wanted a `Vec` of len 200, try
|
LL | vec![0usize; 200];
| ~~~~~~~~~~~
LL - vec![0usize..200];
LL + vec![0usize; 200];
|
error: a `Vec` of `Range` that is only one element
--> tests/ui/single_range_in_vec_init.rs:33:5
@ -113,12 +127,14 @@ LL | vec![0..200usize];
|
help: if you wanted a `Vec` that contains the entire range, try
|
LL | (0..200usize).collect::<std::vec::Vec<usize>>();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - vec![0..200usize];
LL + (0..200usize).collect::<std::vec::Vec<usize>>();
|
help: if you wanted a `Vec` of len 200usize, try
|
LL | vec![0; 200usize];
| ~~~~~~~~~~~
LL - vec![0..200usize];
LL + vec![0; 200usize];
|
error: an array of `Range` that is only one element
--> tests/ui/single_range_in_vec_init.rs:35:5
@ -128,8 +144,9 @@ LL | [0..200isize];
|
help: if you wanted a `Vec` that contains the entire range, try
|
LL | (0..200isize).collect::<std::vec::Vec<isize>>();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - [0..200isize];
LL + (0..200isize).collect::<std::vec::Vec<isize>>();
|
error: a `Vec` of `Range` that is only one element
--> tests/ui/single_range_in_vec_init.rs:36:5
@ -139,8 +156,9 @@ LL | vec![0..200isize];
|
help: if you wanted a `Vec` that contains the entire range, try
|
LL | (0..200isize).collect::<std::vec::Vec<isize>>();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - vec![0..200isize];
LL + (0..200isize).collect::<std::vec::Vec<isize>>();
|
error: aborting due to 10 previous errors

25
src/tools/clippy/tests/ui/string_lit_chars_any.stderr
View file

@ -8,8 +8,9 @@ LL | "\\.+*?()|[]{}^$#&-~".chars().any(|x| x == c);
= help: to override `-D warnings` add `#[allow(clippy::string_lit_chars_any)]`
help: use `matches!(...)` instead
|
LL | matches!(c, '\\' | '.' | '+' | '*' | '?' | '(' | ')' | '|' | '[' | ']' | '{' | '}' | '^' | '$' | '#' | '&' | '-' | '~');
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - "\\.+*?()|[]{}^$#&-~".chars().any(|x| x == c);
LL + matches!(c, '\\' | '.' | '+' | '*' | '?' | '(' | ')' | '|' | '[' | ']' | '{' | '}' | '^' | '$' | '#' | '&' | '-' | '~');
|
error: usage of `.chars().any(...)` to check if a char matches any from a string literal
--> tests/ui/string_lit_chars_any.rs:19:5
@ -19,8 +20,9 @@ LL | r#"\.+*?()|[]{}^$#&-~"#.chars().any(|x| x == c);
|
help: use `matches!(...)` instead
|
LL | matches!(c, '\\' | '.' | '+' | '*' | '?' | '(' | ')' | '|' | '[' | ']' | '{' | '}' | '^' | '$' | '#' | '&' | '-' | '~');
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - r#"\.+*?()|[]{}^$#&-~"#.chars().any(|x| x == c);
LL + matches!(c, '\\' | '.' | '+' | '*' | '?' | '(' | ')' | '|' | '[' | ']' | '{' | '}' | '^' | '$' | '#' | '&' | '-' | '~');
|
error: usage of `.chars().any(...)` to check if a char matches any from a string literal
--> tests/ui/string_lit_chars_any.rs:20:5
@ -30,8 +32,9 @@ LL | "\\.+*?()|[]{}^$#&-~".chars().any(|x| c == x);
|
help: use `matches!(...)` instead
|
LL | matches!(c, '\\' | '.' | '+' | '*' | '?' | '(' | ')' | '|' | '[' | ']' | '{' | '}' | '^' | '$' | '#' | '&' | '-' | '~');
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - "\\.+*?()|[]{}^$#&-~".chars().any(|x| c == x);
LL + matches!(c, '\\' | '.' | '+' | '*' | '?' | '(' | ')' | '|' | '[' | ']' | '{' | '}' | '^' | '$' | '#' | '&' | '-' | '~');
|
error: usage of `.chars().any(...)` to check if a char matches any from a string literal
--> tests/ui/string_lit_chars_any.rs:21:5
@ -41,8 +44,9 @@ LL | r#"\.+*?()|[]{}^$#&-~"#.chars().any(|x| c == x);
|
help: use `matches!(...)` instead
|
LL | matches!(c, '\\' | '.' | '+' | '*' | '?' | '(' | ')' | '|' | '[' | ']' | '{' | '}' | '^' | '$' | '#' | '&' | '-' | '~');
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - r#"\.+*?()|[]{}^$#&-~"#.chars().any(|x| c == x);
LL + matches!(c, '\\' | '.' | '+' | '*' | '?' | '(' | ')' | '|' | '[' | ']' | '{' | '}' | '^' | '$' | '#' | '&' | '-' | '~');
|
error: usage of `.chars().any(...)` to check if a char matches any from a string literal
--> tests/ui/string_lit_chars_any.rs:23:5
@ -52,8 +56,9 @@ LL | "\\.+*?()|[]{}^$#&-~".chars().any(|x| { x == c });
|
help: use `matches!(...)` instead
|
LL | matches!(c, '\\' | '.' | '+' | '*' | '?' | '(' | ')' | '|' | '[' | ']' | '{' | '}' | '^' | '$' | '#' | '&' | '-' | '~');
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - "\\.+*?()|[]{}^$#&-~".chars().any(|x| { x == c });
LL + matches!(c, '\\' | '.' | '+' | '*' | '?' | '(' | ')' | '|' | '[' | ']' | '{' | '}' | '^' | '$' | '#' | '&' | '-' | '~');
|
error: aborting due to 5 previous errors

10
src/tools/clippy/tests/ui/suspicious_command_arg_space.stderr
View file

@ -8,8 +8,9 @@ LL | std::process::Command::new("echo").arg("-n hello").spawn().unwrap();
= help: to override `-D warnings` add `#[allow(clippy::suspicious_command_arg_space)]`
help: consider splitting the argument
|
LL | std::process::Command::new("echo").args(["-n", "hello"]).spawn().unwrap();
| ~~~~ ~~~~~~~~~~~~~~~
LL - std::process::Command::new("echo").arg("-n hello").spawn().unwrap();
LL + std::process::Command::new("echo").args(["-n", "hello"]).spawn().unwrap();
|
error: single argument that looks like it should be multiple arguments
--> tests/ui/suspicious_command_arg_space.rs:7:43
@ -19,8 +20,9 @@ LL | std::process::Command::new("cat").arg("--number file").spawn().unwrap()
|
help: consider splitting the argument
|
LL | std::process::Command::new("cat").args(["--number", "file"]).spawn().unwrap();
| ~~~~ ~~~~~~~~~~~~~~~~~~~~
LL - std::process::Command::new("cat").arg("--number file").spawn().unwrap();
LL + std::process::Command::new("cat").args(["--number", "file"]).spawn().unwrap();
|
error: aborting due to 2 previous errors

15
src/tools/clippy/tests/ui/suspicious_doc_comments.stderr
View file

@ -8,7 +8,8 @@ LL | ///! Fake module documentation.
= help: to override `-D warnings` add `#[allow(clippy::suspicious_doc_comments)]`
help: use an inner doc comment to document the parent module or crate
|
LL | //! Fake module documentation.
LL - ///! Fake module documentation.
LL + //! Fake module documentation.
|
error: this is an outer doc comment and does not apply to the parent module or crate
@ -19,7 +20,8 @@ LL | ///! This module contains useful functions.
|
help: use an inner doc comment to document the parent module or crate
|
LL | //! This module contains useful functions.
LL - ///! This module contains useful functions.
LL + //! This module contains useful functions.
|
error: this is an outer doc comment and does not apply to the parent module or crate
@ -71,7 +73,8 @@ LL | ///! a
|
help: use an inner doc comment to document the parent module or crate
|
LL | //! a
LL - ///! a
LL + //! a
|
error: this is an outer doc comment and does not apply to the parent module or crate
@ -97,7 +100,8 @@ LL | ///! Very cool macro
|
help: use an inner doc comment to document the parent module or crate
|
LL | //! Very cool macro
LL - ///! Very cool macro
LL + //! Very cool macro
|
error: this is an outer doc comment and does not apply to the parent module or crate
@ -108,7 +112,8 @@ LL | ///! Huh.
|
help: use an inner doc comment to document the parent module or crate
|
LL | //! Huh.
LL - ///! Huh.
LL + //! Huh.
|
error: aborting due to 9 previous errors

40
src/tools/clippy/tests/ui/suspicious_to_owned.stderr
View file

@ -8,12 +8,14 @@ LL | let _ = cow.to_owned();
= help: to override `-D warnings` add `#[allow(clippy::suspicious_to_owned)]`
help: depending on intent, either make the Cow an Owned variant
|
LL | let _ = cow.into_owned();
| ~~~~~~~~~~~~~~~~
LL - let _ = cow.to_owned();
LL + let _ = cow.into_owned();
|
help: or clone the Cow itself
|
LL | let _ = cow.clone();
| ~~~~~~~~~~~
LL - let _ = cow.to_owned();
LL + let _ = cow.clone();
|
error: this `to_owned` call clones the Cow<'_, [char; 3]> itself and does not cause the Cow<'_, [char; 3]> contents to become owned
--> tests/ui/suspicious_to_owned.rs:29:13
@ -23,12 +25,14 @@ LL | let _ = cow.to_owned();
|
help: depending on intent, either make the Cow an Owned variant
|
LL | let _ = cow.into_owned();
| ~~~~~~~~~~~~~~~~
LL - let _ = cow.to_owned();
LL + let _ = cow.into_owned();
|
help: or clone the Cow itself
|
LL | let _ = cow.clone();
| ~~~~~~~~~~~
LL - let _ = cow.to_owned();
LL + let _ = cow.clone();
|
error: this `to_owned` call clones the Cow<'_, Vec<char>> itself and does not cause the Cow<'_, Vec<char>> contents to become owned
--> tests/ui/suspicious_to_owned.rs:40:13
@ -38,12 +42,14 @@ LL | let _ = cow.to_owned();
|
help: depending on intent, either make the Cow an Owned variant
|
LL | let _ = cow.into_owned();
| ~~~~~~~~~~~~~~~~
LL - let _ = cow.to_owned();
LL + let _ = cow.into_owned();
|
help: or clone the Cow itself
|
LL | let _ = cow.clone();
| ~~~~~~~~~~~
LL - let _ = cow.to_owned();
LL + let _ = cow.clone();
|
error: this `to_owned` call clones the Cow<'_, str> itself and does not cause the Cow<'_, str> contents to become owned
--> tests/ui/suspicious_to_owned.rs:51:13
@ -53,12 +59,14 @@ LL | let _ = cow.to_owned();
|
help: depending on intent, either make the Cow an Owned variant
|
LL | let _ = cow.into_owned();
| ~~~~~~~~~~~~~~~~
LL - let _ = cow.to_owned();
LL + let _ = cow.into_owned();
|
help: or clone the Cow itself
|
LL | let _ = cow.clone();
| ~~~~~~~~~~~
LL - let _ = cow.to_owned();
LL + let _ = cow.clone();
|
error: implicitly cloning a `String` by calling `to_owned` on its dereferenced type
--> tests/ui/suspicious_to_owned.rs:66:13

35
src/tools/clippy/tests/ui/suspicious_xor_used_as_pow.stderr
View file

@ -8,8 +8,9 @@ LL | let _ = 2 ^ 5;
= help: to override `-D warnings` add `#[allow(clippy::suspicious_xor_used_as_pow)]`
help: did you mean to write
|
LL | let _ = 2.pow(5);
| ~~~~~~~~
LL - let _ = 2 ^ 5;
LL + let _ = 2.pow(5);
|
error: `^` is not the exponentiation operator
--> tests/ui/suspicious_xor_used_as_pow.rs:22:13
@ -19,8 +20,9 @@ LL | let _ = 2i32 ^ 9i32;
|
help: did you mean to write
|
LL | let _ = 2i32.pow(9i32);
| ~~~~~~~~~~~~~~
LL - let _ = 2i32 ^ 9i32;
LL + let _ = 2i32.pow(9i32);
|
error: `^` is not the exponentiation operator
--> tests/ui/suspicious_xor_used_as_pow.rs:24:13
@ -30,8 +32,9 @@ LL | let _ = 2i32 ^ 2i32;
|
help: did you mean to write
|
LL | let _ = 2i32.pow(2i32);
| ~~~~~~~~~~~~~~
LL - let _ = 2i32 ^ 2i32;
LL + let _ = 2i32.pow(2i32);
|
error: `^` is not the exponentiation operator
--> tests/ui/suspicious_xor_used_as_pow.rs:26:13
@ -41,8 +44,9 @@ LL | let _ = 50i32 ^ 3i32;
|
help: did you mean to write
|
LL | let _ = 50i32.pow(3i32);
| ~~~~~~~~~~~~~~~
LL - let _ = 50i32 ^ 3i32;
LL + let _ = 50i32.pow(3i32);
|
error: `^` is not the exponentiation operator
--> tests/ui/suspicious_xor_used_as_pow.rs:28:13
@ -52,8 +56,9 @@ LL | let _ = 5i32 ^ 8i32;
|
help: did you mean to write
|
LL | let _ = 5i32.pow(8i32);
| ~~~~~~~~~~~~~~
LL - let _ = 5i32 ^ 8i32;
LL + let _ = 5i32.pow(8i32);
|
error: `^` is not the exponentiation operator
--> tests/ui/suspicious_xor_used_as_pow.rs:30:13
@ -63,8 +68,9 @@ LL | let _ = 2i32 ^ 32i32;
|
help: did you mean to write
|
LL | let _ = 2i32.pow(32i32);
| ~~~~~~~~~~~~~~~
LL - let _ = 2i32 ^ 32i32;
LL + let _ = 2i32.pow(32i32);
|
error: `^` is not the exponentiation operator
--> tests/ui/suspicious_xor_used_as_pow.rs:13:9
@ -78,8 +84,9 @@ LL | macro_test_inside!();
= note: this error originates in the macro `macro_test_inside` (in Nightly builds, run with -Z macro-backtrace for more info)
help: did you mean to write
|
LL | 1.pow(2) // should warn even if inside macro
| ~~~~~~~~
LL - 1 ^ 2 // should warn even if inside macro
LL + 1.pow(2) // should warn even if inside macro
|
error: aborting due to 7 previous errors

55
src/tools/clippy/tests/ui/transmute_ptr_to_ptr.stderr
View file

@ -8,8 +8,9 @@ LL | let _: *const f32 = transmute(ptr);
= help: to override `-D warnings` add `#[allow(clippy::transmute_ptr_to_ptr)]`
help: use `pointer::cast` instead
|
LL | let _: *const f32 = ptr.cast::<f32>();
| ~~~~~~~~~~~~~~~~~
LL - let _: *const f32 = transmute(ptr);
LL + let _: *const f32 = ptr.cast::<f32>();
|
error: transmute from a pointer to a pointer
--> tests/ui/transmute_ptr_to_ptr.rs:34:27
@ -19,8 +20,9 @@ LL | let _: *mut f32 = transmute(mut_ptr);
|
help: use `pointer::cast` instead
|
LL | let _: *mut f32 = mut_ptr.cast::<f32>();
| ~~~~~~~~~~~~~~~~~~~~~
LL - let _: *mut f32 = transmute(mut_ptr);
LL + let _: *mut f32 = mut_ptr.cast::<f32>();
|
error: transmute from a reference to a reference
--> tests/ui/transmute_ptr_to_ptr.rs:37:23
@ -60,8 +62,9 @@ LL | let _: *const u32 = transmute(mut_ptr);
|
help: use `pointer::cast_const` instead
|
LL | let _: *const u32 = mut_ptr.cast_const();
| ~~~~~~~~~~~~~~~~~~~~
LL - let _: *const u32 = transmute(mut_ptr);
LL + let _: *const u32 = mut_ptr.cast_const();
|
error: transmute from a pointer to a pointer
--> tests/ui/transmute_ptr_to_ptr.rs:52:27
@ -71,8 +74,9 @@ LL | let _: *mut u32 = transmute(ptr);
|
help: use `pointer::cast_mut` instead
|
LL | let _: *mut u32 = ptr.cast_mut();
| ~~~~~~~~~~~~~~
LL - let _: *mut u32 = transmute(ptr);
LL + let _: *mut u32 = ptr.cast_mut();
|
error: transmute from a pointer to a pointer
--> tests/ui/transmute_ptr_to_ptr.rs:64:14
@ -82,8 +86,9 @@ LL | unsafe { transmute(v) }
|
help: use an `as` cast instead
|
LL | unsafe { v as *const &() }
| ~~~~~~~~~~~~~~~
LL - unsafe { transmute(v) }
LL + unsafe { v as *const &() }
|
error: transmute from a pointer to a pointer
--> tests/ui/transmute_ptr_to_ptr.rs:79:28
@ -93,8 +98,9 @@ LL | let _: *const i8 = transmute(ptr);
|
help: use an `as` cast instead
|
LL | let _: *const i8 = ptr as *const i8;
| ~~~~~~~~~~~~~~~~
LL - let _: *const i8 = transmute(ptr);
LL + let _: *const i8 = ptr as *const i8;
|
error: transmute from a pointer to a pointer
--> tests/ui/transmute_ptr_to_ptr.rs:86:28
@ -104,8 +110,9 @@ LL | let _: *const i8 = transmute(ptr);
|
help: use `pointer::cast` instead
|
LL | let _: *const i8 = ptr.cast::<i8>();
| ~~~~~~~~~~~~~~~~
LL - let _: *const i8 = transmute(ptr);
LL + let _: *const i8 = ptr.cast::<i8>();
|
error: transmute from a pointer to a pointer
--> tests/ui/transmute_ptr_to_ptr.rs:93:26
@ -115,8 +122,9 @@ LL | let _: *mut u8 = transmute(ptr);
|
help: use an `as` cast instead
|
LL | let _: *mut u8 = ptr as *mut u8;
| ~~~~~~~~~~~~~~
LL - let _: *mut u8 = transmute(ptr);
LL + let _: *mut u8 = ptr as *mut u8;
|
error: transmute from a pointer to a pointer
--> tests/ui/transmute_ptr_to_ptr.rs:94:28
@ -126,8 +134,9 @@ LL | let _: *const u8 = transmute(mut_ptr);
|
help: use an `as` cast instead
|
LL | let _: *const u8 = mut_ptr as *const u8;
| ~~~~~~~~~~~~~~~~~~~~
LL - let _: *const u8 = transmute(mut_ptr);
LL + let _: *const u8 = mut_ptr as *const u8;
|
error: transmute from a pointer to a pointer
--> tests/ui/transmute_ptr_to_ptr.rs:101:26
@ -137,8 +146,9 @@ LL | let _: *mut u8 = transmute(ptr);
|
help: use `pointer::cast_mut` instead
|
LL | let _: *mut u8 = ptr.cast_mut();
| ~~~~~~~~~~~~~~
LL - let _: *mut u8 = transmute(ptr);
LL + let _: *mut u8 = ptr.cast_mut();
|
error: transmute from a pointer to a pointer
--> tests/ui/transmute_ptr_to_ptr.rs:102:28
@ -148,8 +158,9 @@ LL | let _: *const u8 = transmute(mut_ptr);
|
help: use `pointer::cast_const` instead
|
LL | let _: *const u8 = mut_ptr.cast_const();
| ~~~~~~~~~~~~~~~~~~~~
LL - let _: *const u8 = transmute(mut_ptr);
LL + let _: *const u8 = mut_ptr.cast_const();
|
error: aborting due to 16 previous errors

10
src/tools/clippy/tests/ui/transmutes_expressible_as_ptr_casts.stderr
View file

@ -17,8 +17,9 @@ LL | let _ptr_i8_transmute = unsafe { transmute::<*const i32, *const i8>(ptr
= help: to override `-D warnings` add `#[allow(clippy::transmute_ptr_to_ptr)]`
help: use `pointer::cast` instead
|
LL | let _ptr_i8_transmute = unsafe { ptr_i32.cast::<i8>() };
| ~~~~~~~~~~~~~~~~~~~~
LL - let _ptr_i8_transmute = unsafe { transmute::<*const i32, *const i8>(ptr_i32) };
LL + let _ptr_i8_transmute = unsafe { ptr_i32.cast::<i8>() };
|
error: transmute from a pointer to a pointer
--> tests/ui/transmutes_expressible_as_ptr_casts.rs:27:46
@ -28,8 +29,9 @@ LL | let _ptr_to_unsized_transmute = unsafe { transmute::<*const [i32], *con
|
help: use an `as` cast instead
|
LL | let _ptr_to_unsized_transmute = unsafe { slice_ptr as *const [u32] };
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _ptr_to_unsized_transmute = unsafe { transmute::<*const [i32], *const [u32]>(slice_ptr) };
LL + let _ptr_to_unsized_transmute = unsafe { slice_ptr as *const [u32] };
|
error: transmute from `*const i32` to `usize` which could be expressed as a pointer cast instead
--> tests/ui/transmutes_expressible_as_ptr_casts.rs:33:50

18
src/tools/clippy/tests/ui/unit_arg.stderr
View file

@ -10,7 +10,8 @@ LL | | });
= help: to override `-D warnings` add `#[allow(clippy::unit_arg)]`
help: remove the semicolon from the last statement in the block
|
LL | 1
LL - 1;
LL + 1
|
help: or move the expression in front of the call and replace it with the unit literal `()`
|
@ -43,7 +44,8 @@ LL | | });
|
help: remove the semicolon from the last statement in the block
|
LL | foo(2)
LL - foo(2);
LL + foo(2)
|
help: or move the expression in front of the call and replace it with the unit literal `()`
|
@ -64,7 +66,8 @@ LL | | });
|
help: remove the semicolon from the last statement in the block
|
LL | 1
LL - 1;
LL + 1
|
help: or move the expression in front of the call and replace it with the unit literal `()`
|
@ -98,7 +101,8 @@ LL | | });
|
help: remove the semicolon from the last statement in the block
|
LL | foo(2)
LL - foo(2);
LL + foo(2)
|
help: or move the expressions in front of the call and replace them with the unit literal `()`
|
@ -124,11 +128,13 @@ LL | | );
|
help: remove the semicolon from the last statement in the block
|
LL | foo(1)
LL - foo(1);
LL + foo(1)
|
help: remove the semicolon from the last statement in the block
|
LL | foo(3)
LL - foo(3);
LL + foo(3)
|
help: or move the expressions in front of the call and replace them with the unit literal `()`
|

10
src/tools/clippy/tests/ui/unknown_clippy_lints.stderr
View file

@ -39,8 +39,9 @@ LL | #[warn(clippy::dead_cod)]
|
help: a lint with a similar name exists in `rustc` lints
|
LL | #[warn(dead_code)]
| ~~~~~~~~~
LL - #[warn(clippy::dead_cod)]
LL + #[warn(dead_code)]
|
error: unknown lint: `clippy::unused_colle`
--> tests/ui/unknown_clippy_lints.rs:13:8
@ -62,8 +63,9 @@ LL | #[warn(clippy::missing_docs)]
|
help: a lint with a similar name exists in `rustc` lints
|
LL | #[warn(missing_docs)]
| ~~~~~~~~~~~~
LL - #[warn(clippy::missing_docs)]
LL + #[warn(missing_docs)]
|
error: aborting due to 9 previous errors

315
src/tools/clippy/tests/ui/unnecessary_lazy_eval.stderr
View file

@ -8,8 +8,9 @@ LL | let _ = opt.unwrap_or_else(|| 2);
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_lazy_evaluations)]`
help: use `unwrap_or` instead
|
LL | let _ = opt.unwrap_or(2);
| ~~~~~~~~~~~~
LL - let _ = opt.unwrap_or_else(|| 2);
LL + let _ = opt.unwrap_or(2);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:84:13
@ -19,8 +20,9 @@ LL | let _ = opt.unwrap_or_else(|| astronomers_pi);
|
help: use `unwrap_or` instead
|
LL | let _ = opt.unwrap_or(astronomers_pi);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _ = opt.unwrap_or_else(|| astronomers_pi);
LL + let _ = opt.unwrap_or(astronomers_pi);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:85:13
@ -30,8 +32,9 @@ LL | let _ = opt.unwrap_or_else(|| ext_str.some_field);
|
help: use `unwrap_or` instead
|
LL | let _ = opt.unwrap_or(ext_str.some_field);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _ = opt.unwrap_or_else(|| ext_str.some_field);
LL + let _ = opt.unwrap_or(ext_str.some_field);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:87:13
@ -41,8 +44,9 @@ LL | let _ = opt.and_then(|_| ext_opt);
|
help: use `and` instead
|
LL | let _ = opt.and(ext_opt);
| ~~~~~~~~~~~~
LL - let _ = opt.and_then(|_| ext_opt);
LL + let _ = opt.and(ext_opt);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:88:13
@ -52,8 +56,9 @@ LL | let _ = opt.or_else(|| ext_opt);
|
help: use `or` instead
|
LL | let _ = opt.or(ext_opt);
| ~~~~~~~~~~~
LL - let _ = opt.or_else(|| ext_opt);
LL + let _ = opt.or(ext_opt);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:89:13
@ -63,8 +68,9 @@ LL | let _ = opt.or_else(|| None);
|
help: use `or` instead
|
LL | let _ = opt.or(None);
| ~~~~~~~~
LL - let _ = opt.or_else(|| None);
LL + let _ = opt.or(None);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:90:13
@ -74,8 +80,9 @@ LL | let _ = opt.get_or_insert_with(|| 2);
|
help: use `get_or_insert` instead
|
LL | let _ = opt.get_or_insert(2);
| ~~~~~~~~~~~~~~~~
LL - let _ = opt.get_or_insert_with(|| 2);
LL + let _ = opt.get_or_insert(2);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:91:13
@ -85,8 +92,9 @@ LL | let _ = opt.ok_or_else(|| 2);
|
help: use `ok_or` instead
|
LL | let _ = opt.ok_or(2);
| ~~~~~~~~
LL - let _ = opt.ok_or_else(|| 2);
LL + let _ = opt.ok_or(2);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:92:13
@ -96,8 +104,9 @@ LL | let _ = nested_tuple_opt.unwrap_or_else(|| Some((1, 2)));
|
help: use `unwrap_or` instead
|
LL | let _ = nested_tuple_opt.unwrap_or(Some((1, 2)));
| ~~~~~~~~~~~~~~~~~~~~~~~
LL - let _ = nested_tuple_opt.unwrap_or_else(|| Some((1, 2)));
LL + let _ = nested_tuple_opt.unwrap_or(Some((1, 2)));
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:93:13
@ -107,8 +116,9 @@ LL | let _ = cond.then(|| astronomers_pi);
|
help: use `then_some` instead
|
LL | let _ = cond.then_some(astronomers_pi);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _ = cond.then(|| astronomers_pi);
LL + let _ = cond.then_some(astronomers_pi);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:94:13
@ -118,8 +128,9 @@ LL | let _ = true.then(|| -> _ {});
|
help: use `then_some` instead
|
LL | let _ = true.then_some({});
| ~~~~~~~~~~~~~
LL - let _ = true.then(|| -> _ {});
LL + let _ = true.then_some({});
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:95:13
@ -129,8 +140,9 @@ LL | let _ = true.then(|| {});
|
help: use `then_some` instead
|
LL | let _ = true.then_some({});
| ~~~~~~~~~~~~~
LL - let _ = true.then(|| {});
LL + let _ = true.then_some({});
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:99:13
@ -140,8 +152,9 @@ LL | let _ = Some(1).unwrap_or_else(|| *r);
|
help: use `unwrap_or` instead
|
LL | let _ = Some(1).unwrap_or(*r);
| ~~~~~~~~~~~~~
LL - let _ = Some(1).unwrap_or_else(|| *r);
LL + let _ = Some(1).unwrap_or(*r);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:101:13
@ -151,8 +164,9 @@ LL | let _ = Some(1).unwrap_or_else(|| *b);
|
help: use `unwrap_or` instead
|
LL | let _ = Some(1).unwrap_or(*b);
| ~~~~~~~~~~~~~
LL - let _ = Some(1).unwrap_or_else(|| *b);
LL + let _ = Some(1).unwrap_or(*b);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:103:13
@ -162,8 +176,9 @@ LL | let _ = Some(1).as_ref().unwrap_or_else(|| &r);
|
help: use `unwrap_or` instead
|
LL | let _ = Some(1).as_ref().unwrap_or(&r);
| ~~~~~~~~~~~~~
LL - let _ = Some(1).as_ref().unwrap_or_else(|| &r);
LL + let _ = Some(1).as_ref().unwrap_or(&r);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:104:13
@ -173,8 +188,9 @@ LL | let _ = Some(1).as_ref().unwrap_or_else(|| &b);
|
help: use `unwrap_or` instead
|
LL | let _ = Some(1).as_ref().unwrap_or(&b);
| ~~~~~~~~~~~~~
LL - let _ = Some(1).as_ref().unwrap_or_else(|| &b);
LL + let _ = Some(1).as_ref().unwrap_or(&b);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:107:13
@ -184,8 +200,9 @@ LL | let _ = Some(10).unwrap_or_else(|| 2);
|
help: use `unwrap_or` instead
|
LL | let _ = Some(10).unwrap_or(2);
| ~~~~~~~~~~~~
LL - let _ = Some(10).unwrap_or_else(|| 2);
LL + let _ = Some(10).unwrap_or(2);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:108:13
@ -195,8 +212,9 @@ LL | let _ = Some(10).and_then(|_| ext_opt);
|
help: use `and` instead
|
LL | let _ = Some(10).and(ext_opt);
| ~~~~~~~~~~~~
LL - let _ = Some(10).and_then(|_| ext_opt);
LL + let _ = Some(10).and(ext_opt);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:109:28
@ -206,8 +224,9 @@ LL | let _: Option<usize> = None.or_else(|| ext_opt);
|
help: use `or` instead
|
LL | let _: Option<usize> = None.or(ext_opt);
| ~~~~~~~~~~~
LL - let _: Option<usize> = None.or_else(|| ext_opt);
LL + let _: Option<usize> = None.or(ext_opt);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:110:13
@ -217,8 +236,9 @@ LL | let _ = None.get_or_insert_with(|| 2);
|
help: use `get_or_insert` instead
|
LL | let _ = None.get_or_insert(2);
| ~~~~~~~~~~~~~~~~
LL - let _ = None.get_or_insert_with(|| 2);
LL + let _ = None.get_or_insert(2);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:111:35
@ -228,8 +248,9 @@ LL | let _: Result<usize, usize> = None.ok_or_else(|| 2);
|
help: use `ok_or` instead
|
LL | let _: Result<usize, usize> = None.ok_or(2);
| ~~~~~~~~
LL - let _: Result<usize, usize> = None.ok_or_else(|| 2);
LL + let _: Result<usize, usize> = None.ok_or(2);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:112:28
@ -239,8 +260,9 @@ LL | let _: Option<usize> = None.or_else(|| None);
|
help: use `or` instead
|
LL | let _: Option<usize> = None.or(None);
| ~~~~~~~~
LL - let _: Option<usize> = None.or_else(|| None);
LL + let _: Option<usize> = None.or(None);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:115:13
@ -250,8 +272,9 @@ LL | let _ = deep.0.unwrap_or_else(|| 2);
|
help: use `unwrap_or` instead
|
LL | let _ = deep.0.unwrap_or(2);
| ~~~~~~~~~~~~
LL - let _ = deep.0.unwrap_or_else(|| 2);
LL + let _ = deep.0.unwrap_or(2);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:116:13
@ -261,8 +284,9 @@ LL | let _ = deep.0.and_then(|_| ext_opt);
|
help: use `and` instead
|
LL | let _ = deep.0.and(ext_opt);
| ~~~~~~~~~~~~
LL - let _ = deep.0.and_then(|_| ext_opt);
LL + let _ = deep.0.and(ext_opt);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:117:13
@ -272,8 +296,9 @@ LL | let _ = deep.0.or_else(|| None);
|
help: use `or` instead
|
LL | let _ = deep.0.or(None);
| ~~~~~~~~
LL - let _ = deep.0.or_else(|| None);
LL + let _ = deep.0.or(None);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:118:13
@ -283,8 +308,9 @@ LL | let _ = deep.0.get_or_insert_with(|| 2);
|
help: use `get_or_insert` instead
|
LL | let _ = deep.0.get_or_insert(2);
| ~~~~~~~~~~~~~~~~
LL - let _ = deep.0.get_or_insert_with(|| 2);
LL + let _ = deep.0.get_or_insert(2);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:119:13
@ -294,8 +320,9 @@ LL | let _ = deep.0.ok_or_else(|| 2);
|
help: use `ok_or` instead
|
LL | let _ = deep.0.ok_or(2);
| ~~~~~~~~
LL - let _ = deep.0.ok_or_else(|| 2);
LL + let _ = deep.0.ok_or(2);
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:150:28
@ -305,8 +332,9 @@ LL | let _: Option<usize> = None.or_else(|| Some(3));
|
help: use `or` instead
|
LL | let _: Option<usize> = None.or(Some(3));
| ~~~~~~~~~~~
LL - let _: Option<usize> = None.or_else(|| Some(3));
LL + let _: Option<usize> = None.or(Some(3));
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:151:13
@ -316,8 +344,9 @@ LL | let _ = deep.0.or_else(|| Some(3));
|
help: use `or` instead
|
LL | let _ = deep.0.or(Some(3));
| ~~~~~~~~~~~
LL - let _ = deep.0.or_else(|| Some(3));
LL + let _ = deep.0.or(Some(3));
|
error: unnecessary closure used to substitute value for `Option::None`
--> tests/ui/unnecessary_lazy_eval.rs:152:13
@ -327,8 +356,9 @@ LL | let _ = opt.or_else(|| Some(3));
|
help: use `or` instead
|
LL | let _ = opt.or(Some(3));
| ~~~~~~~~~~~
LL - let _ = opt.or_else(|| Some(3));
LL + let _ = opt.or(Some(3));
|
error: unnecessary closure used to substitute value for `Result::Err`
--> tests/ui/unnecessary_lazy_eval.rs:158:13
@ -338,8 +368,9 @@ LL | let _ = res2.unwrap_or_else(|_| 2);
|
help: use `unwrap_or` instead
|
LL | let _ = res2.unwrap_or(2);
| ~~~~~~~~~~~~
LL - let _ = res2.unwrap_or_else(|_| 2);
LL + let _ = res2.unwrap_or(2);
|
error: unnecessary closure used to substitute value for `Result::Err`
--> tests/ui/unnecessary_lazy_eval.rs:159:13
@ -349,8 +380,9 @@ LL | let _ = res2.unwrap_or_else(|_| astronomers_pi);
|
help: use `unwrap_or` instead
|
LL | let _ = res2.unwrap_or(astronomers_pi);
| ~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _ = res2.unwrap_or_else(|_| astronomers_pi);
LL + let _ = res2.unwrap_or(astronomers_pi);
|
error: unnecessary closure used to substitute value for `Result::Err`
--> tests/ui/unnecessary_lazy_eval.rs:160:13
@ -360,8 +392,9 @@ LL | let _ = res2.unwrap_or_else(|_| ext_str.some_field);
|
help: use `unwrap_or` instead
|
LL | let _ = res2.unwrap_or(ext_str.some_field);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _ = res2.unwrap_or_else(|_| ext_str.some_field);
LL + let _ = res2.unwrap_or(ext_str.some_field);
|
error: unnecessary closure used to substitute value for `Result::Err`
--> tests/ui/unnecessary_lazy_eval.rs:182:35
@ -371,8 +404,9 @@ LL | let _: Result<usize, usize> = res.and_then(|_| Err(2));
|
help: use `and` instead
|
LL | let _: Result<usize, usize> = res.and(Err(2));
| ~~~~~~~~~~~
LL - let _: Result<usize, usize> = res.and_then(|_| Err(2));
LL + let _: Result<usize, usize> = res.and(Err(2));
|
error: unnecessary closure used to substitute value for `Result::Err`
--> tests/ui/unnecessary_lazy_eval.rs:183:35
@ -382,8 +416,9 @@ LL | let _: Result<usize, usize> = res.and_then(|_| Err(astronomers_pi));
|
help: use `and` instead
|
LL | let _: Result<usize, usize> = res.and(Err(astronomers_pi));
| ~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _: Result<usize, usize> = res.and_then(|_| Err(astronomers_pi));
LL + let _: Result<usize, usize> = res.and(Err(astronomers_pi));
|
error: unnecessary closure used to substitute value for `Result::Err`
--> tests/ui/unnecessary_lazy_eval.rs:184:35
@ -393,8 +428,9 @@ LL | let _: Result<usize, usize> = res.and_then(|_| Err(ext_str.some_field))
|
help: use `and` instead
|
LL | let _: Result<usize, usize> = res.and(Err(ext_str.some_field));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _: Result<usize, usize> = res.and_then(|_| Err(ext_str.some_field));
LL + let _: Result<usize, usize> = res.and(Err(ext_str.some_field));
|
error: unnecessary closure used to substitute value for `Result::Err`
--> tests/ui/unnecessary_lazy_eval.rs:186:35
@ -404,8 +440,9 @@ LL | let _: Result<usize, usize> = res.or_else(|_| Ok(2));
|
help: use `or` instead
|
LL | let _: Result<usize, usize> = res.or(Ok(2));
| ~~~~~~~~~
LL - let _: Result<usize, usize> = res.or_else(|_| Ok(2));
LL + let _: Result<usize, usize> = res.or(Ok(2));
|
error: unnecessary closure used to substitute value for `Result::Err`
--> tests/ui/unnecessary_lazy_eval.rs:187:35
@ -415,8 +452,9 @@ LL | let _: Result<usize, usize> = res.or_else(|_| Ok(astronomers_pi));
|
help: use `or` instead
|
LL | let _: Result<usize, usize> = res.or(Ok(astronomers_pi));
| ~~~~~~~~~~~~~~~~~~~~~~
LL - let _: Result<usize, usize> = res.or_else(|_| Ok(astronomers_pi));
LL + let _: Result<usize, usize> = res.or(Ok(astronomers_pi));
|
error: unnecessary closure used to substitute value for `Result::Err`
--> tests/ui/unnecessary_lazy_eval.rs:188:35
@ -426,8 +464,9 @@ LL | let _: Result<usize, usize> = res.or_else(|_| Ok(ext_str.some_field));
|
help: use `or` instead
|
LL | let _: Result<usize, usize> = res.or(Ok(ext_str.some_field));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _: Result<usize, usize> = res.or_else(|_| Ok(ext_str.some_field));
LL + let _: Result<usize, usize> = res.or(Ok(ext_str.some_field));
|
error: unnecessary closure used to substitute value for `Result::Err`
--> tests/ui/unnecessary_lazy_eval.rs:189:35
@ -440,8 +479,9 @@ LL | | or_else(|_| Ok(ext_str.some_field));
|
help: use `or` instead
|
LL | or(Ok(ext_str.some_field));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - or_else(|_| Ok(ext_str.some_field));
LL + or(Ok(ext_str.some_field));
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:219:14
@ -451,8 +491,9 @@ LL | let _x = false.then(|| i32::MAX + 1);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(i32::MAX + 1);
| ~~~~~~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| i32::MAX + 1);
LL + let _x = false.then_some(i32::MAX + 1);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:221:14
@ -462,8 +503,9 @@ LL | let _x = false.then(|| i32::MAX * 2);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(i32::MAX * 2);
| ~~~~~~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| i32::MAX * 2);
LL + let _x = false.then_some(i32::MAX * 2);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:223:14
@ -473,8 +515,9 @@ LL | let _x = false.then(|| i32::MAX - 1);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(i32::MAX - 1);
| ~~~~~~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| i32::MAX - 1);
LL + let _x = false.then_some(i32::MAX - 1);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:225:14
@ -484,8 +527,9 @@ LL | let _x = false.then(|| i32::MIN - 1);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(i32::MIN - 1);
| ~~~~~~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| i32::MIN - 1);
LL + let _x = false.then_some(i32::MIN - 1);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:227:14
@ -495,8 +539,9 @@ LL | let _x = false.then(|| (1 + 2 * 3 - 2 / 3 + 9) << 2);
|
help: use `then_some` instead
|
LL | let _x = false.then_some((1 + 2 * 3 - 2 / 3 + 9) << 2);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| (1 + 2 * 3 - 2 / 3 + 9) << 2);
LL + let _x = false.then_some((1 + 2 * 3 - 2 / 3 + 9) << 2);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:229:14
@ -506,8 +551,9 @@ LL | let _x = false.then(|| 255u8 << 7);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(255u8 << 7);
| ~~~~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| 255u8 << 7);
LL + let _x = false.then_some(255u8 << 7);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:231:14
@ -517,8 +563,9 @@ LL | let _x = false.then(|| 255u8 << 8);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(255u8 << 8);
| ~~~~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| 255u8 << 8);
LL + let _x = false.then_some(255u8 << 8);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:233:14
@ -528,8 +575,9 @@ LL | let _x = false.then(|| 255u8 >> 8);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(255u8 >> 8);
| ~~~~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| 255u8 >> 8);
LL + let _x = false.then_some(255u8 >> 8);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:236:14
@ -539,8 +587,9 @@ LL | let _x = false.then(|| i32::MAX + -1);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(i32::MAX + -1);
| ~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| i32::MAX + -1);
LL + let _x = false.then_some(i32::MAX + -1);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:238:14
@ -550,8 +599,9 @@ LL | let _x = false.then(|| -i32::MAX);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(-i32::MAX);
| ~~~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| -i32::MAX);
LL + let _x = false.then_some(-i32::MAX);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:240:14
@ -561,8 +611,9 @@ LL | let _x = false.then(|| -i32::MIN);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(-i32::MIN);
| ~~~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| -i32::MIN);
LL + let _x = false.then_some(-i32::MIN);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:243:14
@ -572,8 +623,9 @@ LL | let _x = false.then(|| 255 >> -7);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(255 >> -7);
| ~~~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| 255 >> -7);
LL + let _x = false.then_some(255 >> -7);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:245:14
@ -583,8 +635,9 @@ LL | let _x = false.then(|| 255 << -1);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(255 << -1);
| ~~~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| 255 << -1);
LL + let _x = false.then_some(255 << -1);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:247:14
@ -594,8 +647,9 @@ LL | let _x = false.then(|| 1 / 0);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(1 / 0);
| ~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| 1 / 0);
LL + let _x = false.then_some(1 / 0);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:249:14
@ -605,8 +659,9 @@ LL | let _x = false.then(|| x << -1);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(x << -1);
| ~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| x << -1);
LL + let _x = false.then_some(x << -1);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:251:14
@ -616,8 +671,9 @@ LL | let _x = false.then(|| x << 2);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(x << 2);
| ~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| x << 2);
LL + let _x = false.then_some(x << 2);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:261:14
@ -627,8 +683,9 @@ LL | let _x = false.then(|| x / 0);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(x / 0);
| ~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| x / 0);
LL + let _x = false.then_some(x / 0);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:263:14
@ -638,8 +695,9 @@ LL | let _x = false.then(|| x % 0);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(x % 0);
| ~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| x % 0);
LL + let _x = false.then_some(x % 0);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:266:14
@ -649,8 +707,9 @@ LL | let _x = false.then(|| 1 / -1);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(1 / -1);
| ~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| 1 / -1);
LL + let _x = false.then_some(1 / -1);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:268:14
@ -660,8 +719,9 @@ LL | let _x = false.then(|| i32::MIN / -1);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(i32::MIN / -1);
| ~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| i32::MIN / -1);
LL + let _x = false.then_some(i32::MIN / -1);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:271:14
@ -671,8 +731,9 @@ LL | let _x = false.then(|| i32::MIN / 0);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(i32::MIN / 0);
| ~~~~~~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| i32::MIN / 0);
LL + let _x = false.then_some(i32::MIN / 0);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:273:14
@ -682,8 +743,9 @@ LL | let _x = false.then(|| 4 / 2);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(4 / 2);
| ~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| 4 / 2);
LL + let _x = false.then_some(4 / 2);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval.rs:281:14
@ -693,8 +755,9 @@ LL | let _x = false.then(|| f1 + f2);
|
help: use `then_some` instead
|
LL | let _x = false.then_some(f1 + f2);
| ~~~~~~~~~~~~~~~~~~
LL - let _x = false.then(|| f1 + f2);
LL + let _x = false.then_some(f1 + f2);
|
error: aborting due to 63 previous errors

20
src/tools/clippy/tests/ui/unnecessary_lazy_eval_unfixable.stderr
View file

@ -8,8 +8,9 @@ LL | let _ = Ok(1).unwrap_or_else(|()| 2);
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_lazy_evaluations)]`
help: use `unwrap_or` instead
|
LL | let _ = Ok(1).unwrap_or(2);
| ~~~~~~~~~~~~
LL - let _ = Ok(1).unwrap_or_else(|()| 2);
LL + let _ = Ok(1).unwrap_or(2);
|
error: unnecessary closure used to substitute value for `Result::Err`
--> tests/ui/unnecessary_lazy_eval_unfixable.rs:19:13
@ -19,8 +20,9 @@ LL | let _ = Ok(1).unwrap_or_else(|e::E| 2);
|
help: use `unwrap_or` instead
|
LL | let _ = Ok(1).unwrap_or(2);
| ~~~~~~~~~~~~
LL - let _ = Ok(1).unwrap_or_else(|e::E| 2);
LL + let _ = Ok(1).unwrap_or(2);
|
error: unnecessary closure used to substitute value for `Result::Err`
--> tests/ui/unnecessary_lazy_eval_unfixable.rs:21:13
@ -30,8 +32,9 @@ LL | let _ = Ok(1).unwrap_or_else(|SomeStruct { .. }| 2);
|
help: use `unwrap_or` instead
|
LL | let _ = Ok(1).unwrap_or(2);
| ~~~~~~~~~~~~
LL - let _ = Ok(1).unwrap_or_else(|SomeStruct { .. }| 2);
LL + let _ = Ok(1).unwrap_or(2);
|
error: unnecessary closure used with `bool::then`
--> tests/ui/unnecessary_lazy_eval_unfixable.rs:31:13
@ -41,8 +44,9 @@ LL | let _ = true.then(|| -> &[u8] { &[] });
|
help: use `then_some` instead
|
LL | let _ = true.then_some({ &[] });
| ~~~~~~~~~~~~~~~~~~
LL - let _ = true.then(|| -> &[u8] { &[] });
LL + let _ = true.then_some({ &[] });
|
error: aborting due to 4 previous errors

50
src/tools/clippy/tests/ui/unnecessary_literal_unwrap.stderr
View file

@ -62,8 +62,9 @@ LL | let _val = None::<()>.expect("this always happens");
|
help: remove the `None` and `expect()`
|
LL | let _val = panic!("this always happens");
| ~~~~~~~
LL - let _val = None::<()>.expect("this always happens");
LL + let _val = panic!("this always happens");
|
error: used `unwrap_or_default()` on `None` value
--> tests/ui/unnecessary_literal_unwrap.rs:22:24
@ -133,8 +134,9 @@ LL | None::<()>.expect("this always happens");
|
help: remove the `None` and `expect()`
|
LL | panic!("this always happens");
| ~~~~~~~
LL - None::<()>.expect("this always happens");
LL + panic!("this always happens");
|
error: used `unwrap_or_default()` on `None` value
--> tests/ui/unnecessary_literal_unwrap.rs:30:5
@ -222,8 +224,9 @@ LL | let _val = Ok::<_, ()>(1).unwrap_err();
|
help: remove the `Ok` and `unwrap_err()`
|
LL | let _val = panic!("{:?}", 1);
| ~~~~~~~~~~~~~~ ~
LL - let _val = Ok::<_, ()>(1).unwrap_err();
LL + let _val = panic!("{:?}", 1);
|
error: used `expect_err()` on `Ok` value
--> tests/ui/unnecessary_literal_unwrap.rs:41:16
@ -233,8 +236,9 @@ LL | let _val = Ok::<_, ()>(1).expect_err("this always happens");
|
help: remove the `Ok` and `expect_err()`
|
LL | let _val = panic!("{1}: {:?}", 1, "this always happens");
| ~~~~~~~~~~~~~~~~~~~ ~
LL - let _val = Ok::<_, ()>(1).expect_err("this always happens");
LL + let _val = panic!("{1}: {:?}", 1, "this always happens");
|
error: used `unwrap()` on `Ok` value
--> tests/ui/unnecessary_literal_unwrap.rs:43:5
@ -268,8 +272,9 @@ LL | Ok::<_, ()>(1).unwrap_err();
|
help: remove the `Ok` and `unwrap_err()`
|
LL | panic!("{:?}", 1);
| ~~~~~~~~~~~~~~ ~
LL - Ok::<_, ()>(1).unwrap_err();
LL + panic!("{:?}", 1);
|
error: used `expect_err()` on `Ok` value
--> tests/ui/unnecessary_literal_unwrap.rs:46:5
@ -279,8 +284,9 @@ LL | Ok::<_, ()>(1).expect_err("this always happens");
|
help: remove the `Ok` and `expect_err()`
|
LL | panic!("{1}: {:?}", 1, "this always happens");
| ~~~~~~~~~~~~~~~~~~~ ~
LL - Ok::<_, ()>(1).expect_err("this always happens");
LL + panic!("{1}: {:?}", 1, "this always happens");
|
error: used `unwrap_err()` on `Err` value
--> tests/ui/unnecessary_literal_unwrap.rs:50:16
@ -314,8 +320,9 @@ LL | let _val = Err::<(), _>(1).unwrap();
|
help: remove the `Err` and `unwrap()`
|
LL | let _val = panic!("{:?}", 1);
| ~~~~~~~~~~~~~~ ~
LL - let _val = Err::<(), _>(1).unwrap();
LL + let _val = panic!("{:?}", 1);
|
error: used `expect()` on `Err` value
--> tests/ui/unnecessary_literal_unwrap.rs:53:16
@ -325,8 +332,9 @@ LL | let _val = Err::<(), _>(1).expect("this always happens");
|
help: remove the `Err` and `expect()`
|
LL | let _val = panic!("{1}: {:?}", 1, "this always happens");
| ~~~~~~~~~~~~~~~~~~~ ~
LL - let _val = Err::<(), _>(1).expect("this always happens");
LL + let _val = panic!("{1}: {:?}", 1, "this always happens");
|
error: used `unwrap_err()` on `Err` value
--> tests/ui/unnecessary_literal_unwrap.rs:55:5
@ -360,8 +368,9 @@ LL | Err::<(), _>(1).unwrap();
|
help: remove the `Err` and `unwrap()`
|
LL | panic!("{:?}", 1);
| ~~~~~~~~~~~~~~ ~
LL - Err::<(), _>(1).unwrap();
LL + panic!("{:?}", 1);
|
error: used `expect()` on `Err` value
--> tests/ui/unnecessary_literal_unwrap.rs:58:5
@ -371,8 +380,9 @@ LL | Err::<(), _>(1).expect("this always happens");
|
help: remove the `Err` and `expect()`
|
LL | panic!("{1}: {:?}", 1, "this always happens");
| ~~~~~~~~~~~~~~~~~~~ ~
LL - Err::<(), _>(1).expect("this always happens");
LL + panic!("{1}: {:?}", 1, "this always happens");
|
error: used `unwrap_or()` on `Some` value
--> tests/ui/unnecessary_literal_unwrap.rs:62:16

48
src/tools/clippy/tests/ui/unnecessary_map_or.stderr
View file

@ -8,8 +8,9 @@ LL | let _ = Some(5).map_or(false, |n| n == 5);
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_map_or)]`
help: use a standard comparison instead
|
LL | let _ = Some(5) == Some(5);
| ~~~~~~~~~~~~~~~~~~
LL - let _ = Some(5).map_or(false, |n| n == 5);
LL + let _ = Some(5) == Some(5);
|
error: this `map_or` can be simplified
--> tests/ui/unnecessary_map_or.rs:14:13
@ -19,8 +20,9 @@ LL | let _ = Some(5).map_or(true, |n| n != 5);
|
help: use a standard comparison instead
|
LL | let _ = Some(5) != Some(5);
| ~~~~~~~~~~~~~~~~~~
LL - let _ = Some(5).map_or(true, |n| n != 5);
LL + let _ = Some(5) != Some(5);
|
error: this `map_or` can be simplified
--> tests/ui/unnecessary_map_or.rs:15:13
@ -34,8 +36,12 @@ LL | | });
|
help: use a standard comparison instead
|
LL | let _ = Some(5) == Some(5);
| ~~~~~~~~~~~~~~~~~~
LL - let _ = Some(5).map_or(false, |n| {
LL - let _ = 1;
LL - n == 5
LL - });
LL + let _ = Some(5) == Some(5);
|
error: this `map_or` can be simplified
--> tests/ui/unnecessary_map_or.rs:19:13
@ -121,8 +127,9 @@ LL | let _ = Ok::<i32, i32>(5).map_or(false, |n| n == 5);
|
help: use a standard comparison instead
|
LL | let _ = Ok::<i32, i32>(5) == Ok(5);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - let _ = Ok::<i32, i32>(5).map_or(false, |n| n == 5);
LL + let _ = Ok::<i32, i32>(5) == Ok(5);
|
error: this `map_or` can be simplified
--> tests/ui/unnecessary_map_or.rs:29:13
@ -132,8 +139,9 @@ LL | let _ = Some(5).map_or(false, |n| n == 5).then(|| 1);
|
help: use a standard comparison instead
|
LL | let _ = (Some(5) == Some(5)).then(|| 1);
| ~~~~~~~~~~~~~~~~~~~~
LL - let _ = Some(5).map_or(false, |n| n == 5).then(|| 1);
LL + let _ = (Some(5) == Some(5)).then(|| 1);
|
error: this `map_or` can be simplified
--> tests/ui/unnecessary_map_or.rs:30:13
@ -167,8 +175,9 @@ LL | let _ = !Some(5).map_or(false, |n| n == 5);
|
help: use a standard comparison instead
|
LL | let _ = !(Some(5) == Some(5));
| ~~~~~~~~~~~~~~~~~~~~
LL - let _ = !Some(5).map_or(false, |n| n == 5);
LL + let _ = !(Some(5) == Some(5));
|
error: this `map_or` can be simplified
--> tests/ui/unnecessary_map_or.rs:33:13
@ -178,8 +187,9 @@ LL | let _ = Some(5).map_or(false, |n| n == 5) || false;
|
help: use a standard comparison instead
|
LL | let _ = (Some(5) == Some(5)) || false;
| ~~~~~~~~~~~~~~~~~~~~
LL - let _ = Some(5).map_or(false, |n| n == 5) || false;
LL + let _ = (Some(5) == Some(5)) || false;
|
error: this `map_or` can be simplified
--> tests/ui/unnecessary_map_or.rs:34:13
@ -189,8 +199,9 @@ LL | let _ = Some(5).map_or(false, |n| n == 5) as usize;
|
help: use a standard comparison instead
|
LL | let _ = (Some(5) == Some(5)) as usize;
| ~~~~~~~~~~~~~~~~~~~~
LL - let _ = Some(5).map_or(false, |n| n == 5) as usize;
LL + let _ = (Some(5) == Some(5)) as usize;
|
error: this `map_or` can be simplified
--> tests/ui/unnecessary_map_or.rs:58:13
@ -248,8 +259,9 @@ LL | let _ = r.map_or(false, |x| x == 8);
|
help: use a standard comparison instead
|
LL | let _ = r == Ok(8);
| ~~~~~~~~~~
LL - let _ = r.map_or(false, |x| x == 8);
LL + let _ = r == Ok(8);
|
error: this `map_or` can be simplified
--> tests/ui/unnecessary_map_or.rs:90:5

44
src/tools/clippy/tests/ui/unnecessary_wraps.stderr
View file

@ -13,8 +13,9 @@ LL | | }
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_wraps)]`
help: remove `Option` from the return type...
|
LL | fn func1(a: bool, b: bool) -> i32 {
| ~~~
LL - fn func1(a: bool, b: bool) -> Option<i32> {
LL + fn func1(a: bool, b: bool) -> i32 {
|
help: ...and then change returning expressions
|
LL ~ return 42;
@ -40,8 +41,9 @@ LL | | }
|
help: remove `Option` from the return type...
|
LL | fn func2(a: bool, b: bool) -> i32 {
| ~~~
LL - fn func2(a: bool, b: bool) -> Option<i32> {
LL + fn func2(a: bool, b: bool) -> i32 {
|
help: ...and then change returning expressions
|
LL ~ return 10;
@ -60,11 +62,13 @@ LL | | }
|
help: remove `Option` from the return type...
|
LL | fn func5() -> i32 {
| ~~~
LL - fn func5() -> Option<i32> {
LL + fn func5() -> i32 {
|
help: ...and then change returning expressions
|
LL | 1
LL - Some(1)
LL + 1
|
error: this function's return value is unnecessarily wrapped by `Result`
@ -78,11 +82,13 @@ LL | | }
|
help: remove `Result` from the return type...
|
LL | fn func7() -> i32 {
| ~~~
LL - fn func7() -> Result<i32, ()> {
LL + fn func7() -> i32 {
|
help: ...and then change returning expressions
|
LL | 1
LL - Ok(1)
LL + 1
|
error: this function's return value is unnecessarily wrapped by `Option`
@ -96,11 +102,13 @@ LL | | }
|
help: remove `Option` from the return type...
|
LL | fn func12() -> i32 {
| ~~~
LL - fn func12() -> Option<i32> {
LL + fn func12() -> i32 {
|
help: ...and then change returning expressions
|
LL | 1
LL - Some(1)
LL + 1
|
error: this function's return value is unnecessary
@ -116,8 +124,9 @@ LL | | }
|
help: remove the return type...
|
LL | fn issue_6640_1(a: bool, b: bool) -> () {
| ~~
LL - fn issue_6640_1(a: bool, b: bool) -> Option<()> {
LL + fn issue_6640_1(a: bool, b: bool) -> () {
|
help: ...and then remove returned values
|
LL ~ return ;
@ -142,8 +151,9 @@ LL | | }
|
help: remove the return type...
|
LL | fn issue_6640_2(a: bool, b: bool) -> () {
| ~~
LL - fn issue_6640_2(a: bool, b: bool) -> Result<(), i32> {
LL + fn issue_6640_2(a: bool, b: bool) -> () {
|
help: ...and then remove returned values
|
LL ~ return ;

85
src/tools/clippy/tests/ui/unnested_or_patterns.stderr
View file

@ -8,8 +8,9 @@ LL | if let box 0 | box 2 = Box::new(0) {}
= help: to override `-D warnings` add `#[allow(clippy::unnested_or_patterns)]`
help: nest the patterns
|
LL | if let box (0 | 2) = Box::new(0) {}
| ~~~~~~~~~~~
LL - if let box 0 | box 2 = Box::new(0) {}
LL + if let box (0 | 2) = Box::new(0) {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:17:12
@ -19,8 +20,9 @@ LL | if let box ((0 | 1)) | box (2 | 3) | box 4 = Box::new(0) {}
|
help: nest the patterns
|
LL | if let box (0 | 1 | 2 | 3 | 4) = Box::new(0) {}
| ~~~~~~~~~~~~~~~~~~~~~~~
LL - if let box ((0 | 1)) | box (2 | 3) | box 4 = Box::new(0) {}
LL + if let box (0 | 1 | 2 | 3 | 4) = Box::new(0) {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:19:12
@ -30,8 +32,9 @@ LL | if let Some(1) | C0 | Some(2) = None {}
|
help: nest the patterns
|
LL | if let Some(1 | 2) | C0 = None {}
| ~~~~~~~~~~~~~~~~
LL - if let Some(1) | C0 | Some(2) = None {}
LL + if let Some(1 | 2) | C0 = None {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:20:12
@ -41,8 +44,9 @@ LL | if let &mut 0 | &mut 2 = &mut 0 {}
|
help: nest the patterns
|
LL | if let &mut (0 | 2) = &mut 0 {}
| ~~~~~~~~~~~~
LL - if let &mut 0 | &mut 2 = &mut 0 {}
LL + if let &mut (0 | 2) = &mut 0 {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:21:12
@ -52,8 +56,9 @@ LL | if let x @ 0 | x @ 2 = 0 {}
|
help: nest the patterns
|
LL | if let x @ (0 | 2) = 0 {}
| ~~~~~~~~~~~
LL - if let x @ 0 | x @ 2 = 0 {}
LL + if let x @ (0 | 2) = 0 {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:22:12
@ -63,8 +68,9 @@ LL | if let (0, 1) | (0, 2) | (0, 3) = (0, 0) {}
|
help: nest the patterns
|
LL | if let (0, 1 | 2 | 3) = (0, 0) {}
| ~~~~~~~~~~~~~~
LL - if let (0, 1) | (0, 2) | (0, 3) = (0, 0) {}
LL + if let (0, 1 | 2 | 3) = (0, 0) {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:23:12
@ -74,8 +80,9 @@ LL | if let (1, 0) | (2, 0) | (3, 0) = (0, 0) {}
|
help: nest the patterns
|
LL | if let (1 | 2 | 3, 0) = (0, 0) {}
| ~~~~~~~~~~~~~~
LL - if let (1, 0) | (2, 0) | (3, 0) = (0, 0) {}
LL + if let (1 | 2 | 3, 0) = (0, 0) {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:24:12
@ -85,8 +92,9 @@ LL | if let (x, ..) | (x, 1) | (x, 2) = (0, 1) {}
|
help: nest the patterns
|
LL | if let (x, ..) | (x, 1 | 2) = (0, 1) {}
| ~~~~~~~~~~~~~~~~~~~~
LL - if let (x, ..) | (x, 1) | (x, 2) = (0, 1) {}
LL + if let (x, ..) | (x, 1 | 2) = (0, 1) {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:25:12
@ -96,8 +104,9 @@ LL | if let [0] | [1] = [0] {}
|
help: nest the patterns
|
LL | if let [0 | 1] = [0] {}
| ~~~~~~~
LL - if let [0] | [1] = [0] {}
LL + if let [0 | 1] = [0] {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:26:12
@ -107,8 +116,9 @@ LL | if let [x, 0] | [x, 1] = [0, 1] {}
|
help: nest the patterns
|
LL | if let [x, 0 | 1] = [0, 1] {}
| ~~~~~~~~~~
LL - if let [x, 0] | [x, 1] = [0, 1] {}
LL + if let [x, 0 | 1] = [0, 1] {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:27:12
@ -118,8 +128,9 @@ LL | if let [x, 0] | [x, 1] | [x, 2] = [0, 1] {}
|
help: nest the patterns
|
LL | if let [x, 0 | 1 | 2] = [0, 1] {}
| ~~~~~~~~~~~~~~
LL - if let [x, 0] | [x, 1] | [x, 2] = [0, 1] {}
LL + if let [x, 0 | 1 | 2] = [0, 1] {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:28:12
@ -129,8 +140,9 @@ LL | if let [x, ..] | [x, 1] | [x, 2] = [0, 1] {}
|
help: nest the patterns
|
LL | if let [x, ..] | [x, 1 | 2] = [0, 1] {}
| ~~~~~~~~~~~~~~~~~~~~
LL - if let [x, ..] | [x, 1] | [x, 2] = [0, 1] {}
LL + if let [x, ..] | [x, 1 | 2] = [0, 1] {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:30:12
@ -140,8 +152,9 @@ LL | if let TS(0, x) | TS(1, x) = TS(0, 0) {}
|
help: nest the patterns
|
LL | if let TS(0 | 1, x) = TS(0, 0) {}
| ~~~~~~~~~~~~
LL - if let TS(0, x) | TS(1, x) = TS(0, 0) {}
LL + if let TS(0 | 1, x) = TS(0, 0) {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:31:12
@ -151,8 +164,9 @@ LL | if let TS(1, 0) | TS(2, 0) | TS(3, 0) = TS(0, 0) {}
|
help: nest the patterns
|
LL | if let TS(1 | 2 | 3, 0) = TS(0, 0) {}
| ~~~~~~~~~~~~~~~~
LL - if let TS(1, 0) | TS(2, 0) | TS(3, 0) = TS(0, 0) {}
LL + if let TS(1 | 2 | 3, 0) = TS(0, 0) {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:32:12
@ -162,8 +176,9 @@ LL | if let TS(x, ..) | TS(x, 1) | TS(x, 2) = TS(0, 0) {}
|
help: nest the patterns
|
LL | if let TS(x, ..) | TS(x, 1 | 2) = TS(0, 0) {}
| ~~~~~~~~~~~~~~~~~~~~~~~~
LL - if let TS(x, ..) | TS(x, 1) | TS(x, 2) = TS(0, 0) {}
LL + if let TS(x, ..) | TS(x, 1 | 2) = TS(0, 0) {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:37:12
@ -173,8 +188,9 @@ LL | if let S { x: 0, y } | S { y, x: 1 } = (S { x: 0, y: 1 }) {}
|
help: nest the patterns
|
LL | if let S { x: 0 | 1, y } = (S { x: 0, y: 1 }) {}
| ~~~~~~~~~~~~~~~~~
LL - if let S { x: 0, y } | S { y, x: 1 } = (S { x: 0, y: 1 }) {}
LL + if let S { x: 0 | 1, y } = (S { x: 0, y: 1 }) {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns.rs:48:12
@ -184,8 +200,9 @@ LL | if let [1] | [53] = [0] {}
|
help: nest the patterns
|
LL | if let [1 | 53] = [0] {}
| ~~~~~~~~
LL - if let [1] | [53] = [0] {}
LL + if let [1 | 53] = [0] {}
|
error: aborting due to 17 previous errors

40
src/tools/clippy/tests/ui/unnested_or_patterns2.stderr
View file

@ -8,8 +8,9 @@ LL | if let Some(Some(0)) | Some(Some(1)) = None {}
= help: to override `-D warnings` add `#[allow(clippy::unnested_or_patterns)]`
help: nest the patterns
|
LL | if let Some(Some(0 | 1)) = None {}
| ~~~~~~~~~~~~~~~~~
LL - if let Some(Some(0)) | Some(Some(1)) = None {}
LL + if let Some(Some(0 | 1)) = None {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns2.rs:13:12
@ -19,8 +20,9 @@ LL | if let Some(Some(0)) | Some(Some(1) | Some(2)) = None {}
|
help: nest the patterns
|
LL | if let Some(Some(0 | 1 | 2)) = None {}
| ~~~~~~~~~~~~~~~~~~~~~
LL - if let Some(Some(0)) | Some(Some(1) | Some(2)) = None {}
LL + if let Some(Some(0 | 1 | 2)) = None {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns2.rs:14:12
@ -30,8 +32,9 @@ LL | if let Some(Some(0 | 1) | Some(2)) | Some(Some(3) | Some(4)) = None {}
|
help: nest the patterns
|
LL | if let Some(Some(0 | 1 | 2 | 3 | 4)) = None {}
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - if let Some(Some(0 | 1) | Some(2)) | Some(Some(3) | Some(4)) = None {}
LL + if let Some(Some(0 | 1 | 2 | 3 | 4)) = None {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns2.rs:15:12
@ -41,8 +44,9 @@ LL | if let Some(Some(0) | Some(1 | 2)) = None {}
|
help: nest the patterns
|
LL | if let Some(Some(0 | 1 | 2)) = None {}
| ~~~~~~~~~~~~~~~~~~~~~
LL - if let Some(Some(0) | Some(1 | 2)) = None {}
LL + if let Some(Some(0 | 1 | 2)) = None {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns2.rs:16:12
@ -52,8 +56,9 @@ LL | if let ((0,),) | ((1,) | (2,),) = ((0,),) {}
|
help: nest the patterns
|
LL | if let ((0 | 1 | 2,),) = ((0,),) {}
| ~~~~~~~~~~~~~~~
LL - if let ((0,),) | ((1,) | (2,),) = ((0,),) {}
LL + if let ((0 | 1 | 2,),) = ((0,),) {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns2.rs:17:12
@ -63,8 +68,9 @@ LL | if let 0 | (1 | 2) = 0 {}
|
help: nest the patterns
|
LL | if let 0 | 1 | 2 = 0 {}
| ~~~~~~~~~
LL - if let 0 | (1 | 2) = 0 {}
LL + if let 0 | 1 | 2 = 0 {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns2.rs:18:12
@ -74,8 +80,9 @@ LL | if let box (0 | 1) | (box 2 | box (3 | 4)) = Box::new(0) {}
|
help: nest the patterns
|
LL | if let box (0 | 1 | 2 | 3 | 4) = Box::new(0) {}
| ~~~~~~~~~~~~~~~~~~~~~~~
LL - if let box (0 | 1) | (box 2 | box (3 | 4)) = Box::new(0) {}
LL + if let box (0 | 1 | 2 | 3 | 4) = Box::new(0) {}
|
error: unnested or-patterns
--> tests/ui/unnested_or_patterns2.rs:19:12
@ -85,8 +92,9 @@ LL | if let box box 0 | box (box 2 | box 4) = Box::new(Box::new(0)) {}
|
help: nest the patterns
|
LL | if let box box (0 | 2 | 4) = Box::new(Box::new(0)) {}
| ~~~~~~~~~~~~~~~~~~~
LL - if let box box 0 | box (box 2 | box 4) = Box::new(Box::new(0)) {}
LL + if let box box (0 | 2 | 4) = Box::new(Box::new(0)) {}
|
error: aborting due to 8 previous errors

10
src/tools/clippy/tests/ui/unused_enumerate_index.stderr
View file

@ -8,8 +8,9 @@ LL | for (_, x) in v.iter().enumerate() {
= help: to override `-D warnings` add `#[allow(clippy::unused_enumerate_index)]`
help: remove the `.enumerate()` call
|
LL | for x in v.iter() {
| ~ ~~~~~~~~
LL - for (_, x) in v.iter().enumerate() {
LL + for x in v.iter() {
|
error: you seem to use `.enumerate()` and immediately discard the index
--> tests/ui/unused_enumerate_index.rs:59:19
@ -19,8 +20,9 @@ LL | for (_, x) in dummy.enumerate() {
|
help: remove the `.enumerate()` call
|
LL | for x in dummy {
| ~ ~~~~~
LL - for (_, x) in dummy.enumerate() {
LL + for x in dummy {
|
error: you seem to use `.enumerate()` and immediately discard the index
--> tests/ui/unused_enumerate_index.rs:63:39

20
src/tools/clippy/tests/ui/unused_format_specs.stderr
View file

@ -8,8 +8,9 @@ LL | println!("{:5}.", format_args!(""));
= help: to override `-D warnings` add `#[allow(clippy::unused_format_specs)]`
help: for the width to apply consider using `format!()`
|
LL | println!("{:5}.", format!(""));
| ~~~~~~
LL - println!("{:5}.", format_args!(""));
LL + println!("{:5}.", format!(""));
|
help: if the current behavior is intentional, remove the format specifiers
|
LL - println!("{:5}.", format_args!(""));
@ -24,8 +25,9 @@ LL | println!("{:.3}", format_args!("abcde"));
|
help: for the precision to apply consider using `format!()`
|
LL | println!("{:.3}", format!("abcde"));
| ~~~~~~
LL - println!("{:.3}", format_args!("abcde"));
LL + println!("{:.3}", format!("abcde"));
|
help: if the current behavior is intentional, remove the format specifiers
|
LL - println!("{:.3}", format_args!("abcde"));
@ -66,8 +68,9 @@ LL | usr_println!(true, "{:5}.", format_args!(""));
|
help: for the width to apply consider using `format!()`
|
LL | usr_println!(true, "{:5}.", format!(""));
| ~~~~~~
LL - usr_println!(true, "{:5}.", format_args!(""));
LL + usr_println!(true, "{:5}.", format!(""));
|
help: if the current behavior is intentional, remove the format specifiers
|
LL - usr_println!(true, "{:5}.", format_args!(""));
@ -82,8 +85,9 @@ LL | usr_println!(true, "{:.3}", format_args!("abcde"));
|
help: for the precision to apply consider using `format!()`
|
LL | usr_println!(true, "{:.3}", format!("abcde"));
| ~~~~~~
LL - usr_println!(true, "{:.3}", format_args!("abcde"));
LL + usr_println!(true, "{:.3}", format!("abcde"));
|
help: if the current behavior is intentional, remove the format specifiers
|
LL - usr_println!(true, "{:.3}", format_args!("abcde"));

20
src/tools/clippy/tests/ui/unused_result_ok.stderr
View file

@ -8,8 +8,9 @@ LL | x.parse::<u32>().ok();
= help: to override `-D warnings` add `#[allow(clippy::unused_result_ok)]`
help: consider using `let _ =` and removing the call to `.ok()` instead
|
LL | let _ = x.parse::<u32>();
| ~~~~~~~~~~~~~~~~~~~~~~~~
LL - x.parse::<u32>().ok();
LL + let _ = x.parse::<u32>();
|
error: ignoring a result with `.ok()` is misleading
--> tests/ui/unused_result_ok.rs:18:5
@ -19,8 +20,9 @@ LL | x . parse::<i32>() . ok ();
|
help: consider using `let _ =` and removing the call to `.ok()` instead
|
LL | let _ = x . parse::<i32>();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LL - x . parse::<i32>() . ok ();
LL + let _ = x . parse::<i32>();
|
error: ignoring a result with `.ok()` is misleading
--> tests/ui/unused_result_ok.rs:34:5
@ -30,8 +32,9 @@ LL | v!().ok();
|
help: consider using `let _ =` and removing the call to `.ok()` instead
|
LL | let _ = v!();
| ~~~~~~~~~~~~
LL - v!().ok();
LL + let _ = v!();
|
error: ignoring a result with `.ok()` is misleading
--> tests/ui/unused_result_ok.rs:29:9
@ -45,8 +48,9 @@ LL | w!();
= note: this error originates in the macro `w` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider using `let _ =` and removing the call to `.ok()` instead
|
LL | let _ = Ok::<(), ()>(());
| ~~~~~~~~~~~~~~~~~~~~~~~~
LL - Ok::<(), ()>(()).ok();
LL + let _ = Ok::<(), ()>(());
|
error: aborting due to 4 previous errors

55
tests/rustdoc-ui/intra-doc/disambiguator-mismatch.stderr
View file

@ -11,8 +11,9 @@ LL | #![deny(rustdoc::broken_intra_doc_links)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: to link to the enum, prefix with `enum@`
|
LL | /// Link to [enum@S]
| ~~~~~
LL - /// Link to [struct@S]
LL + /// Link to [enum@S]
|
error: incompatible link kind for `S`
--> $DIR/disambiguator-mismatch.rs:27:14
@ -22,8 +23,9 @@ LL | /// Link to [mod@S]
|
help: to link to the enum, prefix with `enum@`
|
LL | /// Link to [enum@S]
| ~~~~~
LL - /// Link to [mod@S]
LL + /// Link to [enum@S]
|
error: incompatible link kind for `S`
--> $DIR/disambiguator-mismatch.rs:32:14
@ -33,8 +35,9 @@ LL | /// Link to [union@S]
|
help: to link to the enum, prefix with `enum@`
|
LL | /// Link to [enum@S]
| ~~~~~
LL - /// Link to [union@S]
LL + /// Link to [enum@S]
|
error: incompatible link kind for `S`
--> $DIR/disambiguator-mismatch.rs:37:14
@ -44,8 +47,9 @@ LL | /// Link to [trait@S]
|
help: to link to the enum, prefix with `enum@`
|
LL | /// Link to [enum@S]
| ~~~~~
LL - /// Link to [trait@S]
LL + /// Link to [enum@S]
|
error: incompatible link kind for `T`
--> $DIR/disambiguator-mismatch.rs:42:14
@ -55,8 +59,9 @@ LL | /// Link to [struct@T]
|
help: to link to the trait, prefix with `trait@`
|
LL | /// Link to [trait@T]
| ~~~~~~
LL - /// Link to [struct@T]
LL + /// Link to [trait@T]
|
error: incompatible link kind for `m`
--> $DIR/disambiguator-mismatch.rs:47:14
@ -89,8 +94,9 @@ LL | /// Link to [const@s]
|
help: to link to the static, prefix with `static@`
|
LL | /// Link to [static@s]
| ~~~~~~~
LL - /// Link to [const@s]
LL + /// Link to [static@s]
|
error: incompatible link kind for `c`
--> $DIR/disambiguator-mismatch.rs:63:14
@ -100,8 +106,9 @@ LL | /// Link to [static@c]
|
help: to link to the constant, prefix with `const@`
|
LL | /// Link to [const@c]
| ~~~~~~
LL - /// Link to [static@c]
LL + /// Link to [const@c]
|
error: incompatible link kind for `c`
--> $DIR/disambiguator-mismatch.rs:68:14
@ -111,8 +118,9 @@ LL | /// Link to [fn@c]
|
help: to link to the constant, prefix with `const@`
|
LL | /// Link to [const@c]
| ~~~~~~
LL - /// Link to [fn@c]
LL + /// Link to [const@c]
|
error: incompatible link kind for `c`
--> $DIR/disambiguator-mismatch.rs:73:14
@ -146,8 +154,9 @@ LL | /// Link to [fn@std]
|
help: to link to the crate, prefix with `mod@`
|
LL | /// Link to [mod@std]
| ~~~~
LL - /// Link to [fn@std]
LL + /// Link to [mod@std]
|
error: incompatible link kind for `X::y`
--> $DIR/disambiguator-mismatch.rs:88:14
@ -157,8 +166,9 @@ LL | /// Link to [method@X::y]
|
help: to link to the field, prefix with `field@`
|
LL | /// Link to [field@X::y]
| ~~~~~~
LL - /// Link to [method@X::y]
LL + /// Link to [field@X::y]
|
error: unresolved link to `S::A`
--> $DIR/disambiguator-mismatch.rs:93:14
@ -168,8 +178,9 @@ LL | /// Link to [field@S::A]
|
help: to link to the variant, prefix with `variant@`
|
LL | /// Link to [variant@S::A]
| ~~~~~~~~
LL - /// Link to [field@S::A]
LL + /// Link to [variant@S::A]
|
error: aborting due to 15 previous errors

5
tests/rustdoc-ui/intra-doc/incompatible-primitive-disambiguator.stderr
View file

@ -11,8 +11,9 @@ LL | #![deny(rustdoc::broken_intra_doc_links)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: to link to the associated constant, prefix with `const@`
|
LL | //! [const@u8::MIN]
| ~~~~~~
LL - //! [static@u8::MIN]
LL + //! [const@u8::MIN]
|
error: aborting due to 1 previous error

20
tests/rustdoc-ui/intra-doc/prim-conflict.stderr
View file

@ -26,12 +26,14 @@ LL | /// [type@char]
|
help: to link to the module, prefix with `mod@`
|
LL | /// [mod@char]
| ~~~~
LL - /// [type@char]
LL + /// [mod@char]
|
help: to link to the primitive type, prefix with `prim@`
|
LL | /// [prim@char]
| ~~~~~
LL - /// [type@char]
LL + /// [prim@char]
|
error: incompatible link kind for `char`
--> $DIR/prim-conflict.rs:19:6
@ -41,8 +43,9 @@ LL | /// [struct@char]
|
help: to link to the module, prefix with `mod@`
|
LL | /// [mod@char]
| ~~~~
LL - /// [struct@char]
LL + /// [mod@char]
|
error: incompatible link kind for `char`
--> $DIR/prim-conflict.rs:26:10
@ -52,8 +55,9 @@ LL | //! [struct@char]
|
help: to link to the primitive type, prefix with `prim@`
|
LL | //! [prim@char]
| ~~~~~
LL - //! [struct@char]
LL + //! [prim@char]
|
error: aborting due to 4 previous errors

25
tests/rustdoc-ui/intra-doc/value-ctor.stderr
View file

@ -11,8 +11,9 @@ LL | #![deny(rustdoc::broken_intra_doc_links)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: to link to the variant, prefix with `variant@`
|
LL | /// [variant@Foo::X]
| ~~~~~~~~
LL - /// [value@Foo::X]
LL + /// [variant@Foo::X]
|
error: unresolved link to `MyStruct`
--> $DIR/value-ctor.rs:10:11
@ -22,8 +23,9 @@ LL | /// [tst][value@MyStruct]
|
help: to link to the struct, prefix with `struct@`
|
LL | /// [tst][struct@MyStruct]
| ~~~~~~~
LL - /// [tst][value@MyStruct]
LL + /// [tst][struct@MyStruct]
|
error: unresolved link to `Internals`
--> $DIR/value-ctor.rs:20:15
@ -33,8 +35,9 @@ LL | /// while [b][value@Internals] fails.
|
help: to link to the struct, prefix with `struct@`
|
LL | /// while [b][struct@Internals] fails.
| ~~~~~~~
LL - /// while [b][value@Internals] fails.
LL + /// while [b][struct@Internals] fails.
|
error: incompatible link kind for `Internals`
--> $DIR/value-ctor.rs:22:15
@ -44,8 +47,9 @@ LL | /// while [d][variant@Internals] fails.
|
help: to link to the struct, prefix with `struct@`
|
LL | /// while [d][struct@Internals] fails.
| ~~~~~~~
LL - /// while [d][variant@Internals] fails.
LL + /// while [d][struct@Internals] fails.
|
error: unresolved link to `Internals2`
--> $DIR/value-ctor.rs:34:15
@ -55,8 +59,9 @@ LL | /// while [b][value@Internals2] fails.
|
help: to link to the enum, prefix with `enum@`
|
LL | /// while [b][enum@Internals2] fails.
| ~~~~~
LL - /// while [b][value@Internals2] fails.
LL + /// while [b][enum@Internals2] fails.
|
error: aborting due to 5 previous errors

35
tests/rustdoc-ui/intra-doc/weird-syntax.stderr
View file

@ -11,8 +11,9 @@ LL | #![deny(rustdoc::broken_intra_doc_links)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: to link to the trait, prefix with `trait@`
|
LL | /// [`trait@Clone`]
| ~~~~~~
LL - /// [`struct@Clone`]
LL + /// [`trait@Clone`]
|
error: incompatible link kind for `Clone`
--> $DIR/weird-syntax.rs:21:9
@ -22,8 +23,9 @@ LL | /// [```struct@Clone```]
|
help: to link to the trait, prefix with `trait@`
|
LL | /// [```trait@Clone```]
| ~~~~~~
LL - /// [```struct@Clone```]
LL + /// [```trait@Clone```]
|
error: incompatible link kind for `Clone`
--> $DIR/weird-syntax.rs:24:11
@ -33,8 +35,9 @@ LL | /// [ ` struct@Clone ` ]
|
help: to link to the trait, prefix with `trait@`
|
LL | /// [ ` trait@Clone ` ]
| ~~~~~~
LL - /// [ ` struct@Clone ` ]
LL + /// [ ` trait@Clone ` ]
|
error: unresolved link to `Clone`
--> $DIR/weird-syntax.rs:27:9
@ -104,8 +107,9 @@ LL | /// [x][ struct@Clone]
|
help: to link to the trait, prefix with `trait@`
|
LL | /// [x][ trait@Clone]
| ~~~~~~
LL - /// [x][ struct@Clone]
LL + /// [x][ trait@Clone]
|
error: incompatible link kind for `Clone`
--> $DIR/weird-syntax.rs:65:9
@ -115,8 +119,9 @@ LL | /// [x][struct@Clone ]
|
help: to link to the trait, prefix with `trait@`
|
LL | /// [x][trait@Clone ]
| ~~~~~~
LL - /// [x][struct@Clone ]
LL + /// [x][trait@Clone ]
|
error: unresolved link to `Clone`
--> $DIR/weird-syntax.rs:74:9
@ -158,8 +163,9 @@ LL | /// [w]( struct@Clone)
|
help: to link to the trait, prefix with `trait@`
|
LL | /// [w]( trait@Clone)
| ~~~~~~
LL - /// [w]( struct@Clone)
LL + /// [w]( trait@Clone)
|
error: incompatible link kind for `Clone`
--> $DIR/weird-syntax.rs:94:9
@ -169,8 +175,9 @@ LL | /// [w](struct@Clone )
|
help: to link to the trait, prefix with `trait@`
|
LL | /// [w](trait@Clone )
| ~~~~~~
LL - /// [w](struct@Clone )
LL + /// [w](trait@Clone )
|
error: unresolved link to `Clone`
--> $DIR/weird-syntax.rs:97:9

5
tests/rustdoc-ui/issues/ice-generic-type-alias-105742.stderr
View file

@ -319,8 +319,9 @@ LL | | > {
| |__^ ...because it uses `Self` as a type parameter
help: consider using an opaque type instead
|
LL | pub fn next<'a, T>(s: &'a mut impl SVec<Item = T, Output = T>) {
| ~~~~
LL - pub fn next<'a, T>(s: &'a mut dyn SVec<Item = T, Output = T>) {
LL + pub fn next<'a, T>(s: &'a mut impl SVec<Item = T, Output = T>) {
|
error[E0107]: missing generics for associated type `SVec::Item`
--> $DIR/ice-generic-type-alias-105742.rs:16:21

Some files were not shown because too many files have changed in this diff Show more