bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Verify that an if condition block returns a value

Browse source
This commit is contained in:
Esteban Küber 2017-08-17 16:51:52 -07:00
parent 20a2716206
commit f06323337d
4 changed files with 51 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/libsyntax/parse/parser.rs
View file

@ -2968,7 +2968,12 @@ impl<'a> Parser<'a> {
}
let lo = self.prev_span;
let cond = self.parse_expr_res(RESTRICTION_NO_STRUCT_LITERAL, None)?;
if self.eat_keyword(keywords::Else) {
// Verify that the parsed `if` condition makes sense as a condition. If it is a block, then
// verify that the last statement is either an implicit return (no `;`) or an explicit
// return. This won't catch blocks with an explicit `return`, but that would be caught by
// the dead code lint.
if self.eat_keyword(keywords::Else) || !cond.returns() {
let sp = lo.next_point();
let mut err = self.diagnostic()
.struct_span_err(sp, "missing condition for `if` statemement");