bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Fix suggestion from move async to async move.

Browse source
This commit is contained in:
Giles Cope 2019-08-19 13:25:06 +01:00
parent 9dd5c19199
commit ef3e66d69f
3 changed files with 41 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/librustc_mir/borrow_check/conflict_errors.rs
View file

@ -1190,7 +1190,16 @@ impl<'cx, 'tcx> MirBorrowckCtxt<'cx, 'tcx> {
); );
let suggestion = match tcx.sess.source_map().span_to_snippet(args_span) { let suggestion = match tcx.sess.source_map().span_to_snippet(args_span) {
Ok(string) => format!("move {}", string), Ok(mut string) => {
if string.starts_with("async ") {
string.insert_str(6, "move ");
} else if string.starts_with("async|") {
string.insert_str(5, " move");
} else {
string.insert_str(0, "move ");
};
string
},
Err(_) => "move |<args>| <body>".to_string() Err(_) => "move |<args>| <body>".to_string()
}; };

10
src/test/ui/async-await/async-borrowck-escaping-closure-error.rs Normal file
View file

@ -0,0 +1,10 @@
// edition:2018
#![feature(async_closure,async_await)]
fn foo() -> Box<dyn std::future::Future<Output = u32>> {
let x = 0u32;
Box::new((async || x)())
//~^ ERROR E0373
}
fn main() {
}

21
src/test/ui/async-await/async-borrowck-escaping-closure-error.stderr Normal file
View file

@ -0,0 +1,21 @@
error[E0373]: closure may outlive the current function, but it borrows `x`, which is owned by the current function
--> $DIR/async-borrowck-escaping-closure-error.rs:5:15
|
LL | Box::new((async || x)())
| ^^^^^^^^ - `x` is borrowed here
| |
| may outlive borrowed value `x`
|
note: closure is returned here
--> $DIR/async-borrowck-escaping-closure-error.rs:5:5
|
LL | Box::new((async || x)())
| ^^^^^^^^^^^^^^^^^^^^^^^^
help: to force the closure to take ownership of `x` (and any other referenced variables), use the `move` keyword
|
LL | Box::new((async move || x)())
| ^^^^^^^^^^^^^
error: aborting due to previous error
For more information about this error, try `rustc --explain E0373`.