bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Lint redundant lifetimes in impl header

Browse source
This commit is contained in:
Michael Goulet 2023-12-05 16:32:47 +00:00
parent 2d813547bf
commit ee78eab62b
3 changed files with 18 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
compiler/rustc_hir_analysis/src/check/wfcheck.rs
View file

@ -2028,19 +2028,20 @@ fn lint_redundant_lifetimes<'tcx>(
| DefKind::TraitAlias
| DefKind::Fn
| DefKind::Const
| DefKind::Impl { of_trait: false } => {
| DefKind::Impl { of_trait: _ } => {
// Proceed
}
DefKind::AssocFn | DefKind::AssocTy | DefKind::AssocConst => {
let parent_def_id = tcx.local_parent(owner_id);
if matches!(tcx.def_kind(parent_def_id), DefKind::Impl { of_trait: true }) {
// Don't check for redundant lifetimes for trait implementations,
// since the signature is required to be compatible with the trait.
// Don't check for redundant lifetimes for associated items of trait
// implementations, since the signature is required to be compatible
// with the trait, even if the implementation implies some lifetimes
// are redundant.
return;
}
}
DefKind::Impl { of_trait: true }
| DefKind::Mod
DefKind::Mod
| DefKind::Variant
| DefKind::TyAlias
| DefKind::ForeignTy