bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

diagnostics: Do not suggest using #[unix_sigpipe] without a value

Browse source 
Remove `Word` from the `unix_sigpipe` attribute template so that plain
`#[unix_sigpipe]` is not included in suggestions of valid forms of the
attribute. Also re-arrange diagnostics code slightly to avoid duplicate
diagnostics.
This commit is contained in:
Martin Nordholts 2024-03-10 15:02:26 +01:00
parent 48a15aa2c4
commit ee428c55b2
5 changed files with 9 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

8
compiler/rustc_passes/src/entry.rs
View file

@ -156,13 +156,13 @@ fn sigpipe(tcx: TyCtxt<'_>, def_id: DefId) -> u8 {
(Some(sym::inherit), None) => sigpipe::INHERIT,
(Some(sym::sig_ign), None) => sigpipe::SIG_IGN,
(Some(sym::sig_dfl), None) => sigpipe::SIG_DFL,
(_, Some(_)) => {
// Keep going so that `fn emit_malformed_attribute()` can print
// an excellent error message
(Some(_), None) => {
tcx.dcx().emit_err(UnixSigpipeValues { span: attr.span });
sigpipe::DEFAULT
}
_ => {
tcx.dcx().emit_err(UnixSigpipeValues { span: attr.span });
// Keep going so that `fn emit_malformed_attribute()` can print
// an excellent error message
sigpipe::DEFAULT
}
}