bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

remove unnecessary uses of clone

Browse source
This commit is contained in:
Takayuki Maeda 2022-12-13 02:06:24 +09:00
parent f34356eace
commit ee40a67cd9
7 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_ast/src/token.rs
View file

@ -114,7 +114,7 @@ impl Lit {
if let NtExpr(expr) | NtLiteral(expr) = &**nt if let NtExpr(expr) | NtLiteral(expr) = &**nt
&& let ast::ExprKind::Lit(token_lit) = expr.kind => && let ast::ExprKind::Lit(token_lit) = expr.kind =>
{ {
Some(token_lit.clone()) Some(token_lit)
} }
_ => None, _ => None,
} }

2
compiler/rustc_ast_passes/src/feature_gate.rs
View file

@ -630,7 +630,7 @@ fn check_incompatible_features(sess: &Session) {
{ {
let spans = vec![f1_span, f2_span]; let spans = vec![f1_span, f2_span];
sess.struct_span_err( sess.struct_span_err(
spans.clone(), spans,
&format!( &format!(
"features `{}` and `{}` are incompatible, using them at the same time \ "features `{}` and `{}` are incompatible, using them at the same time \
is not allowed", is not allowed",

2
compiler/rustc_borrowck/src/diagnostics/conflict_errors.rs
View file

@ -745,7 +745,7 @@ impl<'cx, 'tcx> MirBorrowckCtxt<'cx, 'tcx> {
err.span_suggestion_verbose( err.span_suggestion_verbose(
span.shrink_to_hi(), span.shrink_to_hi(),
"consider cloning the value if the performance cost is acceptable", "consider cloning the value if the performance cost is acceptable",
".clone()".to_string(), ".clone()",
Applicability::MachineApplicable, Applicability::MachineApplicable,
); );
} }

2
compiler/rustc_builtin_macros/src/alloc_error_handler.rs
View file

@ -32,7 +32,7 @@ pub fn expand(
(item, true, ecx.with_def_site_ctxt(fn_kind.sig.span)) (item, true, ecx.with_def_site_ctxt(fn_kind.sig.span))
} else { } else {
ecx.sess.parse_sess.span_diagnostic.span_err(item.span(), "alloc_error_handler must be a function"); ecx.sess.parse_sess.span_diagnostic.span_err(item.span(), "alloc_error_handler must be a function");
return vec![orig_item.clone()]; return vec![orig_item];
}; };
// Generate a bunch of new items using the AllocFnFactory // Generate a bunch of new items using the AllocFnFactory

2
compiler/rustc_builtin_macros/src/concat_bytes.rs
View file

@ -196,7 +196,7 @@ pub fn expand_concat_bytes(
} }
} }
if !missing_literals.is_empty() { if !missing_literals.is_empty() {
let mut err = cx.struct_span_err(missing_literals.clone(), "expected a byte literal"); let mut err = cx.struct_span_err(missing_literals, "expected a byte literal");
err.note("only byte literals (like `b\"foo\"`, `b's'`, and `[3, 4, 5]`) can be passed to `concat_bytes!()`"); err.note("only byte literals (like `b\"foo\"`, `b's'`, and `[3, 4, 5]`) can be passed to `concat_bytes!()`");
err.emit(); err.emit();
return base::MacEager::expr(DummyResult::raw_expr(sp, true)); return base::MacEager::expr(DummyResult::raw_expr(sp, true));

2
compiler/rustc_codegen_llvm/src/back/lto.rs
View file

@ -206,7 +206,7 @@ pub(crate) fn run_thin(
} }
pub(crate) fn prepare_thin(module: ModuleCodegen<ModuleLlvm>) -> (String, ThinBuffer) { pub(crate) fn prepare_thin(module: ModuleCodegen<ModuleLlvm>) -> (String, ThinBuffer) {
let name = module.name.clone(); let name = module.name;
let buffer = ThinBuffer::new(module.module_llvm.llmod(), true); let buffer = ThinBuffer::new(module.module_llvm.llmod(), true);
(name, buffer) (name, buffer)
} }

2
compiler/rustc_infer/src/infer/error_reporting/nice_region_error/static_impl_trait.rs
View file

@ -330,7 +330,7 @@ pub fn suggest_new_region_bound(
Applicability::MaybeIncorrect, Applicability::MaybeIncorrect,
); );
} }
if let Some((param_span, param_ty)) = param.clone() { if let Some((param_span, ref param_ty)) = param {
err.span_suggestion_verbose( err.span_suggestion_verbose(
param_span, param_span,
add_static_bound, add_static_bound,