bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

relax priv-in-pub lint on generic bounds and where clauses in trait impls

Browse source
This commit is contained in:
Jack Wrenn 2021-11-04 16:31:18 +00:00
parent 473eaa42e9
commit ebef8a8cee
9 changed files with 330 additions and 87 deletions
Download patch file Download diff file Expand all files Collapse all files

6
compiler/rustc_privacy/src/lib.rs
View file

@ -2069,7 +2069,11 @@ impl<'tcx> Visitor<'tcx> for PrivateItemsInPublicInterfacesVisitor<'tcx> {
// Subitems of trait impls have inherited publicity.
hir::ItemKind::Impl(ref impl_) => {
let impl_vis = ty::Visibility::of_impl(item.def_id, tcx, &Default::default());
self.check(item.def_id, impl_vis).generics().predicates();
// check that private components do not appear in the generics or predicates of inherent impls
// this check is intentionally NOT performed for impls of traits, per #90586
if impl_.of_trait.is_none() {
self.check(item.def_id, impl_vis).generics().predicates();
}
for impl_item_ref in impl_.items {
let impl_item_vis = if impl_.of_trait.is_none() {
min(tcx.visibility(impl_item_ref.id.def_id), impl_vis, tcx)