bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #128886 - GrigorenkoPV:untranslatable-diagnostic, r=nnethercote

Browse source 
Get rid of some `#[allow(rustc::untranslatable_diagnostic)]`

`@rustbot` label +A-translation
cc https://github.com/rust-lang/rust/issues/100717
This commit is contained in:
Guillaume Gomez 2024-08-12 17:09:17 +02:00 • committed by GitHub
commit ea74eff55c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
23 changed files with 125 additions and 77 deletions
Download patch file Download diff file Expand all files Collapse all files

6
compiler/rustc_passes/messages.ftl
View file

@ -223,6 +223,9 @@ passes_doc_masked_only_extern_crate =
.not_an_extern_crate_label = not an `extern crate` item
.note = read <https://doc.rust-lang.org/unstable-book/language-features/doc-masked.html> for more information
passes_doc_rust_logo =
the `#[doc(rust_logo)]` attribute is used for Rust branding
passes_doc_test_literal = `#![doc(test(...)]` does not take a literal
passes_doc_test_takes_list =
@ -595,6 +598,9 @@ passes_remove_fields =
*[other] fields
}
passes_repr_align_function =
`repr(align)` attributes on functions are unstable
passes_repr_conflicting =
conflicting representation hints

6
compiler/rustc_passes/src/check_attr.rs
View file

@ -1142,7 +1142,6 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
/// of one item. Read the documentation of [`check_doc_inline`] for more information.
///
/// [`check_doc_inline`]: Self::check_doc_inline
#[allow(rustc::untranslatable_diagnostic)] // FIXME: make this translatable
fn check_doc_attrs(
&self,
attr: &Attribute,
@ -1220,7 +1219,7 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
&self.tcx.sess,
sym::rustdoc_internals,
meta.span(),
"the `#[doc(rust_logo)]` attribute is used for Rust branding",
fluent::passes_doc_rust_logo,
)
.emit();
}
@ -1736,7 +1735,6 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
}
/// Checks if the `#[repr]` attributes on `item` are valid.
#[allow(rustc::untranslatable_diagnostic)] // FIXME: make this translatable
fn check_repr(
&self,
attrs: &[Attribute],
@ -1793,7 +1791,7 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
&self.tcx.sess,
sym::fn_align,
hint.span(),
"`repr(align)` attributes on functions are unstable",
fluent::passes_repr_align_function,
)
.emit();
}

1
compiler/rustc_passes/src/entry.rs
View file

@ -106,7 +106,6 @@ fn check_and_search_item(id: ItemId, ctxt: &mut EntryContext<'_>) {
}
}
#[allow(rustc::untranslatable_diagnostic)] // FIXME: make this translatable
fn configure_main(tcx: TyCtxt<'_>, visitor: &EntryContext<'_>) -> Option<(DefId, EntryFnType)> {
if let Some((def_id, _)) = visitor.start_fn {
Some((def_id.to_def_id(), EntryFnType::Start))