bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Pin memchr to 2.5.0 in the library rather than rustc_ast

Browse source 
The latest versions of `memchr` experience LTO-related issues when
compiling for windows-gnu [1], so needs to be pinned. The issue is
present in the standard library.

`memchr` has been pinned in `rustc_ast`, but since the workspace was
recently split, this pin no longer has any effect on library crates.

Resolve this by adding `memchr` as an _unused_ dependency in `std`,
pinned to 2.5. Additionally, remove the pin in `rustc_ast` to allow
non-library crates to upgrade to the latest version.

Link: https://github.com/rust-lang/rust/issues/127890 [1]
This commit is contained in:
Trevor Gross 2024-08-26 14:56:18 -04:00
parent 11e760b7f4
commit e95d15a115
4 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
compiler/rustc_ast/Cargo.toml
View file

@ -4,10 +4,9 @@ version = "0.0.0"
edition = "2021"
[dependencies]
# FIXME: bumping memchr to 2.7.1 causes linker errors in MSVC thin-lto
# tidy-alphabetical-start
bitflags = "2.4.1"
memchr = "=2.5.0"
memchr = "2.7.4"
rustc_ast_ir = { path = "../rustc_ast_ir" }
rustc_data_structures = { path = "../rustc_data_structures" }
rustc_index = { path = "../rustc_index" }