bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Auto merge of #85359 - lrh2000:reserved-prefixes, r=nikomatsakis

Browse source 
Reserve prefixed identifiers and literals (RFC 3101)

This PR denies any identifiers immediately followed by one of three tokens `"`, `'` or `#`, which is stricter than the requirements of RFC 3101 but may be necessary according to the discussion at [Zulip].

[Zulip]: 238470099

The tracking issue #84599 says we'll add a feature gate named `reserved_prefixes`, but I don't think I can do this because it is impossible for the lexer to know whether a feature is enabled or not. I guess determining the behavior by the edition information should be enough.

Fixes #84599
This commit is contained in:
bors 2021-06-27 20:33:25 +00:00
commit e8cb1a4a56
16 changed files with 518 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

9
compiler/rustc_lint/src/context.rs
View file

@ -723,6 +723,15 @@ pub trait LintContext: Sized {
BuiltinLintDiagnostics::OrPatternsBackCompat(span,suggestion) => {
db.span_suggestion(span, "use pat_param to preserve semantics", suggestion, Applicability::MachineApplicable);
}
BuiltinLintDiagnostics::ReservedPrefix(span) => {
db.span_label(span, "unknown prefix");
db.span_suggestion_verbose(
span.shrink_to_hi(),
"insert whitespace here to avoid this being parsed as a prefix in Rust 2021",
" ".into(),
Applicability::MachineApplicable,
);
}
}
// Rewrap `db`, and pass control to the user.
decorate(LintDiagnosticBuilder::new(db));