bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #116201 - Jarcho:noop_fix, r=fee1-dead

Browse source 
Fix `noop_method_call` detection

This needs to be merged before #116198 can compile. The error occurs before the compiler is built so this needs to be a separate PR.
This commit is contained in:
Matthias Krüger 2023-09-29 10:11:12 +02:00 • committed by GitHub
commit e814f1e3c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 39 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
compiler/rustc_lint/src/noop_method_call.rs
View file

@ -98,6 +98,12 @@ impl<'tcx> LateLintPass<'tcx> for NoopMethodCall {
let Ok(Some(i)) = ty::Instance::resolve(cx.tcx, cx.param_env, did, args) else { return };
// (Re)check that it implements the noop diagnostic.
let Some(name) = cx.tcx.get_diagnostic_name(i.def_id()) else { return };
if !matches!(
name,
sym::noop_method_borrow | sym::noop_method_clone | sym::noop_method_deref
) {
return;
}
let receiver_ty = cx.typeck_results().expr_ty(receiver);
let expr_ty = cx.typeck_results().expr_ty_adjusted(expr);