bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Always inline simple BytePos and CharPos methods.

Browse source 
Because they are (a) trivial, and (b) super hot.

This change speeds up most rustc-benchmarks, the best by 5%.
This commit is contained in:
Nicholas Nethercote 2018-05-03 09:12:26 +10:00
parent f76f6fbdea
commit e740b97be6
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/libsyntax_pos/lib.rs
View file

@ -1150,13 +1150,17 @@ pub struct CharPos(pub usize);
// have been unsuccessful // have been unsuccessful
impl Pos for BytePos { impl Pos for BytePos {
#[inline(always)]
fn from_usize(n: usize) -> BytePos { BytePos(n as u32) } fn from_usize(n: usize) -> BytePos { BytePos(n as u32) }
#[inline(always)]
fn to_usize(&self) -> usize { let BytePos(n) = *self; n as usize } fn to_usize(&self) -> usize { let BytePos(n) = *self; n as usize }
} }
impl Add for BytePos { impl Add for BytePos {
type Output = BytePos; type Output = BytePos;
#[inline(always)]
fn add(self, rhs: BytePos) -> BytePos { fn add(self, rhs: BytePos) -> BytePos {
BytePos((self.to_usize() + rhs.to_usize()) as u32) BytePos((self.to_usize() + rhs.to_usize()) as u32)
} }
@ -1165,6 +1169,7 @@ impl Add for BytePos {
impl Sub for BytePos { impl Sub for BytePos {
type Output = BytePos; type Output = BytePos;
#[inline(always)]
fn sub(self, rhs: BytePos) -> BytePos { fn sub(self, rhs: BytePos) -> BytePos {
BytePos((self.to_usize() - rhs.to_usize()) as u32) BytePos((self.to_usize() - rhs.to_usize()) as u32)
} }
@ -1183,13 +1188,17 @@ impl Decodable for BytePos {
} }
impl Pos for CharPos { impl Pos for CharPos {
#[inline(always)]
fn from_usize(n: usize) -> CharPos { CharPos(n) } fn from_usize(n: usize) -> CharPos { CharPos(n) }
#[inline(always)]
fn to_usize(&self) -> usize { let CharPos(n) = *self; n } fn to_usize(&self) -> usize { let CharPos(n) = *self; n }
} }
impl Add for CharPos { impl Add for CharPos {
type Output = CharPos; type Output = CharPos;
#[inline(always)]
fn add(self, rhs: CharPos) -> CharPos { fn add(self, rhs: CharPos) -> CharPos {
CharPos(self.to_usize() + rhs.to_usize()) CharPos(self.to_usize() + rhs.to_usize())
} }
@ -1198,6 +1207,7 @@ impl Add for CharPos {
impl Sub for CharPos { impl Sub for CharPos {
type Output = CharPos; type Output = CharPos;
#[inline(always)]
fn sub(self, rhs: CharPos) -> CharPos { fn sub(self, rhs: CharPos) -> CharPos {
CharPos(self.to_usize() - rhs.to_usize()) CharPos(self.to_usize() - rhs.to_usize())
} }