bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Detect Python-like slicing and suggest how to fix

Browse source 
Fix #108215
This commit is contained in:
Hirochika Matsumoto 2023-05-03 22:32:52 +09:00
parent b29a1e00f8
commit e65c060d78
4 changed files with 47 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

16
compiler/rustc_parse/src/parser/stmt.rs
View file

@ -567,6 +567,22 @@ impl<'a> Parser<'a> {
snapshot.recover_diff_marker();
}
if self.token == token::Colon {
// if a previous and next token of the current one is
// integer literal (e.g. `1:42`), it's likely a range
// expression for Pythonistas and we can suggest so.
if self.prev_token.is_integer_lit()
&& self.look_ahead(1, |token| token.is_integer_lit())
{
// TODO(hkmatsumoto): Might be better to trigger
// this only when parsing an index expression.
err.span_suggestion_verbose(
self.token.span,
"you might have meant to make a slice with range index",
"..",
Applicability::MaybeIncorrect,
);
}
// if next token is following a colon, it's likely a path
// and we can suggest a path separator
self.bump();