bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Auto merge of #110367 - saethlin:no-truncations, r=oli-obk

Browse source 
Remove some suspicious cast truncations

These truncations were added a long time ago, and as best I can tell without a perf justification. And with rust-lang/rust#110410 it has become perf-neutral to not truncate anymore. We worked hard for all these bits, let's use them.
This commit is contained in:
bors 2023-04-17 09:38:31 +00:00
commit e49122fb1c
4 changed files with 9 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_span/src/lib.rs
View file

@ -2160,9 +2160,7 @@ where
};
Hash::hash(&TAG_VALID_SPAN, hasher);
// We truncate the stable ID hash and line and column numbers. The chances
// of causing a collision this way should be minimal.
Hash::hash(&(file.name_hash as u64), hasher);
Hash::hash(&file.name_hash, hasher);
// Hash both the length and the end location (line/column) of a span. If we
// hash only the length, for example, then two otherwise equal spans with