We are able to resolve methods even if they need subst
This commit is contained in:
parent
8c600120e6
commit
e1b313af46
3 changed files with 11 additions and 8 deletions
|
@ -1,5 +1,4 @@
|
||||||
use crate::context::LintContext;
|
use crate::context::LintContext;
|
||||||
use crate::rustc_middle::ty::TypeVisitable;
|
|
||||||
use crate::LateContext;
|
use crate::LateContext;
|
||||||
use crate::LateLintPass;
|
use crate::LateLintPass;
|
||||||
use rustc_errors::fluent;
|
use rustc_errors::fluent;
|
||||||
|
@ -65,11 +64,6 @@ impl<'tcx> LateLintPass<'tcx> for NoopMethodCall {
|
||||||
let substs = cx
|
let substs = cx
|
||||||
.tcx
|
.tcx
|
||||||
.normalize_erasing_regions(cx.param_env, cx.typeck_results().node_substs(expr.hir_id));
|
.normalize_erasing_regions(cx.param_env, cx.typeck_results().node_substs(expr.hir_id));
|
||||||
if substs.needs_subst() {
|
|
||||||
// We can't resolve on types that require monomorphization, so we don't handle them if
|
|
||||||
// we need to perform substitution.
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
// Resolve the trait method instance.
|
// Resolve the trait method instance.
|
||||||
let Ok(Some(i)) = ty::Instance::resolve(cx.tcx, cx.param_env, did, substs) else {
|
let Ok(Some(i)) = ty::Instance::resolve(cx.tcx, cx.param_env, did, substs) else {
|
||||||
return
|
return
|
||||||
|
|
|
@ -46,6 +46,7 @@ fn main() {
|
||||||
|
|
||||||
fn generic<T>(non_clone_type: &PlainType<T>) {
|
fn generic<T>(non_clone_type: &PlainType<T>) {
|
||||||
non_clone_type.clone();
|
non_clone_type.clone();
|
||||||
|
//~^ WARNING call to `.clone()` on a reference in this situation does nothing
|
||||||
}
|
}
|
||||||
|
|
||||||
fn non_generic(non_clone_type: &PlainType<u32>) {
|
fn non_generic(non_clone_type: &PlainType<u32>) {
|
||||||
|
|
|
@ -28,12 +28,20 @@ LL | let non_borrow_type_borrow: &PlainType<u32> = non_borrow_type.borrow();
|
||||||
= note: the type `&PlainType<u32>` which `borrow` is being called on is the same as the type returned from `borrow`, so the method call does not do anything and can be removed
|
= note: the type `&PlainType<u32>` which `borrow` is being called on is the same as the type returned from `borrow`, so the method call does not do anything and can be removed
|
||||||
|
|
||||||
warning: call to `.clone()` on a reference in this situation does nothing
|
warning: call to `.clone()` on a reference in this situation does nothing
|
||||||
--> $DIR/noop-method-call.rs:52:19
|
--> $DIR/noop-method-call.rs:48:19
|
||||||
|
|
|
||||||
|
LL | non_clone_type.clone();
|
||||||
|
| ^^^^^^^^ unnecessary method call
|
||||||
|
|
|
||||||
|
= note: the type `&PlainType<T>` which `clone` is being called on is the same as the type returned from `clone`, so the method call does not do anything and can be removed
|
||||||
|
|
||||||
|
warning: call to `.clone()` on a reference in this situation does nothing
|
||||||
|
--> $DIR/noop-method-call.rs:53:19
|
||||||
|
|
|
|
||||||
LL | non_clone_type.clone();
|
LL | non_clone_type.clone();
|
||||||
| ^^^^^^^^ unnecessary method call
|
| ^^^^^^^^ unnecessary method call
|
||||||
|
|
|
|
||||||
= note: the type `&PlainType<u32>` which `clone` is being called on is the same as the type returned from `clone`, so the method call does not do anything and can be removed
|
= note: the type `&PlainType<u32>` which `clone` is being called on is the same as the type returned from `clone`, so the method call does not do anything and can be removed
|
||||||
|
|
||||||
warning: 4 warnings emitted
|
warning: 5 warnings emitted
|
||||||
|
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue