bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

use structured fields in some existing warnings

Browse source 
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
This commit is contained in:
Eliza Weisman 2021-10-07 10:48:48 -07:00
parent 928c787fce
commit e00eac8b9c
No known key found for this signature in database
GPG key ID: F9C1A595C3814436
2 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
compiler/rustc_codegen_ssa/src/back/link.rs
View file

@ -844,8 +844,8 @@ fn link_natively<'a, B: ArchiveBuilder<'a>>(
if out.contains(msg_segv) || out.contains(msg_bus) { if out.contains(msg_segv) || out.contains(msg_bus) {
warn!( warn!(
"looks like the linker segfaulted when we tried to call it, \ "looks like the linker segfaulted when we tried to call it, \
automatically retrying again. cmd = {:?}, out = {}.", automatically retrying again",
cmd, out, ?cmd, %out,
); );
continue; continue;
} }
@ -853,9 +853,8 @@ fn link_natively<'a, B: ArchiveBuilder<'a>>(
if is_illegal_instruction(&output.status) { if is_illegal_instruction(&output.status) {
warn!( warn!(
"looks like the linker hit an illegal instruction when we \ "looks like the linker hit an illegal instruction when we \
tried to call it, automatically retrying again. cmd = {:?}, ]\ tried to call it, automatically retrying again."
out = {}, status = {}.", ?cmd, %out, status = %output.status,
cmd, out, output.status,
); );
continue; continue;
} }

2
compiler/rustc_errors/src/emitter.rs
View file

@ -2308,7 +2308,7 @@ pub fn is_case_difference(sm: &SourceMap, suggested: &str, sp: Span) -> bool {
let found = match sm.span_to_snippet(sp) { let found = match sm.span_to_snippet(sp) {
Ok(snippet) => snippet, Ok(snippet) => snippet,
Err(e) => { Err(e) => {
warn!("Invalid span {:?}. Err={:?}", sp, e); warn!(error = ?e, "Invalid span {:?}", sp);
return false; return false;
} }
}; };