Fix -Z instrument-coverage
on MSVC
Found that -C link-dead-code (which was enabled automatically under -Z instrument-coverage) was causing the linking error that resulted in segmentation faults in coverage instrumented binaries. Link dead code is now disabled under MSVC, allowing `-Z instrument-coverage` to be enabled under MSVC for the first time. More details are included in Issue #76038. (This PR was broken out from PR #75828)
This commit is contained in:
parent
85fbf49ce0
commit
ddb054aee8
6 changed files with 45 additions and 34 deletions
|
@ -1668,7 +1668,7 @@ fn linker_with_args<'a, B: ArchiveBuilder<'a>>(
|
|||
// FIXME: Order dependent, applies to the following objects. Where should it be placed?
|
||||
// Try to strip as much out of the generated object by removing unused
|
||||
// sections if possible. See more comments in linker.rs
|
||||
if sess.opts.cg.link_dead_code != Some(true) {
|
||||
if !sess.link_dead_code() {
|
||||
let keep_metadata = crate_type == CrateType::Dylib;
|
||||
cmd.gc_sections(keep_metadata);
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue