bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Forbid pub mymacro!();

Browse source 
It's not clear what this means, because a macro in item position can expand to
zero or more items.  For now we disallow it, which is technically a

    [breaking-change]

but is landing without an RFC.  The `pub` keyword previously had no effect,
which seems quite unintended.

Fixes #18317.
Fixes #14660.
This commit is contained in:
Keegan McAllister 2015-02-12 20:43:57 -08:00
parent cf636c233d
commit dcd4cef119
4 changed files with 105 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/libsyntax/parse/parser.rs
View file

@ -4621,6 +4621,17 @@ impl<'a> Parser<'a> {
self.parse_method(attrs, visa)
}
fn complain_if_pub_macro(&mut self, visa: Visibility, span: Span) {
match visa {
Public => {
self.span_err(span, "can't qualify macro invocation with `pub`");
self.span_help(span, "try adjusting the macro to put `pub` inside \
the invocation");
}
Inherited => (),
}
}
/// Parse a method in a trait impl, starting with `attrs` attributes.
pub fn parse_method(&mut self,
attrs: Vec<Attribute>,
@ -4635,6 +4646,10 @@ impl<'a> Parser<'a> {
&& (self.look_ahead(2, |t| *t == token::OpenDelim(token::Paren))
|| self.look_ahead(2, |t| *t == token::OpenDelim(token::Brace))) {
// method macro.
let last_span = self.last_span;
self.complain_if_pub_macro(visa, last_span);
let pth = self.parse_path(NoTypesAllowed);
self.expect(&token::Not);
@ -5838,6 +5853,9 @@ impl<'a> Parser<'a> {
|| self.look_ahead(2, |t| *t == token::OpenDelim(token::Brace))) {
// MACRO INVOCATION ITEM
let last_span = self.last_span;
self.complain_if_pub_macro(visibility, last_span);
// item macro.
let pth = self.parse_path(NoTypesAllowed);
self.expect(&token::Not);