Fix review comments and other improvements

This commit is contained in:
bjorn3 2024-08-11 10:29:32 +00:00
parent d63a067bfd
commit db68a19b61
6 changed files with 34 additions and 24 deletions

View file

@ -108,8 +108,8 @@ impl ArchiveBuilderBuilder for LlvmArchiveBuilderBuilder {
fn new_archive_builder<'a>(&self, sess: &'a Session) -> Box<dyn ArchiveBuilder + 'a> {
// Keeping LlvmArchiveBuilder around in case of a regression caused by using
// ArArchiveBuilder.
// FIXME remove a couple of months after #128936 gets merged in case no
// regression is found.
// FIXME(#128955) remove a couple of months after #128936 gets merged in case
// no regression is found.
if false {
Box::new(LlvmArchiveBuilder { sess, additions: Vec::new() })
} else {