bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Remove unused AsciiExt imports and fix tests related to ascii methods

Browse source 
Many AsciiExt imports have become useless thanks to the inherent ascii
methods added in the last commits. These were removed. In some places, I
fully specified the ascii method being called to enforce usage of the
AsciiExt trait. Note that some imports are not removed but tagged with
a `#[cfg(stage0)]` attribute. This is necessary, because certain ascii
methods are not yet available in stage0. All those imports will be
removed later.

Additionally, failing tests were fixed. The test suite should exit
successfully now.
This commit is contained in:
Lukas Kalbertodt 2017-10-02 09:50:36 +02:00
parent 1916e3c4aa
commit da57580736
12 changed files with 10 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/libstd/ascii.rs
View file

@ -38,8 +38,8 @@ use iter::FusedIterator;
/// ```
/// use std::ascii::AsciiExt;
///
/// assert_eq!("café".to_ascii_uppercase(), "CAFÉ");
/// assert_eq!("café".to_ascii_uppercase(), "CAFé");
/// assert_eq!(AsciiExt::to_ascii_uppercase("café"), "CAFÉ");
/// assert_eq!(AsciiExt::to_ascii_uppercase("café"), "CAFé");
/// ```
///
/// In the first example, the lowercased string is represented `"cafe\u{301}"`
@ -681,7 +681,9 @@ impl fmt::Debug for EscapeDefault {
#[cfg(test)]
mod tests {
use super::*;
//! Note that most of these tests are not testing `AsciiExt` methods, but
//! test inherent ascii methods of char, u8, str and [u8]. `AsciiExt` is
//! just using those methods, though.
use char::from_u32;
#[test]