bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Remove lint pass on borrow and deref

Browse source
This commit is contained in:
Ryan Levick 2021-02-16 15:12:19 +01:00
parent 6bf6652616
commit da3995f0ec
6 changed files with 25 additions and 74 deletions
Download patch file Download diff file Expand all files Collapse all files

12
compiler/rustc_lint/src/noop_method_call.rs
View file

@ -50,9 +50,7 @@ impl<'tcx> LateLintPass<'tcx> for NoopMethodCall {
Some((DefKind::AssocFn, did)) => match cx.tcx.trait_of_item(did) {
// Check that we're dealing with a trait method for one of the traits we care about.
Some(trait_id)
if [sym::Clone, sym::Deref, sym::Borrow]
.iter()
.any(|s| cx.tcx.is_diagnostic_item(*s, trait_id)) =>
if [sym::Clone].iter().any(|s| cx.tcx.is_diagnostic_item(*s, trait_id)) =>
{
(trait_id, did)
}
@ -73,13 +71,7 @@ impl<'tcx> LateLintPass<'tcx> for NoopMethodCall {
_ => return,
};
// (Re)check that it implements the noop diagnostic.
for (s, peel_ref) in [
(sym::noop_method_borrow, true),
(sym::noop_method_clone, false),
(sym::noop_method_deref, true),
]
.iter()
{
for (s, peel_ref) in [(sym::noop_method_clone, false)].iter() {
if cx.tcx.is_diagnostic_item(*s, i.def_id()) {
let method = &call.ident.name;
let receiver = &elements[0];