bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Prefer 'associated function' over 'static method' in msg.

Browse source 
TRPL seems to refer to 'static functions' as 'associated functions'.
This terminology should be used consistently.
This commit is contained in:
Corey Farwell 2016-02-23 00:04:30 -05:00
parent 0ef8d42605
commit d9dba7699f
2 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/librustc_typeck/check/method/suggest.rs
View file

@ -141,7 +141,8 @@ pub fn report_error<'a, 'tcx>(fcx: &FnCtxt<'a, 'tcx>,
if !static_sources.is_empty() { if !static_sources.is_empty() {
err.fileline_note( err.fileline_note(
span, span,
"found defined static methods, maybe a `self` is missing?"); "found the following associated functions; to be used as \
methods, functions must have a `self` parameter");
report_candidates(fcx, &mut err, span, item_name, static_sources); report_candidates(fcx, &mut err, span, item_name, static_sources);
} }

7
src/test/compile-fail/issue-7575.rs
View file

@ -9,6 +9,7 @@
// except according to those terms. // except according to those terms.
// Test the mechanism for warning about possible missing `self` declarations. // Test the mechanism for warning about possible missing `self` declarations.
// ignore-tidy-linelength
trait CtxtFn { trait CtxtFn {
fn f8(self, usize) -> usize; fn f8(self, usize) -> usize;
@ -72,15 +73,15 @@ impl ManyImplTrait for Myisize {}
fn no_param_bound(u: usize, m: Myisize) -> usize { fn no_param_bound(u: usize, m: Myisize) -> usize {
u.f8(42) + u.f9(342) + m.fff(42) u.f8(42) + u.f9(342) + m.fff(42)
//~^ ERROR no method named `f9` found for type `usize` in the current scope //~^ ERROR no method named `f9` found for type `usize` in the current scope
//~^^ NOTE found defined static methods, maybe a `self` is missing? //~^^ NOTE found the following associated functions; to be used as methods, functions must have a `self` parameter
//~^^^ ERROR no method named `fff` found for type `Myisize` in the current scope //~^^^ ERROR no method named `fff` found for type `Myisize` in the current scope
//~^^^^ NOTE found defined static methods, maybe a `self` is missing? //~^^^^ NOTE found the following associated functions; to be used as methods, functions must have a `self` parameter
} }
fn param_bound<T: ManyImplTrait>(t: T) -> bool { fn param_bound<T: ManyImplTrait>(t: T) -> bool {
t.is_str() t.is_str()
//~^ ERROR no method named `is_str` found for type `T` in the current scope //~^ ERROR no method named `is_str` found for type `T` in the current scope
//~^^ NOTE found defined static methods, maybe a `self` is missing? //~^^ NOTE found the following associated functions; to be used as methods, functions must have a `self` parameter
} }
fn main() { fn main() {